1. 03 Jan, 2019 1 commit
  2. 11 Dec, 2018 1 commit
  3. 04 Dec, 2018 1 commit
  4. 26 Nov, 2018 1 commit
  5. 15 Nov, 2018 1 commit
    • Clemens Hammacher's avatar
      [base] Introduce VectorOf helper · 3ad032b7
      Clemens Hammacher authored
      We often need to create a {Vector} view of data owned by a container
      like {std::vector}. The canonical way to do this is this:
      Vector<T>{vec.data(), vec.size()}
      
      This pattern is repeating information which can be deduced
      automatically, like the type T.
      
      This CL introduces a {VectorOf} helper which can construct a {Vector}
      for any container providing a {data()} and {size()} accessor, and uses
      it to replace the pattern above.
      
      R=ishell@chromium.org
      
      Bug: v8:8238
      Change-Id: Ib3a11662acc82cb83f2b4afd07ba88e579d71dba
      Reviewed-on: https://chromium-review.googlesource.com/c/1337584Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57538}
      3ad032b7
  6. 23 Jul, 2018 1 commit
  7. 21 Jun, 2018 1 commit
  8. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  9. 18 Oct, 2017 1 commit
  10. 26 Sep, 2017 1 commit
  11. 07 Sep, 2017 1 commit
  12. 10 Nov, 2016 1 commit
  13. 12 Jul, 2016 1 commit
  14. 01 Jun, 2016 2 commits
  15. 27 May, 2016 1 commit
    • franzih's avatar
      [builtins] Rewrite uri.js as builtin functions. · 8c31bd81
      franzih authored
      Rewrite decodeURI and decodeURIComponent as builtin functions
      and install them in the bootstrapper.
      
      Delete unused runtime functions:
       - TruncateString
       - NewString
       - OneByteSeqStringGetChar
       - OneByteSeqStringSetChar
       - TwoByteSeqStringGetChar
       - TwoByteSeqStringSetChar
      
      Add regression test for decoding large strings. Clusterfuzz detected
      a problem with %TruncateString, see
      https://bugs.chromium.org/p/chromium/issues/detail?id=612109#c6
      This is automatically fixed by this rewrite because %TruncateString
      is deleted anyways.
      
      Crude benchmark on 585 decodeURI and decodeURIComponent tests
      averaged over five runs:
      
      * builtin functions
      real	0m9.69s
      user	2m39.8816s
      sys    	0m12.6398s
      
      * JS functions calling into the runtime e.g., for %TruncateString
      real	0m11.0598s
      user	3m6.7026s
      sys	0m13.5756s
      
      By running:
      $  time tools/run-tests.py   --arch=x64  --mode=Release --buildbot
        test262/built-ins/decodeURI* mjsunit/uri
      >>> Running tests for x64.Release
      
      BUG=v8:4912, chromium:612109
      R=yangguo@chromium.org, bmeurer@chromium.org
      
      Review-Url: https://codereview.chromium.org/1994733003
      Cr-Commit-Position: refs/heads/master@{#36543}
      8c31bd81
  16. 24 May, 2016 1 commit
  17. 17 May, 2016 1 commit
    • franzih's avatar
      [builtins] Move EncodeURI from runtime to builtins. · c60cb90c
      franzih authored
      Repackage encodeURI and encodeURIComponent as builtin functions
      and install them in the bootstrapper.
      
      Crude benchmark on 351 encodeURI and encodeURIComponent tests averaged
      over five runs:
      
      * builtin functions
      real	0m8.01s
      user	0m18.00s
      sys	0m7.37s
      
      * JS functions calling into the runtime e.g., for %NewString
      real	0m8.44s
      user	0m19.52s
      sys	0m7.49s
      
      By running:
      $ time tools/run-tests.py   --arch=x64 --mode=Release --buildbot
      mjsunit/uri test262/built-ins/encodeURI*
      >>> Running tests for x64.Release
      
      BUG=v8:4912
      R=yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/1983593002
      Cr-Commit-Position: refs/heads/master@{#36273}
      c60cb90c