- 31 May, 2017 32 commits
-
-
Michael Lippautz authored
Furthermore avoid lock-step between pointer updating phases as they should execute in parallel without synchronization restrictions. This reverts commit 68a72399. Bug: chromium:726040 Change-Id: I76bb31d146f8aa20f8b7c486eeae9f09efa0cd53 Reviewed-on: https://chromium-review.googlesource.com/518150 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#45644}
-
Ben Smith authored
Bug: chromium:724973 Change-Id: I227b30b50f92fac7d6cf3ec3369e324282352ccb Reviewed-on: https://chromium-review.googlesource.com/514348Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#45643}
-
Clemens Hammacher authored
When checking {const char*} (or similar) against each other, don't print them as c strings on failure. Just print the pointer value. In wasm, where we use byte pointers into wasm wire bytes, this was sometimes hiding check failures behind segfaults which happened when trying to output invalid pointers as c strings. Anyway, it's more useful to see the raw pointer values in these cases. Other use cases, where we really compare against c string pointers should be rare in our code base. R=ishell@chromium.org Change-Id: I92a13221d18c987a97cf2a29ac8f454178ff2bb5 Reviewed-on: https://chromium-review.googlesource.com/517166 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#45642}
-
Andreas Haas authored
In https://chromium-review.googlesource.com/c/505614/ I added code to the test runner which deletes the old corpus of the wasm fuzzer. It's time now to remove this code again. R=machenbach@chromium.org Change-Id: Ic3b8f7a1f6d725f0bf070b404a75ac37551a07c0 Reviewed-on: https://chromium-review.googlesource.com/519405Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#45641}
-
jgruber authored
DebugInfo was very closely tied to break point support: * It contained only information relevant to break points. * It was created and freed by break point implementation. * Existence of a DebugInfo on the shared function info implied existence of break points. This CL is a step towards making DebugInfo usable by other debugging functionality such as block coverage by decoupling it from break point support, which is now only one kind of information stored on the DebugInfo object. BUG=v8:6000 Review-Url: https://codereview.chromium.org/2909893002 Cr-Commit-Position: refs/heads/master@{#45640}
-
Clemens Hammacher authored
Most prototype implementations are not fully supported in the interpreter. This is the case at least for exception handling, simd, and atomics. Any function can be redirected to the interpreter though, either by passing --wasm-interpret-all, or by dynamically redirecting to the interpreter for debugging. Making the flags experimental keeps the fuzzer from playing around with these flags. Drive-by: Refactor tests which explicitly set the prototype flag to use a new scope for that. R=ahaas@chromium.org BUG=chromium:727584 Change-Id: I67da79f579f1ac93c67189afef40c6524bdd4430 Reviewed-on: https://chromium-review.googlesource.com/519402 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#45639}
-
Jochen Eisinger authored
Also restrict include/ rules to only add bots for changes affecting headers R=machenbach@chromium.org Change-Id: I97dc3c6249994566912a82ac9fbf8c7d3a57890c Reviewed-on: https://chromium-review.googlesource.com/519342Reviewed-by:
-
Alexey Kozyatinskiy authored
V8 provides ScriptCompiler::CompileFunctionInContext method which takes expression and compile it as anonymous function like (function() .. expression ..). To produce correct locations for stmts inside of this expression V8 compile this function with negative offset. Instead of stmt position blackboxing use function start position which is negative in described case. Bug: chromium:705963 Change-Id: I86b113198fb59e77b3bbf523c8cd943e22f8a6ca Reviewed-on: https://chromium-review.googlesource.com/519384 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#45637}
-
Michael Achenbach authored
V8-side for: https://chromium-review.googlesource.com/c/519143/ NOTRY=true Bug: chromium:726584 Change-Id: Id6f186a47cfdf9287a399ce3fe58c9edb6474ed9 Reviewed-on: https://chromium-review.googlesource.com/519166Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45636}
-
neis authored
Instead of allocating and embedding certain heap numbers into the code during code assembly, emit dummies but record the allocation requests. Later then, in Assembler::GetCode, allocate the heap numbers and patch the code by replacing the dummies with the actual objects. The RelocInfos for the embedded objects are already recorded correctly when emitting the dummies. R=jarin@chromium.org BUG=v8:6048 Review-Url: https://codereview.chromium.org/2900683002 Cr-Commit-Position: refs/heads/master@{#45635}
-
Tobias Tebbi authored
Bug: chromium:726638 Change-Id: Ib30b147ec60f9f13c5164765f8c63be7a1339e9f Reviewed-on: https://chromium-review.googlesource.com/517497Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#45634}
-
martyn.capewell authored
This reverts commit c5aad5f2 The CL was reverted due to missing Chromium dependencies. This commit removes the simulator trace-based tests, and the associated header file dependencies, previously pulled in by DEPS. The NEON support now has only hand-written tests, in test-assembler-arm64.cc. The remaining tests can be added in a later patch. BUG=chromium:718439 Original issue's description: > Reland "ARM64: Add NEON support" > > This reverts commit cc047635. > The CL was reverted due to a missing DEPS mirror. > > Original issue's description: > > ARM64: Add NEON support > > > > Add assembler, disassembler and simulator support for NEON in the ARM64 backend. > > > > BUG= > > > > Review-Url: https://codereview.chromium.org/2622643005 > > Cr-Commit-Position: refs/heads/master@{#44306} > > BUG= > > Review-Url: https://codereview.chromium.org/2812573003 > Cr-Commit-Position: refs/heads/master@{#44652} Review-Url: https://codereview.chromium.org/2896303003 Cr-Commit-Position: refs/heads/master@{#45633}
-
Ulan Degenbaev authored
BUG=v8:6277 Change-Id: I80314e6c5146e1f5021d07081b9eda3da5da6834 Reviewed-on: https://chromium-review.googlesource.com/518047 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Chromium dropped this a while back. This'll prepare switching the bot to GN. NOTRY=true Bug: chromium:726584 Change-Id: I55d7ef7ae33b66c1ca6721acba018aa19438e2da Reviewed-on: https://chromium-review.googlesource.com/519404 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:6048 Change-Id: I685a629dec46d40c3518096b0a5d3901048e0bee Reviewed-on: https://chromium-review.googlesource.com/519165Reviewed-by:
-
jgruber authored
BUG=v8:5737 Review-Url: https://codereview.chromium.org/2913783002 Cr-Commit-Position: refs/heads/master@{#45629}
-
Michael Starzinger authored
This removes any kind of heap access from the asm.js validator internals and hence makes it independent of a specific Isolate. It is a precursor towards potentially being able to run validation while streaming. R=clemensh@chromium.org Change-Id: Ia3770bf03bb973b56de897b27be60d7e050af2c4 Reviewed-on: https://chromium-review.googlesource.com/518188 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45628}
-
Georg Neis authored
Bug: v8:6048 Change-Id: I1fbea87f6b7cb48c8f57532238475f2c17c863fb Reviewed-on: https://chromium-review.googlesource.com/519267Reviewed-by:
-
Ulan Degenbaev authored
Black allocation is switched on at the start of incremental marking if concurrent marking is enabled. New space objects in the allocation area are handled by the main thread. BUG=chromium:694255 Change-Id: I694affe11b95f51e2fe79563b2b048aaef982c03 Reviewed-on: https://chromium-review.googlesource.com/518862 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#45626}
-
Alexey Kozyatinskiy authored
In current implementation in expressions like await foo() we have break location right after foo call and before actual await. And we additionally have a lot of other statement locations because of do scope. Let's move async debugging closer to sync debugging and introduce only one break location for await - before awaited function call. Bug: v8:6425,v8:6162 Change-Id: I7568767856022c49101e7f3b7e39a2e401d21644 Reviewed-on: https://chromium-review.googlesource.com/514046Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45625}
-
Michael Lippautz authored
Bug: chromium:728096 Change-Id: I8f95f15b56cd49f3e199b74b119abb49eadfe2e1 Reviewed-on: https://chromium-review.googlesource.com/519163 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Peter Marshall authored
Causes crashes on canary if there is a GC and the value makes it onto the stack. Bug: chromium:727662 Change-Id: I44fa8cf8a83b43d64418896c0a1f5518401b454f Reviewed-on: https://chromium-review.googlesource.com/519302Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
R=mvstanton@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ib45a1d12f2ef869d8b07754d234ff0eedd542188 Reviewed-on: https://chromium-review.googlesource.com/517495 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ic2c4d90dbf91b43e6e4d9cba580385bfd61802ca Reviewed-on: https://chromium-review.googlesource.com/518044Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45621}
-
dusan.simicic authored
Add support for insert.df, andi.b, ori.b, nori.b, xori.b, bmnzi.b, bmzi.b, bseli.b, shf.df MSA instructions in mips32 and mips64 simulator. BUG= Review-Url: https://codereview.chromium.org/2908753002 Cr-Commit-Position: refs/heads/master@{#45620}
-
Igor Sheludko authored
... to properly handle stack overflows near the hard stack limit. Bug: chromium:716522 Change-Id: I6acdb29f039b9835bdf45b087d6561a05ed837bb Reviewed-on: https://chromium-review.googlesource.com/517799 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
BUG=chromium:694255 Change-Id: I7edece8191d85376d3435e799ac64f3cbe814456 Reviewed-on: https://chromium-review.googlesource.com/519002Reviewed-by:
-
Tobias Tebbi authored
The assertion was too strict, not matching the check in JSTypedArray::Create. Delete the TODO because the code does not actually rely on the assertion for safety: EmitElementStore always performs a length check. Drive-by-fix: KeyedAccessStoreMode::STANDARD_STORE is equally safe and does one comparison less. Bug: chromium:724889 Change-Id: I988a4eb6ad36d35143a008f7289b075f5c05e7ed Reviewed-on: https://chromium-review.googlesource.com/517102Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#45617}
-
Igor Sheludko authored
TBR=jarin@chromium.org NOTRY=true Bug: v8:6447 Change-Id: Ied42c4ba8fc19f2441f6c2ffd31d3f56055ac487 Reviewed-on: https://chromium-review.googlesource.com/518823Reviewed-by:
-
Marja Hölttä authored
- Enable aggressive lazy inner funcs (make non-declaration funcs lazy, ie let f = function() { ... } when --experimental-preparser-scope-analysis is on. - Turn on variable tracking for lazy top level functions: this makes their inner functions skippable. - Test fix for an testing bug uncovered by this work: when restoring the data for the relevant scope, don't assume it's the outermost scope for which we have data. - Fix: if we abort lazy parsing a function, we shouldn't produce any data for it. BUG=v8:5516 Change-Id: I0606fbabb5886dc57dbb53ab5f3fb894ff5d032e Reviewed-on: https://chromium-review.googlesource.com/518165Reviewed-by: -
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e840a06..0312f98 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/ea7d9cf..32a3f0b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/34e6d43..7474c16 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I30259bb2e7399419ee7f258e15edd9488efa7f16 Reviewed-on: https://chromium-review.googlesource.com/518722Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#45614}
-
dgozman authored
- introduced session id, which fixes an issue of reconnect while evaluating; - forEachContext provides a safe way to iterate over contexts in a group. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2905543004 Cr-Commit-Position: refs/heads/master@{#45613}
-
- 30 May, 2017 8 commits
-
-
Jochen Eisinger authored
Use the appropriate ENTER_V8* macros instead BUG=v8:5830 R=marja@chromium.org Change-Id: I85d7ae69830f6bad4f7057c4a646906846a1baa0 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/517793 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Retrieve length from the buffer instead of storing in as value in the map. This reverts commit a73323d3. Bug: Change-Id: I2f17b1b121380ec3d70f42d7cd0015720d6dc7d1 Reviewed-on: https://chromium-review.googlesource.com/518132Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#45611}
-
Ali Ijaz Sheikh authored
Bug: Change-Id: If8c9db5ad4114f9ce3ca925d85a776fdb7da8fed Reviewed-on: https://chromium-review.googlesource.com/513525Reviewed-by:
-
sampsong authored
BUG= R=jyan@ca.ibm.com, bjaideep@ca.ibm.com, joransiu@ca.ibm.com Review-Url: https://codereview.chromium.org/2905453002 Cr-Commit-Position: refs/heads/master@{#45609}
-
rodolph.perfetta authored
In TurboFan the ArchDebugBreak opcode is not used for debugging but to force a crash in unreachable or unimplemented code path. The opcode was marked as having no side effects allowing the scheduler to bring it "up" with unfortunate consequences. This patch also update the behaviour of assembler::debug when not using the simulator. Review-Url: https://codereview.chromium.org/2901383004 Cr-Commit-Position: refs/heads/master@{#45608}
-
jgruber authored
This adds a bunch of assertions to CSA, mostly about documenting and checking parameter types. Drive-by-change: Removed unused function. BUG=v8:6325 Review-Url: https://codereview.chromium.org/2847923003 Cr-Original-Original-Commit-Position: refs/heads/master@{#45398} Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd Review-Url: https://codereview.chromium.org/2847923003 Cr-Original-Commit-Position: refs/heads/master@{#45443} Committed: https://chromium.googlesource.com/v8/v8/+/62b0de1ef53816d6dae3fa519a846f942b701dda Review-Url: https://codereview.chromium.org/2847923003 Cr-Commit-Position: refs/heads/master@{#45607}
-
Michael Achenbach authored
This reverts commit a402dd63. Reason for revert: Breaks msan: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/15197 Original change's description: > [heap] Simplify array buffer tracker > > Retrieve length from the buffer instead of storing in as value in the > map. > > Change-Id: Icdc87bb46c29fff779bf6e98139324662ced5bf6 > Reviewed-on: https://chromium-review.googlesource.com/518171 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45600} NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=mlippautz@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I22e3590528beb911d366b9d93ec302857a631971 Reviewed-on: https://chromium-review.googlesource.com/518117 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
jgruber authored
Passing --print-builtin-size will print the size of all builtins on isolate creation. BUG=v8:5737 Review-Url: https://codereview.chromium.org/2895163002 Cr-Commit-Position: refs/heads/master@{#45605}
-
