- 26 Feb, 2019 23 commits
-
-
tzik authored
V8 used to use the microtask context when it runs EnqueueJob step 2. > Let job settings be some appropriate environment settings object. https://html.spec.whatwg.org/multipage/webappapis.html#enqueuejob(queuename,-job,-arguments) However, it's being updated to use the handler's context. https://github.com/whatwg/html/issues/1426#issuecomment-340071080 Change-Id: I24840a28ef2c903539fe4ace74ae59da290f5109 Reviewed-on: https://chromium-review.googlesource.com/c/1465902Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#59870}
-
Yang Guo authored
R=mlippautz@chromium.org Change-Id: Ic1d2fce007ddcb72f56ad257032e434c575a3f8d Reviewed-on: https://chromium-review.googlesource.com/c/1456104 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59869}
-
Allan Sandfeld Jensen authored
The logic for removing while iterating is non-standard and a left over from a previous index based loop. This patch replaces it with a standard erase based version. This fixes a runtime crash with MSVC that invalidates the iterator and then asserts. This also makes the code safe in case the last move can be redundant. Change-Id: Ie6990e0d65a3b83a4b7da3e2e89ed4e60a6cd215 Reviewed-on: https://chromium-review.googlesource.com/c/1488762Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59868}
-
Igor Sheludko authored
Bug: v8:8834 Change-Id: I4d57b15f2d5058511a2c474897a52cac236a6a00 Reviewed-on: https://chromium-review.googlesource.com/c/1488767Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#59867}
-
Toon Verwaest authored
GetSymbol previously always internalized the underlying string, even if the preparser does not need it. The most common case where this isn't needed is property name parsing. This seems to speed up preparsing quite a bit. For future reference: Property names in object literals still are needed due to various checks (e.g., get 'constructor', duplicate __proto__, ...); as well as cover grammar parsing (property names can turn into variable references). If we turn all strings that the preparser needs to identify back into contextual keywords we may be able to avoid the former. Change-Id: I549e4600053de3136ca08d4915cc04db36d66a89 Reviewed-on: https://chromium-review.googlesource.com/c/1488764Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59866}
-
Simon Zünd authored
This CL introduces a new expression that can replace "std::string" fields in other expressions. The main goal is to get SourcePositions for identifiers to make them available in the language server. The CL introduces a separate symbol "name", that allows to incrementellay replace strings with name expression where needed. As an example, variable delcarations now use a NameExpression for the variable name. R=danno@chromium.org, tebbi@chromium.org Bug: v8:7793 Change-Id: I5b88bbaeac597b8e9760d2e01880e5e599ebf802 Reviewed-on: https://chromium-review.googlesource.com/c/1488752 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59865}
-
Igor Sheludko authored
... which always contains constant value. Bug: v8:8834 Change-Id: I27af24d07371b112d48eaab4d3a782a74af5fb20 Reviewed-on: https://chromium-review.googlesource.com/c/1487611Reviewed-by:
-
Georg Neis authored
When --concurrent_inlining is on, precompute (during serialization) the list of receiver maps and the transition matrix of element accesses. Bug: v8:7790 Change-Id: I257eaea630f33831ab6600851ccdf297e17e35ca Reviewed-on: https://chromium-review.googlesource.com/c/1475769 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59863}
-
Jaroslav Sevcik authored
... as suggested by the bug's reporter. Bug: chromium:935358 Change-Id: Iab9d207e4f55a395d0496ef5d5ea0e9b6783ae66 Reviewed-on: https://chromium-review.googlesource.com/c/1488757Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59862}
-
Yang Guo authored
R=bmeurer@chromium.org Bug: chromium:934201 Change-Id: I73048fef3afea5d06be88a2768d77f7e349daef5 Reviewed-on: https://chromium-review.googlesource.com/c/1488760Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59861}
-
Toon Verwaest authored
By making EmptyIdentifierString (used for failure-mode parsing) point to the empty_string() we can drop nullptr checks in the preparser. This is similar to what the parser already does. Change-Id: I4640f7ae6b24afc8d5275818caed0cca185ca72c Reviewed-on: https://chromium-review.googlesource.com/c/1488759Reviewed-by:
-
Michael Achenbach authored
We'll remove the gcc version from the builder name in a follow up. TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:933093 Change-Id: I65359afd7245f155f7d1fd0519033ab8f8f736bb Reviewed-on: https://chromium-review.googlesource.com/c/1488758Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59859}
-
Toon Verwaest authored
That way we can avoid allocating unreusable zone memory. Change-Id: I0f30cbf5133026c63a9729bc45e728daa4740e9f Reviewed-on: https://chromium-review.googlesource.com/c/1488756Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 32fc0acf. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/30270 layout test breakage: https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64/30270/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html There is a dead node arriving in representation selection, which might indicate that the problem is not in this CL, but that this CL stirs up the node soup in such a way that dead code elimination gets confused. Original change's description: > Optimize `in` operator > > This change implements optimizations for the `in` operator for packed array > elements and object properties. It adds a new feedback slot kind and an IC > path similar to KeyedLoadIC for handling the lookups. TurboFan uses the > feedback to optimize based on the maps and keys. > > For more details see: > https://docs.google.com/document/d/1tIfzywY8AeNVcy_sen-5Xev21MeZwjcU8QhSdzHvXig > > This can provide 10x performance improvements of on loops of the form: > > for (let i = 0; i < ary.length; ++i) { > if (i in ary) { > ... > } > } > > > Bug: v8:8733 > Change-Id: I766bf865a547a059e5bce5399bb6112e5d9a85c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1432598 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Matt Gardner <magardn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#59843} TBR=ulan@chromium.org,rmcilroy@chromium.org,jkummerow@chromium.org,jarin@chromium.org,ishell@chromium.org,bmeurer@chromium.org,verwaest@chromium.org,magardn@microsoft.com Change-Id: Ib2db974e5bed4c4a2b6b450f796bdc4b0b8fd562 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8733 Reviewed-on: https://chromium-review.googlesource.com/c/1488761Reviewed-by:
-
Michael Starzinger authored
This flips the section codes for the exception section (part of the exception handling proposal) and the data-count section (part of the bulk memory proposal). Also see the following discussions for the underlying motivation: https://github.com/WebAssembly/bulk-memory-operations/pull/42 https://github.com/WebAssembly/exception-handling/issues/70 R=binji@chromium.org BUG=v8:8868 Change-Id: I9f5f524e7aec067720346a5bb8d45c7c80a4c7a2 Reviewed-on: https://chromium-review.googlesource.com/c/1478207Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59856}
-
Georg Neis authored
This directory is created by ccls (language server for C++ and others). R=sigurds@chromium.org Change-Id: I2413921ca896ad2003fcfd10fdadb739f1af18c8 Reviewed-on: https://chromium-review.googlesource.com/c/1487151Reviewed-by:
-
Sigurd Schneider authored
Remove EmbeddedVector from utils.h Bug: v8:8834, v8:8912 Change-Id: I04e9f12121757bd0b87c68d7a4a5b213c2d8b686 Reviewed-on: https://chromium-review.googlesource.com/c/1486473Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9f11dc3..ebd384a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I1cb46f5fdd1604f0beb509e18a1bda31bbe8a2e1 Reviewed-on: https://chromium-review.googlesource.com/c/1485245Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59853}
-
Michael Starzinger authored
R=ahaas@chromium.org TEST=mjsunit/regress/wasm/regress-935138 BUG=chromium:935138 Change-Id: I73465e0edcdfcd33b96764ffaf5f33519e424bb8 Reviewed-on: https://chromium-review.googlesource.com/c/1486471 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#59852}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:933093 Change-Id: I48236ef06c990526b72be418773d0a098c85178f Reviewed-on: https://chromium-review.googlesource.com/c/1488754Reviewed-by:
-
Georg Neis authored
Change-Id: I2d5b54c88bece3e22c4ae25d7fba094647f64f52 Reviewed-on: https://chromium-review.googlesource.com/c/1487051Reviewed-by:
-
Matt Gardner authored
MSVC 14.x and 15.x handle -0 correctly unless /fp:fast is used. /fp:precise is the default. bug: v8:3477, v8:8912 Change-Id: I242a1dfd845f750cab7c56f13107612259d44d23 Reviewed-on: https://chromium-review.googlesource.com/c/1487414Reviewed-by:
-
Simon Zünd authored
This CL contains a basic Json parser used to read and write the Json-RPC messages of the language server protocol. This CL is part of the initial language server implementation but submitted separately for easier review. R=tebbi@chromium.org Bug: v8:8880 Change-Id: Icea040975e1ed1d587954c3342d8d876e01c26b8 Reviewed-on: https://chromium-review.googlesource.com/c/1479956 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
- 25 Feb, 2019 17 commits
-
-
Caitlin Potter authored
Turns --harmony-hashbang on by default. Intent to ship: https://groups.google.com/d/msg/v8-dev/hlCVa_XZ3TM/UWjjyOq3FwAJ ChromeStatus page: https://www.chromestatus.com/feature/5134505706782720 BUG=v8:8523 R=gsathya@chromium.org, mathias@chromium.org, adamk@chromium.org Change-Id: I821f69e45eb0a63a3f49181e2b88b0bcd091af2c Reviewed-on: https://chromium-review.googlesource.com/c/1486113Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#59847}
-
Z Duong Nguyen-Huu authored
currently it cannot call run-tests.py since it use Linux path Change-Id: I15af9c7e6503e6d473611a24f5f223ff68b1dbbd Reviewed-on: https://chromium-review.googlesource.com/c/1484110Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#59846}
-
Frank Tang authored
This is a reland of f1b21a10 Original change's description: > [Intl] Ship Intl.Locale > > Bug: v8:7684 > Change-Id: I5994c3fc4b97c4322c4e0cf20305da75e66efd5a > Reviewed-on: https://chromium-review.googlesource.com/c/1478220 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59780} Bug: v8:7684 Change-Id: I4f73205398a9649e2f55a1b090cd3afffade68c4 Reviewed-on: https://chromium-review.googlesource.com/c/1480918Reviewed-by:
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: I6e9f6fc718928f2f86d3b3c2dd144a6636b05790 Reviewed-on: https://chromium-review.googlesource.com/c/1481895 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59844}
-
Matt Gardner authored
This change implements optimizations for the `in` operator for packed array elements and object properties. It adds a new feedback slot kind and an IC path similar to KeyedLoadIC for handling the lookups. TurboFan uses the feedback to optimize based on the maps and keys. For more details see: https://docs.google.com/document/d/1tIfzywY8AeNVcy_sen-5Xev21MeZwjcU8QhSdzHvXig This can provide 10x performance improvements of on loops of the form: for (let i = 0; i < ary.length; ++i) { if (i in ary) { ... } } Bug: v8:8733 Change-Id: I766bf865a547a059e5bce5399bb6112e5d9a85c8 Reviewed-on: https://chromium-review.googlesource.com/c/1432598Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This prevents accumulation of non-regular chunks if unmapper tasks are not making progress. Bug: chromium:934453 Change-Id: I552bc4f566f4be8877d9e806cca2aa9c284a7f4f Reviewed-on: https://chromium-review.googlesource.com/c/1483055Reviewed-by:
-
Mike Stanton authored
A custom deoptimization continuation point erroneously cast a parameter to a number. Tests added. BUG: v8:7672 Change-Id: I59848aacdedc1de9fd7d83d55045618f37d39fb0 Reviewed-on: https://chromium-review.googlesource.com/c/1485974Reviewed-by:
-
Michael Lippautz authored
Embedders should use EmbedderHeapTracer::RegisterEmbedderReference instead. Bug: chromium:923361 Change-Id: If76c0354475798b09af95bedee0890594b29cd14 Reviewed-on: https://chromium-review.googlesource.com/c/1486472Reviewed-by:
-
Jakob Gruber authored
This is a quirk needed for the regexp fuzzer, which passes its own custom RegExpMatchInfo object to RegExpImpl::Exec and expects execution without side effects. Bug: chromium:934621 Change-Id: I90286fda06593d7c574d8d4629481ebad2fa5b1d Reviewed-on: https://chromium-review.googlesource.com/c/1485833Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59839}
-
Ulan Degenbaev authored
This fixes the case of accumulating large pages after scavenges if there is no mark-compact GC. Bug: chromium:934453 Change-Id: Ide57c64ae985cc79ad9f477a759ab729f894c73b Reviewed-on: https://chromium-review.googlesource.com/c/1482740Reviewed-by:
-
Junliang Yan authored
Port 591408cb Original Commit Message: We'll need one bit in the SharedFunctionInfo::flags to record whether it's safe to skip arguments adaptor frames (for v8:8895), so this just removes the SharedFunctionInfo::IsDerivedConstructorBit which is redundant, since the same information is already available in the SharedFunctionInfo::FunctionKindBits, and most places in the code use that already, with the exception of the JSConstructStubGeneric builtin. This changes the JSConstructStubGeneric builtin to just check the function kind instead of testing the explicit bit, which also makes this more consistent. It seems like there's not much overhead to that, doing an additional bitmasking plus two comparisons instead of one. This shouldn't really matter since invocation and execution of the constructors is going to dominate and optimized code inlines all of this anyways. If this turns out to affect performance, we can still look into encoding the FunctionKindBits more cleverly. the shift when accessing the function kind. This seems logic, since for the actual boolean bit fields it doesn't matter where they are in the flags, whereas for the function kind this saves one shift. R=bmeurer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, miladfar@ca.ibm.com BUG= LOG=N Change-Id: I4e3ba5a066285bf50e869c32228d79d26d57258f Reviewed-on: https://chromium-review.googlesource.com/c/1486411Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#59837}
-
Pierre Langlois authored
When calling the `bitmap(chunk)` method of the various *MarkingState accessors we would receive a raw `Bitmap` pointer which does not tell you if accesses to markbits should be made atomically or not. As a result, we would default to doing atomic operation when in fact it may not be necessary. Here we're introducing a templated `ConcurrentBitmap` class that wraps operations done on the markbits and allows them to be made non-atomic. Additionaly, some of the `Bitmap` methods were only used to verify the heap and in the tests so they do not need atomic implementations. Using them in a concurrent context should now fail to link to make sure they're not mis-used in the future. Change-Id: Ifb55f8522c8bf0c87d65da9227864ee428d21bbd Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Reviewed-on: https://chromium-review.googlesource.com/c/1482916Reviewed-by:
-
Mike Stanton authored
This CL reduces the instruction size of Array.prototype.every and some by ~20%. Should performance allow it we could do the same for other array builtins. We attach a boolean to the FastJSArrayWitness that remembers if it's dealing with a FixedArray or a FixedDoubleArray. We have to check this in the loop, but it is likely that reduced code size more than pays for the extra check, since the loop will be dominated by the call to the users callback function. BUG: v8:7672 Change-Id: Id3bab2b163d7ba73424250d8bb194712909cd37e Reviewed-on: https://chromium-review.googlesource.com/c/1484293Reviewed-by:
-
Georg Neis authored
This was a pair of a set of maps and their common instance type (if any), but the instance type field was only used in a printing function. Removing the whole class in favor of ZoneHandleSet<Map> means we avoid looking at the heap to determine the common instance type. Eventually we can use the broker to do this if we need to. Bug: v8:7790 Change-Id: If0cadf9b17e3b9e77cffc4f0b69e2585aff7c85c Reviewed-on: https://chromium-review.googlesource.com/c/1481214Reviewed-by:
-
Tobias Tebbi authored
Since our allocations don't guarantee more than kTaggedSize alignment, it doesn't make sense to warn about mis-alignment beyond that. Bug: v8:8863 v8:7793 Change-Id: Ia1c2dd25efdb2c1084968ab4ffe8de25b8654cdb Reviewed-on: https://chromium-review.googlesource.com/c/1486251Reviewed-by:
-
Peter Marshall authored
This has been marked as flaky for a long time but was fixed by https://chromium-review.googlesource.com/c/v8/v8/+/1480378. Bug: v8:5193 Change-Id: I5f03f028fd006bcc83407b48ed49289c5573cade Reviewed-on: https://chromium-review.googlesource.com/c/1476993Reviewed-by:
-
Ross McIlroy authored
With stress bytecode flushing it's possible for the main SFI of a script to have it's bytecode flushed during deserialization of the script. If this happens, just fall-through to recompile the SFI. BUG=v8:8901,v8:8395 Change-Id: I786c1ca93167b76810481892ade525d14ff9168f Reviewed-on: https://chromium-review.googlesource.com/c/1485837Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59831}
-
