- 25 Jun, 2015 1 commit
-
-
erikcorry authored
Previous code review https://codereview.chromium.org/1182783009/ R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1204123003 Cr-Commit-Position: refs/heads/master@{#29290}
-
- 24 Jun, 2015 2 commits
-
-
machenbach authored
Revert of Extend big-disjunction optimization to case-independent regexps (patchset #5 id:80001 of https://codereview.chromium.org/1182783009/) Reason for revert: [Sheriff] Test times out now on msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2947 Original issue's description: > Extend big-disjunction optimization to case-independent regexps > > R=yangguo@chromium.org > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/d2135603bcf462e15a1284d8ed969f6692610dda > Cr-Commit-Position: refs/heads/master@{#29264} TBR=yangguo@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1204013003 Cr-Commit-Position: refs/heads/master@{#29266}
-
erikcorry authored
R=yangguo@chromium.org BUG=chromium:482998 LOG=n Review URL: https://codereview.chromium.org/1182783009 Cr-Commit-Position: refs/heads/master@{#29264}
-
- 15 Jun, 2015 1 commit
-
-
ulan authored
Reasons: - It is not used. - It complicates code in GC. BUG=chromium:499713 LOG=NO Review URL: https://codereview.chromium.org/1184723002 Cr-Commit-Position: refs/heads/master@{#29027}
-
- 04 Jun, 2015 1 commit
-
-
mbrandy authored
Embed constant pools within their corresponding Code objects. This removes support for out-of-line constant pools in favor of the new approach -- the main advantage being that it eliminates the need to allocate and manage separate constant pool array objects. Currently supported on PPC and ARM. Enabled by default on PPC only. This yields a 6% improvment in Octane on PPC64. R=bmeurer@chromium.org, rmcilroy@chromium.org, michael_dawson@ca.ibm.com BUG=chromium:478811 LOG=Y Review URL: https://codereview.chromium.org/1162993006 Cr-Commit-Position: refs/heads/master@{#28801}
-
- 03 Jun, 2015 2 commits
-
-
bbudge authored
LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1153373003 Cr-Commit-Position: refs/heads/master@{#28797}
-
bmeurer authored
Revert of Embedded constant pools. (patchset #12 id:220001 of https://codereview.chromium.org/1131783003/) Reason for revert: Breaks Linux nosnap cctest/test-api/FastReturnValuesWithProfiler, see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/609/steps/Check/logs/FastReturnValuesWithP.. Original issue's description: > Add support for Embedded Constant Pools for PPC and Arm > > Embed constant pools within their corresponding Code > objects. > > This removes support for out-of-line constant pools in favor > of the new approach -- the main advantage being that it > eliminates the need to allocate and manage separate constant > pool array objects. > > Currently supported on PPC and ARM. Enabled by default on > PPC only. > > This yields a 6% improvment in Octane on PPC64. > > R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com > BUG=chromium:478811 > LOG=Y > > Committed: https://crrev.com/a9404029343d65f146e3443f5280c40a97e736af > Cr-Commit-Position: refs/heads/master@{#28770} TBR=rmcilroy@chromium.org,ishell@chromium.org,rodolph.perfetta@arm.com,mbrandy@us.ibm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:478811 Review URL: https://codereview.chromium.org/1155703006 Cr-Commit-Position: refs/heads/master@{#28772}
-
- 02 Jun, 2015 2 commits
-
-
mbrandy authored
Embed constant pools within their corresponding Code objects. This removes support for out-of-line constant pools in favor of the new approach -- the main advantage being that it eliminates the need to allocate and manage separate constant pool array objects. Currently supported on PPC and ARM. Enabled by default on PPC only. This yields a 6% improvment in Octane on PPC64. R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:478811 LOG=Y Review URL: https://codereview.chromium.org/1131783003 Cr-Commit-Position: refs/heads/master@{#28770}
-
ishell authored
BUG= Review URL: https://codereview.chromium.org/1156993018 Cr-Commit-Position: refs/heads/master@{#28752}
-
- 01 Jun, 2015 2 commits
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
ishell authored
Review URL: https://codereview.chromium.org/1165603002 Cr-Commit-Position: refs/heads/master@{#28737}
-
- 30 Apr, 2015 2 commits
-
-
jochen authored
Original issue's description: > Remove the weak list of array buffers > > Instead, collect live array buffers during marking and free pointers we > no longer found. > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n BUG=v8:3996 TBR=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1115853004 Cr-Commit-Position: refs/heads/master@{#28156}
-
machenbach authored
Revert of Remove the weak list of array buffers (patchset #8 id:140001 of https://codereview.chromium.org/1114563002/) Reason for revert: [Sheriff] Crashes in layout tests: https://chromegw.corp.google.com/i/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2668 Original issue's description: > Remove the weak list of array buffers > > Instead, collect live array buffers during marking and free pointers we > no longer found. > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b > Cr-Commit-Position: refs/heads/master@{#28132} TBR=dslomov@chromium.org,hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1115043005 Cr-Commit-Position: refs/heads/master@{#28148}
-
- 29 Apr, 2015 2 commits
-
-
jochen authored
Instead, collect live array buffers during marking and free pointers we no longer found. BUG=v8:3996 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1114563002 Cr-Commit-Position: refs/heads/master@{#28132}
-
jkummerow authored
Review URL: https://codereview.chromium.org/1109153002 Cr-Commit-Position: refs/heads/master@{#28124}
-
- 27 Apr, 2015 1 commit
-
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1107843002 Cr-Commit-Position: refs/heads/master@{#28060}
-
- 24 Apr, 2015 1 commit
-
-
jochen authored
Revert of Reland "Remove the weak list of views from array buffers" (patchset #2 id:20001 of https://codereview.chromium.org/1093183004/) Reason for revert: still working on perf Original issue's description: > Reland "Remove the weak list of views from array buffers" > > Original description: > > Instead, views have to check their array buffer for whether > > it's neutered or not. > > > > BUG=v8:3996 > > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > > LOG=n > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/655b04637e9da2749f53c866bca8f5f6abb05a3f > Cr-Commit-Position: refs/heads/master@{#28029} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1053203007 Cr-Commit-Position: refs/heads/master@{#28038}
-
- 23 Apr, 2015 1 commit
-
-
jochen authored
Original description: > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1093183004 Cr-Commit-Position: refs/heads/master@{#28029}
-
- 22 Apr, 2015 2 commits
-
-
jochen authored
Revert of Remove the weak list of views from array buffers (patchset #6 id:100001 of https://codereview.chromium.org/1094863002/) Reason for revert: I'm reverting this while working on the regression fix Original issue's description: > Remove the weak list of views from array buffers > > Instead, views have to check their array buffer for whether > it's neutered or not. > > BUG=v8:3996 > R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org > LOG=n > > Committed: https://crrev.com/5ae083a05a6743d6cb91585f449539f7846a5d8c > Cr-Commit-Position: refs/heads/master@{#27995} TBR=dslomov@chromium.org,hpayer@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1061753008 Cr-Commit-Position: refs/heads/master@{#28014}
-
jochen authored
Instead, views have to check their array buffer for whether it's neutered or not. BUG=v8:3996 R=hpayer@chromium.org,dslomov@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1094863002 Cr-Commit-Position: refs/heads/master@{#27995}
-
- 13 Apr, 2015 1 commit
-
-
adamk authored
This avoids both a mysterious boolean argument ("insert") and lets non-mutating lookups skip passing an allocator (in one such case, we were passing a scary-looking ZoneAllocationPolicy(NULL)!). Review URL: https://codereview.chromium.org/1074943002 Cr-Commit-Position: refs/heads/master@{#27799}
-
- 07 Apr, 2015 1 commit
-
-
jkummerow authored
The motivation is that we prefer to avoid creating internal properties, and we have a usable field on maps ("transitions", which is not used for prototype maps). This CL also ensures the invariant that prototype maps are never shared, even if they are in dictionary mode. Review URL: https://codereview.chromium.org/1033653002 Cr-Commit-Position: refs/heads/master@{#27617}
-
- 26 Mar, 2015 1 commit
-
-
yurys authored
Before this patch the embedder could assign timestamp to the last interval after calling GetHeapStats. This would be slightly different from the timstamps assigned by v8 internally and written into heap snapshot. This patch allow to avoid this small discrepancy by returning timestamp along with last heap stats update. BUG=chromium:467222 LOG=Y Review URL: https://codereview.chromium.org/1037803002 Cr-Commit-Position: refs/heads/master@{#27466}
-
- 24 Mar, 2015 1 commit
-
-
yurys authored
Every time embedder calls v8::HeapProfiler::GetHeapStats we store next unuassigned heap object id and timestamp of the request. This patch serializes all that data into heap snapshot so that embedder can restore allocation timeline. BUG=chromium:467222 LOG=Y Review URL: https://codereview.chromium.org/1019813004 Cr-Commit-Position: refs/heads/master@{#27384}
-
- 18 Mar, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1015983003 Cr-Commit-Position: refs/heads/master@{#27274}
-
- 17 Mar, 2015 1 commit
-
-
dcarney authored
additionally, remove unnecessary deopts when transitioning to global accessor properties from data properties R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/996133002 Cr-Commit-Position: refs/heads/master@{#27239}
-
- 10 Mar, 2015 1 commit
-
-
yurys authored
None of these fields is used in Blink. Embedder always can implement them using existing API. BUG=chromium:465651 LOG=Y Review URL: https://codereview.chromium.org/983833006 Cr-Commit-Position: refs/heads/master@{#27113}
-
- 06 Mar, 2015 1 commit
-
-
jkummerow authored
Original issue: https://codereview.chromium.org/980573002/ Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/988703002 Cr-Commit-Position: refs/heads/master@{#27044}
-
- 05 Mar, 2015 2 commits
-
-
jkummerow authored
Revert of Simplify and compact transitions storage (patchset #4 id:80001 of https://codereview.chromium.org/980573002/) Reason for revert: x64 test failures Original issue's description: > Simplify and compact transitions storage > > Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. > To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. > > Committed: https://crrev.com/45fbef7f2252fce10634931cb103ccc1fc95ae6a > Cr-Commit-Position: refs/heads/master@{#27029} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/982143002 Cr-Commit-Position: refs/heads/master@{#27030}
-
jkummerow authored
Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/980573002 Cr-Commit-Position: refs/heads/master@{#27029}
-
- 24 Feb, 2015 1 commit
-
-
jkummerow authored
Review URL: https://codereview.chromium.org/950283002 Cr-Commit-Position: refs/heads/master@{#26835}
-
- 05 Feb, 2015 1 commit
-
-
marja authored
size_t is the correct data type for this purpose. Our APIs (in particular ExternalSourceStream::GetMoreData) are already using it, and there were some static_casts to convert between them. This CL doesn't intend to fix all of V8, just the minimal sense-making part around scanner character streams. BUG= Review URL: https://codereview.chromium.org/864273005 Cr-Commit-Position: refs/heads/master@{#26449}
-
- 19 Jan, 2015 2 commits
-
-
ishell authored
PropertyKind: DATA -> kData ACCESSOR -> kAccessor PropertyType: FIELD -> DATA CONSTANT -> DATA_CONSTANT ACCESSOR_FIELD -> ACCESSOR CALLBACKS -> ACCESSOR_CONSTANT PropertyLocation: IN_OBJECT -> kField IN_DESCRIPTOR -> kDescriptor StoreMode: FORCE_IN_OBJECT -> FORCE_FIELD FieldDescriptor -> DataDescriptor ConstantDescriptor -> DataConstantDescriptor CallbacksDescriptor -> AccessorConstantDescriptor Review URL: https://codereview.chromium.org/856503002 Cr-Commit-Position: refs/heads/master@{#26146}
-
jochen authored
BUG=chromium:449943 R=svenpanne@chromium.org LOG=n Review URL: https://codereview.chromium.org/848403003 Cr-Commit-Position: refs/heads/master@{#26127}
-
- 07 Jan, 2015 1 commit
-
-
dcarney authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/834443004 Cr-Commit-Position: refs/heads/master@{#25981}
-
- 16 Dec, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/805453002 Cr-Commit-Position: refs/heads/master@{#25842}
-
- 19 Nov, 2014 1 commit
-
-
ishell authored
First step towards replacing PropertyType with two enums: {DATA,ACCESSOR} x {CONST,WRITABLE}. Review URL: https://codereview.chromium.org/733253004 Cr-Commit-Position: refs/heads/master@{#25417}
-
- 13 Nov, 2014 1 commit
-
-
Yang Guo authored
This allows serializing public symbols that are embedded in code. BUG=v8:3689 LOG=N R=rossberg@chromium.org Review URL: https://codereview.chromium.org/722723002 Cr-Commit-Position: refs/heads/master@{#25315}
-
- 12 Nov, 2014 1 commit
-
-
dslomov@chromium.org authored
1. Global{Context,Scope}=>Script{Context,Scope} 2. Enable fixed tests 3. Update comments R=rossberg@chromium.org BUG=v8:2198 LOG=N Review URL: https://codereview.chromium.org/716833002 Cr-Commit-Position: refs/heads/master@{#25291} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25291 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
MapCache simplification. It is now a FixedArray that maps number of properties to a WeakCell with a Map. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/712943002 Cr-Commit-Position: refs/heads/master@{#25253} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25253 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-