1. 17 Dec, 2019 1 commit
    • Toon Verwaest's avatar
      [json] Update feedback maps since they might be deprecated · 08a5b95d
      Toon Verwaest authored
      Objects in arrays take the shape of the object right before as feedback to
      speed up object creation. If a subsequent object with the same shape has a
      member that also has the same shape, that member can cause the feedback map to
      be deprecated. To avoid confusion, we now update (dedeprecate) the feedback map
      before use.
      
      Thanks a bunch Seth Brenith for figuring out the issue!
      
      Bug: chromium:1029077
      Change-Id: I047b1acfd4906616a2302f253ab9cd29272bdc79
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970211
      Commit-Queue: Toon Verwaest <verwaest@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Auto-Submit: Toon Verwaest <verwaest@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65474}
      08a5b95d
  2. 26 Nov, 2019 1 commit
    • Jakob Kummerow's avatar
      More LookupIterator fixes after r65078 · 3ac7a3e5
      Jakob Kummerow authored
      (1) One more place in ic.cc must guard against "lookup->name()" calls
      when the LookupIterator might be in indexed mode.
      
      (2) Rather than burdening LookupIterator users with specifying
      "kGuaranteedNoTypedArray", we can do the corresponding calculation in
      the LookupIterator itself, which makes it robust towards any callers
      that haven't been updated (specifically, in Object.values).
      
      Bug: chromium:1027461,chromium:1028213
      Change-Id: I76b5d08e309fc2a694955b537adbeb5a30e681f7
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1936474Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65177}
      3ac7a3e5
  3. 25 Nov, 2019 3 commits
  4. 20 Nov, 2019 1 commit
  5. 15 Nov, 2019 1 commit
  6. 31 Oct, 2019 1 commit
  7. 11 Oct, 2019 1 commit
  8. 02 Oct, 2019 1 commit
  9. 28 Aug, 2019 1 commit
  10. 26 Aug, 2019 1 commit
  11. 20 Aug, 2019 1 commit
  12. 05 Aug, 2019 1 commit
  13. 09 Jul, 2019 1 commit
  14. 26 Jun, 2019 1 commit
  15. 24 Jun, 2019 1 commit
    • Mathias Bynens's avatar
      [objects] Rename JSValue to JSPrimitiveWrapper · e428dfd7
      Mathias Bynens authored
      We currently use the class name “JSValue” for JSObjects that wrap
      primitive values. This name is a common source of confusion. This patch
      switches to a name that’s more clear.
      
      In addition to manual tweaks, the patch applies the following mechanical
      global replacements:
      
      before                          | after
      --------------------------------|--------------------------------------
      if_valueisnotvalue              | if_valueisnotwrapper
      if_valueisvalue                 | if_valueiswrapper
      js_value                        | js_primitive_wrapper
      JS_VALUE_TYPE                   | JS_PRIMITIVE_WRAPPER_TYPE
      JSPrimitiveWrapperType          | JSPrimitiveWrapper type
      jsvalue                         | js_primitive_wrapper
      JSValue                         | JSPrimitiveWrapper
      _GENERATED_JSVALUE_FIELDS       | _GENERATED_JSPRIMITIVE_WRAPPER_FIELDS
      
      Change-Id: I9d9edea784eab6067b013e1f781e4db2070f807c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672942Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#62337}
      e428dfd7
  16. 30 May, 2019 1 commit
  17. 24 May, 2019 1 commit
  18. 23 May, 2019 5 commits
  19. 22 May, 2019 1 commit
  20. 21 May, 2019 4 commits