- 06 Apr, 2016 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1865863003 Cr-Commit-Position: refs/heads/master@{#35297}
-
- 29 Feb, 2016 1 commit
-
-
bmeurer authored
Rename the existing (patching) ToBooleanStub to ToBooleanICStub to match our naming convention, and add a new TurboFan-powered ToBooleanStub, which just does the ToBoolean conversion without any runtime call or code patching, so we can use it for Ignition (and TurboFan). Drive-by-fix: Add an Oddball::to_boolean field similar to the ones we already have for to_string and to_number, so we don't need to actually dispatch on the concrete Oddball at all. R=epertoso@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/1744163002 Cr-Commit-Position: refs/heads/master@{#34361}
-
- 26 Nov, 2015 1 commit
-
-
rossberg authored
Moves all files related to AST and scopes into ast/, and all files related to scanner & parser to parsing/. Also eliminates a couple of spurious dependencies. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1481613002 Cr-Commit-Position: refs/heads/master@{#32351}
-
- 17 Nov, 2015 1 commit
-
-
mvstanton authored
BUG= Review URL: https://codereview.chromium.org/1424153003 Cr-Commit-Position: refs/heads/master@{#32040}
-
- 01 Oct, 2015 1 commit
-
-
ishell authored
This CL also allows to use arbitrary number of feedback vector elements for particular slot kind. Review URL: https://codereview.chromium.org/1370303004 Cr-Commit-Position: refs/heads/master@{#31050}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 10 Sep, 2015 1 commit
-
-
mvstanton authored
The refactoring is because it's awkward and error-prone to deterimine which IC slot an ObjectLiteralProperty uses for feedback. The fix is for each one to know it's own slot. In the numbering pass, we allocate slots for the ObjectLiteral, then hand out those slots into the properties. It adds one word to the ObjectLiteralProperty expression - I'm investigating if thats a problem. This changes makes compiling the object literal cleaner across the three compilers. Also, the slot allocation logic in ObjectLiteral::ComputeFeedbackRequirements() was refactoring to mimic the style in full-codegen. This is useful since it must remain in sync with FullCodegen::VisitObjectLiteral(). Review URL: https://codereview.chromium.org/1321993004 Cr-Commit-Position: refs/heads/master@{#30686}
-
- 04 Sep, 2015 1 commit
-
-
mvstanton authored
The last changes for vector store functionality, they are in 3 areas: 1) The new vector [keyed] store code stubs - implementation. 2) IC and handler compiler adjustments 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. TBR=bmeurer@chromium.org, jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/1319123004 Cr-Commit-Position: refs/heads/master@{#30581}
-
- 03 Sep, 2015 2 commits
-
-
machenbach authored
Revert of Vector ICs: platform support for vector-based stores. (patchset #7 id:120001 of https://codereview.chromium.org/1328603003/ ) Reason for revert: [Sheriff] Breaks compile on arm: http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20builder/builds/6590 Original issue's description: > Vector ICs: platform support for vector-based stores. > > The last changes for vector store functionality, they are in 3 areas: > > 1) The new vector [keyed] store code stubs - implementation. > 2) IC and handler compiler adjustments > 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. > > BUG= > > Committed: https://crrev.com/63af1b3aec6547e7cdf502666ff79c562de8b679 > Cr-Commit-Position: refs/heads/master@{#30570} TBR=bmeurer@chromium.org,jkummerow@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1303053004 Cr-Commit-Position: refs/heads/master@{#30571}
-
mvstanton authored
The last changes for vector store functionality, they are in 3 areas: 1) The new vector [keyed] store code stubs - implementation. 2) IC and handler compiler adjustments 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. BUG= Review URL: https://codereview.chromium.org/1328603003 Cr-Commit-Position: refs/heads/master@{#30570}
-
- 28 Aug, 2015 1 commit
-
-
mvstanton authored
Also, polymorphic element stores have a slightly different shape for the array attached to a vector slot. It's of the form [map, map, handler], where the 2nd map is either a transition map or undefined (the maps are actually in WeakCells). Review URL: https://codereview.chromium.org/1316953003 Cr-Commit-Position: refs/heads/master@{#30432}
-
- 20 Aug, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1285183010 Cr-Commit-Position: refs/heads/master@{#30263}
-
- 25 Jun, 2015 1 commit
-
-
bbudge authored
I missed some functions that need to change. LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1199413009 Cr-Commit-Position: refs/heads/master@{#29276}
-
- 27 May, 2015 1 commit
-
-
jkummerow authored
And delete remnants of non-vectorized LoadICs from the type feedback oracle Review URL: https://codereview.chromium.org/1147253004 Cr-Commit-Position: refs/heads/master@{#28650}
-
- 05 May, 2015 2 commits
-
-
danno authored
Revert of Collect type feedback on result of Math.[round|ceil|floor] (patchset #13 id:230001 of https://codereview.chromium.org/1053143005/) Reason for revert: All sorts of performance regressions Original issue's description: > Collect type feedback on result of Math.[round|ceil|floor] > > By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. > > Committed: https://crrev.com/f36ecaf3a4d61568ca50a20718acce7dd5da9a5f > Cr-Commit-Position: refs/heads/master@{#28215} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1115973005 Cr-Commit-Position: refs/heads/master@{#28237}
-
danno authored
By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. Review URL: https://codereview.chromium.org/1053143005 Cr-Commit-Position: refs/heads/master@{#28215}
-
- 15 Apr, 2015 1 commit
-
-
mvstanton authored
We'd like to know in optimized code with more precision what feedback state was achieved for a load. R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/1083933002 Cr-Commit-Position: refs/heads/master@{#27826}
-
- 26 Mar, 2015 1 commit
-
-
verwaest authored
Instead of CanRetainOtherContext, we now manually blacklist all access-checked objects. BUG= Review URL: https://codereview.chromium.org/1020803004 Cr-Commit-Position: refs/heads/master@{#27473}
-
- 10 Mar, 2015 1 commit
-
-
Ben L. Titzer authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/979323005 Cr-Commit-Position: refs/heads/master@{#27111}
-
- 29 Jan, 2015 1 commit
-
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/885813002 Cr-Commit-Position: refs/heads/master@{#26315}
-
- 23 Jan, 2015 1 commit
-
-
danno authored
Along the way: - Thread isolate parameter explicitly through code that used to rely on getting it from the zone. - Canonicalize the parameter position of isolate and zone for affected code - Change Hydrogen New<> instruction templates to automatically pass isolate R=mstarzinger@chromium.org LOG=N Review URL: https://codereview.chromium.org/868883002 Cr-Commit-Position: refs/heads/master@{#26252}
-
- 19 Dec, 2014 1 commit
-
-
mvstanton authored
r25817 optimized hydrogen keyed loads with string keys. (https://codereview.chromium.org/755513003). This CL adapts that work for the vector-ic keyed load. BUG= Review URL: https://codereview.chromium.org/820673002 Cr-Commit-Position: refs/heads/master@{#25903}
-
- 15 Dec, 2014 1 commit
-
-
fedor.indutny authored
Keyed loads should not unconditionally be compiled to element loads. Update KeyedLoadICs to keep track of the key type, so that Hydrogen can emit ICs for string-keyed loads it doesn't have inline support for. BUG=v8:3167 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/755513003 Cr-Commit-Position: refs/heads/master@{#25817}
-
- 27 Nov, 2014 1 commit
-
-
Michael Stanton authored
The IC system now fully integrates the vector concept and can handle loads and keyed loads vector-based. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/754303003 Cr-Commit-Position: refs/heads/master@{#25552}
-
- 20 Nov, 2014 1 commit
-
-
ulan authored
if there is not enough type-feedback to detect that f is Function.prototype.apply. BUG=v8:3709 LOG=N TEST=mjsunit/regress/regress-3709 Review URL: https://codereview.chromium.org/736043002 Cr-Commit-Position: refs/heads/master@{#25447}
-
- 20 Oct, 2014 1 commit
-
-
mvstanton@chromium.org authored
BUG=v8:3605 LOG=N R=jkummerow@chromium.org, ulan@chromium.org Review URL: https://codereview.chromium.org/650073002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Oct, 2014 2 commits
-
-
jkummerow@chromium.org authored
BUG=chromium:422212 LOG=n R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/648703002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24529 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
It's good to have typing around this value. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/641373002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Oct, 2014 1 commit
-
-
jkummerow@chromium.org authored
Bonus: fix bitrot in (disabled) Hydrogen-BCH R=yangguo@chromium.org Review URL: https://codereview.chromium.org/623513002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Sep, 2014 1 commit
-
-
mvstanton@chromium.org authored
The TypeFeedbackVector is poised to host significant functionality. While it remains a FixedArray under the covers, we need a place to hold logic and definitions unique to its function. BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/581993002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24027 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/444623002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Jul, 2014 1 commit
-
-
verwaest@chromium.org authored
Adjust hydrogen handling of function.prototype to be based on map feedback. Handle non-instance prototype loading using an IC rather than in the hydrogen instruction. In the future, remove the special instruction and replace by multiple hydrogen instructions. BUG= R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/408193002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22526 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2014 2 commits
-
-
mvstanton@chromium.org authored
Comparing one CallIC::State to another was not done correctly, leading to a failure to patch a CallIC when transitioning from monomorphic Array to megamorphic. BUG=chromium:377198,chromium:377290 LOG=Y R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/305493003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21499 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
This reverts r21429, r21434, r21435, r21440, r21445. BUG=chromium:377198 LOG=y R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/300693002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 May, 2014 1 commit
-
-
mvstanton@chromium.org authored
Gather transition feedback on array calls, and inline the Array function call when it makes sense. R=danno@chromium.org Review URL: https://codereview.chromium.org/279423005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Apr, 2014 1 commit
-
-
mvstanton@chromium.org authored
LOG=N BUG=v8:3212 R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/254623002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21085 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Mar, 2014 1 commit
-
-
mvstanton@chromium.org authored
This reverts commit r19919. TBR=bmeuer@chromium.org Review URL: https://codereview.chromium.org/196343021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19961 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Mar, 2014 1 commit
-
-
mvstanton@chromium.org authored
Attempting to re-use the type feedback vector stored in the SharedFunctionInfo turns out to be difficult among the various cases. It will be much easier to do this when deferred type feedback processing is removed, as is in the works. Created bug v8:3212 to track re-introducing the optimization of reusing the type vector on recompile before optimization. The CL also brings back the type vector on the SharedFunctionInfo. BUG=351257 LOG=Y R=bmeurer@chromium.org, bmeuer@chromium.org Review URL: https://codereview.chromium.org/199973004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19919 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-