- 13 May, 2016 3 commits
-
-
hablich authored
Revert of [Reland] Implement CPU time for OS X and POSIX. (patchset #1 id:1 of https://codereview.chromium.org/1966183003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1972303002/ Original issue's description: > [Reland] Implement CPU time for OS X and POSIX. > > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch > implements CPU time for OS X and POSIX to provide more accurate > accounting of CPU time used by each thread. > > BUG=v8:4984 > LOG=n > > Committed: https://crrev.com/efa27fb25e1fa5b8465f4af710086b73b0cba660 > Cr-Commit-Position: refs/heads/master@{#36213} TBR=fmeawad@chromium.org,jochen@chromium.org,rsesek@chromium.org,bmeurer@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4984 Review-Url: https://codereview.chromium.org/1977753002 Cr-Commit-Position: refs/heads/master@{#36225}
-
machenbach authored
Revert of add UseCounters for NonOctalDecimalIntegerLiteral in strict mode (patchset #6 id:100001 of https://codereview.chromium.org/1948403002/ ) Reason for revert: [Sheriff] Breaks https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/602 Original issue's description: > In parallel to the strict octal check that would reject `012` in strict mode, this patch collects UseCounters for `089` in strict mode. The spec says this should be an error, but this patch does not report it as such. > > BUG=v8:4973 > LOG=y > > Committed: https://crrev.com/d0b6686c14339bd5d0aeaf610705c7ed85393e1f > Cr-Commit-Position: refs/heads/master@{#36221} TBR=littledan@chromium.org,caitpotter88@gmail.com,jwolfe@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4973 Review-Url: https://codereview.chromium.org/1970333004 Cr-Commit-Position: refs/heads/master@{#36224}
-
v8-autoroll authored
Rolling v8/build to b9f715e76c74cb252f60796f4276888cd5b4b5fb TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1972923005 Cr-Commit-Position: refs/heads/master@{#36223}
-
- 12 May, 2016 33 commits
-
-
vogelheim authored
Expression::bounds_ is used only by a subset of compile passes, but the data structure occupies space for every Expression node ever parsed. This unneccessarily increases memory consumption. Particularly, peak memory consumption during startup, which may cause out-of-memory errors. This CL - removes Expression::bounds_; - introduces an AstTypeBounds container, which mappes Expression* to Bounds; - modifies the code that actually requires bounds information, namely Crankshaft compile and AsmWasmBuilder, to instantiate such an AstTypeBounds container before typing and to pass it to the code that consumes this information; and - modifies all accesses to Expression::bounds_ to instead access the bounds via the container instead. Additionally, this rewrites test-ast-expression-visitor. The reason is that this code attempted to test AstExpressionVisitor but did so exclusively through its subclass ExpressionTypeCollector, meaning that the test dealt almost exclusively with type bounds despite the class-under-test having no knowledge or functionality related to it. Worse, the test was written in a way to assume that type bounds were available outside & after compilation, which is something this change changes. BUG=v8:4947 Review-Url: https://codereview.chromium.org/1968383002 Cr-Commit-Position: refs/heads/master@{#36222}
-
jwolfe authored
In parallel to the strict octal check that would reject `012` in strict mode, this patch collects UseCounters for `089` in strict mode. The spec says this should be an error, but this patch does not report it as such. BUG=v8:4973 LOG=y Review-Url: https://codereview.chromium.org/1948403002 Cr-Commit-Position: refs/heads/master@{#36221}
-
oth authored
This change introduces a pipeline for the final stages of bytecode generation. The peephole optimizer is made distinct from the BytecodeArrayBuilder. A new BytecodeArrayWriter is responsible for writing bytecode. It also keeps track of the maximum register seen and offers a potentially smaller frame size. R=rmcilroy@chromium.org LOG=N BUG=v8:4280 Review-Url: https://codereview.chromium.org/1947403002 Cr-Commit-Position: refs/heads/master@{#36220}
-
bmeurer authored
We eagerly inserted Int32Mul for Math.imul during builtin lowering and messed up with the types, which confused the representation selection. This adds a proper NumberImul operator, and fixes the builtin reducer to do the right thing according to the spec. R=mstarzinger@chromium.org BUG=v8:5006 LOG=n Review-Url: https://codereview.chromium.org/1971163002 Cr-Commit-Position: refs/heads/master@{#36219}
-
jacob.bramley authored
The usat instruction is available from ARMv6, so there's no need to check for the ARMv7 feature before using it. ARMv6 is the oldest supported architecture in V8. Correcting this allows the removal of a special case for predictable code size. BUG= Review-Url: https://codereview.chromium.org/1974903002 Cr-Commit-Position: refs/heads/master@{#36218}
-
rmcilroy authored
Adds a V8.Execute histogram to measure the amount of time spent executing JS code. BUG=v8:4865 LOG=N Review-Url: https://codereview.chromium.org/1974003002 Cr-Commit-Position: refs/heads/master@{#36217}
-
mstarzinger authored
This adds the --validate-asm flag which will trigger validation of all asm.js modules before they are being compiled. In case a module doesn't pass validation, a warning will be printed, but compilation as well as execution will continue unhampered. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/1972593002 Cr-Commit-Position: refs/heads/master@{#36216}
-
adamk authored
Also make all AstVisitors consistently visit all the relevant parts of ForOfStatement. PrettyPrinter no longer fares well, but given how much desugaring happens to ForOf in the parser, any pretty-printed view of it isn't going to be human readable. AstPrinter, on the other hand, now gives a realistic view of what's been generated for for-of. Review-Url: https://codereview.chromium.org/1968753004 Cr-Commit-Position: refs/heads/master@{#36215}
-
nikolaos authored
This flag forces the page to (soft) refresh a given number of times for each iteration. The statistics of all refreshes are collected in the same file. R=cbruni@chromium.org, mvstanton@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/1967123002 Cr-Commit-Position: refs/heads/master@{#36214}
-
lpy authored
V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch implements CPU time for OS X and POSIX to provide more accurate accounting of CPU time used by each thread. BUG=v8:4984 LOG=n Review-Url: https://codereview.chromium.org/1966183003 Cr-Commit-Position: refs/heads/master@{#36213}
-
ahaas authored
The operators are needed because the wasm spec requires that nan bits are preserved. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/1973493003 Cr-Commit-Position: refs/heads/master@{#36212}
-
machenbach authored
BUG=chromium:611010 NOTRY=true Review-Url: https://codereview.chromium.org/1976593002 Cr-Commit-Position: refs/heads/master@{#36211}
-
machenbach authored
BUG=chromium:474921 LOG=n NOTRY=true Review-Url: https://codereview.chromium.org/1971133002 Cr-Commit-Position: refs/heads/master@{#36210}
-
hablich authored
Revert of Remove v8_toolset_for_d8 flag (patchset #1 id:1 of https://codereview.chromium.org/1969793002/ ) Reason for revert: blocks roll: https://codereview.chromium.org/1975753002/ Original issue's description: > Remove v8_toolset_for_d8 flag > > R=machenbach@chromium.org > BUG=chromium:609107 > > Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4 > Cr-Commit-Position: refs/heads/master@{#36198} TBR=machenbach@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:609107 Review-Url: https://codereview.chromium.org/1974773002 Cr-Commit-Position: refs/heads/master@{#36209}
-
clemensh authored
Names passed for imports and exports are checked during decoding, leading to errors if they are no valid UTF-8. Function names are not checked during decode, but rather lead to undefined being returned at runtime if they are not UTF-8. We need to do these checks on the Wasm side, since the factory methods assume to get valid UTF-8 strings. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1967023004 Cr-Commit-Position: refs/heads/master@{#36208}
-
ahaas authored
With this CL it is possible to compile a wasm module with multiple threads in parallel. Parallel compilation works as follows: 1) The main thread allocates a compilation unit for each wasm function. 2) The main thread spawns WasmCompilationTasks which run on the background threads. 3.a) The background threads and the main thread pick one compilation unit at a time and execute the parallel phase of the compilation unit. After finishing the execution of the parallel phase, the compilation unit is stored in a result queue. 3.b) If the result queue contains a compilation unit, the main thread dequeues it and finishes its compilation. 4) After the execution of the parallel phase of all compilation units has started, the main thread waits for all WasmCompilationTasks to finish. 5) The main thread finalizes the compilation of the module. I'm going to add some additional tests before committing this CL. R=titzer@chromium.org, bmeurer@chromium.org, mlippautz@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/17215438659d8ff2d7d55f95226bf8a1477ccd79 Cr-Commit-Position: refs/heads/master@{#36178} Review-Url: https://codereview.chromium.org/1961973002 Cr-Commit-Position: refs/heads/master@{#36207}
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/1870693002 Cr-Commit-Position: refs/heads/master@{#36206}
-
jgruber authored
Any function that is being compiled for live edit is marked as debug. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/1977433002 Cr-Commit-Position: refs/heads/master@{#36205}
-
jgruber authored
We will use this function to find toplevel function infos in an upcoming commit. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/1970153002 Cr-Commit-Position: refs/heads/master@{#36204}
-
jochen authored
BUG=chromium:609134 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/1973513002 Cr-Commit-Position: refs/heads/master@{#36203}
-
clemensh authored
And add more tests for traps at different locations. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1924253002 Cr-Commit-Position: refs/heads/master@{#36202}
-
cbruni authored
Currently we do not check for @@isConcatSpreadable properly. If the Symbol is set on the Array.prototype or Object.prototype the current fast paths fail. This CL adds a fix to globally invalidate a isConcatSpreadable_protector. Drive-by-fix: use named accessors for context variables LOG=N BUG=chromium:542504, v8:903 Review-Url: https://codereview.chromium.org/1409123003 Cr-Commit-Position: refs/heads/master@{#36201}
-
jgruber authored
Clear the list of shared function infos attached to a script before compiling for live edit in order to avoid duplicates. This was lost in 058deb27. Additionally, we restore the original list of shared function infos once we're done with live edit work. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/1969293003 Cr-Commit-Position: refs/heads/master@{#36200}
-
machenbach authored
Revert of Change v8_snapshot_toolchain to be a GN build arg. (patchset #3 id:40001 of https://codereview.chromium.org/1969693002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/1974733002/ Breaks: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/136166 Original issue's description: > Change v8_snapshot_toolchain to be a GN build arg. > > It is likely that CrOS and other distros will want to be > able to build the v8 snapshot with a custom toolchain. > > This CL makes snapshot_toolchain a declared build arg, and > renames it to v8_snapshot_toolchain to minimize the risk > of a name collision. > > R=machenbach@chromium.org, jochen@chromium.org > BUG=608596 > > Committed: https://crrev.com/2ae74af8f405f461d8e44d60b978f940673e46c8 > Cr-Commit-Position: refs/heads/master@{#36193} TBR=jochen@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608596 Review-Url: https://codereview.chromium.org/1975713002 Cr-Commit-Position: refs/heads/master@{#36199}
-
jochen authored
R=machenbach@chromium.org BUG=chromium:609107 Review-Url: https://codereview.chromium.org/1969793002 Cr-Commit-Position: refs/heads/master@{#36198}
-
zhengxing.li authored
port 40f34541 (r36181) original commit message: The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub looked at the function slot in order to skip stub frames and find the JS frame. However, stub frames do not have a function slot (in fact their fixed frame ends one slot before the JS frame's function slot). Therefore, if this location in the stub frame happens to have the function object the create arguments stubs won't skip this frame correctly. Replace this approach with one where the stub is specialized to either skip a frame if required (since there will only ever be one extra frame on Ignition the loop approach isn't necessary). BUG= Review-Url: https://codereview.chromium.org/1976483002 Cr-Commit-Position: refs/heads/master@{#36197}
-
bmeurer authored
We now have all the required eager bailout points in place, so we can remove the defensive programming in JSNativeContextSpecialization. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1973773003 Cr-Commit-Position: refs/heads/master@{#36196}
-
yangguo authored
R=jgruber@chromium.org,kozyatinskiy@chromium.org BUG=chromium:590256 LOG=N Review-Url: https://codereview.chromium.org/1961963002 Cr-Commit-Position: refs/heads/master@{#36195}
-
bmeurer authored
We got the condition wrong and actually deoptimized when the typed array was not neutered. This fixes the deopt loop in Math.random and actually many programs that use typed arrays. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1970123002 Cr-Commit-Position: refs/heads/master@{#36194}
-
dpranke authored
It is likely that CrOS and other distros will want to be able to build the v8 snapshot with a custom toolchain. This CL makes snapshot_toolchain a declared build arg, and renames it to v8_snapshot_toolchain to minimize the risk of a name collision. R=machenbach@chromium.org, jochen@chromium.org BUG=608596 Review-Url: https://codereview.chromium.org/1969693002 Cr-Commit-Position: refs/heads/master@{#36193}
-
v8-autoroll authored
Rolling v8/build to eeaf94824520078abaa924c17562d31dd531b04d TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1968363003 Cr-Commit-Position: refs/heads/master@{#36192}
-
littledan authored
TBR=adamk@chromium.org Review-Url: https://codereview.chromium.org/1969263002 Cr-Commit-Position: refs/heads/master@{#36191}
-
littledan authored
This patch removes the following properties, as their use count is very low, they are V8-only, and not on a standards track. - v8Parse - resolved - pattern v8BreakIterator is left in as it has significantly more usage. BUG=v8:3785 R=adamk,jshin@chromium.org Review-Url: https://codereview.chromium.org/1968893002 Cr-Commit-Position: refs/heads/master@{#36190}
-
- 11 May, 2016 4 commits
-
-
lpy authored
Revert of Implement CPU time for OS X and POSIX. (patchset #10 id:180001 of https://codereview.chromium.org/1959103004/ ) Reason for revert: Buildbot is failing on Mac release build. Original issue's description: > Implement CPU time for OS X and POSIX. > > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch > implements CPU time for OS X and POSIX to provide more accurate > accounting of CPU time used by each thread. > > BUG=v8:4984 > LOG=n > > Committed: https://crrev.com/025f3d262bab2748362374f1b90ac723a9655ee4 > Cr-Commit-Position: refs/heads/master@{#36188} TBR=jochen@chromium.org,bmeurer@chromium.org,fmeawad@chromium.org,rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4984 Review-Url: https://codereview.chromium.org/1966173003 Cr-Commit-Position: refs/heads/master@{#36189}
-
lpy authored
V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch implements CPU time for OS X and POSIX to provide more accurate accounting of CPU time used by each thread. BUG=v8:4984 LOG=n Review-Url: https://codereview.chromium.org/1959103004 Cr-Commit-Position: refs/heads/master@{#36188}
-
jshin authored
When I18N is enabled, use ICU's case conversion API and transliteration API [1] to implement String.prototype.to{Upper,Lower}Case and String.prototype.toLocale{Upper,Lower}Case. * ICU-based case conversion was implemented in runtime-i18n.cc/i18n.js * The above 4 functions are overridden with those in i18n.js when --icu_case_mapping flag is turned on. To control the override by the flag, they're overriden in icu-case-mapping.js Previously, toLocale{U,L}Case just called to{U,L}Case so that they didn't support locale-sensitive case conversion for Turkic languages (az, tr), Greek (el) and Lithuanian (lt). Before ICU APIs for the most general case are called, a fast-path for Latin-1 is tried. It's taken from Blink and adopted as necessary. This fast path is always tried for to{U,L}Case. For toLocale{U,L}Case, it's only taken when a locale (explicitly specified or default) is not in {az, el, lt, tr}. With these changes, a build with --icu_case_mapping=true passes a bunch of tests in test262/intl402/Strings/* and intl/* that failed before. Handling of pure ASCII strings (aligned at word boundary) are not as fast as Unibrow's implementation that uses word-by-word case conversion. OTOH, Latin-1 input handling is faster than Unibrow. General Unicode input handling is slower but more accurate. See https://docs.google.com/spreadsheets/d/1KJCJxKc1FxFXjwmYqABS0_2cNdPetvnd8gY8_HGSbrg/edit?usp=sharing for the benchmark. This CL started with http://crrev.com/1544023002#ps200001 by littledan@, but has changed significantly since. [1] See why transliteration API is needed for uppercasing in Greek. http://bugs.icu-project.org/trac/ticket/10582 R=yangguo BUG=v8:4476,v8:4477 LOG=Y TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case, intl/general/case* Review-Url: https://codereview.chromium.org/1812673005 Cr-Commit-Position: refs/heads/master@{#36187}
-
bjaideep authored
Port 40f34541 Original commit message: The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub looked at the function slot in order to skip stub frames and find the JS frame. However, stub frames do not have a function slot (in fact their fixed frame ends one slot before the JS frame's function slot). Therefore, if this location in the stub frame happens to have the function object the create arguments stubs won't skip this frame correctly. Replace this approach with one where the stub is specialized to either skip a frame if required (since there will only ever be one extra frame on Ignition the loop approach isn't necessary). R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4928 LOG=N Review-Url: https://codereview.chromium.org/1966263002 Cr-Commit-Position: refs/heads/master@{#36186}
-