Skip to content

V
V8
Switch branch/tag
  1. 30 Nov, 2018 1 commit
  3. 27 Nov, 2018 1 commit
  5. 22 Nov, 2018 1 commit
  7. 14 Nov, 2018 1 commit
  9. 13 Nov, 2018 2 commits
  11. 12 Nov, 2018 1 commit
  13. 09 Nov, 2018 1 commit
  15. 05 Nov, 2018 1 commit
  17. 31 Oct, 2018 3 commits
  19. 30 Oct, 2018 1 commit
  21. 29 Oct, 2018 2 commits
  23. 25 Oct, 2018 1 commit
    • Florian Sattler's avatar
      [parser] Remove explicit ok status tracking. · 339bb225
      Florian Sattler authored 
      Replace the explicit ok tracing by setting the scanner to fail, allowing us to
return automatically. RETURN_IF_PARSE_ERROR is now used instead of CHECK_OK to
verify if the parser failed.

In a follow-up CL we'll merge RETURN_IF_PARSE_ERROR after Expect* into an
EXPECT* macro. We'll keep (for now) RETURN_IF_PARSE_ERROR that guard uses of
possible NullExpression (e.g., impl()->IsIdentifier(...)). All other RETURN_IF*
will be removed. Uses after failure can likely later be fixed too by introducing
a FailureExpression.

Bug: v8:8363 ,v8:7926

Change-Id: I9896449eb9be476c453da4417a0bfd17c169ff38
Reviewed-on: https://chromium-review.googlesource.com/c/1294649
Commit-Queue: Florian Sattler <sattlerf@google.com>
Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56972}
      339bb225
  25. 11 Oct, 2018 1 commit
  27. 09 Oct, 2018 2 commits
  29. 08 Oct, 2018 1 commit
  31. 01 Oct, 2018 1 commit
  33. 28 Sep, 2018 1 commit
  35. 26 Sep, 2018 1 commit
  37. 21 Sep, 2018 1 commit
  39. 07 Sep, 2018 1 commit
  41. 28 Aug, 2018 1 commit
  43. 22 Aug, 2018 1 commit
  45. 04 Jul, 2018 1 commit
  47. 25 Jun, 2018 1 commit
    • Camillo Bruni's avatar
      Reland "[parser][log] Log script id during background compilation" · e7f5c5cc
      Camillo Bruni authored 
      This reverts commit a800e050.

Original change's description:
> Revert "[parser][log] Log script id during background compilation"
>
> This reverts commit aafd5c52.
>
> Reason for revert: Tentative revert for
>
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
> https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
>
> Original change's description:
> > [parser][log] Log script id during background compilation
> >
> > - Add separate script-create, script-reserve-id and script-details log events
> > - Add log events for CompilationCache hits and puts
> > - Simplify function event logging by only pass along the script id
> > - Explicitly create Scripts in parse-processor.js on script events only
> > - Create a temporary script id in the ParseInfo for use during background
> >   parsing and compilation
> > - Clean up ParseInfo initialization to centralize creation and use of
> >   script ids
> > - Allow creating Scripts with predefined script ids
> >
> > Bug: chromium:757467, chromium:850038
> > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
> > Reviewed-on: https://chromium-review.googlesource.com/1097131
> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#53978}
>
> TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
>
> Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:757467, chromium:850038
> Reviewed-on: https://chromium-review.googlesource.com/1112538
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53984}

TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:757467, chromium:850038
Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
Reviewed-on: https://chromium-review.googlesource.com/1112539Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53994}
      e7f5c5cc
  49. 22 Jun, 2018 2 commits
  51. 21 Feb, 2018 2 commits
  53. 17 Jan, 2018 1 commit
  55. 18 Dec, 2017 1 commit
  57. 30 Nov, 2017 1 commit
  59. 27 Nov, 2017 1 commit
  61. 14 Nov, 2017 1 commit
  63. 24 Oct, 2017 1 commit
  65. 22 Oct, 2017 1 commit