1. 01 Jul, 2021 1 commit
  2. 30 Jun, 2021 1 commit
    • Ng Zhi An's avatar
      [tools] Fix lldb_commands jco by casting call · c8350144
      Ng Zhi An authored
      Currently, running jco gives us an error message like so:
      
      (lldb) jco $pc
      Failed to evaluate command _v8_internal_Print_Code((void*)($pc)) :
      error: <user expression 0>:1:1: '_v8_internal_Print_Code' has unknown
      return type; cast the call to its declared return type
      _v8_internal_Print_Code((void*)($pc))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      The fix is to cast the call to (void). I've only used and found this
      issue with jco, but I think the other commands have the same issue, so
      fixing those together here.
      
      FYI I am using lldb version 11.
      
      Bug: v8:11879
      Change-Id: Id9d8e8091fd011585e6fea863de5b4d7c9d47c5a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994764Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Commit-Queue: Zhi An Ng <zhin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#75487}
      c8350144
  3. 11 Feb, 2021 1 commit
  4. 02 Jun, 2020 1 commit
    • Daniel Bevenius's avatar
      [tools] Add error handling to no_arg_cmd · fcac59ad
      Daniel Bevenius authored
      Currently, it can be little difficult to understand why a command in
      lldb-commands.py stops working. For example, at the moment running the
      jlh command results in an empty line:
      
      $ lldb --one-line "command script import ../../tools/lldb_commands.py" \
           v8_hello_world
      (lldb) br s -f hello-world.cc -l 49
      (lldb) jlh script
      
      (lldb)
      
      With this commit this would instead display the following error message:
      
      (lldb) jlh script
      Failed to evaluate command
      _v8_internal_Print_Object(*(v8::internal::Object**)(*(void*)(script))) :
      error: cannot cast from type 'v8::Local<v8::Script>' to pointer type
      'void *'
      
      The output is really only two lines but I've wrapped the lines here so
      they don't exceed the 72 column width. I'll follow up with a commit to
      fix the issue reported.
      
      Change-Id: I634a412b616dad7cadd74dce36418d27c1997777
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083477Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68093}
      fcac59ad
  5. 19 Feb, 2019 1 commit
  6. 13 Jul, 2018 1 commit
  7. 11 Jul, 2018 1 commit
  8. 09 Jul, 2018 1 commit
  9. 27 Mar, 2017 1 commit
    • daniel.bevenius's avatar
      [tools] add lldbinit · ec1ffe39
      daniel.bevenius authored
      The goal of this commit is to add the equivalent to gdbinit but
      for lldb. I've tried to replicate the commands as close as possible
      but I'm unsure about the jss command and hoping to get some feedback
      on it in addition to the bta command which I'm not sure how/when this
      could be used. This is probably just inexperience on my part.
      
      The lldbinit file can be placed into a directory prefixed with dot
      (.lldbinit) and the python script is currently expected to be in the
      same directory. The path to the script can be changed manually if needed
      as well.
      
      NOTRY=true
      
      Review-Url: https://codereview.chromium.org/2758373002
      Cr-Commit-Position: refs/heads/master@{#44136}
      ec1ffe39