- 09 Oct, 2015 7 commits
-
-
jochen authored
Makes debugging failures a bit easier BUG=none R=ulan@chromium.org LOG=n Review URL: https://codereview.chromium.org/1398703007 Cr-Commit-Position: refs/heads/master@{#31195}
-
karl authored
Fixes clang on windows warning: ..\..\v8\src\base\platform\platform-win32.cc(836,1) : error: function declared 'noreturn' should not return [-Werror,-Winvalid-noreturn] CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_rel,win_clang_x64_rel Review URL: https://codereview.chromium.org/1390193003 Cr-Commit-Position: refs/heads/master@{#31194}
-
jarin authored
The test had an effect phi with one effect input connected to a loop with two control inputs. Also, the Terminate node was used by the effect phi. Review URL: https://codereview.chromium.org/1398763002 Cr-Commit-Position: refs/heads/master@{#31193}
-
cbruni authored
strict mode. LOG=N BUG=chromium:423739 Review URL: https://codereview.chromium.org/1381083004 Cr-Commit-Position: refs/heads/master@{#31192}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#31191}
-
littledan authored
This patch turns on ES2015-style function hoisting semantics in staging. --harmony_sloppy_function was previously staged, leading to a number of bugs being filed and the staging being reversed; important bugs have been fixed, so it is time to try again. R=adamk LOG=Y BUG=v8:4285 Review URL: https://codereview.chromium.org/1393423002 Cr-Commit-Position: refs/heads/master@{#31190}
-
caitpotter88 authored
Make the end position of a regexp literal the first character following the regexp. This matches the behaviour of number literals and string literals, as well as single-character tokens. This change corrects the lazy-parsing of arrow functions with concise bodies, whose last token is a regular expression literal. BUG=v8:4474 LOG=N R=wingo@igalia.com, adamk@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1389313003 Cr-Commit-Position: refs/heads/master@{#31189}
-
- 08 Oct, 2015 22 commits
-
-
bradnelson authored
Not all register codes are safe for use on all architectures. Using RegisterConfiguration when picking a calling convention in test-multiple-return. BUG=None TEST=test-multiple-return R=titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1401453002 Cr-Commit-Position: refs/heads/master@{#31188}
-
littledan authored
Revert of Use simple/fast macro version of MinMax in JS (patchset #2 id:20001 of https://codereview.chromium.org/1390023003/ ) Reason for revert: This contains bugs, as found by mstarzinger. Reverting until we can find a clean fix (maybe it should be an inline function instead of a macro). Original issue's description: > Use simple/fast macro version of MinMax in JS > > Use the simple macro version of {Min, Max} where possible to > improve performance > > Follow-up to CR: https://codereview.chromium.org/1331993004 > > BUG= > > Committed: https://crrev.com/27c96c26212a10bb7f19f7bf3ff793b31bbad354 > Cr-Commit-Position: refs/heads/master@{#31162} TBR=jkummerow@chromium.org,mstarzinger@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1394303003 Cr-Commit-Position: refs/heads/master@{#31187}
-
akos.palfi authored
BUG= Review URL: https://codereview.chromium.org/1393903003 Cr-Commit-Position: refs/heads/master@{#31186}
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg,v8_linux_gcc_rel Review URL: https://codereview.chromium.org/1393023003 Cr-Commit-Position: refs/heads/master@{#31185}
-
bradnelson authored
This will allow exploration of possibilities like passing around buffer base and length. BUG=None TEST=test-multiple-return LOG=N R=mtrofin@chromium.org,titzer@chromium.org Review URL: https://codereview.chromium.org/1391333003 Cr-Commit-Position: refs/heads/master@{#31184}
-
mlippautz authored
R=ulan@chromium.org BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1394863002 Cr-Commit-Position: refs/heads/master@{#31183}
-
machenbach authored
BUG= Review URL: https://codereview.chromium.org/1396803002 Cr-Commit-Position: refs/heads/master@{#31182}
-
neis authored
Also add some more tests. R=rossberg BUG= Review URL: https://codereview.chromium.org/1392203002 Cr-Commit-Position: refs/heads/master@{#31181}
-
neis authored
This CL depends on #1362363002. R=rossberg BUG= Review URL: https://codereview.chromium.org/1361403003 Cr-Commit-Position: refs/heads/master@{#31180}
-
mlippautz authored
See bug report. R=ulan@chromium.org BUG=chromium:538567 LOG=N Review URL: https://codereview.chromium.org/1393293002 Cr-Commit-Position: refs/heads/master@{#31179}
-
bmeurer authored
This adds support to also lower stores to global property cells in state kConstant or kConstantType, where we need to deoptimize eagerly in case we have a value/type mismatch. Also fixes bugs in the construction of the frame states in the AstGraphBuilder. R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1398723002 Cr-Commit-Position: refs/heads/master@{#31178}
-
machenbach authored
BUG=chromium:468025 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1396613003 Cr-Commit-Position: refs/heads/master@{#31177}
-
jacob.bramley authored
This fixes several warnings when cross-building using GCC (since r31087, 5cf1c0bc). In particular, CPURegister::code() now returns 'int', matching the other platforms (and the coding style guide). The rest of the patch consists of similar changes to make this work. BUG= Review URL: https://codereview.chromium.org/1393043003 Cr-Commit-Position: refs/heads/master@{#31176}
-
mlippautz authored
This change removes the unswept free bytes counter. The new approach - directly decrements allocated memory and capacity before sweeping (using live bytes from the marker), and - adds back capacity during refilling a free list. This is another pre-work for moving around free lists while keeping the counters in a sane state. The previous approach allowed us to nail down how much memory is to-be-swept. However, there were no users of this as we only used it do decrement it from allocated memory (which still accounted for dead objects). If we want to keep track of unswept free bytes in a space during compaction we can introduce a separate new concurrent counter for this purpose. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1380723002 Cr-Commit-Position: refs/heads/master@{#31175}
-
v8-autoroll authored
Rolling v8/tools/clang to ee2cf312005aa4d47268041d36bfc50921afea29 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1392193002 Cr-Commit-Position: refs/heads/master@{#31174}
-
mythria authored
Removes deprecated functions from the following files: test/cctest/test-object-observe.cc test/cctest/test-parsing.cc test/cctest/test-platform.cc test/cctest/test-platform-linux.cc test/cctest/test-platform-win32.cc test/cctest/test-profile-generator.cc test/cctest/test-random-number-generator.cc test/cctest/test-regexp.cc test/cctest/test-reloc-info.cc test/cctest/test-representation.cc test/cctest/test-sampler-api.cc test/cctest/test-serialize.cc test/cctest/test-simd.cc test/cctest/test-slots-buffer.cc test/cctest/test-spaces.cc test/cctest/test-strings.cc test/cctest/test-strtod.cc test/cctest/test-symbols.cc test/cctest/test-threads.cc BUG=v8:4134 LOG=n Review URL: https://codereview.chromium.org/1371363006 Cr-Commit-Position: refs/heads/master@{#31173}
-
bmeurer authored
There's no need for a dedicated ToBoolean builtin in JavaScript, since ToBoolean(x) can easily be expressed in JavaScript as !!x, which has the additional advantage that the compilers are able to properly optimize that (out of the box). Review URL: https://codereview.chromium.org/1400463002 Cr-Commit-Position: refs/heads/master@{#31172}
-
bmeurer authored
For property cells with cell type kConstantType, we can compute an appropriate JavaScript type based on the current value of that cell. Numbers cannot use Type::Of here, because the type might be too precise, so we handle smi and heap number specially. R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1400483002 Cr-Commit-Position: refs/heads/master@{#31171}
-
bmeurer authored
R=jarin@chromium.org BUG=v8:4470 LOG=n Review URL: https://codereview.chromium.org/1394753002 Cr-Commit-Position: refs/heads/master@{#31170}
-
machenbach authored
Repository URL changed in chromium. TBR=tandrii@chromium.org Review URL: https://codereview.chromium.org/1396773002 Cr-Commit-Position: refs/heads/master@{#31169}
-
adamk authored
R=littledan@chromium.org Review URL: https://codereview.chromium.org/1398603002 Cr-Commit-Position: refs/heads/master@{#31168}
-
bmeurer authored
Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:40001 of https://codereview.chromium.org/1383053005/ ) Reason for revert: Breaks Arm debug. Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/93ae81101af68d81b7af84ea4046ea849e605116 > Cr-Commit-Position: refs/heads/master@{#31163} TBR=jochen@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1398643002 Cr-Commit-Position: refs/heads/master@{#31167}
-
- 07 Oct, 2015 11 commits
-
-
rmcilroy authored
Implements support for declaring global variables. Also adds support for loading from and storing to both global and unallocated global variables. Adds the following bytecodes: - StoreGlobal - LoadContextSlot BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1378523005 Cr-Commit-Position: refs/heads/master@{#31166}
-
littledan authored
This patch brings test262 up to the latest version on GitHub. Some highlights from new failures are: - Reflect - Default parameters - Case conversion edge cases R=adamk Review URL: https://codereview.chromium.org/1391793002 Cr-Commit-Position: refs/heads/master@{#31165}
-
rmcilroy authored
Add a flag to explicitly filter scripts in ignition and use it for the test262 variant. The previous approach of overloading ignition-filter meant that only top-level code was getting compiled through ignition. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1396493002 Cr-Commit-Position: refs/heads/master@{#31164}
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg Review URL: https://codereview.chromium.org/1383053005 Cr-Commit-Position: refs/heads/master@{#31163}
-
karl authored
Use the simple macro version of {Min, Max} where possible to improve performance Follow-up to CR: https://codereview.chromium.org/1331993004 BUG= Review URL: https://codereview.chromium.org/1390023003 Cr-Commit-Position: refs/heads/master@{#31162}
-
mstarzinger authored
This removes stale strings from the bailout-reason.h file that are no longer being used and hence only eat up space in the binary. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1391973002 Cr-Commit-Position: refs/heads/master@{#31161}
-
littledan authored
In ES5, ToObject was called on elements before invoking the .toLocaleString() method on them. ES2015 specifies that ToObject is not called. A test262 test verifies this change. This patch implements the new ES2015 behavior. It is verified by the test262 test built-ins/Array/prototype/toLocaleString/primitive_this_value_getter R=adamk Review URL: https://codereview.chromium.org/1390893003 Cr-Commit-Position: refs/heads/master@{#31160}
-
littledan authored
In ES2015, section 20.3.1.15, TimeClip (an internal algorihtm which is called when normalizing Date representations) is specified to add 0 to its result, which converts -0 into +0. This patch adds that conversion to the Date code. It is verified by the test262 test built-ins/Date/TimeClip_negative_zero R=adamk Review URL: https://codereview.chromium.org/1387293002 Cr-Commit-Position: refs/heads/master@{#31159}
-
caitpotter88 authored
BUG= R= LOG=N Review URL: https://codereview.chromium.org/1392763003 Cr-Commit-Position: refs/heads/master@{#31158}
-
mstarzinger authored
This removes the include of compiler.h from all our assemblers, which was only needed for the SourcePosition class. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1397493002 Cr-Commit-Position: refs/heads/master@{#31157}
-
ofrobots authored
Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to be a no-op. new_space_.LowerInlineAllocationLimit( new_space_.inline_allocation_limit_step()); LowerInlineAllocatoinLimit does the following things: 1. Set the inline_allocation_limit_step_ to the passed in value. No-op. 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has already been called when new_space_.ResetAllocationInfo was called above. 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by ResetAllocationInfo as well. BUG= R=hpayer@chromium.org,ulan@chromium.org Review URL: https://codereview.chromium.org/1390013002 Cr-Commit-Position: refs/heads/master@{#31156}
-