- 25 Jul, 2018 17 commits
-
-
Tobias Tebbi authored
I suspect that the non-deterministic order of changed variables in the generated Label constructor calls is what causes non-deterministic builds, since this is the only change I observed locally in the generated .cc files. Drive-by cleanup: follow style-guide by avoiding mutable ref parameter. Bug: chromium:867308 Change-Id: I137af359df570ee11b95cb620ace179bf93481c5 Reviewed-on: https://chromium-review.googlesource.com/1148729Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54687}
-
Sigurd Schneider authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I7a25b340248b1b1499c6fd0753f210c359003843 Reviewed-on: https://chromium-review.googlesource.com/1149369Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54686}
-
Clemens Hammacher authored
No functional change, just a cleanup I forgot to integrate in the reland: https://crrev.com/c/1146100 R=mstarzinger@chromium.org Bug: v8:7977 Change-Id: Ifbb437d6a1ec9ec1b8623859bdf183dab1a1c0f6 Reviewed-on: https://chromium-review.googlesource.com/1148721Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54685}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7965 Change-Id: I1bdd5b3bc8626727c94b95b519a8896384ff990b Reviewed-on: https://chromium-review.googlesource.com/1148573 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54684}
-
Leszek Swirski authored
This reverts commit 9d18a7fd. Reason for revert: Breaks build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noi18n%20-%20debug/21856 Original change's description: > [iwyu] Remove sfi-inl.h -> wasm include > > This significantly reduces the build time when modifying wasm > files: before touching all wasm headers required 684 steps to > rebuild, now it's 216. > > BUG=v8:7754,v8:7490 > > Change-Id: Id7ff6f9063168556daad4840ee614cf68144cdb2 > Reviewed-on: https://chromium-review.googlesource.com/1145264 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54681} TBR=ulan@chromium.org,marja@chromium.org,titzer@chromium.org,jgruber@chromium.org,clemensh@chromium.org,tebbi@chromium.org,bmeurer@chromium.org,verwaest@chromium.org Change-Id: I3b4087916f65b16db75974dba58914c8ea377a08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7754, v8:7490 Reviewed-on: https://chromium-review.googlesource.com/1149920Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54683}
-
Benedikt Meurer authored
When going to PREMONOMORPHIC state we previously stored the premonomorphic sentinel into the first IC slot and then the second slot was storing the uninitialized sentinel. So when TurboFan kicked in and optimized the function we'd just put a LOAD_IC in there and hoped for the best that this is either not in hot code or will reoptimize for another reason later to fixup the LOAD_IC. This is a quite annoying footgun for developers because the performance inevitably depends on timing of when the optimizing compiler kicks in. To fix this issue we now keep a weak reference to the receiver map in the second slot of the IC in PREMONOMORPHIC state and use that to speculatively optimize when we go to TurboFan. This improves the performance on the reported bug from spread: 2342 ms. spread: 2352 ms. spread: 2339 ms. to spread: 1490 ms. spread: 1451 ms. spread: 1445 ms. which corresponds to a 36% improvement in this particular case. In general you'll get more predictable performance with this change. We might want to also use the map when going to MONOMORPHIC state at a later point to maybe skip the additional transition to POLYMORPHIC in some cases, but that's independent of this bug. Bug: v8:5267, v8:7973 Change-Id: Ia4eef7651e219a40927531cdffe320ade1dd19a4 Reviewed-on: https://chromium-review.googlesource.com/1148205Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54682}
-
Marja Hölttä authored
This significantly reduces the build time when modifying wasm files: before touching all wasm headers required 684 steps to rebuild, now it's 216. BUG=v8:7754,v8:7490 Change-Id: Id7ff6f9063168556daad4840ee614cf68144cdb2 Reviewed-on: https://chromium-review.googlesource.com/1145264 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54681}
-
Florian Sattler authored
Avoid copying the last character to a local variable, by checking the parsing state in a different order. BUG=v8:7926 Change-Id: Ifb722dd3864737dc66d8e0885adbeba1376a059e Reviewed-on: https://chromium-review.googlesource.com/1148569Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Put all loads on the effect chain. This removes freedom of the scheduler, which might regress performance of the generated code (probably negligible) and might improve performance of code generation. It also prevents hard to diagnose bugs where the scheduler might schedule loads too early such that we miss an update during a function call or gc. In order to make all updates and uses of the "current control" and "current effect" more visible, this CL also introduces {SetEffect} and {SetControl} methods, and uses {Effect} and {Control} more rigorously. R=mstarzinger@chromium.org Change-Id: I917ce1775345a1fadf6166022c8848e36e195c56 Reviewed-on: https://chromium-review.googlesource.com/1129235 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Starzinger authored
This flag allows to share a single WasmEngine among all Isolates within the same process. It will ultimately allow to share the WasmCode objects associated with modules that are transferred via structured cloning. R=clemensh@chromium.org TEST=mjsunit/wasm/worker-module BUG=v8:7424 Change-Id: I70d852d319b2a80bd02e0a2a838dcdfa071df6e1 Reviewed-on: https://chromium-review.googlesource.com/1138213 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Peter Marshall authored
Change-Id: I87b141d44706fedf7821c266c6207564fd77a9b6 Reviewed-on: https://chromium-review.googlesource.com/1148577Reviewed-by:
-
Clemens Hammacher authored
Drive-by: Convert const to constexpr. R=titzer@chromium.org Bug: v8:7965 Change-Id: Ifddfba78e819a0d340fba27a6efedea654b057e8 Reviewed-on: https://chromium-review.googlesource.com/1148722Reviewed-by:
-
Sathya Gunasekaran authored
- Return empty handles instead of exceptions. - Handlify functions instead of returning raw pointers. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I28b018e5bdcaa375748eb04e9a6fed8cf64a5b05 Reviewed-on: https://chromium-review.googlesource.com/1148301 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I75877bbdefab35c54b6293835e26222b78c69684 Reviewed-on: https://chromium-review.googlesource.com/1148447 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54674}
-
Frank Tang authored
Spec: http://tc39.github.io/proposal-intl-list-format/ Design Doc: go/add-intl.listformat-to-v8 Test: intl/list-format/* R=gsathya@chromium.org, mvstanton@chromium.org Bug: v8:7871 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I87cd84e0cabdf90adaa1486dccd9d2bee14e261d Reviewed-on: https://chromium-review.googlesource.com/1126179Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#54673}
-
Sathya Gunasekaran authored
This is a reland of 1f5ab936 Tests started passing before this was reverted so this isn't culprit. Original change's description: > [Intl] Fix legacy error handling > > Bug: v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I382404f4c59c1e997ea0fb58f3a995b653c0d6bc > Reviewed-on: https://chromium-review.googlesource.com/1148031 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54625} TBR: jgruber@chromium.org Bug: v8:5751 Change-Id: I546b10e5cbbbac3aa947ca55cea1f7cc4ae77270 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1148660Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d1e53db..2c97c10 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6a1002b..6cf86b3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6ec6d27..01ce059 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6daaa1c1ac5e2ba4bf66d9f1b7df080c6f5c563 Reviewed-on: https://chromium-review.googlesource.com/1149511 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54671}
-
- 24 Jul, 2018 23 commits
-
-
Ross Mcilroy authored
Mark/IsIndependent is marked V8_DEPRECATE_SOON, but is still needed in some places. In order to allow us to warn on V8_DEPRECATE_SOON within V8, explicity disable deprecation warnings on these calls temporarily. BUG=v8:7754 Change-Id: I0a7f3aedc04412c120217ba83d2cf91aafff568d Reviewed-on: https://chromium-review.googlesource.com/1147751 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54670}
-
Frank Tang authored
Bug: v8:7871 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I466d0d2fc7ad61924e3e7e519307281c01873166 Reviewed-on: https://chromium-review.googlesource.com/1142380 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec: http://tc39.github.io/proposal-intl-list-format/ Design Doc: go/add-intl.listformat-to-v8 Test: intl/list-format/* R=gsathya@chromium.org, mvstanton@chromium.org Bug: v8:7871 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0dfb91b7806007e4f02f3b0438c30528c8143081 Reviewed-on: https://chromium-review.googlesource.com/1124343 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
TBR=mstarzinger@chromium.org No-Try: true Bug: v8:7976 Change-Id: I12585016afbf86e3d50bacb45a57ab20b6be72ff Reviewed-on: https://chromium-review.googlesource.com/1148728Reviewed-by:
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0661d6503b66e71de56bdc37e22ef45ef77c0806 Reviewed-on: https://chromium-review.googlesource.com/1141351 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Peter Marshall authored
Change-Id: Ib0a047c0e02b3feaf878af2ec87d5d0f35167280 Reviewed-on: https://chromium-review.googlesource.com/1148561 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
TBR=mstarzinger@chromium.org No-Try: true Bug: v8:7977 Change-Id: Idcf88b884a7ad904243f0046aa0bbef118fb19ad Reviewed-on: https://chromium-review.googlesource.com/1148576 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Bill Budge authored
- Eliminates less general forms of vmov between core and scalar FP registers. Bug: v8:7754 Change-Id: I3224c57e03dfd64ea6552b215017dacc357dda26 Reviewed-on: https://chromium-review.googlesource.com/1144126 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Bug:v8:7754 Change-Id: I76bc28f4868da452278bc8fc174b462bb26034f1 Reviewed-on: https://chromium-review.googlesource.com/1148592 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7965 Change-Id: I5e44e8a4dd522703e7a20e32abae1f66ba44451e Reviewed-on: https://chromium-review.googlesource.com/1148566Reviewed-by:
-
Ross Mcilroy authored
BUG=v8:7754 Change-Id: Id04fddb65c7943e9cb394c700eda45c6c6f7ebfd Reviewed-on: https://chromium-review.googlesource.com/1147746 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54660}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ie93c398ab5c138a559ee156aeb24a7782280aaa9 Reviewed-on: https://chromium-review.googlesource.com/1148213Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 9c4200b2. Reason for revert: breaks arm64 msan: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/22108 Original change's description: > [scanner] Faster SkipMultiLineComment by avoiding a copy. > > Avoid coping the last character to a local variable, by checking the parsing > state in a different order. > > BUG=v8:7926 > > Change-Id: I0b62f711674beac8c81a25dd566a5ed0d681948b > Reviewed-on: https://chromium-review.googlesource.com/1148456 > Commit-Queue: Florian Sattler <sattlerf@google.com> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54657} TBR=marja@chromium.org,sattlerf@google.com Change-Id: I665bce8214e6d0b8f8a619820ff13f37bc722332 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7926 Reviewed-on: https://chromium-review.googlesource.com/1148620Reviewed-by:
-
Florian Sattler authored
Avoid coping the last character to a local variable, by checking the parsing state in a different order. BUG=v8:7926 Change-Id: I0b62f711674beac8c81a25dd566a5ed0d681948b Reviewed-on: https://chromium-review.googlesource.com/1148456 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Clemens Hammacher authored
This is a reland of a462a785 Original change's description: > [turboassembler] Introduce hard-abort mode > > For checks and assertions (mostly for debug code, like stack alignment > or zero extension), we had two modes: Emit a call to the {Abort} > runtime function (the default), and emit a debug break (used for > testing, enabled via --trap-on-abort). > In wasm, where we cannot just call a runtime function because code must > be isolate independent, we always used the trap-on-abort behaviour. > This causes problems for our fuzzers, which do not catch SIGTRAP, and > hence do not detect debug code failures. > > This CL introduces a third mode ("hard abort"), which calls a C > function via {ExternalReference}. The C function still outputs the > abort reason, but does not print the stack trace. It then aborts via > "OS::Abort", just like the runtime function. > This will allow fuzzers to detect the crash and even find a nice error > message. > > Even though this looks like a lot of code churn, it is actually not. > Most added lines are new tests, and other changes are minimal. > > R=mstarzinger@chromium.org > > Bug: chromium:863799 > Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b > Reviewed-on: https://chromium-review.googlesource.com/1142163 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54592} Bug: chromium:863799 Change-Id: I7729a47b4823a982a8e201df36520aa2b6ef5326 Reviewed-on: https://chromium-review.googlesource.com/1146100Reviewed-by:
-
Marja Hölttä authored
It is unused. BUG=v8:7308 Change-Id: Ib1b51da316c929adcb117901d989180b5b81c42f Reviewed-on: https://chromium-review.googlesource.com/1146734 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Stephan Herhut authored
Bug: v8:7490 Change-Id: If667ffd8b1b800b838c1a74aaf329418034fa9e3 Reviewed-on: https://chromium-review.googlesource.com/1148216 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Brian Stell authored
This is a part of larger cl https://chromium-review.googlesource.com/c/v8/v8/+/1144524 "Port canonicalizeLanguageTag and isStructuallyValidLanguageTag from JS to C++." This is being separated out because: 1) this will unblock ftang's work 2) there is an increased memory usage issue report I'd like to understand before connecting IsStructurallyValidLanguageTag for widespread usage The memory concern will be dealt with in a follow-up cl. Also in this cl: Fix to ignore the first tag when checking for duplicate subtags. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I76f4f6861490d8f9ccb36d6a0f7a7d5fa32ff995 Reviewed-on: https://chromium-review.googlesource.com/1147561Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Brian Stell <bstell@chromium.org> Cr-Commit-Position: refs/heads/master@{#54653}
-
Dominik Inführ authored
Add names for fields in JSGeneratorObjects in Heap Snapshot Generator. Bug: chromium:854097 Change-Id: I075acf0821c9d002535b4fdc4ce4ddbb2fc9627c Reviewed-on: https://chromium-review.googlesource.com/1148387 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I090258338b1ac5e50bfd8c2195fb740ffa1386c2 Reviewed-on: https://chromium-review.googlesource.com/1148398 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Previous version: https://chromium-review.googlesource.com/c/v8/v8/+/1143467 BUG=v8:7308 TBR=jgruber@chromium.org Change-Id: I0c1fe73250b0aed270cdb9fa5e1bc55315ace3d2 Reviewed-on: https://chromium-review.googlesource.com/1148333 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Change-Id: I02c117ef66480eb73eb9cc1d4f80bbc64e9d3624 Reviewed-on: https://chromium-review.googlesource.com/1146655 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Théotime Grohens authored
This CL simplifies the implementation of inlined DataView methods in TurboFan. It removes the explicit exception handling, and just deopts and relies on the baseline code to handle exceptions instead. It also adapts the DataView test files in mjsunit/compiler/ accordingly. Change-Id: I013c76970e1480df2b755d17d397bd0f9f26f0ec Reviewed-on: https://chromium-review.googlesource.com/1148207 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
-
