- 04 May, 2016 2 commits
-
-
alph authored
The observer might want to lookup something in the heap, e.g. code objects it has in the call stack. BUG=v8:4959 LOG=N Review-Url: https://codereview.chromium.org/1948893002 Cr-Commit-Position: refs/heads/master@{#36027}
-
mlippautz authored
BUG=chromium:598319 LOG=N Review-Url: https://codereview.chromium.org/1948573003 Cr-Commit-Position: refs/heads/master@{#36011}
-
- 03 May, 2016 6 commits
-
-
mlippautz authored
BUG=chromium:598319 LOG=N Review-Url: https://codereview.chromium.org/1943733003 Cr-Commit-Position: refs/heads/master@{#35996}
-
mlippautz authored
Reland of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1947473002/ ) Reason for revert: Unrelated to waterfall failures. Original issue's description: > Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) > > Reason for revert: > GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin > > Original issue's description: > > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > > > BUG=chromium:598319 > > LOG=N > > > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > > Cr-Commit-Position: refs/heads/master@{#35970} > > TBR=ulan@chromium.org,mlippautz@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:598319 > > Committed: https://crrev.com/a4129bb45a3bb8cc68bb2e07ee1e0a734f04ce4b > Cr-Commit-Position: refs/heads/master@{#35979} TBR=ulan@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947503002 Cr-Commit-Position: refs/heads/master@{#35986}
-
yangguo authored
Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) Reason for revert: GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin Original issue's description: > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > BUG=chromium:598319 > LOG=N > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > Cr-Commit-Position: refs/heads/master@{#35970} TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947473002 Cr-Commit-Position: refs/heads/master@{#35979}
-
yangguo authored
v8::Object::{Set,Get,Delete}HiddenValue have long been deprecated. Please use v8::Object::{Set,Has,Get}Private instead. R=jochen@chromium.org LOG=Y Review-Url: https://codereview.chromium.org/1942233002 Cr-Commit-Position: refs/heads/master@{#35977}
-
mlippautz authored
BUG=chromium:598319 LOG=N Review-Url: https://codereview.chromium.org/1943263002 Cr-Commit-Position: refs/heads/master@{#35970}
-
danno authored
Review-Url: https://codereview.chromium.org/1903723003 Cr-Commit-Position: refs/heads/master@{#35963}
-
- 29 Apr, 2016 2 commits
-
-
mlippautz authored
- Move the concurrent unmapping to MemoryAllocator - Hide (private) members where possible - MemoryAllocator:Free is now the bottleneck for freeing - Pooled pages are either allocated from a set of pooled pages are obtained through work stealing from the concurrent unmapper BUG=chromium:605866, chromium:581412 LOG=N This reverts commit 25ff296c. Review-Url: https://codereview.chromium.org/1929503002 Cr-Commit-Position: refs/heads/master@{#35910}
-
ulan authored
This will allow us to enable GC events without enabling IC events. Telemetry currently cannot handle huge number of IC events in a trace. BUG= Review-Url: https://codereview.chromium.org/1924333003 Cr-Commit-Position: refs/heads/master@{#35902}
-
- 28 Apr, 2016 4 commits
-
-
mlippautz authored
Also revert "[heap] Force inlining of AllocatedSinceLastGC" This is a speculative revert to see if it actually impacts the benchmarks in question. This reverts commit 723e120b. This reverts commit 08dbdd40. BUG=chromium:605524 LOG=N TBR=ulan@chromium.org Review-Url: https://codereview.chromium.org/1932883002 Cr-Commit-Position: refs/heads/master@{#35881}
-
neis authored
Instead of replacing the array with an empty one after resuming, overwrite contents with a new Oddball. This will simplify the work to be done by the bytecode graphbuilder and potentially allow for more optimization. (For full-codegen generators, nothing changes.) BUG=v8:4907 LOG=n Review-Url: https://codereview.chromium.org/1923253002 Cr-Commit-Position: refs/heads/master@{#35872}
-
mlippautz authored
Speculatively forcining inlining as not inlining potentially regresses performance. BUG=chromium:605524 LOG=N Review-Url: https://codereview.chromium.org/1924033003 Cr-Commit-Position: refs/heads/master@{#35869}
-
mlippautz authored
BUG=chromium:607226, chromium:581412 LOG=N Review-Url: https://codereview.chromium.org/1928883002 Cr-Commit-Position: refs/heads/master@{#35844}
-
- 27 Apr, 2016 2 commits
-
-
hablich authored
Revert of [heap] Uncommit pooled pages concurrently (patchset #5 id:120001 of https://codereview.chromium.org/1913083002/ ) Reason for revert: Creates a spike of OOM(v8) crashers on Win32. Original issue's description: > [heap] Uncommit pooled pages concurrently > > - Move the concurrent unmapping to MemoryAllocator > - Hide (private) members where possible > - MemoryAllocator:Free is now the bottleneck for freeing > - Pooled pages are either allocated from a set of pooled pages are obtained > through work stealing from the concurrent unmapper > > BUG=chromium:605866, chromium:581412 > LOG=N > > Committed: https://crrev.com/2158df87116906160cebc3ad20c97f454822da03 > Cr-Commit-Position: refs/heads/master@{#35797} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605866, chromium:581412 Review URL: https://codereview.chromium.org/1925563003 Cr-Commit-Position: refs/heads/master@{#35819}
-
hlopko authored
To land and test wrapper tracing incrementally, we will use both, and parts which are expected to work with the tracing will be removed from V8GCController's handle visiting. LOG=no BUG=468240 Review URL: https://codereview.chromium.org/1925573002 Cr-Commit-Position: refs/heads/master@{#35809}
-
- 26 Apr, 2016 1 commit
-
-
mlippautz authored
- Move the concurrent unmapping to MemoryAllocator - Hide (private) members where possible - MemoryAllocator:Free is now the bottleneck for freeing - Pooled pages are either allocated from a set of pooled pages are obtained through work stealing from the concurrent unmapper BUG=chromium:605866, chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1913083002 Cr-Commit-Position: refs/heads/master@{#35797}
-
- 25 Apr, 2016 3 commits
-
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1909883002 Cr-Commit-Position: refs/heads/master@{#35774}
-
ulan authored
Reland "Check for semaphore alignment on posix platforms. (patchset #1 id:1 of https://codereview.chromium.org/1912923003/ )" This patch also fixed three misaligned semaphores. This reverts commit 80c73e2c. BUG=chromium:605349 LOG=NO Review URL: https://codereview.chromium.org/1917923002 Cr-Commit-Position: refs/heads/master@{#35773}
-
mlippautz authored
BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1900423002 Cr-Commit-Position: refs/heads/master@{#35768}
-
- 22 Apr, 2016 1 commit
-
-
adamk authored
The feature was deprecated in M49 and flagged off in M50. This patch removes it entirely from the codebase. Review URL: https://codereview.chromium.org/1909433003 Cr-Commit-Position: refs/heads/master@{#35714}
-
- 20 Apr, 2016 3 commits
-
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1899183002 Cr-Commit-Position: refs/heads/master@{#35656}
-
hlopko authored
We need to empty the deque after EmbedderHeapTracer::TracePrologue, and we don't have to empty the deque after ProcessEphemeralMarking, as the deque should be empty already. BUG=468240 LOG=no Review URL: https://codereview.chromium.org/1900783002 Cr-Commit-Position: refs/heads/master@{#35654}
-
mlippautz authored
In a full mark-compact GC, instead of copying memory to old space for pages that have more than X% live bytes, we just move the whole page over to old space. X=70 (default value) BUG=chromium:581412 LOG=N TBR=hpayer@chromium.org This reverts commit 8b333727. Review URL: https://codereview.chromium.org/1901093002 Cr-Commit-Position: refs/heads/master@{#35649}
-
- 19 Apr, 2016 3 commits
-
-
hlopko authored
As the code on the blink side sits down, we realize we don't need isolate arg anymore. As the heap tracer is set per isolate, it can actually be confusing if the isolate passed as argument is always the same as the isolate the heap tracer was set for. Wdyt? BUG=468240 LOG=no Review URL: https://codereview.chromium.org/1900953003 Cr-Commit-Position: refs/heads/master@{#35620}
-
machenbach authored
Revert of
[heap] Add page evacuation mode for new->old (patchset #21 id:800001 of https://codereview.chromium.org/1863983002/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/102 Original issue's description: > [heap] Add page evacuation mode for new->old > > In a full mark-compact GC, instead of copying memory to old space for > pages that have more than X% live bytes, we just move the whole page over to old > space. > > X=70 (default value) > > BUG=chromium:581412 > LOG=N > > Committed: https://crrev.com/0d7e23a6edd3822970983030a77a5b80cd337911 > Cr-Commit-Position: refs/heads/master@{#35610} TBR=hpayer@chromium.org,ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Review URL: https://codereview.chromium.org/1896883003 Cr-Commit-Position: refs/heads/master@{#35619} -
mlippautz authored
In a full mark-compact GC, instead of copying memory to old space for pages that have more than X% live bytes, we just move the whole page over to old space. X=70 (default value) BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1863983002 Cr-Commit-Position: refs/heads/master@{#35610}
-
- 18 Apr, 2016 3 commits
-
-
hlopko authored
Quick one, ptal. BUG=468240 LOG=no Committed: https://crrev.com/0eae5650dec265e961a1024fd2090301f2cdca16 Cr-Commit-Position: refs/heads/master@{#35578} Review URL: https://codereview.chromium.org/1895753002 Cr-Commit-Position: refs/heads/master@{#35594}
-
yangguo authored
There were a couple of issues with it: - interpreter is not supported - the source position was just accidentally correct for full-codegen - the eval origin could have been cached Also fixes a few other places to use AbstractCode. R=mstarzinger@chromium.org Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d Cr-Commit-Position: refs/heads/master@{#35257} Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16 Cr-Commit-Position: refs/heads/master@{#35481} Review URL: https://codereview.chromium.org/1854713002 Cr-Commit-Position: refs/heads/master@{#35581}
-
hlopko authored
Quick one, ptal. BUG=468240 LOG=no Review URL: https://codereview.chromium.org/1895753002 Cr-Commit-Position: refs/heads/master@{#35578}
-
- 15 Apr, 2016 6 commits
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1887343004 Cr-Commit-Position: refs/heads/master@{#35540}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1887343003 Cr-Commit-Position: refs/heads/master@{#35531}
-
mlippautz authored
Replace page link walking with arithmetic computation. BUG=chromium:603460 LOG=N Review URL: https://codereview.chromium.org/1883933003 Cr-Commit-Position: refs/heads/master@{#35529}
-
machenbach authored
Revert of Rehash and clear deleted entries in weak collections during GC (patchset #8 id:140001 of https://codereview.chromium.org/1877233005/ ) Reason for revert: [Sheriff] Speculative revert. Suspect for gc stress crashes, like: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/5119 Original issue's description: > Rehash and clear deleted entries in weak collections during GC > > Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity. > > BUG=v8:4909 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/e093a047796d4c0575fe63d36529e7fe89b8865d > Cr-Commit-Position: refs/heads/master@{#35514} TBR=hpayer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4909 Review URL: https://codereview.chromium.org/1891863003 Cr-Commit-Position: refs/heads/master@{#35519}
-
cbruni authored
BUG= Committed: https://crrev.com/5210f167e802a3758aac1f2900a6560c8de07831 Cr-Commit-Position: refs/heads/master@{#35231} Review URL: https://codereview.chromium.org/1834373003 Cr-Commit-Position: refs/heads/master@{#35516}
-
jochen authored
Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity. BUG=v8:4909 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1877233005 Cr-Commit-Position: refs/heads/master@{#35514}
-
- 14 Apr, 2016 4 commits
-
-
hpayer authored
We will move this back to start of incremental marking when we make faster progress. Perf sheriffs: This CL may cause a regression on benchmarks that improved earlier by enabling black allocation. BUG=chromium:599174 LOG=n Review URL: https://codereview.chromium.org/1889853002 Cr-Commit-Position: refs/heads/master@{#35500}
-
yangguo authored
Revert of Correctly annotate eval origin. (patchset #5 id:80001 of https://codereview.chromium.org/1854713002/ ) Reason for revert: performance impact Original issue's description: > Correctly annotate eval origin. > > There were a couple of issues with it: > - interpreter is not supported > - the source position was just accidentally correct for full-codegen > - the eval origin could have been cached > > Also fixes a few other places to use AbstractCode. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d > Cr-Commit-Position: refs/heads/master@{#35257} > > Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16 > Cr-Commit-Position: refs/heads/master@{#35481} TBR=mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1888013002 Cr-Commit-Position: refs/heads/master@{#35491}
-
mlippautz authored
- Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed This reverts commit 6df04b29. BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* Review URL: https://codereview.chromium.org/1891683002 Cr-Commit-Position: refs/heads/master@{#35485}
-
yangguo authored
There were a couple of issues with it: - interpreter is not supported - the source position was just accidentally correct for full-codegen - the eval origin could have been cached Also fixes a few other places to use AbstractCode. R=mstarzinger@chromium.org Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d Cr-Commit-Position: refs/heads/master@{#35257} Review URL: https://codereview.chromium.org/1854713002 Cr-Commit-Position: refs/heads/master@{#35481}
-