Skip to content

V
V8
Switch branch/tag
  1. 03 Aug, 2022 3 commits
  3. 02 Aug, 2022 1 commit
  5. 29 Jul, 2022 4 commits
  7. 28 Jul, 2022 1 commit
  9. 27 Jul, 2022 4 commits
  11. 26 Jul, 2022 3 commits
  13. 25 Jul, 2022 3 commits
  15. 22 Jul, 2022 2 commits
  17. 21 Jul, 2022 2 commits
  19. 20 Jul, 2022 3 commits
    • Seth Brenith's avatar
      Fix v8windbg Locals pane behavior · 607ad422
      Seth Brenith authored 
      Background:

In order to show custom content in the "Locals" pane in WinDbg, v8windbg
replaces the getter function for a built-in debug model property named
"Debugger.Models.StackFrame.LocalVariables". This is the property that
the debugger fetches when determining what to display in "Locals". The
new implementation of that getter, V8LocalVariables::GetValue, can
either call the original getter (so that WinDbg displays the usual
content for normal C++ frames) or produce a custom result (for builtins
and JIT-compiled JS frames).

The current problem:

In new builds of WinDbg, users of v8windbg no longer see any content in
the Locals pane for stack frames that correspond to builtins or
JIT-compiled code. This is because of a behavior change in WinDbg:
previously, attempting to get Debugger.Models.StackFrame.LocalVariables
would eagerly attempt to find the symbols for the frame and return an
error code if symbols were not found, but now it returns a lazy object
which does not perform symbol lookup until you iterate its properties.
V8LocalVariables::GetValue currently starts with an early-exit path
based on checking whether the original getter succeeded, so the new lazy
implementation causes us to always take that early exit.

Proposed fix:

Rather than relying on the return value from the original getter, which
is not guaranteed to work consistently, we can base our decisions on the
instruction pointer. If it points outside any module, or if it points to
within a function in the module containing V8 whose name starts with
"Builtins_", then we can build a custom result for the Locals pane.

Change-Id: I6644071d5d83a25b964d9f4018265532528cc85c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3759228Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#81856}
      607ad422
    • Jakob Kummerow's avatar
      [cleanup][wasm] Simplify DecodeLocals and PushControl · 9b62b332
      Jakob Kummerow authored 
      Some follow-up after getting rid of `let`.

Change-Id: I073372f4edd0847c4ffa428595a6f74158c87a98
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773515Reviewed-by: 's avatarManos Koukoutos <manoskouk@chromium.org>
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81844}
      9b62b332
    • Michael Achenbach's avatar
      [trials] Remove unnecessary flag · d4a8b80b
      Michael Achenbach authored 
      No-Try: true
Bug: chromium:1340816
Change-Id: Ic49c5e00a90085b575465bbb463645977ee1d34b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3768987
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81837}
      d4a8b80b
  21. 19 Jul, 2022 7 commits
  23. 18 Jul, 2022 3 commits
  25. 15 Jul, 2022 3 commits
  27. 14 Jul, 2022 1 commit