- 23 Apr, 2018 1 commit
-
-
Clemens Hammacher authored
This CL fixes the new {CodeReference} class to comply to the style guide. It makes it a proper class, renames private fields to end in an underscore and simplifies the union declaration. R=ahaas@chromium.org CC=herhut@chromium.org Bug: v8:7570 Change-Id: I329bbc6fca1ba3c0cb34fb4e1179eb4fa9044e76 Reviewed-on: https://chromium-review.googlesource.com/1023414Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52722}
-
- 18 Apr, 2018 1 commit
-
-
Stephan Herhut authored
This is a reland of 4d7ad46d Original change's description: > Introduce CodeReference > > Add a struct CodeReference that can be stack allocated to pass a > reference to either an on-heap code object or off-heap WasmCode object > in a gc safe manner. The struct also provides a common interface such > that code can be written independently of the kind of code object it > references. > > Change-Id: I5a6f74462e6e141d167c7fd9bac8c21941fd83b1 > Reviewed-on: https://chromium-review.googlesource.com/977905 > Commit-Queue: Stephan Herhut <herhut@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52580} Change-Id: I40861474fe4a3efd72e6c59e2e7b847ab6772735 Reviewed-on: https://chromium-review.googlesource.com/1013939 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52665}
-
- 12 Apr, 2018 2 commits
-
-
Sigurd Schneider authored
This reverts commit 4d7ad46d. Reason for revert: Makes i18n bot red https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Linux_-_noi18n_-_debug%2F20162%2F%2B%2Frecipes%2Fsteps%2FCheck%2F0%2Flogs%2FAssemblerIa32JumpTabl..%2F0 Original change's description: > Introduce CodeReference > > Add a struct CodeReference that can be stack allocated to pass a > reference to either an on-heap code object or off-heap WasmCode object > in a gc safe manner. The struct also provides a common interface such > that code can be written independently of the kind of code object it > references. > > Change-Id: I5a6f74462e6e141d167c7fd9bac8c21941fd83b1 > Reviewed-on: https://chromium-review.googlesource.com/977905 > Commit-Queue: Stephan Herhut <herhut@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52580} TBR=mstarzinger@chromium.org,herhut@chromium.org Change-Id: I9c49da9ee97e7423284e58bec3fdc1d212ff1af0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1010544Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52582}
-
Stephan Herhut authored
Add a struct CodeReference that can be stack allocated to pass a reference to either an on-heap code object or off-heap WasmCode object in a gc safe manner. The struct also provides a common interface such that code can be written independently of the kind of code object it references. Change-Id: I5a6f74462e6e141d167c7fd9bac8c21941fd83b1 Reviewed-on: https://chromium-review.googlesource.com/977905 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52580}
-