- 17 Oct, 2019 1 commit
-
-
Zhou, Zhiguo authored
This CL logs debug information of WASM in Intel VTune Amplifer via VTune's JIT Profiling API. With this CL, the profiling information of JITted code and its corresponding C/C++ source code is displayed optionally. To use this feature, a runtime flag "vtune_prof_annotat e_wasm" should be passed to the VTune-enabled V8 engine. Currently, the inline function in C/C++ is not well supported due to the limitation of source map. As a drive-by fix, the dynamically allocated event-specific data of JavaScript (src/third_party/vtune/vtune-jit.cc) is managed with C++ containers for safety. Change-Id: Ic27420fcdcd775bc5c7778abf5cff6edf0fb38b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782126Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Cr-Commit-Position: refs/heads/master@{#64351}
-
- 12 Aug, 2019 1 commit
-
-
Yang Guo authored
R=machenbach@chromium.org Bug: chromium:992584 Change-Id: I301013731a502689f2edd5c90e5e7bf2136198c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745337Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63159}
-
- 31 May, 2019 1 commit
-
-
Yang Guo authored
R=rmcilroy@chromium.org Bug: v8:9247 Change-Id: I2644436fd44ecf0e206a81cf28071cccb49793df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635690 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61936}
-
- 27 May, 2019 1 commit
-
-
Clemens Hammacher authored
This replaces all typedefs that define types and not functions by the equivalent "using" declaration. This was done mostly automatically using this command: ag -l '\btypedef\b' src test | xargs -L1 \ perl -i -p0e 's/typedef ([^*;{}]+) (\w+);/using \2 = \1;/sg' Patchset 2 then adds some manual changes for typedefs for pointer types, where the regular expression did not match. R=mstarzinger@chromium.org TBR=yangguo@chromium.org, jarin@chromium.org Bug: v8:9183 Change-Id: I6f6ee28d1793b7ac34a58f980b94babc21874b78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631409 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61849}
-
- 24 Apr, 2019 1 commit
-
-
Clemens Hammacher authored
This is one step towards removing the {StrLength} helper and using {size_t} consistently instead. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Ibcdfd579531a259d490c39a8e8c96d469a5a4aac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578901 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60974}
-
- 23 Jul, 2018 1 commit
-
-
Ross Mcilroy authored
Replace with isolate version. BUG=v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iac7091b983960d22b892074c5fd0a97dee9025c9 Reviewed-on: https://chromium-review.googlesource.com/1146332 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54604}
-
- 16 Jul, 2018 1 commit
-
-
Dan Elphick authored
Deprecate String::Utf8Length in favor of a new, similar function that takes the Isolate used for the String::Flatten call as an argument. BUG: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Icaf04b272679fd853e9cdbe6c7088f63e9aacb95 Reviewed-on: https://chromium-review.googlesource.com/1124724 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54476}
-
- 28 Mar, 2018 1 commit
-
-
Raphael Kubo da Costa authored
This prevents the flag from being set from e.g. Chromium. Instead, just use relative paths like everything else in the build system. Bug: chromium:825347, v8:7601 Change-Id: I080d9999b0b63bafc2c1978f70322eb48814a3b8 Reviewed-on: https://chromium-review.googlesource.com/980557 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52263}
-
- 23 Jan, 2018 1 commit
-
-
Yang Guo authored
Bug: v8:7341 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I90879be3a94745859b7da7c9bb9b6533af11cc2d Reviewed-on: https://chromium-review.googlesource.com/878221Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50790}
-
- 02 Aug, 2017 1 commit
-
-
Julien Brianceau authored
Bug: chromium:750830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Icab7b5a1c469d5e77d04df8bfca8319784e92af4 Reviewed-on: https://chromium-review.googlesource.com/595655 Commit-Queue: Julien Brianceau <jbriance@cisco.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47072}
-
- 13 Feb, 2017 1 commit
-
-
chunyang.dai authored
BUG= Review-Url: https://codereview.chromium.org/2688483004 Cr-Commit-Position: refs/heads/master@{#43133}
-
- 02 May, 2016 1 commit
-
-
ben authored
Previous attempt: https://codereview.chromium.org/1924403002 Review-Url: https://codereview.chromium.org/1937753002 Cr-Commit-Position: refs/heads/master@{#35942}
-
- 30 Apr, 2016 2 commits
-
-
bmeurer authored
Revert of Stop using deprecated hash_map in vtune-jit.cc. (patchset #1 id:1 of https://codereview.chromium.org/1924403002/ ) Reason for revert: Breaks vtune-jit build, see https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/builds/10670 Original issue's description: > Stop using deprecated hash_map in vtune-jit.cc. > > Fixes https://github.com/nodejs/node/issues/6422. TBR=jochen@chromium.org,info@bnoordhuis.nl,ben@strongloop.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1940693002 Cr-Commit-Position: refs/heads/master@{#35917}
-
ben authored
Fixes https://github.com/nodejs/node/issues/6422. Review-Url: https://codereview.chromium.org/1924403002 Cr-Commit-Position: refs/heads/master@{#35916}
-
- 29 Apr, 2016 1 commit
-
-
machenbach authored
This prepares for pulling chromium's build as dependency for gn. After this, the files in build and gypfiles need to stay in sync until chromium is updated. BUG=chromium:474921 LOG=n Review-Url: https://codereview.chromium.org/1848553003 Cr-Commit-Position: refs/heads/master@{#35898}
-
- 25 Apr, 2016 1 commit
-
-
machenbach authored
This will allow to pull in gyp as a deps to the same location as chromium (tools/gyp not build/gyp), needed for gn switch. This is the first step of a 3-way move. 1) Copy v8.gyp in v8 2) Update references in embedders (follow up) 3) Remove old v8.gyp (follow up) BUG=chromium:474921 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1920793002 Cr-Commit-Position: refs/heads/master@{#35760}
-
- 09 Dec, 2015 1 commit
-
-
jochen authored
Embedders still can use those APIs by default test-api.cc still has an exception to use the old APIs... BUG=v8:4143 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1505803004 Cr-Commit-Position: refs/heads/master@{#32701}
-
- 20 Jul, 2015 1 commit
-
-
jochen authored
BUG=v8:4134 R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/1244433003 Cr-Commit-Position: refs/heads/master@{#29740}
-
- 16 Jun, 2015 1 commit
-
-
hablich authored
LOG=n Review URL: https://codereview.chromium.org/1183743003 Cr-Commit-Position: refs/heads/master@{#29051}
-
- 22 Oct, 2014 1 commit
-
-
jochen@chromium.org authored
In R23940 (https://code.google.com/p/v8/source/detail?r=23940) it introduces Isolate::CreateParams and mentions that V8::SetJitCodeEventHandler should either be passed to Isolate::New as well, or invoked via the Isolate. When Chrome as embedder of V8, we will set the Jit Code event handler for Vtune support during the initialization of renderer process and V8 has be initialized at that time. It's better that we invoke V8::SetJitCodeEventHander via the Isolate. So we change the vTune::InitializeVtuneForV8(v8::Isolate::CreateParams& params) to vTune::InitializeVtuneForV8(v8::Isolate* isolate). we will do corresponding changes in chromium code if this patch is landed and Chromium updates V8 to the new release branch. some part of this patch is provided by denis.pravdin@intel.com. BUG= R=danno@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/655183002 Patch from Chunyang Dai <chunyang.dai@intel.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24811 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Sep, 2014 1 commit
-
-
jochen@chromium.org authored
several API methods will automatically initialize it. During this uninitialized state, code event handlers and function entry handlers can be attached to the isolate. This CL deprecates SetFunctionEntryHook and moves the configuration of those handlers to the Isolate factory method. This will allow for initializing the Isolate at creation time in the future. Users of V8::SetFunctionEntryHook should pass the entry hook to Isolate::New instead. V8::SetJitCodeEventHandler should either be passed to Isolate::New as well, or (if startup events are not required) invoked via the Isolate. BUG=none LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/570993002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23940 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Jul, 2014 1 commit
-
-
danno@chromium.org authored
During https://code.google.com/p/v8/source/detail?r=19925 checkin context bound scripts (Script) and context unbound scripts (UnboundScript) are Distinguished. And then Sven Panne helped to fix the vtune support compilation error in https://code.google.com/p/v8/source/detail?r=20955. The problem is that there is runtime error for vtune support. In our original implementation, we encapsulated and passed v8::internal::Script to V8 API. It will leads to type check error for current V8::Script definition. So I changed the Handle<Script> definition in JitCodeEvent to Handle<UnboundScript> and add the corresponding change in log.cc. If you do NOT prefer to change in include/v8.h. I think I can change the definition of CodeEventLogger::LogRecordedBuffer(...) so that the we can pass the correct type (JSFunction) as V8::Script to V8 API. BUG= R=danno@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/334263018 Patch from Chunyang Dai <chunyang.dai@intel.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Apr, 2014 1 commit
-
-
svenpanne@chromium.org authored
BUG=v8:3288 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/254793002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jan, 2014 5 commits
-
-
dslomov@chromium.org authored
This adds a fixed array sub-type that will represent a backing store for typed arrays allocated with TypedArray(length) construtor. R=mvstanton@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/101413006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18651 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This reverts commit r18649 for breaking Linux/nosnap and Win64 tests. TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/140793003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18650 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This adds a fixed array sub-type that will represent a backing store for typed arrays allocated with TypedArray(length) construtor. R=mvstanton@chromium.org, verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18646 Review URL: https://codereview.chromium.org/101413006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18649 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This reverts commit r18646 for breaking Win32 build. TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/132233012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18647 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This adds a fixed array sub-type that will represent a backing store for typed arrays allocated with TypedArray(length) construtor. R=mvstanton@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/101413006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18646 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2013 1 commit
-
-
haitao.feng@intel.com authored
The Vtune API provides the support for Android platform. So we fix the compilation issue and it works on Android platform. R=danno@chromium.org Review URL: https://codereview.chromium.org/20688002 Patch from Chunyang Dai <chunyang.dai@intel.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15942 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2013 1 commit
-
-
jochen@chromium.org authored
That way, third-party libraries use the correct toolset settings. BUG=v8:2745 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18846002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15585 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jun, 2013 1 commit
-
-
jkummerow@chromium.org authored
This allows for compiling third-party code (such as ICU) with less strict flags. BUG=v8:2745 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18181006 Patch from Jochen Eisinger <jochen@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jun, 2013 1 commit
-
-
danno@chromium.org authored
So in the vtune support code ( in vtune-jit.cc file)v8::Handle<T* value> consturctor cannot be invoked directly. We use "->ToString()" to create the Handle<String> object to fix the compilation error. R=danno@chromium.org Review URL: https://codereview.chromium.org/17343005 Patch from Chunyang Dai <chunyang.dai@intel.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15299 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 May, 2013 1 commit
-
-
danno@chromium.org authored
InitilizeVtuneForV8 --> InitializeVtuneForV8 R=danno@chromium.org Review URL: https://codereview.chromium.org/14830004 Patch from Chunyang Dai <chunyang.dai@intel.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14598 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 May, 2013 1 commit
-
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/14900003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14562 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Apr, 2013 1 commit
-
-
danno@chromium.org authored
In this patch, we added the JIT code event handler for Vtune. Most of the code is in the folder src/third_party/vtune. Two APIs are added in include/v8.h to get the requirement info from V8. We add the v8_enable_vtunejit parameter for GYP to enable these Vtune code compilation. vTune::InitilizeVtuneForV8() is invoked in the embedder of V8 to make sure it's invokded if vtune support is enabled. Review URL: https://codereview.chromium.org/11574031 Patch from Chunyang Dai <chunyang.dai@intel.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14253 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-