- 13 Jun, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: I8cd57abf612393852532a695663175dff8e3a199 Reviewed-on: https://chromium-review.googlesource.com/1098955 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53713}
-
- 11 Jun, 2018 5 commits
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Id354b039977a82af8b2c6bba416cf5a1f804ca71 Reviewed-on: https://chromium-review.googlesource.com/1095257 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53637}
-
Sigurd Schneider authored
This CL allows selection/highlighting of wasm source when a graph node is clicked. Bug: v8:7327 Change-Id: I4a3347a83c8a38804feabffefaefd761596005c3 Reviewed-on: https://chromium-review.googlesource.com/1092712 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53636}
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: I445a6589612f12c5fffa2bd23831b961c94d960e Reviewed-on: https://chromium-review.googlesource.com/1092535Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53633}
-
Sigurd Schneider authored
D3.v5 needs a merge before applying combined update and enter actions. Bug: v8:7327 Change-Id: If5a044c18e4229c5eadb18c18aea191bcbacef32 Reviewed-on: https://chromium-review.googlesource.com/1095188Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53632}
-
Sigurd Schneider authored
- Improve typing by introducing PhaseView interface. - Recalculate scale extent after resizing. - Fix null sentinel which should have been undefined. Bug: v8:7327 Change-Id: I06881ac3f5681cb419b5da9c6b8aa3a6b2652088 Reviewed-on: https://chromium-review.googlesource.com/1090914Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53631}
-
- 08 Jun, 2018 1 commit
-
-
Sigurd Schneider authored
This CL updates the d3.js library to version 5.4. The most notable change is that the library can now distinguish between click and drag events if an element supports both selection via click and displacement via drag. Curiously, npm created a 'package-lock.json', which is ~500 lines, and which is supposed to be checked into the repository according to documentation. Change-Id: Ifabd236296d951f390e0a1516d89e73138ce1713 Reviewed-on: https://chromium-review.googlesource.com/1076234Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53604}
-
- 29 May, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: I2be450c6498ce863d5e36acf02db643788e6c8bf Reviewed-on: https://chromium-review.googlesource.com/1068045 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53400}
-
- 22 May, 2018 2 commits
-
-
Sigurd Schneider authored
Change-Id: I6d84e7ef500aecd83a77ed2ce3fed4e15b29b7ac Reviewed-on: https://chromium-review.googlesource.com/1065881 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53289}
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ic1c4a10a251a8243fc337dc149eb057a29cace2b Reviewed-on: https://chromium-review.googlesource.com/1065670 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53279}
-
- 18 May, 2018 2 commits
-
-
Sigurd Schneider authored
Shortcuts e and c select (and make visible) the next effect/control node downwards in the chain; ALT+e/c moves upward. Additionally, the graph bounding box is redetermined every time the graph is redrawn (instead of only when relayouted). Bug: v8:7327 Change-Id: If01b16fc25273703e25e429bdc36753a2fa87f7c Reviewed-on: https://chromium-review.googlesource.com/1064210 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53259}
-
Sigurd Schneider authored
This also includes the precise reducer name. Currently the information is available in the node tooltip in turbolizer. The new shortcut 's' in the graph view selects the nodes the currently selected nodes were created from. Bug: v8:7327 Change-Id: I7ca7327d0cfa112972e3567df6e4a223c8eff3c0 Reviewed-on: https://chromium-review.googlesource.com/1064059 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53258}
-
- 16 May, 2018 1 commit
-
-
Sigurd Schneider authored
This CL adds support for inlined functions in Turbolizer. It is also a refactoring of the Turbolizer code-base. Most importantly, handling of source positions changed to exact source positions, and not code ranges. This improves selection interoperability between different phase views. A separate CL changes the Turbolizer JSON format to include inlining information. This Turbolizer update, however, is intended to be backwards compatible with the JSON format Turbolizer generated before the JSON format change. Bug: v8:7327 Change-Id: Ic67506a6f3a36fe98c012b1e76994972779c1fd2 Reviewed-on: https://chromium-review.googlesource.com/1032784 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53213}
-
- 23 Feb, 2018 1 commit
-
-
Sigurd Schneider authored
A.p.includes can now replace monkey-patched A.p.contains. Bug: v8:7310, v8:7327 Change-Id: Ibbd6c5526322599c06f5485471cf6a6361b082b9 Reviewed-on: https://chromium-review.googlesource.com/934265 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#51521}
-
- 21 Feb, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Id1dbe6ad2cbf790075e360c5d0b5422d2ca4271b Reviewed-on: https://chromium-review.googlesource.com/928221Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51413}
-
- 18 Jan, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ic33a0d86f055ac5ec3607d8e57d796428f4b9d20 Reviewed-on: https://chromium-review.googlesource.com/873378Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#50682}
-
- 12 Jan, 2018 1 commit
-
-
Sigurd Schneider authored
- Turbolizer highlights input and output nodes on hover. - The three panes support resizing now (snap to side still works). Bug: Change-Id: Ida1513fd714a02ab772885ea1fdf6d9da8d540f6 Reviewed-on: https://chromium-review.googlesource.com/837068 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#50523}
-
- 23 Jun, 2017 1 commit
-
-
Michael Starzinger authored
This removes the --turbo flag and solely relies on the filter pattern provided via --turbo-filter when deciding whether to use TurboFan. Note that disabling optimization wholesale can still be done with --no-opt, which should be used in favor of --no-turbo everywhere. Also note that this contains semantic changes to the TurboFan activation criteria. We respect the filter pattern more stringently and no longer activate TurboFan just because the source contains patterns forcing use of Ignition via {AstNumberingVisitor::DisableFullCodegenAndCrankshaft}. R=rmcilroy@chromium.org BUG=v8:6408 Change-Id: I0c855f6a62350eb62283a3431c8cc1baa750950e Reviewed-on: https://chromium-review.googlesource.com/528121Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#46167}
-
- 15 May, 2017 1 commit
-
-
pierre.langlois authored
The output of disassemblers was changed to display instruction offsets as hexadecimal numbers instead of a decimal numbers. Reflect this change in turbolizer. BUG= Review-Url: https://codereview.chromium.org/2885453002 Cr-Commit-Position: refs/heads/master@{#45315}
-
- 29 Mar, 2017 1 commit
-
-
Leszek Swirski authored
Previously code view was set using innerHTML. This would cause problems for html characters in the code -- in particular, '<' without a space after it would start new HTML tags, and the code following it wouldn't be visible. Now, the source text is set using textContent, which doesn't parse the value as HTML and implicitly escapes any HTML characters in the code. Change-Id: I612a18c37bbb4da6a87063bb39d7f7123a3c4c0d Reviewed-on: https://chromium-review.googlesource.com/461826Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#44233}
-
- 24 Nov, 2016 1 commit
-
-
jing.bao authored
BUG= Review-Url: https://codereview.chromium.org/2523263003 Cr-Commit-Position: refs/heads/master@{#41270}
-
- 07 Nov, 2016 1 commit
-
-
jing.bao authored
fix schedule viewing for text like 1756: HeapConstant[0x3ff62d29 <FixedArray[31]>] : HeapConstant(0x3ff62d29 <FixedArray[31]>) BUG= Review-Url: https://codereview.chromium.org/2471573007 Cr-Commit-Position: refs/heads/master@{#40786}
-
- 14 Sep, 2016 1 commit
-
-
Alexander.Gilday2 authored
All events recorded are shown in separate columns simulatneously, using rectangles with heatmap-style colouring. Hovering over the shapes gives the event name, count, and percentage. BUG= Review-Url: https://codereview.chromium.org/2228553004 Cr-Commit-Position: refs/heads/master@{#39408}
-
- 08 Sep, 2016 1 commit
-
-
bgeron authored
BUG= Review-Url: https://codereview.chromium.org/2293483002 Cr-Commit-Position: refs/heads/master@{#39297}
-
- 11 Aug, 2016 1 commit
-
-
bgeron authored
BUG= Review-Url: https://codereview.chromium.org/2230313002 Cr-Commit-Position: refs/heads/master@{#38588}
-
- 10 Aug, 2016 4 commits
-
-
bgeron authored
BUG= R=danno Review-Url: https://codereview.chromium.org/2232933002 Cr-Commit-Position: refs/heads/master@{#38562}
-
bgeron authored
BUG= R=danno Review-Url: https://codereview.chromium.org/2230783005 Cr-Commit-Position: refs/heads/master@{#38561}
-
danno authored
Also convert CodeView to a class and fix a host of selection bugs in the process, as well as move the logic and data to "enrich" location with one type of location data with location data known globally to the whole graph in the selection broker. Review-Url: https://codereview.chromium.org/2230083004 Cr-Commit-Position: refs/heads/master@{#38544}
-
danno authored
Review-Url: https://codereview.chromium.org/2234523002 Cr-Commit-Position: refs/heads/master@{#38520}
-
- 09 Aug, 2016 2 commits
-
-
bgeron authored
R=danno,jarin BUG= Review-Url: https://codereview.chromium.org/2226293002 Cr-Commit-Position: refs/heads/master@{#38502}
-
bgeron authored
BUG= Review-Url: https://codereview.chromium.org/2225683009 Cr-Commit-Position: refs/heads/master@{#38500}
-
- 08 Aug, 2016 1 commit
-
-
bgeron authored
R=danno BUG= Review-Url: https://codereview.chromium.org/2227643002 Cr-Commit-Position: refs/heads/master@{#38442}
-
- 28 Jul, 2016 2 commits
-
-
Alexander.Gilday2 authored
Change was meant to be in previous patch but was accidentally reverted. README.md updated with new filename, also. BUG= Review-Url: https://codereview.chromium.org/2184223005 Cr-Commit-Position: refs/heads/master@{#38134}
-
Alexander.Gilday2 authored
perf-turbo.py merges a perf data file and a turbofan trace file into a single json object which can then be piped to a file and uploaded to turbolizer to display the profiling data in the disassembly. With the changes, turbolizer now shows the event counts for instruction in percentage form and with heatmap-stype colouring. Multiple different events can be recorded at once with a new drop-down menu to select which event to view the counts of. The documentation has been updated with instructions. Using the script is optional and turbolizer retains previous functionality if a trace without profiling data is uploaded. BUG=None Review-Url: https://codereview.chromium.org/2174803002 Cr-Commit-Position: refs/heads/master@{#38124}
-
- 26 Jul, 2016 1 commit
-
-
bgeron authored
BUG= R=danno Review-Url: https://codereview.chromium.org/2171543004 Cr-Commit-Position: refs/heads/master@{#38045}
-
- 25 Jul, 2016 5 commits
-
-
bgeron authored
/ also selects the search box. BUG= Review-Url: https://codereview.chromium.org/2169053002 Cr-Commit-Position: refs/heads/master@{#38027}
-
bgeron authored
BUG= R=danno Review-Url: https://codereview.chromium.org/2169043002 Cr-Commit-Position: refs/heads/master@{#38025}
-
bgeron authored
If you dragged the node out of the bounding box, this commit allows you to see it again after you zoom. The zoom looks jittery, but I think it's better than not being able to see it at all. BUG= R=danno Review-Url: https://codereview.chromium.org/2168713005 Cr-Commit-Position: refs/heads/master@{#38024}
-
bgeron authored
BUG= R=danno Review-Url: https://codereview.chromium.org/2169023002 Cr-Commit-Position: refs/heads/master@{#38004}
-
bgeron authored
- Remove duplicated CSS. - Expand landing area of upload button. - Give the toolbox a transparent white background. - Make the phase-select box look nicer before file load. - Remove the margin at the top of the screen. The height of the margin was exactly the height of span#graph-toolbox, and due to the semantics of position:relative, space was reserved for it at the top of div#middle. BUG= R=danno Review-Url: https://codereview.chromium.org/2164373002 Cr-Commit-Position: refs/heads/master@{#38003}
-