- 31 Aug, 2018 1 commit
-
-
Marijn Kruisselbrink authored
Bug: chromium:872465 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I75eccab304405569b40c5dcc18177354372a02c9 Reviewed-on: https://chromium-review.googlesource.com/1199464Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#55563}
-
- 30 Aug, 2018 2 commits
-
-
Peter Marshall authored
We have an API (GetCodeRange) which gives the location of V8 code on the heap, but builtin code no longer lives on the heap. The upcoming work on the V8 stack unwinder requires the embedder to provide the code ranges for both the heap and builtins, so this API will be used there. Bug: v8:8116 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I15e900716e68256b9732be0ea1a5cda24878eccf Reviewed-on: https://chromium-review.googlesource.com/1196551Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55532}
-
Michael Lippautz authored
Revert "Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery."" This reverts commit eb164dbd. Revert "[d8] Fixed external gc test (limit multiplied by number of isolates)." This reverts commit 38cbc26a. Revert "[heap] Fixed typo in method name." This reverts commit 263174af. Bug: chromium:845409, chromium:879045 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I555bcff2ad04ae23368c7b3999a237083010f9c6 Reviewed-on: https://chromium-review.googlesource.com/1196550Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55529}
-
- 29 Aug, 2018 1 commit
-
-
Rodrigo Bruno authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id2b474917ffd711ed30b9ae5f25ec86e13b140b5 Reviewed-on: https://chromium-review.googlesource.com/1193876Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55487}
-
- 28 Aug, 2018 1 commit
-
-
Rodrigo Bruno authored
Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This is a reland of ba735dde Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} Bug: chromium:845409 Change-Id: Iaff177f7bebbc073460fab0ae4e5cd9e632e1921 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1177301Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55454}
-
- 24 Aug, 2018 3 commits
-
-
Stephan Herhut authored
This is a reland of 524215be Original change's description: > Use new arraybuffer deleter interface in d8 > > With this cl we start using the custom deleter to free externalized > array buffers. This also allows us to keep wasm memories registered > with the wasm memory tracker and thereby to propagate that a memory > is wasm allocated over postMessage calls. > > Bug: v8:8073, chromium:836800 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I57e3ea44d9c6633ada7996677dd1de4da810ab64 > Reviewed-on: https://chromium-review.googlesource.com/1186681 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Stephan Herhut <herhut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55361} Bug: v8:8073, chromium:836800 Change-Id: Ia3c057ced496363cfdd07eed16ed1d0c7a3f3084 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1188222Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#55389}
-
Michaël Zasso authored
Introduced in https://chromium-review.googlesource.com/1183431. The namespace was missing making compilation of Node.js with GCC fail. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I55c1117ab347db17fd8acfa92c653e8cf737586f Reviewed-on: https://chromium-review.googlesource.com/1188126Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/master@{#55377}
-
Michael Lippautz authored
Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie959e443fdf5dce92c4cd42ef62ec914a13b867e Reviewed-on: https://chromium-review.googlesource.com/1187151 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55376}
-
- 23 Aug, 2018 3 commits
-
-
Michael Achenbach authored
This reverts commit 524215be. Reason for revert: Breaks cfi: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20cfi/16422 Original change's description: > Use new arraybuffer deleter interface in d8 > > With this cl we start using the custom deleter to free externalized > array buffers. This also allows us to keep wasm memories registered > with the wasm memory tracker and thereby to propagate that a memory > is wasm allocated over postMessage calls. > > Bug: v8:8073, chromium:836800 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I57e3ea44d9c6633ada7996677dd1de4da810ab64 > Reviewed-on: https://chromium-review.googlesource.com/1186681 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Stephan Herhut <herhut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55361} TBR=mstarzinger@chromium.org,herhut@chromium.org Change-Id: I64c4e76d8d68bad8df4ba3297c099b9b44eabc7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8073, chromium:836800 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1187241Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55366}
-
Stephan Herhut authored
With this cl we start using the custom deleter to free externalized array buffers. This also allows us to keep wasm memories registered with the wasm memory tracker and thereby to propagate that a memory is wasm allocated over postMessage calls. Bug: v8:8073, chromium:836800 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I57e3ea44d9c6633ada7996677dd1de4da810ab64 Reviewed-on: https://chromium-review.googlesource.com/1186681Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#55361}
-
Stephan Herhut authored
Currently, we use an AllocationKind to signal to the embedder how v8 has allocated the backingstore of an array buffer. The embedder then has to implement matching logic to free an exernalized buffer. By Using custom deleters v8 can communicate how to free an externalized array buffer without requiring all embedders to implement corresponding freeing logic. Bug: v8:8073 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I553dec31ba167d6a7b342ded50d685be7dffd1c5 Reviewed-on: https://chromium-review.googlesource.com/1183484 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55347}
-
- 22 Aug, 2018 1 commit
-
-
Dan Elphick authored
This is a reland of 957854dd Relanding now that pdfium has been fixed when non-standard flags are used. Original change's description: > Reland "[cleanup] Reland: Remove deprecated functions" > > This reverts commit 717b9385. > > Reason for revert: Cast build is now fixed > > Original change's description: > > Revert "[cleanup] Reland: Remove deprecated functions" > > > > This reverts commit c8376b00. > > > > Reason for revert: Still borked: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/114796 > > > > Original change's description: > > > [cleanup] Reland: Remove deprecated functions > > > > > > This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 > > > with no changes since the break in chromium for ChromeOS is now fixed. > > > > > > Removes all V8_DEPRECATED functions that weren't recently marked as well > > > any V8_DEPRECATE_SOON function that relied on using using the address of > > > an object to get hold of the Isolate. > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1172350 TBR=yangguo@chromium.org Bug: v8:7786 Change-Id: Ic877155da3e4b280cc48e7dca9dc8dd78667a3d8 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Reviewed-on: https://chromium-review.googlesource.com/1177861Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55309}
-
- 21 Aug, 2018 1 commit
-
-
Michael Lippautz authored
This call can be used by embedder to request a GC for testing reasons. The GC also takes the current embedder stack state as an argument that is forwarded to the embedder when entering the atomic pause. This way embedders can request garbage collections for testing and set how the embedder should treat the stack. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id10604565b4457dd0fca402afeb5f8e592fa0bae Reviewed-on: https://chromium-review.googlesource.com/1183431 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55285}
-
- 20 Aug, 2018 1 commit
-
-
Michael Starzinger authored
This makes sure the aforementioned predicate is independent of the current context (aka. Realm) and only uses the instance type of the given object to determine whether it is a WebAssembly module object. R=titzer@chromium.org TEST=mjsunit/regress/wasm/regress-8059 BUG=v8:8059 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Icc8e400f8412483f2a3883ca65c58b7ef938ef23 Reviewed-on: https://chromium-review.googlesource.com/1180886Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55205}
-
- 17 Aug, 2018 2 commits
-
-
Marja Hölttä authored
This way the snapshot will contain only old space objects. BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib19642795b1e8c7cbeda5162be86909c1a777767 Reviewed-on: https://chromium-review.googlesource.com/1177384Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55186}
-
Ben L. Titzer authored
JSArrays and JSArrayBuffers are very different animals. As such, split the js-array.h header into two parts. R=ulan@chromium.org,mstarzinger@chromium.org Bug: v8:5402 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I82f987ecea3e2e1ceaf8f8962a2b88165558c57e Reviewed-on: https://chromium-review.googlesource.com/1177760Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55183}
-
- 16 Aug, 2018 1 commit
-
-
Jakob Kummerow authored
This reverts commit 957854dd. Reason for revert: breaks fuzzing builds => blocks rolling, crbug.com/874440 Original change's description: > Reland "[cleanup] Reland: Remove deprecated functions" > > This reverts commit 717b9385. > > Reason for revert: Cast build is now fixed > > Original change's description: > > Revert "[cleanup] Reland: Remove deprecated functions" > > > > This reverts commit c8376b00. > > > > Reason for revert: Still borked: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/114796 > > > > Original change's description: > > > [cleanup] Reland: Remove deprecated functions > > > > > > This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 > > > with no changes since the break in chromium for ChromeOS is now fixed. > > > > > > Removes all V8_DEPRECATED functions that weren't recently marked as well > > > any V8_DEPRECATE_SOON function that relied on using using the address of > > > an object to get hold of the Isolate. > > > > > > Bug: v8:7786 > > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > > > Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 > > > Reviewed-on: https://chromium-review.googlesource.com/1172350 > > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > > Commit-Queue: Dan Elphick <delphick@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#55119} > > > > TBR=yangguo@chromium.org,delphick@chromium.org > > > > Change-Id: Id1308a694092acfc90a3e7183d66c002feb63999 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: v8:7786 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > > Reviewed-on: https://chromium-review.googlesource.com/1174751 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55127} > > TBR=yangguo@chromium.org,leszeks@chromium.org,delphick@chromium.org > > Change-Id: Id65dae1abdad6f854afec9eb59ed2bddd9246f79 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7786 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > Reviewed-on: https://chromium-review.googlesource.com/1175721 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55136} TBR=yangguo@chromium.org,leszeks@chromium.org,delphick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7786 Change-Id: I5dc792a3a1c986b8609487ca6ad1e485a8940521 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Reviewed-on: https://chromium-review.googlesource.com/1177661Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#55167}
-
- 15 Aug, 2018 2 commits
-
-
Camillo Bruni authored
- Explicitly allows construction of {Named,Indexed}PropertyHandlerConfiguration with all the members filled. Bug: v8:7612 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I426ea33846b5dbf2b3482c722c963a6e4b0abded Reviewed-on: https://chromium-review.googlesource.com/1163882Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55142}
-
Dan Elphick authored
This reverts commit 717b9385. Reason for revert: Cast build is now fixed Original change's description: > Revert "[cleanup] Reland: Remove deprecated functions" > > This reverts commit c8376b00. > > Reason for revert: Still borked: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/114796 > > Original change's description: > > [cleanup] Reland: Remove deprecated functions > > > > This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 > > with no changes since the break in chromium for ChromeOS is now fixed. > > > > Removes all V8_DEPRECATED functions that weren't recently marked as well > > any V8_DEPRECATE_SOON function that relied on using using the address of > > an object to get hold of the Isolate. > > > > Bug: v8:7786 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > > Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 > > Reviewed-on: https://chromium-review.googlesource.com/1172350 > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Commit-Queue: Dan Elphick <delphick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#55119} > > TBR=yangguo@chromium.org,delphick@chromium.org > > Change-Id: Id1308a694092acfc90a3e7183d66c002feb63999 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7786 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > Reviewed-on: https://chromium-review.googlesource.com/1174751 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55127} TBR=yangguo@chromium.org,leszeks@chromium.org,delphick@chromium.org Change-Id: Id65dae1abdad6f854afec9eb59ed2bddd9246f79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Reviewed-on: https://chromium-review.googlesource.com/1175721Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55136}
-
- 14 Aug, 2018 5 commits
-
-
Sathya Gunasekaran authored
Revert "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This reverts commit ba735dde. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21991 Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} TBR=ulan@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: Iaf65227c65c11effa11662ac7d7bd7736f4d7846 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1174858Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55129}
-
Rodrigo Bruno authored
Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b Reviewed-on: https://chromium-review.googlesource.com/1160162 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55128}
-
Leszek Swirski authored
This reverts commit c8376b00. Reason for revert: Still borked: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/114796 Original change's description: > [cleanup] Reland: Remove deprecated functions > > This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 > with no changes since the break in chromium for ChromeOS is now fixed. > > Removes all V8_DEPRECATED functions that weren't recently marked as well > any V8_DEPRECATE_SOON function that relied on using using the address of > an object to get hold of the Isolate. > > Bug: v8:7786 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel > Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 > Reviewed-on: https://chromium-review.googlesource.com/1172350 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55119} TBR=yangguo@chromium.org,delphick@chromium.org Change-Id: Id1308a694092acfc90a3e7183d66c002feb63999 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Reviewed-on: https://chromium-review.googlesource.com/1174751Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#55127}
-
Dan Elphick authored
This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 with no changes since the break in chromium for ChromeOS is now fixed. Removes all V8_DEPRECATED functions that weren't recently marked as well any V8_DEPRECATE_SOON function that relied on using using the address of an object to get hold of the Isolate. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 Reviewed-on: https://chromium-review.googlesource.com/1172350Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55119}
-
Andreas Haas authored
The problem was that in AsyncCompileJob::FinishModule we allocate a handle, but when this function is called from streaming compilation, then there was no HandleScope around AsyncCompileJob::FinishModule. This issue was fixed in another CL, https://crrev.com/c/1172357. This CL is just a rebase of the original CL. Original change's description: > [wasm] Implement the new API for WebAssembly.instantiateStreaming > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to > make it spec compliant again. The design doc where the whole change is > discussed is available in the tracking bug. The tracking bug also > references prototype implementations of the whole change, which includes > the changes in this CL. R=starzinger@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib0cb25488654d2b325b4f529d33b76b846c64436 Reviewed-on: https://chromium-review.googlesource.com/1172429Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55106}
-
- 13 Aug, 2018 2 commits
-
-
Clemens Hammacher authored
After https://crrev.com/c/1172285, abortion and deletion of an {AsyncCompileJob} is the same. Hence, remove the {AbortCompileJobsOnIsolate} method and replace all uses by {DeleteCompileJobsOnIsolate}. R=ahaas@chromium.org CC=mstarzinger@chromium.org Bug: chromium:869420 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I053dc47395a257066bbca55069d53445dc28eeb9 Reviewed-on: https://chromium-review.googlesource.com/1172288Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55092}
-
Yang Guo authored
The break id is no longer used. Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib07046d66497cbd5e01a8a1248afd890180200bf Reviewed-on: https://chromium-review.googlesource.com/1172136Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55074}
-
- 09 Aug, 2018 2 commits
-
-
Ben L. Titzer authored
This CL introduces a set of configuration options implemented as a struct of booleans that together comprise the set of enabled or detected features. The configuration options replace command-line flags that were checked deep in the implementation. As such, it is necessary to plumb them through multiple levels of abstraction. R=ahaas@chromium.org CC=mstarzinger@chromium.org BUG=chromium:868844 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1b82f5826e4fd263f68e8cafcd923bac5818a637 Reviewed-on: https://chromium-review.googlesource.com/1163670Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55018}
-
Andreas Haas authored
With the callback we can check if the origin trial is turned on for a given context. I will not land the other CL which added a flag to the isolate. The information if the origin trial is on is context-specific and not isolate-specific, and it's hard on the embedder side to track all creations of a context. With the API proposed in this CL we will ask the embedder every time we start compilation whether the origin trial is on or off. R=yangguo@chromium.org Bug:868844 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8822f40ab12582a5b0bd6640790a269107fc085a Reviewed-on: https://chromium-review.googlesource.com/1163621 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55011}
-
- 07 Aug, 2018 1 commit
-
-
Dan Elphick authored
This reverts commit 5414884a. Reason for revert: breaks the roll due to not testing CrOs Original change's description: > [api] Remove deprecated functions > > Removes all V8_DEPRECATED functions that weren't recently marked as well > any V8_DEPRECATE_SOON function that relied on using the address of > an object to get hold of the Isolate. > > Normally we would have advanced the V8_DEPRECATE_SOON methods to > V8_DEPRECATE in this release and removed them in the follow release, but > their continuing presence blocks the work on creating a shared > Read-Only space where some objects would not belong to any single > Isolate. In preparation chromium and node.js (via the v8/node github) > have been modified in advance. > > Bug: v8:7786 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I8b4b06189896d94aff908ebcd121b3b38f9b482a > Reviewed-on: https://chromium-review.googlesource.com/1154915 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54915} TBR=yangguo@chromium.org,delphick@chromium.org Change-Id: Iaf23e04d55a95b01b0423effa6cde3c0be5e2ba8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1164902Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54937}
-
- 06 Aug, 2018 3 commits
-
-
Marja Hölttä authored
This reverts commit a5efd507. Reason for revert: was a GC bug, unrelated to this CL. Original change's description: > Revert (partially) "Reland [in-place weak refs] Use WeakArrayList in Heap::noscript_list." > > Reason: flaky wasm crashes. > > This leaves WeakArrayList::RemoveOne (+ tests for it) in place. > > BUG=v8:7308, v8:8014 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I1195d061ae7d3c82f921f94f50df3f09a55de5ca > Reviewed-on: https://chromium-review.googlesource.com/1161904 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54891} TBR=marja@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7308, v8:8014 Change-Id: Id8002e2178ac89378b047dd0acd1bf4e3c272918 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1162124Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54921}
-
Rodrigo Bruno authored
Node.js is using AdjustAmountOfExternalAllocatedMemory to get external memory from V8 [1]. In addition, they have a unittest that verifies that AdjustAmountOfExternalAllocatedMemory returns the correct value [2]. This CL proposes a new way to report external memory through HeapStatistics. [1]https://github.com/nodejs/node/blob/07cb69720bec251a1c450b3770db2136ac009778/src/node_process.cc#L187 [2]https://github.com/nodejs/node/blob/master/test/parallel/test-memory-usage.js Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia58ed0bab1c1d4ee23672e1347b9a00b6705a43c Reviewed-on: https://chromium-review.googlesource.com/1162156 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54919}
-
Dan Elphick authored
Removes all V8_DEPRECATED functions that weren't recently marked as well any V8_DEPRECATE_SOON function that relied on using the address of an object to get hold of the Isolate. Normally we would have advanced the V8_DEPRECATE_SOON methods to V8_DEPRECATE in this release and removed them in the follow release, but their continuing presence blocks the work on creating a shared Read-Only space where some objects would not belong to any single Isolate. In preparation chromium and node.js (via the v8/node github) have been modified in advance. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8b4b06189896d94aff908ebcd121b3b38f9b482a Reviewed-on: https://chromium-review.googlesource.com/1154915 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54915}
-
- 03 Aug, 2018 1 commit
-
-
Marja Hölttä authored
Reason: flaky wasm crashes. This leaves WeakArrayList::RemoveOne (+ tests for it) in place. BUG=v8:7308, v8:8014 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1195d061ae7d3c82f921f94f50df3f09a55de5ca Reviewed-on: https://chromium-review.googlesource.com/1161904Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54891}
-
- 02 Aug, 2018 1 commit
-
-
Andreas Haas authored
This reverts commit b556c9ea. Reason for revert: Flakes in layout tests: https://crbug.com/870187 Original change's description: > [wasm] Implement the new API for WebAssembly.instantiateStreaming > > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to > make it spec compliant again. The design doc where the whole change is > discussed is available in the tracking bug. The tracking bug also > references prototype implementations of the whole change, which includes > the changes in this CL. > > R=mstarzinger@chromium.org > > Bug: chromium:860637 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I776c0f24959ab5663727d3dfee0248a9b0642a42 > Reviewed-on: https://chromium-review.googlesource.com/1143187 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54834} TBR=mstarzinger@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:860637 Change-Id: Icbf2603143068a49c61de162aa7185a753703e5d Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1160261Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54872}
-
- 01 Aug, 2018 3 commits
-
-
Michael Starzinger authored
This changes the WebAssembly serializer to take a full snapshot of the code table before measuring and serializing the module. It allows other threads (or other Isolates) to mutate the native module while the main thread is serializing the module. R=clemensh@chromium.org BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I64bc27600452880f37f4fbb2f40c77c79975358f Reviewed-on: https://chromium-review.googlesource.com/1156596 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54838}
-
Andreas Haas authored
This is the second V8 CL to refactor WebAssembly.instantiateStreaming to make it spec compliant again. The design doc where the whole change is discussed is available in the tracking bug. The tracking bug also references prototype implementations of the whole change, which includes the changes in this CL. R=mstarzinger@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I776c0f24959ab5663727d3dfee0248a9b0642a42 Reviewed-on: https://chromium-review.googlesource.com/1143187 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54834}
-
Sathya Gunasekaran authored
Similar to existings helpers like SetProperty, WriteToReadOnlyProperty, etc, this create an helper for CreateDataProperty that abstracts away the LookupIterator. Bug: v8:5751 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5ca02a2bad982adf233f3ea9de799e5706cd248a Reviewed-on: https://chromium-review.googlesource.com/1156400Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54832}
-
- 31 Jul, 2018 3 commits
-
-
Ben L. Titzer authored
As discussed offline, this header is not really useful without its inline definitions. So instead of trying to split it (unnaturally), declare defeat and make it an inline header file. Also remove two unnecessary uses of it, move the JSON stringifier class into its .cc file (because it needs IncrementalStringBuilder inline) and forward declare in prettyprinter.h. R=petermarshall@chromium.org, mstarzinger@chromium.org BUG=v8:7965 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I7ba032ca718a195e156ec3e59f8e858a25423450 Reviewed-on: https://chromium-review.googlesource.com/1156401Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54818}
-
Georg Neis authored
Use sizeof of the C type instead. Also fix a few #undef's that got reported after my changes. R=jarin@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I30a43b3d93e6df04fb9fb33050b52988edd7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1155108Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54817}
-
Dan Elphick authored
This new method only compares Strings and so doesn't need a Context. It also can't throw so it returns bool. Can be used in place of the deprecated Equals method and many Equals call currently taking a Context. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4cfe7747aa140e5a55d9513681ee4704414e1545 Reviewed-on: https://chromium-review.googlesource.com/1151321 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54812}
-