- 06 Oct, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
This split is required for adding scriptHash argument. R=dgozman@chromium.org TBR=machenbach@chromium.org Bug: chromium:459499 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0266cd22be4053829af47ba445e0ddfb6b726e71 Reviewed-on: https://chromium-review.googlesource.com/703863 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#48355}
-
- 02 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js. There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs. Drive by: debugger-script.js and usage of debugger context in inspector code base. R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org Bug: v8:5510,chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7 Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47091}
-
- 28 Jul, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
To avoid using debugging context and debugger-script.js on inspector side we can move SetScriptSource call to v8::internal::Debug. Theoretically we can move live edit implementation to native completely but since it will be reimplemented it looks redundant. R=yangguo@chromium.org,jgruber@chromium.org Bug: chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Id09492c2d2a93efbde429c9cc1bc181d5fdda19b Reviewed-on: https://chromium-review.googlesource.com/590736 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46985}
-
- 06 Mar, 2017 1 commit
-
-
kozyatinskiy authored
This CL provide type with each break location, type could be: call, return or debugger statement. BUG=chromium:432469 R=yangguo@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2728563002 Cr-Commit-Position: refs/heads/master@{#43619}
-
- 28 Feb, 2017 1 commit
-
-
kozyatinskiy authored
For breakpoints which are set by setBreakpointByUrl(url:..) backend calculates source hint on first related breakpoints resolved event and then uses this hint to adjust breakpoint position in later arrived scripts with the same url or on page reload. Doc: https://docs.google.com/a/google.com/document/d/1VtWo_-jelzEXSNbjESGTtruZngzXgbHLexfTzxNlnjE/edit?usp=sharing BUG=chromium:688776 R=pfeldman@chromium.org, alph@chromium.org Review-Url: https://codereview.chromium.org/2671193002 Cr-Commit-Position: refs/heads/master@{#43493}
-
- 27 Feb, 2017 1 commit
-
-
kozyatinskiy authored
BUG=chromium:695236 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2710953004 Cr-Commit-Position: refs/heads/master@{#43457}
-
- 03 Feb, 2017 1 commit
-
-
kozyatinskiy authored
This flag is true when compiled script is ES6 module. BUG=v8:1569 R=dgozman@chromium.org,adamk@chromium.org Review-Url: https://codereview.chromium.org/2663973002 Cr-Commit-Position: refs/heads/master@{#42910}
-
- 27 Jan, 2017 1 commit
-
-
clemensh authored
and add an inspector test for it. Also test that a breakpoint can be set on each reported position, and that it is also hit during execution. This CL also fixes two little things which were uncovered by the new test. R=yangguo@chromium.org, titzer@chromium.org, kozyatinskiy@chromium.org BUG=v8:5822 Review-Url: https://codereview.chromium.org/2655653003 Cr-Commit-Position: refs/heads/master@{#42722}
-
- 24 Jan, 2017 1 commit
-
-
kozyatinskiy authored
V8 has internal mechanism to ignore steps and breaks inside internal scripts, in this CL it's reused for blackboxing implementation. Advantages: - much faster blackboxing implementation (before we at least wrap and collect current call stack for each step), - get rid of StepFrame action and potential pause in blackboxed code after N StepFrame steps, - simplification of debugger agent logic. Disadvtanges: - currently when user was paused in blackboxed code (e.g. on breakpoint) and then makes step action, debugger ignores blackboxed state of the script and allows to use step actions as usual - this behavior is regressed, we still able to support it on frontend side. Current state and proposed changes for blackboxing: https://docs.google.com/document/d/1hnzaXPAN8_QC5ENxIgxgMNDbXLraM_OXT73rAyijTF8/edit?usp=sharing BUG=v8:5842 R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2633803002 Cr-Commit-Position: refs/heads/master@{#42614}
-
- 12 Dec, 2016 1 commit
-
-
dgozman authored
This is to improve the performance of common operation of extracting contextId or contextGroupId out of Context. BUG=none Review-Url: https://codereview.chromium.org/2558913004 Cr-Commit-Position: refs/heads/master@{#41657}
-
- 06 Dec, 2016 1 commit
-
-
clemensh authored
Make some methods on V8DebuggerScript virtual and provide the implementations ActualScript for scripts which are backed by scripts on V8's side, and WasmVirtualScript for wasm scripts. The added test case ensures that we at least don't crash on the attempt to get breakable locations for wasm "scripts", which we did previously. Returning a reasonable result for wasm will be implemented in a follow-up commit. R=yangguo@chromium.org, jgruber@chromium.org BUG=chromium:667767,chromium:613110 Review-Url: https://codereview.chromium.org/2532433003 Cr-Commit-Position: refs/heads/master@{#41527}
-
- 05 Dec, 2016 2 commits
-
-
clemensh authored
It only contained type definitions and static functions, so we can also just make it a namespace. R=kozyatinskiy@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2549133002 Cr-Commit-Position: refs/heads/master@{#41501}
-
clemensh authored
This CL adds a new header src/debug/interface-types.h, moves the definition of Location from the debug-interface.h to this new header, and adds a new definition for the WasmDisassembly types. This allows to use the types in other implementation files or headers without having to include the entire debug-interface.h, reducing build dependencies and compile time (especially for incremental builds). The WasmDisassembly type replaces the old std::pair<std::string, std::vector<std::tuple<...>>>, which was a bit hard to unravel. R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2529383002 Cr-Commit-Position: refs/heads/master@{#41488}
-
- 16 Nov, 2016 1 commit
-
-
clemensh authored
This allows to show wasm source (disassembled wasm code) in DevTools. See design doc for details. More tests for the disassembly will have to follow. Also, the text format (generated by V8) will be changed. BUG=chromium:659715 R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org, dgozman@chromium.org Review-Url: https://codereview.chromium.org/2493773003 Cr-Commit-Position: refs/heads/master@{#41055}
-
- 04 Nov, 2016 1 commit
-
-
kozyatinskiy authored
This method iterates through all shared function info which are related to passed script, compiles debug code for SFI in range if needed and returns possible break locations. BUG=chromium:566801 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2465553003 Cr-Commit-Position: refs/heads/master@{#40783}
-
- 29 Oct, 2016 1 commit
-
-
kozyatinskiy authored
* Introduced DebugInterface::Script - native wrapper on internal::Script. * Migrated getCompildScripts and scriptParsed to native wrapper. BUG=chromium:652939, v8:5510 R=yangguo@chromium.org,dgozman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2449213002 Cr-Commit-Position: refs/heads/master@{#40660}
-
- 26 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2343733002 Cr-Commit-Position: refs/heads/master@{#39727}
-
- 21 Sep, 2016 2 commits
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2338413003 Cr-Commit-Position: refs/heads/master@{#39608}
-
kozyatinskiy authored
BUG=chromium:635948 R=alph@chromium.org Review-Url: https://codereview.chromium.org/2359533002 Cr-Commit-Position: refs/heads/master@{#39572}
-
- 19 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2332243002 Cr-Commit-Position: refs/heads/master@{#39506}
-
- 06 Sep, 2016 1 commit
-
-
dgozman authored
- inspector becomes a dependency of v8_base; - generated public protocol files are placed to gen/v8/include/inspector/<Domain.h>; - added v8_enable_inspector_override to be used in embedders (gn only); - combined public headers into v8-inspector.h and v8-inspector-protocol.h. BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2292053003 Cr-Commit-Position: refs/heads/master@{#39226}
-
- 01 Sep, 2016 1 commit
-
-
dgozman authored
Attempt #2, formatted and disabled lint for src/inspector. BUG=chromium:635948 NOPRESUBMIT=true (for grammar check in license code) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39107}
-
- 31 Aug, 2016 2 commits
-
-
machenbach authored
Revert of [inspector] Initial import of v8_inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2292573002/ ) Reason for revert: Presubmit Original issue's description: > [inspector] Initial import of v8_inspector. > > BUG=chromium:635948 > NOPRESUBMIT=true (for code style) > > Committed: https://crrev.com/e29594ea3c5c41de0844e71f7a82c990a8da71ee > Cr-Commit-Position: refs/heads/master@{#39057} TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2300823002 Cr-Commit-Position: refs/heads/master@{#39058}
-
dgozman authored
BUG=chromium:635948 NOPRESUBMIT=true (for code style) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39057}
-