1. 13 Jun, 2018 1 commit
  2. 11 Jun, 2018 1 commit
  3. 24 May, 2018 1 commit
  4. 18 May, 2018 1 commit
  5. 16 May, 2018 1 commit
  6. 14 May, 2018 1 commit
    • Pierre Langlois's avatar
      [turbofan][wasm] Fix --trace-turbo with compiling a WASM function. · 7927d646
      Pierre Langlois authored
      The --trace-turbo flag would cause a crash when compiling a WASM_FUNCTION. It
      was caused by assuming the OptimizedCompilationInfo had a SharedFunctionInfo
      attached if the code isn't a stub and wasm functions are not considered as such.
      
      In order to test this, we've added a new flag to specify were to dump JSON
      files: --trace-turbo-path. This is used to make sure we do not leave lots of
      files behind in the top-level directory. It should be useful as standalone
      feature too.
      
      
      Change-Id: Ia9442638d28100bea45a8683fb233803cc5393f2
      Reviewed-on: https://chromium-review.googlesource.com/1030555
      Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
      Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53153}
      7927d646
  7. 30 Apr, 2018 1 commit
  8. 28 Apr, 2018 1 commit
  9. 14 Apr, 2018 1 commit
    • Jakob Kummerow's avatar
      [ubsan] Change Address typedef to uintptr_t · 2459046c
      Jakob Kummerow authored
      The "Address" type is V8's general-purpose type for manipulating memory
      addresses. Per the C++ spec, pointer arithmetic and pointer comparisons
      are undefined behavior except within the same array; since we generally
      don't operate within a C++ array, our general-purpose type shouldn't be
      a pointer type.
      
      Bug: v8:3770
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Ib96016c24a0f18bcdba916dabd83e3f24a1b5779
      Reviewed-on: https://chromium-review.googlesource.com/988657
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52601}
      2459046c
  10. 04 Apr, 2018 1 commit
  11. 29 Sep, 2017 1 commit
  12. 25 Sep, 2017 1 commit
  13. 13 Sep, 2017 1 commit
  14. 07 Sep, 2017 1 commit
  15. 05 Sep, 2017 1 commit
  16. 30 Aug, 2017 1 commit
  17. 29 Aug, 2017 1 commit
  18. 03 Aug, 2017 2 commits
  19. 31 Jul, 2017 1 commit
    • Leszek Swirski's avatar
      [sfi] Remove opt_count · e47d1757
      Leszek Swirski authored
      Remove opt_count from SFI, which only had two real uses:
      
        1. Detecting OSR in tests -- replaced with a stack walk in
           %GetOptimizationStatus
        2. Naming optimization log files -- replaced with the
           optimization id
      
      This allows us to remove a field from the SFI, moving the
      bailout reason into the counters field.
      
      As a drive-by, add optimization marker information (e.g.
      marked for optimization) to the optimization status.
      
      Change-Id: Id77deb5dd5439dfba058a7e1e1748de26b717d0d
      Reviewed-on: https://chromium-review.googlesource.com/592028Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47009}
      e47d1757
  20. 23 Feb, 2017 1 commit
  21. 20 Jan, 2017 1 commit
  22. 19 Dec, 2016 1 commit
  23. 16 Dec, 2016 1 commit
    • vegorov's avatar
      Move TraceInlinedFunction from Hydrogen graph builder to internal::CodeGenerator. · 686d8c86
      vegorov authored
      This allows to share source dumping infrastructure between CS and TF and opens a possibility for external tools like IRHydra to perform deoptimization to source mapping for TF generated code based on --trace-deopt --print-opt-code --code-comments output.
      
      This CL also restores an old TraceInlinedFunction behavior which was lost during source positions refactoring - originally TraceInlinedFunction dumped source code only once per-SFI to avoid large traces whenever some helper function is inlined multiple times.
      
      This CL also adds --print-opt-source flag that would in the future replace obsolete --hydrogen-track-positions.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2575703003
      Cr-Commit-Position: refs/heads/master@{#41758}
      686d8c86
  24. 14 Nov, 2016 1 commit
    • tebbi's avatar
      This CL enables precise source positions for all V8 compilers. It merges... · c3a6ca68
      tebbi authored
      This CL enables precise source positions for all V8 compilers. It merges compiler::SourcePosition and internal::SourcePosition to a single class used throughout the codebase. The new internal::SourcePosition instances store an id identifying an inlined function in addition to a script offset.
      SourcePosition::InliningId() refers to a the new table DeoptimizationInputData::InliningPositions(), which provides the following data for every inlining id:
       - The inlined SharedFunctionInfo as an offset into DeoptimizationInfo::LiteralArray
       - The SourcePosition of the inlining. Recursively, this yields the full inlining stack.
      Before the Code object is created, the same information can be found in CompilationInfo::inlined_functions().
      
      If SourcePosition::InliningId() is SourcePosition::kNotInlined, it refers to the outer (non-inlined) function.
      So every SourcePosition has full information about its inlining stack, as long as the corresponding Code object is known. The internal represenation of a source position is a positive 64bit integer.
      
      All compilers create now appropriate source positions for inlined functions. In the case of Turbofan, this required using AstGraphBuilderWithPositions for inlined functions too. So this class is now moved to a header file.
      
      At the moment, the additional information in source positions is only used in --trace-deopt and --code-comments. The profiler needs to be updated, at the moment it gets the correct script offsets from the deopt info, but the wrong script id from the reconstructed deopt stack, which can lead to wrong outputs. This should be resolved by making the profiler use the new inlining information for deopts.
      
      I activated the inlined deoptimization tests in test-cpu-profiler.cc for Turbofan, changing them to a case where the deopt stack and the inlining position agree. It is currently still broken for other cases.
      
      The following additional changes were necessary:
       - The source position table (internal::SourcePositionTableBuilder etc.) supports now 64bit source positions. Encoding source positions in a single 64bit int together with the difference encoding in the source position table results in very little overhead for the inlining id, since only 12% of the source positions in Octane have a changed inlining id.
       - The class HPositionInfo was effectively dead code and is now removed.
       - SourcePosition has new printing and information facilities, including computing a full inlining stack.
       - I had to rename compiler/source-position.{h,cc} to compiler/compiler-source-position-table.{h,cc} to avoid clashes with the new src/source-position.cc file.
       - I wrote the new wrapper PodArray for ByteArray. It is a template working with any POD-type. This is used in DeoptimizationInputData::InliningPositions().
       - I removed HInlinedFunctionInfo and HGraph::inlined_function_infos, because they were only used for the now obsolete Crankshaft inlining ids.
       - Crankshaft managed a list of inlined functions in Lithium: LChunk::inlined_functions. This is an analog structure to CompilationInfo::inlined_functions. So I removed LChunk::inlined_functions and made Crankshaft use CompilationInfo::inlined_functions instead, because this was necessary to register the offsets into the literal array in a uniform way. This is a safe change because LChunk::inlined_functions has no other uses and the functions in CompilationInfo::inlined_functions have a strictly longer lifespan, being created earlier (in Hydrogen already).
      
      BUG=v8:5432
      
      Review-Url: https://codereview.chromium.org/2451853002
      Cr-Commit-Position: refs/heads/master@{#40975}
      c3a6ca68
  25. 17 Oct, 2016 2 commits
  26. 20 Sep, 2016 1 commit
  27. 31 Aug, 2016 1 commit
  28. 23 Aug, 2016 1 commit
  29. 19 Aug, 2016 1 commit
  30. 09 Aug, 2016 2 commits
  31. 25 Jul, 2016 1 commit
  32. 15 Jul, 2016 1 commit
    • bgeron's avatar
      [turbolizer] Show a label with a shorter parameter for some opcodes. · feb93dd6
      bgeron authored
      With this patch, every node in turbo-*.json has an opcode, a title, and
      a label. The label field is new; the opcode and title were already
      there. The title is for the mouseover text. The label is what will be
      displayed in the graph view, unless it's too long, in which case only
      the opcode will be displayed. (This is similar to the preexisting
      behaviour of putting titles in labels, except that the titles were
      rarely short enough to fit in a label.)
      
      With this patch, the labels generated are in practice the same as the
      titles we had before, except for LoadField and StoreField, which will be
      rendered as LoadField[[+432]] and StoreField[[+432]] (if 432 was the
      offset).
      
      This diff adds an overloadable method
      
          virtual void Operator1<T>::PrintParameter(ostream&, PrintVerbosity)
      
      for each type T to Operator1. Its default implementation just uses
      operator<<(ostream&, T const&) and adds square brackets around it, but
      it is overridden for FieldAccess to print "[+432]" in the example case.
      
      BUG=
      R=jarin,danno
      
      Review-Url: https://codereview.chromium.org/2093013002
      Cr-Commit-Position: refs/heads/master@{#37795}
      feb93dd6
  33. 01 Jul, 2016 1 commit
  34. 28 Jun, 2016 1 commit
    • mattloring's avatar
      Reland of Include file names in trace_turbo output (patchset #1 id:1 of... · 9480ea44
      mattloring authored
      Reland of Include file names in trace_turbo output (patchset #1 id:1 of https://codereview.chromium.org/2083153004/ )
      
      Reason for revert:
      Ready to test fix and reland.
      
      Original issue's description:
      > Revert of Include file names in trace_turbo output (patchset #3 id:40001 of https://codereview.chromium.org/2083863004/ )
      >
      > Reason for revert:
      > Many build bots are failing with a message of the form:
      >
      > Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json
      >
      > Can be relanded once we understand why these failures are occuring.
      >
      > Original issue's description:
      > > Include file names in trace_turbo output
      > >
      > > The trace turbo output will overwrite itself when functions in different
      > > files share the same name. Output files now have the form
      > > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.
      > >
      > > R=ofrobots@google.com
      > > BUG=
      > >
      > > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
      > > Cr-Commit-Position: refs/heads/master@{#37199}
      >
      > TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org
      > # Skipping CQ checks because original CL landed less than 1 days ago.
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=
      >
      > Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a
      > Cr-Commit-Position: refs/heads/master@{#37204}
      
      TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org,machenbach@google.com
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=
      
      Review-Url: https://codereview.chromium.org/2081323007
      Cr-Commit-Position: refs/heads/master@{#37303}
      9480ea44
  35. 27 Jun, 2016 1 commit
  36. 22 Jun, 2016 2 commits