- 02 Dec, 2017 1 commit
-
-
Mathias Bynens authored
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
-
- 25 Jul, 2017 1 commit
-
-
Clemens Hammacher authored
Add a third parameter to {AsHex} which specifies whether the prefix "0x" should be printed. Also, add the {AsHexBytes} helper which outputs the hex number as individual bytes separated by a whitespace. Also add unit tests for both helpers. Both helper will be used in an upcoming refactoring of wasm error messages: https://chromium-review.googlesource.com/c/565282 R=titzer@chromium.org Change-Id: I42d5ace9841ffb918cb4d6803b6347229e446097 Reviewed-on: https://chromium-review.googlesource.com/583448 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#46859}
-
- 12 Jun, 2017 1 commit
-
-
Marja Hölttä authored
BUG=v8:5402,v8:6474 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Id38249fe9dc88001218aa1faa1b31c9d2f9703d1 Reviewed-on: https://chromium-review.googlesource.com/528102 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45853}
-
- 09 Aug, 2016 1 commit
-
-
bgeron authored
Previously, we would output \x5c to escape a backslash, but this is invalid JSON and it would crash Turbolizer. Use \u005c instead. BUG= Review-Url: https://codereview.chromium.org/2224913002 Cr-Commit-Position: refs/heads/master@{#38479}
-
- 16 Jun, 2016 1 commit
-
-
clemensh authored
This will be used for disassembling individual wasm function for showing them in devtools. The PrintAst function now also optionally provides an offset table mapping from byte offset to line and column in the generated text. R=titzer@chromium.org, ahaas@chromium.org BUG=chromium:613110 Review-Url: https://codereview.chromium.org/2050213002 Cr-Commit-Position: refs/heads/master@{#37026}
-
- 21 Jan, 2016 3 commits
-
-
yangguo authored
We divide character ranges into - BMP, matched normally. - non-BMP, matched as alternatives of surrogate pair ranges. - lone surrogates, matched with lookaround assertion that its indeed lone. R=erik.corry@gmail.com BUG=v8:2952 LOG=N Committed: https://crrev.com/ea820ad5fa282a323a86fe20e64f83ee67ba5f04 Cr-Commit-Position: refs/heads/master@{#33432} Review URL: https://codereview.chromium.org/1578253005 Cr-Commit-Position: refs/heads/master@{#33437}
-
yangguo authored
Revert of [regexp] implement character classes for unicode regexps. (patchset #11 id:220001 of https://codereview.chromium.org/1578253005/ ) Reason for revert: Compile failure on arm. https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7341/steps/compile/logs/stdio Original issue's description: > [regexp] implement character classes for unicode regexps. > > We divide character ranges into > - BMP, matched normally. > - non-BMP, matched as alternatives of surrogate pair ranges. > - lone surrogates, matched with lookaround assertion that its indeed lone. > > R=erik.corry@gmail.com > BUG=v8:2952 > LOG=N > > Committed: https://crrev.com/ea820ad5fa282a323a86fe20e64f83ee67ba5f04 > Cr-Commit-Position: refs/heads/master@{#33432} TBR=littledan@chromium.org,erik.corry@gmail.com,erikcorry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2952 Review URL: https://codereview.chromium.org/1618753002 Cr-Commit-Position: refs/heads/master@{#33434}
-
yangguo authored
We divide character ranges into - BMP, matched normally. - non-BMP, matched as alternatives of surrogate pair ranges. - lone surrogates, matched with lookaround assertion that its indeed lone. R=erik.corry@gmail.com BUG=v8:2952 LOG=N Review URL: https://codereview.chromium.org/1578253005 Cr-Commit-Position: refs/heads/master@{#33432}
-
- 30 Nov, 2015 1 commit
-
-
oth authored
BUG= LOG=N Review URL: https://codereview.chromium.org/1486613002 Cr-Commit-Position: refs/heads/master@{#32411}
-
- 09 Apr, 2015 1 commit
-
-
brucedawson authored
VS 2015 supplies a conforming snprintf implementation, so #define snprintf is no longer needed. Also, VS 2015 checks for #define of snprintf and treats it as a fatal error. LOG=Y R=jarin@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1078453002 Cr-Commit-Position: refs/heads/master@{#27690}
-
- 03 Feb, 2015 1 commit
-
-
danno authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/886313006 Cr-Commit-Position: refs/heads/master@{#26399}
-
- 29 Jan, 2015 1 commit
-
-
danno authored
Review URL: https://codereview.chromium.org/882973002 Cr-Commit-Position: refs/heads/master@{#26323}
-
- 19 Jan, 2015 1 commit
-
-
svenpanne authored
Use simple HAS-A relationship instead of obscure multiple inheritance. In theory, UBSan should be totally happy with this, but it still isn't. This seems to be a bug in UBSan, see e.g. http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-December/040225.html BUG=chromium:448102 LOG=y Review URL: https://codereview.chromium.org/859773002 Cr-Commit-Position: refs/heads/master@{#26139}
-
- 08 Dec, 2014 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/786763002 Cr-Commit-Position: refs/heads/master@{#25709}
-
- 01 Oct, 2014 1 commit
-
-
yangguo@chromium.org authored
TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/616293002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24349 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
Review URL: https://codereview.chromium.org/618643002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24319 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2014 2 commits
-
-
svenpanne@chromium.org authored
TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/559523002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
This is a fix/improvement for r23478 ("Fix disassembly redirection from stdout into a file."). R=yangguo@chromium.org Review URL: https://codereview.chromium.org/554223002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23792 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Aug, 2014 1 commit
-
-
svenpanne@chromium.org authored
Pass \n, \r and \t through OStream without escaping. BUG= R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/458533002 Patch from Vyacheslav Egorov <vegorov@google.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Jul, 2014 2 commits
-
-
svenpanne@chromium.org authored
TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/386023002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22355 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/386973003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22354 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Jul, 2014 2 commits
-
-
svenpanne@chromium.org authored
This is a mostly mechanical CL (more than 90% Emacs macros and query-replace-regexp) moving FILE*/StringStream*-based APIs to OStream-based APIs. There are a few places where this had to stop, otherwise the CL would be even bigger, but this can easily and incrementally cleaned up later. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/363323003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Our clang/win build currently uses MSVS's C library, so it doesn't have snprintf but it does have sprintf_s. BUG=chromium:82385 LOG=n R=jochen@chromium.org Review URL: https://codereview.chromium.org/370823002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22224 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Jun, 2014 1 commit
-
-
svenpanne@chromium.org authored
R=bmeurer@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/352823003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22049 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-