- 25 Aug, 2016 1 commit
-
-
verwaest authored
BUG=v8:5209 Review-Url: https://codereview.chromium.org/2272083003 Cr-Commit-Position: refs/heads/master@{#38920}
-
- 24 Aug, 2016 1 commit
-
-
littledan authored
To make async/await catch prediction work well, this patch regularizes the exception events sent to DevTools from various places in the Promise lifecycle. The core is that there should be an exception event when the rejection first starts, rather than when it is propagated. - Several cases within Promise code which propagate errors are modified to not trigger a new ExceptionEvent in that case, such as .then on a rejected Promise and returning a rejected Promise from .then, as well as Promise.race and Promise.all. - Make Promise.reject() create an ExceptionEvent, subject to catch prediction based on the Promise stack. This is important so that, e.g., if "await Promise.reject()" will trigger a new throw (rather than a silent rethrow of something that never triggered an event in the first place). BUG=v8:5167 Review-Url: https://codereview.chromium.org/2244003003 Cr-Commit-Position: refs/heads/master@{#38847}
-
- 18 Aug, 2016 1 commit
-
-
neis authored
TBR=littledan@chromium.org NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2259793002 Cr-Commit-Position: refs/heads/master@{#38701}
-
- 17 Aug, 2016 2 commits
-
-
bakkot authored
Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #2 id:170001 of https://codereview.chromium.org/2113593002/ ) Reason for revert: WebGL tests have been updated and rolled (at https://codereview.chromium.org/2227023002), so this should no longer fail outdated tests. Original issue's description: > Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ ) > > Reason for revert: > Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/ > > Original issue's description: > > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. > > > > The spec was modified to relax some requirements which implementors had not been > > enforcing. Part of this process involved introducing a new abstract operation > > ToIndex, which had partial overlap with our existing semantics as well as some > > differences (most notably treating undefined as 0). Test262 tests were introduced to > > check for the new semantics, some of which we were failing. This patch amends the > > parts of our implementation corresponding to specification algorithms which use > > ToIndex to follow its semantics precisely. > > > > BUG=v8:4784,v8:5120 > > > > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132 > > Cr-Commit-Position: refs/heads/master@{#37406} > > TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4784,v8:5120 > > Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f > Cr-Commit-Position: refs/heads/master@{#37417} TBR=littledan@chromium.org,adamk@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4784,v8:5120 Review-Url: https://codereview.chromium.org/2247073004 Cr-Commit-Position: refs/heads/master@{#38689}
-
neis authored
Async functions are implemented via special generator functions; special in the sense that they generally do not immediately yield. However, our generators implementation still assumed that every generator function initially yields (concretely: before doing the state dispatch in a loop header). This CL fixes that. R=littledan@chromium.org, rmcilroy@chromium.org BUG=chromium:638019 Review-Url: https://codereview.chromium.org/2253033002 Cr-Commit-Position: refs/heads/master@{#38684}
-
- 12 Aug, 2016 1 commit
-
-
caitp authored
No longer include the "async" keyword, or an async arrow function's single identifier parameter as part of its inferred name. BUG=v8:5281, v8:4483 R=adamk@chromium.org, littledan@chromium.org, marja@chromium.org Review-Url: https://codereview.chromium.org/2235423003 Cr-Commit-Position: refs/heads/master@{#38627}
-
- 10 Aug, 2016 1 commit
-
-
littledan authored
This patch adds additional tests for async functions and generators, in how they interact with destructuring, default arguments and shadow parameter copying. BUG=v8:5167 Review-Url: https://codereview.chromium.org/2229243002 Cr-Commit-Position: refs/heads/master@{#38560}
-
- 08 Aug, 2016 1 commit
-
-
neis authored
Introduces a new VariableLocation MODULE for variables that live in a module's export table. Scope analysis sets this for the approriate variables. Not yet supported by any backend. Also, treats all imports as CONST bindings (including namespace imports), rather than having new special variable modes. BUG= Review-Url: https://codereview.chromium.org/2199283002 Cr-Commit-Position: refs/heads/master@{#38426}
-
- 06 Aug, 2016 1 commit
-
-
littledan authored
- Don't read .constructor when returning a Promise from an async function. Instead, call out to the internals of Promise.resolve directly. This is done by adding back in an "optimization" from an earlier form of the async/await code written by Caitlin Potter. - Async functions always return a new Promise with a distinct identity, even if they simply return another Promise. R=caitp@igalia.com BUG=v8:4483 Review-Url: https://codereview.chromium.org/2219623002 Cr-Commit-Position: refs/heads/master@{#38404}
-
- 04 Aug, 2016 1 commit
-
-
caitp authored
The `PerformPromiseThen` spec-internal operation is used by the async functions proposal, in order to ensure that AwaitExpressions are not observable via usual mechanisms/hooks, such as Symbol.species. BUG=v8:5253 R=littledan@chromium.org, adamk@chromium.org, gsathya@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2209433003 Cr-Commit-Position: refs/heads/master@{#38353}
-
- 02 Aug, 2016 1 commit
-
-
adamk authored
It's shipped in M52. R=caitp@igalia.com, littledan@chromium.org Review-Url: https://codereview.chromium.org/2203843002 Cr-Commit-Position: refs/heads/master@{#38256}
-
- 25 Jul, 2016 1 commit
-
-
neis authored
This flag has been enabled by default for over a month now. R=mstarzinger@chromium.org, rmcilroy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2176143002 Cr-Commit-Position: refs/heads/master@{#38020}
-
- 22 Jul, 2016 1 commit
-
-
jwolfe authored
See discussion in https://codereview.chromium.org/2156303002/#msg8 With the new --harmony-function-tostring behavior, these tests would fail without this change. This change makes the tests pass regardless of whether or not --harmony-function-tostring is used. All of these changes are simply inserting a space after the "function" keyword to match the current function toString behavior. When --harmony-function-tostring is enabled, the toString behavior matches the spacing used in the function declaration. With the declaration matching the current formatting, the toString behavior becomes unaffected by --harmony-function-tostring. BUG=v8:4958 LOG=n Review-Url: https://codereview.chromium.org/2161413002 Cr-Commit-Position: refs/heads/master@{#37959}
-
- 14 Jul, 2016 1 commit
-
-
adamk authored
Instead of unconditionally parsing the catch parameter as an expression and then recovering if it turns out to be a simple variable proxy (the overwhelmingly common case), this patch peeks one token ahead before attempting to parse. This avoids doing the usual RemoveUnresolved gymnastics in ParseTryStatement, and as a side-effect slightly improves function name inference for an async arrow function test case. Review-Url: https://codereview.chromium.org/2151433005 Cr-Commit-Position: refs/heads/master@{#37780}
-
- 13 Jul, 2016 1 commit
-
-
binji authored
* Rename Atomics.futexWait -> Atomics.wait * Rename Atomics.futexWake -> Atomics.wake * Remove Atomics.futexWakeOrRequeue * Return value of Atomics.wait is now a string: "ok", "not-equal" or "timed-out" * Update comments that reference URL for ecmascript_sharedmem to https://github.com/tc39/ecmascript_sharedmem Review-Url: https://codereview.chromium.org/2143443002 Cr-Commit-Position: refs/heads/master@{#37727}
-
- 12 Jul, 2016 1 commit
-
-
bmeurer authored
Remove obsolete definitions from macros.py, and drop the now obsolete %_ToPrimitive, %_ToPrimitive_Number, %_ToPrimitive_String, %_ToName and the %ToPrimitive_String intrinsics/runtime entries. R=yangguo@chromium.org BUG=v8:5049 Review-Url: https://codereview.chromium.org/2137203002 Cr-Commit-Position: refs/heads/master@{#37665}
-
- 11 Jul, 2016 2 commits
-
-
littledan authored
This patch just checks for a stack overflow and returns failure from the cases which Clusterfuzz found. However, there may be more locations in the parser which need similar treatment. R=caitpotter88@gmail.com,neis BUG=v8:4483,chromium:624300 Review-Url: https://codereview.chromium.org/2135503002 Cr-Commit-Position: refs/heads/master@{#37655}
-
yangguo authored
R=bmeurer@chromium.org, littledan@chromium.org BUG=v8:5167 Review-Url: https://codereview.chromium.org/2124813002 Cr-Commit-Position: refs/heads/master@{#37623}
-
- 07 Jul, 2016 1 commit
-
-
franzih authored
Drive-by-fix: hydrogen code does not blindly return the byteLength offset, instead it executes what is defined in the byteLength getter. BUG= Review-Url: https://codereview.chromium.org/2123263002 Cr-Commit-Position: refs/heads/master@{#37595}
-
- 04 Jul, 2016 1 commit
-
-
caitpotter88 authored
Implements the change proposed at https://github.com/tc39/ecma262/pull/593. In summary, Object.getOwnPropertyDescriptors can produce results which cause Object.defineProperties() to throw, by inserting a property with an undefined descriptor into the result object. This change to the algorithm requires that the descriptor only be added to the result object if it is not undefined. BUG=v8:4725 R=littledan@chromium.org, adamk@chromium.org, jwolfe@igalia.com Review-Url: https://codereview.chromium.org/2118613003 Cr-Commit-Position: refs/heads/master@{#37504}
-
- 01 Jul, 2016 1 commit
-
-
caitpotter88 authored
Corrects a small problem with the current implementation of the AsyncFunction constructor. See https://tc39.github.io/ecmascript-asyncawait/#async-function-constructor for details. BUG=v8:4483 R=littledan@chromium.org, adamk@chromium.org, jwolfe@igalia.com Review-Url: https://codereview.chromium.org/2118653004 Cr-Commit-Position: refs/heads/master@{#37484}
-
- 30 Jun, 2016 1 commit
-
-
hablich authored
Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ ) Reason for revert: Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/ Original issue's description: > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. > > The spec was modified to relax some requirements which implementors had not been > enforcing. Part of this process involved introducing a new abstract operation > ToIndex, which had partial overlap with our existing semantics as well as some > differences (most notably treating undefined as 0). Test262 tests were introduced to > check for the new semantics, some of which we were failing. This patch amends the > parts of our implementation corresponding to specification algorithms which use > ToIndex to follow its semantics precisely. > > BUG=v8:4784,v8:5120 > > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132 > Cr-Commit-Position: refs/heads/master@{#37406} TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4784,v8:5120 Review-Url: https://codereview.chromium.org/2113593002 Cr-Commit-Position: refs/heads/master@{#37417}
-
- 29 Jun, 2016 2 commits
-
-
bakkot authored
The spec was modified to relax some requirements which implementors had not been enforcing. Part of this process involved introducing a new abstract operation ToIndex, which had partial overlap with our existing semantics as well as some differences (most notably treating undefined as 0). Test262 tests were introduced to check for the new semantics, some of which we were failing. This patch amends the parts of our implementation corresponding to specification algorithms which use ToIndex to follow its semantics precisely. BUG=v8:4784,v8:5120 Review-Url: https://codereview.chromium.org/2090353003 Cr-Commit-Position: refs/heads/master@{#37406}
-
jwolfe authored
Add a flag harmony_trailing_commas_in_parameters that allows trailing commas in function parameter declaration lists and function call parameter lists. Trailing commas are allowed in parenthetical lists like `(a, b, c,)` only if the next token is `=>`, thereby making it an arrow function declaration. Only 1 trailing comma is allowed, not `(a,,)`. A trailing comma must follow a non-rest parameter, so `(,)` and `(...a,)` are still SyntaxErrors. However, a trailing comma is allowed after a spread parameter, e.g. `a(...b,);`. Add parser tests for all of the above. BUG=v8:5051 LOG=y Review-Url: https://codereview.chromium.org/2094463002 Cr-Commit-Position: refs/heads/master@{#37355}
-
- 28 Jun, 2016 2 commits
-
-
neis authored
When calling the throw method on a generator suspended inside a yield*, yield* in turn tries to call throw on its iterable. If the iterable does not provide a throw method, yield* must try to call the return method instead and then throw a TypeError. Due to a bug in our desugaring, we never threw the TypeError. R=adamk@chromium.org BUG=v8:5132 Review-Url: https://codereview.chromium.org/2094253002 Cr-Commit-Position: refs/heads/master@{#37314}
-
neis authored
When calling the return method on a generator suspended inside a yield*, yield* in turn calls return on its iterable. If this results in a "done" iterator, yield* must return immediately, thus terminating the generator. For some reason, we didn't terminate the generator but continued right after the yield*. R=adamk@chromium.org BUG=v8:5131 Review-Url: https://codereview.chromium.org/2100093002 Cr-Commit-Position: refs/heads/master@{#37310}
-
- 25 Jun, 2016 1 commit
-
-
caitpotter88 authored
BUG=v8:4483, v8:5148 R=littledan@chromium.org, adamk@chromium.org, jwolfe@igalia.com, nikolaos@chromium.org Review-Url: https://codereview.chromium.org/2091313002 Cr-Commit-Position: refs/heads/master@{#37260}
-
- 24 Jun, 2016 1 commit
-
-
adamk authored
Flags removed (all begin with "harmony-"): function-name instanceof iterator-close unicode-regexps regexp-exec regexp-subclass species BUG=v8:3566, v8:3648, v8:3699, v8:4093, v8:4447, v8:4602 Review-Url: https://codereview.chromium.org/2096933002 Cr-Commit-Position: refs/heads/master@{#37235}
-
- 22 Jun, 2016 1 commit
-
-
nikolaos authored
R=adamk@chromium.org BUG=chromium:621496 LOG=N Review-Url: https://codereview.chromium.org/2084703005 Cr-Commit-Position: refs/heads/master@{#37196}
-
- 21 Jun, 2016 2 commits
-
-
nikolaos authored
R=adamk@chromium.org BUG=chromium:621111 LOG=N Review-Url: https://codereview.chromium.org/2086513002 Cr-Commit-Position: refs/heads/master@{#37150}
-
caitpotter88 authored
BUG=v8:4483 R=yangguo@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2082023002 Cr-Commit-Position: refs/heads/master@{#37149}
-
- 15 Jun, 2016 2 commits
-
-
caitpotter88 authored
If an active generator is found on the stack (FUNCTION_BLOCKED_UNDER_GENERATOR), and the target function is not found on top of that generator, add the error. Based on test by wingo@igalia.com and littledan@chromium.org (https://codereview.chromium.org/2035643003/) LOG=N BUG=v8:4483 R=yangguo@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2058733002 Cr-Commit-Position: refs/heads/master@{#37000}
-
jgruber authored
Named capture groups may be specified using the /(?<name>pattern)/u syntax, with named backreferences specified as /\k<name>/u. They're hidden behind the --harmony-regexp-named-captures flag, and are only enabled for unicode regexps. R=yangguo@chromium.org BUG= Review-Url: https://codereview.chromium.org/2050343002 Cr-Commit-Position: refs/heads/master@{#36986}
-
- 14 Jun, 2016 3 commits
-
-
yangguo authored
R=littledan@chromium.org, mathias@qiwi.be BUG=v8:4743 Committed: https://crrev.com/92bfd13457c80f02be01551f4ea9a5badfe0e4c4 Review-Url: https://codereview.chromium.org/2059113002 Cr-Original-Commit-Position: refs/heads/master@{#36969} Cr-Commit-Position: refs/heads/master@{#36974}
-
yangguo authored
Revert of [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}. (patchset #3 id:40001 of https://codereview.chromium.org/2059113002/ ) Reason for revert: compile failure Original issue's description: > [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}. > > R=littledan@chromium.org, mathias@qiwi.be > BUG=v8:4743 > > Committed: https://crrev.com/92bfd13457c80f02be01551f4ea9a5badfe0e4c4 > Cr-Commit-Position: refs/heads/master@{#36969} TBR=littledan@chromium.org,mathias@qiwi.be # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4743 Review-Url: https://codereview.chromium.org/2065083002 Cr-Commit-Position: refs/heads/master@{#36970}
-
yangguo authored
R=littledan@chromium.org, mathias@qiwi.be BUG=v8:4743 Review-Url: https://codereview.chromium.org/2059113002 Cr-Commit-Position: refs/heads/master@{#36969}
-
- 13 Jun, 2016 1 commit
-
-
caitpotter88 authored
BUG=v8:4483, v8:4907, 618603 LOG=N R=neis@chromium.org, yangguo@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2051423003 Cr-Commit-Position: refs/heads/master@{#36938}
-
- 10 Jun, 2016 1 commit
-
-
littledan authored
This patch adds a test for async/await analogous to a previous Promise test. It also fixes a typo in promise.js and makes a previous Promise test more correct by ensuring that all assertions run before completion, fixing the test expectations for the real result (which seems correct). BUG=v8:4483 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2037653002 Cr-Commit-Position: refs/heads/master@{#36903}
-
- 07 Jun, 2016 1 commit
-
-
yangguo authored
R=littledan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2044803003 Cr-Commit-Position: refs/heads/master@{#36778}
-
- 03 Jun, 2016 1 commit
-
-
yangguo authored
R=*bmeurer@chromium.org, caitpotter88@gmail.com, *littledan@chromium.org, *ulan@chromium.org BUG=v8:4483 Review-Url: https://codereview.chromium.org/2033223003 Cr-Commit-Position: refs/heads/master@{#36718}
-