Skip to content

V
V8
Switch branch/tag
  1. 30 Nov, 2015 2 commits
  3. 27 Nov, 2015 7 commits
  5. 26 Nov, 2015 3 commits
  7. 25 Nov, 2015 8 commits
  9. 24 Nov, 2015 5 commits
  11. 23 Nov, 2015 4 commits
    • bmeurer's avatar
      [builtins] Sanitize the machinery around Construct calls. · 374b6ea2
      bmeurer authored 
      There's no point in collecting feedback for super constructor calls,
because in all (interesting) cases we can gather (better) feedback from
other sources (i.e. via inlining or via using a LOAD_IC to get to the
[[Prototype]] of the target).  So CallConstructStub is now only used
for new Foo(...args) sites where we want to collect feedback in the
baseline compiler.  The optimizing compilers, Reflect.construct and
super constructor calls use the Construct builtin directly, which allows
us to remove some weird code from the CallConstructStub (and opens the
possibility for more code sharing with the CallICStub, maybe even going
for a ConstructICStub).

Also remove the 100% redundant HCallNew instruction, which is just a
wrapper for the Construct builtin anyway (indirectly via the
CallConstructStub).

Drive-by-fix: Drop unused has_function_cache bit on Code objects.

R=mstarzinger@chromium.org, yangguo@chromium.org
BUG=v8:4413, v8:4430
LOG=n

Review URL: https://codereview.chromium.org/1469793002

Cr-Commit-Position: refs/heads/master@{#32172}
      374b6ea2
    • mstarzinger's avatar
      Make arguments adaptor not clobber new.target. · c1e7c8d9
      mstarzinger authored 
      This ensures that the ArgumentsAdaptorTrampoline does not clobber the
new.target value, but rather passes it through to the callee unaltered.
Note that callees do not yet use the new.target value so far.

This is a preparatory CL to allows us passing new.target in a register
instead of via a side-channel through the construct stub frame.

R=mvstanton@chromium.org
BUG=v8:4544
LOG=n

Review URL: https://codereview.chromium.org/1458103003

Cr-Commit-Position: refs/heads/master@{#32171}
      c1e7c8d9
    • jochen's avatar
      Remove a bunch of Isolate::Current() callsites from simulators · c7aace4d
      jochen authored 
      BUG=2487
R=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1457223005

Cr-Commit-Position: refs/heads/master@{#32164}
      c7aace4d
    • bmeurer's avatar
      [stubs] Change CallICStub to utilize the ConvertReceiverMode. · d80fd48e
      bmeurer authored 
      The CallICStub has call-site specific knowledge about the receiver,
which we did not utilize; plus the CallICStub does in some case know
whether it is about to [[Call]] a function or potentially some other
callable. In the common case we actually know that the target is a
function and so we can use the CallFunction builtin directly instead
of redispatching in the Call builtin.

BUG=chromium:555127, v8:4413
LOG=n

Review URL: https://codereview.chromium.org/1470803002

Cr-Commit-Position: refs/heads/master@{#32163}
      d80fd48e
  13. 20 Nov, 2015 2 commits
  15. 19 Nov, 2015 4 commits
  17. 18 Nov, 2015 1 commit
  19. 17 Nov, 2015 4 commits