- 31 Jan, 2018 4 commits
-
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f8323d8..2e93695 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/69f2184..7c98d04 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a312f49..3d55f9c This also ports: https://chromium-review.googlesource.com/c/chromium/src/+/894042 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5fadb9e798bc07a28e784447c3455953c7bee5a3 Reviewed-on: https://chromium-review.googlesource.com/894584 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#50976}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Change-Id: I49317fed6c91064109d3adff06b0bba474e11f1d Reviewed-on: https://chromium-review.googlesource.com/892865 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50975}
-
Georg Neis authored
Async generators didn't correctly handle the situation where one calls .return on a suspended-at-start async generator and passes a promise-like object whose awaiting causes a new request to the generator. Bug: chromium:805729 Change-Id: I4da13ab5bd97f8c2a2c5373242a2d5e2ab0f7f10 Reviewed-on: https://chromium-review.googlesource.com/891231Reviewed-by: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#50974}
-
Yang Guo authored
R=adamk@chromium.org Bug: v8:7275 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iada634ab275a1a348d14400b3138ac9e5cc08de7 Reviewed-on: https://chromium-review.googlesource.com/892441Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50973}
-
- 30 Jan, 2018 33 commits
-
-
Malcolm White authored
Bug=chromium:806582 Change-Id: I0d541903dfd1622ae6d4a2628c41dc28704680e6 Reviewed-on: https://chromium-review.googlesource.com/891626Reviewed-by: Ben Smith <binji@chromium.org> Commit-Queue: Malcolm White <malcolmwhite@google.com> Cr-Commit-Position: refs/heads/master@{#50972}
-
Junliang Yan authored
Port 830e39ab Original Commit Message: Wide suspends have a "wide" (or "extra-wide") bytecode at their offset, rather than the suspend itself, so they were failing the return check. R=leszeks@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I0c95b9fd34df7232ae07fd1e508f40cd139e9734 Reviewed-on: https://chromium-review.googlesource.com/894303Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#50971}
-
Michael Achenbach authored
This reverts commit 0db74d49. Reason for revert: https://chromium-swarm.appspot.com/task?id=3b609f9976bac610&refresh=10&show_raw=1 Original change's description: > [test] Random seed processor > > 1. --total-timeout-sec now available for ./run-tests.py. It can be > useful with infinite seed stressing > 2. random seed dropped from the context. Now JSON progress indicator > gets it from the list of command args. > > Bug: v8:6917 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I73e535bc8face9b913c696b8d5e3a246fa231004 > Reviewed-on: https://chromium-review.googlesource.com/888524 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50964} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: I2d96ea328cda2d09b01ff455e47c77d567fafe00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/894522Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50970}
-
Junliang Yan authored
Port 1abeb5a3 Original Commit Message: - Shift opcode numbers for asmjs-compat opcodes - Add --experimental-wasm-se flag to gate sign extension opccodes - Fix codegen for ia32 movsx instructions R=gdeepti@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3af97112b40d159f9ffc4f465768fc7832485f20 Reviewed-on: https://chromium-review.googlesource.com/893703Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#50969}
-
Camillo Bruni authored
- Match PropertyCallbackArguments methods Change-Id: I063a368b186bcca499c8a4a217114227516127e5 Reviewed-on: https://chromium-review.googlesource.com/836891Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50968}
-
Gabriel Charette authored
This is a reland of 76195d9e. It was reverted because the new parallel tasks (with higher number of workers) hang on client.v8.ports bots. Since each test task steals the worker thread it's assigned but only processes one item before waiting for completion by others: I think the problem is that there aren't enough workers in client.v8.ports' config. There aren't any try bots for this config... reduce the tests to use 4 tasks and hope for the best (i.e. a 4 core machine that uses "num cores")... Original change's description: > Smoother distribution of worker assignment in parallel task array. > > This is a merge of https://chromium-review.googlesource.com/c/v8/v8/+/888704 > and https://chromium-review.googlesource.com/c/v8/v8/+/887084 > > Which implements the fix in CL 887084 correctly in a world where > there can be more tasks_ than items_ (crbug.com/806237). > > Bug: chromium:805932 > Change-Id: I05401be4fdce442644a8973281a9d88bd959b271 > Reviewed-on: https://chromium-review.googlesource.com/892883 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50956} Reverted-on: https://chromium-review.googlesource.com/893462 Bug: chromium:805932 Change-Id: I4d0bda3b9f52e9160e613a8f34a95e48b814bb9e Reviewed-on: https://chromium-review.googlesource.com/893362Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#50967}
-
Pierre Langlois authored
The way the code generator's AssembleMove and AssembleSwap methods are written makes it easy to forget which sort of move is being implemented when looking at a sequence of instructions. This patch is an attempt to address this by rewriting those methods using switch/case instead of a string of if/else. To do this, introduce new utility functions to detect what type of move to perform given a pair of InstructionOperands. Bug: Change-Id: I32b146c86409e595b7b59a66bf43220899024fdd Reviewed-on: https://chromium-review.googlesource.com/749201 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#50966}
-
Gabriel Charette authored
This reverts commit 76195d9e. Reason for revert: New parallel tests timeout on the waterfall (I think because it's configured to use less worker threads and TaskProcessingOneItem is currently designed to steal a worker but only process one item...). Original change's description: > Smoother distribution of worker assignment in parallel task array. > > This is a merge of https://chromium-review.googlesource.com/c/v8/v8/+/888704 > and https://chromium-review.googlesource.com/c/v8/v8/+/887084 > > Which implements the fix in CL 887084 correctly in a world where > there can be more tasks_ than items_ (crbug.com/806237). > > Bug: chromium:805932 > Change-Id: I05401be4fdce442644a8973281a9d88bd959b271 > Reviewed-on: https://chromium-review.googlesource.com/892883 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50956} TBR=gab@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: Icf52eb3afeb9467557c1e0db6922d590466943f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:805932 Reviewed-on: https://chromium-review.googlesource.com/893462Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#50965}
-
Michal Majewski authored
1. --total-timeout-sec now available for ./run-tests.py. It can be useful with infinite seed stressing 2. random seed dropped from the context. Now JSON progress indicator gets it from the list of command args. Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I73e535bc8face9b913c696b8d5e3a246fa231004 Reviewed-on: https://chromium-review.googlesource.com/888524 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50964}
-
Clemens Hammacher authored
This adds support for set_global and get_global. R=ahaas@chromium.org Change-Id: I08bfa3c23080f473616970e9894cfb6e55a4f76d Reviewed-on: https://chromium-review.googlesource.com/890744 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50963}
-
Michael Starzinger authored
R=jarin@chromium.org BUG=v8:6408 Change-Id: I28ac6fa2d47ec14b06e6867b3c605c307549c474 Reviewed-on: https://chromium-review.googlesource.com/890266Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50962}
-
Clemens Hammacher authored
Turns out we never generated if blocks or if-else blocks so far. R=ahaas@chromium.org Change-Id: I942dbc614b5b489094f5b029a70c40b336d09fa4 Reviewed-on: https://chromium-review.googlesource.com/890451 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50961}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Change-Id: I4115012e152ff8f40e946d59378d388fc8939143 Reviewed-on: https://chromium-review.googlesource.com/893179Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50960}
-
jgruber authored
Some tests need to ensure all builtins are deserialized. This adds a helper to make that easier. Drive-by-refactoring: Centralize lazy-deserialization tracing. TBR=rmcilroy@chromium.org Bug: v8:6624 Change-Id: I1f7caa6c539b12aabcba5b7b28c50ad40355848b Reviewed-on: https://chromium-review.googlesource.com/891822 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50959}
-
Camillo Bruni authored
Convert certain DCHECKS into CHECKS for some Map setters. This should have minimal performance impact at the same time getting us better coverage out there in the wild. Change-Id: I9a12f43e1baca15d9bf8b1aed86bb6b0dc13921d Reviewed-on: https://chromium-review.googlesource.com/866931 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#50958}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ifcd5d58bd27754d5ba7d05b302dc6089af5e3a53 Reviewed-on: https://chromium-review.googlesource.com/892074Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50957}
-
Gabriel Charette authored
This is a merge of https://chromium-review.googlesource.com/c/v8/v8/+/888704 and https://chromium-review.googlesource.com/c/v8/v8/+/887084 Which implements the fix in CL 887084 correctly in a world where there can be more tasks_ than items_ (crbug.com/806237). Bug: chromium:805932 Change-Id: I05401be4fdce442644a8973281a9d88bd959b271 Reviewed-on: https://chromium-review.googlesource.com/892883 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50956}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: I4903ffc49b5ed475706c0dc604a92b90f6b5d2a0 Reviewed-on: https://chromium-review.googlesource.com/892866Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50955}
-
sreten.kovacevic authored
Use config with these options when target is MIPS Change-Id: Ia93504f90aa42daef37f1cf1025cef9e9a584034 Reviewed-on: https://chromium-review.googlesource.com/890741Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Miran Karić <miran.karic@mips.com> Cr-Commit-Position: refs/heads/master@{#50954}
-
Clemens Hammacher authored
The generated file only contained the last section of the module, since the decoder's range is reset in DecodeSection. This CL fixes this by remembering the original module bytes and dumping them instead. R=ahaas@chromium.org Change-Id: I5e0f97279886817d58caac6114994bb9c1a147fc Reviewed-on: https://chromium-review.googlesource.com/892980Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50953}
-
Choongwoo Han authored
- Port TypedArray.prototype.slice to CSA - Implement TypedArraySpeciesCreateByLength as a CSA - Fix spec bugs: Throw if a source typed array is neutered after creating a result typed array Bug: v8:5929 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia7ce2239d37db6db172c00aa120ef51c31a14bac Reviewed-on: https://chromium-review.googlesource.com/830991 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#50952}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I9f4fcddca2e478d5074d68870d0293aacdeb4aa1 Reviewed-on: https://chromium-review.googlesource.com/813920Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50951}
-
Clemens Hammacher authored
The wasm compile fuzzer generated {br} instructions, but no {br_if} so far. This CL adds that. R=ahaas@chromium.org Change-Id: Ib5e47a26d96e88498104e0d57b9a49b74b7356eb Reviewed-on: https://chromium-review.googlesource.com/890450Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50950}
-
jgruber authored
The test inspects each builtin's RelocInfo. It's isolate-independent, iff there are no entries for embedded objects, runtime calls, external references (which could point to addresses on the isolate), or code targets. Bug: v8:6666 Change-Id: Ie32353db445a9e81e1c9a0a8f1b5ffe1566a0404 Reviewed-on: https://chromium-review.googlesource.com/888639 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50949}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Change-Id: Ib80df7aa269a8e9de7ad739f29883f61f0f0882c Reviewed-on: https://chromium-review.googlesource.com/892978Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50948}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: I592f745385fe0aedf2d9fb6f88e51b85663c6865 Reviewed-on: https://chromium-review.googlesource.com/891821 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50947}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I70d639324f6de4dd11871f67953943e80c238a12 Reviewed-on: https://chromium-review.googlesource.com/890181 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50946}
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Change-Id: I8a97d67be6888014d015ec3f0ec486a3c3d9861a Reviewed-on: https://chromium-review.googlesource.com/889756Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50945}
-
Yang Guo authored
Bug: v8:7335 Change-Id: I6610bba00ff558de5826934c326fc2873c91a1a3 Reviewed-on: https://chromium-review.googlesource.com/890742Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50944}
-
Philip Jägenstedt authored
This only affects document.all, which is the only user of |ObjectTemplate::SetCallAsFunctionHandler|, and will mean that new document.all() will throw TypeError. There are tests for this: //src/third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html (cherry picked from commit 7233447e4ac4587c81e91077857f8a30c4a6d2df) Change-Id: Ibb39b3c61b688591c781158cf4abc0c2d74c908e Reviewed-on: https://chromium-review.googlesource.com/882642Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/890496 Cr-Commit-Position: refs/heads/master@{#50943}
-
Sigurd Schneider authored
Add inbounds benchmark for String.p.charCodeAt and add in and out of bounds benchmarks for String.p.codePointAt. Bug: v8:7092, v8:7326, chromium:806758 Change-Id: I48065627bd79d8fb24e55b2f6dce590e7adbbd6e Reviewed-on: https://chromium-review.googlesource.com/891858Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50942}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8bf670e..f8323d8 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/82f653f..69f2184 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1243a6d..a312f49 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic07d910e6fee31c8bff82b47662edd2bd0907a58 Reviewed-on: https://chromium-review.googlesource.com/892618 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#50941}
-
Kanghua Yu authored
I8x16Shl/I8x16ShrS/I8x16ShrU,I8x16Mul R=bbudge@chromium.org, bmeurer@chromium.org Bug: Change-Id: I97d7f077c26fe6f8be6464582f20d4e3c8fd4667 Reviewed-on: https://chromium-review.googlesource.com/853772 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#50940}
-
- 29 Jan, 2018 3 commits
-
-
Jungshik Shin authored
This is a v8-port of https://chromium-review.googlesource.com/c/chromium/src/+/890176 . By default, ICU tries to load data items (e.g. brkitr/char.brk) from individual files before trying the common data. Because all the ICU data Chrome needs is included in the common ICU data file that is memory mapped in InitializeICU(), trying to load from the disk just wastes cycles because there's no file with separate ICU data items. Bug: chromium:805694 Test: Intl tests Change-Id: Ia7e77d658b56d98027336acd2c91fd5f7b2cea3e Reviewed-on: https://chromium-review.googlesource.com/890343Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50939}
-
Adam Klein authored
This is a reland of 7dbfec50, now that pdfium has been updated to avoid libfuzzer build failures. I've tested this change locally in pdfium xfa and non-xfa builds. The calls in chromium were removed in https://crrev.com/c/865160, while pdfium was updated in https://pdfium-review.googlesource.com/c/pdfium/+/23270. Bug: v8:7269, v8:7273, v8:7274 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I2d49033fcb305eeba87cca1e27840f278220d15e Reviewed-on: https://chromium-review.googlesource.com/890051Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50938}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:6917 Change-Id: I6d526410520fe7b2cfeff536ed260b37dbb2b8b6 Reviewed-on: https://chromium-review.googlesource.com/891819Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50937}
-