Commits · 25260c2b9a261f796db5257b5735f99f27722a2a · Linshizhi / V8

24 Mar, 2014 16 commits

PreParser cleanup: no need to track with-ness of scopes. · 25260c2b

marja@chromium.org authored Mar 24, 2014

Historically, we used to track the "with-ness" of a scope differently; not
creating a with scope, but setting a property on the scope (see
https://codereview.chromium.org/5166006 ). For laziness decisions, checking the
with-ness should be unnecessary: the current scope is function scope, and if the
outer scope is global scope, there's surely no with scope in between.

R=ulan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209863004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20189 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25260c2b

Fix component build some more. · e5f5cc95

marja@chromium.org authored Mar 24, 2014

Not V8_EXPORTing ScriptCompiler::Source got rid of the last errors. This fixes
the new ones created by it. V8_INLINEing these funcs makes sense anyway.

In addition, added declared-private-and-unimplemented assignment operators
which were accidentally omitted.

R=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209873004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5f5cc95

Revert "A64: Now that we have veneers, fix a couple of branches to directly jump to their target." · 49a7de45

svenpanne@chromium.org authored Mar 24, 2014

This reverts commit r20169, it heavily regresses a Mozilla test:

make -j32 arm64.release.check TESTFLAGS=--time TESTJOBS=mozilla/js1_5/Regress/regress-280769-2

Before:
--- Total time: 00:01.928 ---
   1 (00:01.911) mozilla/js1_5/Regress/regress-280769-2
   2 (00:01.910) mozilla/js1_5/Regress/regress-280769-2
   3 (00:01.910) mozilla/js1_5/Regress/regress-280769-2

After:
--- Total time: 01:36.025 ---
   1 (01:36.004) mozilla/js1_5/Regress/regress-280769-2
   2 (01:35.403) mozilla/js1_5/Regress/regress-280769-2
   3 (01:32.098) mozilla/js1_5/Regress/regress-280769-2

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/209333004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

49a7de45

Delete mjsunit/string-oom-slow-* tests. · 55d5b022

jkummerow@chromium.org authored Mar 24, 2014

They are too slow, and there is no feasible way to speed them up.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/205553005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55d5b022

[ia32/x64] Smaller instruction to check NaN · b7c3cd5e

jkummerow@chromium.org authored Mar 24, 2014

substract 1 and test for overflow

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/202083002

Patch from Weiliang Lin <weiliang.lin@intel.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b7c3cd5e

Reland "Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException." · 8b8fb30e

yangguo@chromium.org authored Mar 24, 2014

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/209903003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b8fb30e

Revert "Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException." · 03866841

yangguo@chromium.org authored Mar 24, 2014

This reverts r20179.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/201573007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

03866841

Remove an unused isolate_ field from BacktrackStack. · 1c90c951

rmcilroy@chromium.org authored Mar 24, 2014

Found by Nico Weber with -Wunused-private-field

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/208613002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c90c951

Use V8_FINAL and V8_OVERRIDE in ElementsAccessor classses. · cd5cc705

ishell@chromium.org authored Mar 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/208063002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cd5cc705

Builtin helper function EnsureJSArrayWithWritableFastElements() handlified. · 89732db6

ishell@chromium.org authored Mar 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/208033002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

89732db6

Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException. · 62f65d86

yangguo@chromium.org authored Mar 24, 2014

R=dcarney@chromium.org
BUG=v8:3060
LOG=Y

Review URL: https://codereview.chromium.org/208263002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

62f65d86

add setaccessorproperty to object · 3ab0622b

dcarney@chromium.org authored Mar 24, 2014

R=svenpanne@chromium.org

LOG=N
BUG=v8:2964

Review URL: https://codereview.chromium.org/209853002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ab0622b

Refactor inlined typed array runtime functions. · 15951521

yangguo@chromium.org authored Mar 24, 2014

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/203443002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20177 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15951521

Do stack checks while pushing locals · 493c6b35

dcarney@chromium.org authored Mar 24, 2014

R=yangguo@chromium.org

BUG=

Review URL: https://codereview.chromium.org/207543003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

493c6b35

Fix options for calling push-to-trunk script. · db8196ae

machenbach@chromium.org authored Mar 24, 2014

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/209833002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

db8196ae

Disable concurrent OSR. · 479bb2ff

yangguo@chromium.org authored Mar 24, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/208263011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

479bb2ff

21 Mar, 2014 24 commits

ARM: fix assertions for uxtb and co. · d5753f27

rodolph.perfetta@arm.com authored Mar 21, 2014

Allow operands with ROR #0. Behind the scene they are mapped to LSL #0.

BUG=v8:3209
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/198053014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5753f27

Tentative Windows dll build fix: Don't V8_EXPORT ScriptCompiler::Source. · be4c4953

marja@chromium.org authored Mar 21, 2014

For more information, see the bug. Compare to ScriptOrigin
which is not exported either.

BUG=v8:3228
LOG=Y
R=dcarney@chromium.org, jkummerow@chromium.org

Review URL: https://codereview.chromium.org/207703004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

be4c4953

A64: Now that we have veneers, fix a couple of branches to directly jump to their target. · 759bf428

alexandre.rames@arm.com authored Mar 21, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/207883002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20169 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

759bf428

Let auto-roll push the lkgr. · 04a418c5

machenbach@chromium.org authored Mar 21, 2014

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/205703004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20168 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

04a418c5

Add special check for topmost optimized code in deoptimizer verification. · 2aaaeb78

ulan@chromium.org authored Mar 21, 2014

BUG=354843
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/208283002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2aaaeb78

JSObject::EnsureCanContainElements() handlified. · deca3f36

ishell@chromium.org authored Mar 21, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/198053013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

deca3f36

Enable concurrent OSR. · 265ae631

yangguo@chromium.org authored Mar 21, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/208253002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

265ae631

ARM64: Fix some stub-cache TODOs · 7eb99dbe

m.m.capewell@googlemail.com authored Mar 21, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/208023002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7eb99dbe

ARM: Fix Q register encoding · 6c417833

m.m.capewell@googlemail.com authored Mar 21, 2014

Fix Q register encoding for registers other than Q0. Also, fix value in NeonSize
enumeration.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/207523005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c417833

Add option to run ScopeIterator faster giving up nested scope chain. · 50ca2eb9

ulan@chromium.org authored Mar 21, 2014

We'd like to be able to trade nested scope chain info (consisting of with, block and catch scopes) in favor of speed in some cases.

BUG=chromium:340285
LOG=N
R=ulan@chromium.org, pfeldman, ulan, yangguo

Review URL: https://codereview.chromium.org/203463011

Patch from Andrey Adaykin <aandrey@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50ca2eb9

Reland of r20146 "JSObject::NormalizeElements() handlified." · 90b1077e

ishell@chromium.org authored Mar 21, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/208003002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

90b1077e

Add a utility method to the ia32 macro assembler to move a double immediate into an XMM register. · a428b0d5

titzer@chromium.org authored Mar 21, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/197233011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a428b0d5

Split of rolling Chromium from push-to-trunk. · e134d32f

machenbach@chromium.org authored Mar 21, 2014

This moves rolling Chromium into a new script with its own tests.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/199733012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e134d32f

Visit return statement of inlined function in value context. · fc2563f1

ulan@chromium.org authored Mar 21, 2014

BUG=354357
LOG=N
TEST=mjsunit/regress/regress-354357.js
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/206413005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20158 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc2563f1

Mark CollectCpuProfile as flaky. · d46f8c1e

yangguo@chromium.org authored Mar 21, 2014

R=machenbach@chromium.org
BUG=v8:2999
LOG=N

Review URL: https://codereview.chromium.org/208043002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20157 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d46f8c1e

ArraySplice builtin handlified. · 0b0b6f65

ishell@chromium.org authored Mar 21, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206073007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20156 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0b0b6f65

Ensure that lazy deopt sequence does not override calls. · f20a9473

ulan@chromium.org authored Mar 21, 2014

BUG=354433
LOG=N
TEST=mjsunit/regress/regress-354433.js
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/198463006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20155 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f20a9473

Revert "JSObject::NormalizeElements() handlified." · 309bf937

ishell@chromium.org authored Mar 21, 2014

This reverts commit r20146 which broke V8 GC Stress, Mjsunit tests.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/207963002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

309bf937

Move new expression parsing funcs to ParserBase. · e79ff827

marja@chromium.org authored Mar 21, 2014

Functions moved: ParseMemberWithNewPrefixesExpression, ParseMemberExpression,
ParseMemberExpressionContinuation.

Now all Parse*Expression functions are in ParserBase.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/207633003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20153 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e79ff827

Skip string-oom tests on nacl. · f6f99310

yangguo@chromium.org authored Mar 21, 2014

R=machenbach@chromium.org
TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/207633004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f6f99310

Mark test-assembler-arm64/fmadd_fmsub_float_nans on arm64 as flaky · c616ec7b

jochen@chromium.org authored Mar 21, 2014

BUG=v8:3226
LOG=n
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/205863004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c616ec7b

Move ParseLeftHandSideExpression to ParserBase. · 7708d4a2

marja@chromium.org authored Mar 21, 2014

Includes cleanups:
- Reorganized functions in PreParserFactory to be in the logical order.
- De-hackified things PreParser doesn't need to track, such as IsCall & IsCallNew.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/206433003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7708d4a2

Move ParsePostfixExpression into ParserBase. · 84520308

marja@chromium.org authored Mar 21, 2014

+ enable a test which checks that Parser and PreParser produce the "invalid left
hand side" errors consistently.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/202333004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

84520308

Rename A64 port to ARM64 port · 2ce0bebb

jochen@chromium.org authored Mar 21, 2014

BUG=354405
R=ulan@chromium.org, rodolph.perfetta@arm.com
LOG=y

Review URL: https://codereview.chromium.org/207823003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2ce0bebb