1. 21 May, 2019 1 commit
    • Georg Neis's avatar
      Revert "Reland "[torque] Convert few class layout to torque."" · e165213e
      Georg Neis authored
      This reverts commit 42fee61a.
      
      Reason for revert: it's not safe to access in-object fields that way.
      Will post more information in Gerrit.
      
      Original change's description:
      > Reland "[torque] Convert few class layout to torque."
      > 
      > This is a reland of b9bfd006
      > 
      > Original change's description:
      > > [torque] Convert few class layout to torque and updated torque code formatter.
      > >
      > > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator,
      > >       TemplateList,
      > >       JSStrictArgumentsObject to torque.
      > > 2. Updated torque code formatter to now handle multi-line
      > >             declarations correctly.
      > >
      > > Bug: v8:8952
      > > Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988
      > > Reviewed-by: Simon Zünd <szuend@chromium.org>
      > > Commit-Queue: Suraj Sharma <surshar@microsoft.com>
      > > Cr-Commit-Position: refs/heads/master@{#61624}
      > 
      > Removed the Torque code Formatter update from this CL
      > 
      > Bug: v8:8952
      > Change-Id: I01e88ac36acd7ba18791bec609e5ae737672c731
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619146
      > Commit-Queue: Suraj Sharma <surshar@microsoft.com>
      > Reviewed-by: Simon Zünd <szuend@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61671}
      
      TBR=surshar@microsoft.com,szuend@chromium.org
      
      Change-Id: I6fd66ce67aeecf0128878924d5e5b6a71ad88e32
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8952
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622109Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Commit-Queue: Georg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61692}
      e165213e
  2. 20 May, 2019 1 commit
    • Suraj Sharma's avatar
      Reland "[torque] Convert few class layout to torque." · 42fee61a
      Suraj Sharma authored
      This is a reland of b9bfd006
      
      Original change's description:
      > [torque] Convert few class layout to torque and updated torque code formatter.
      >
      > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator,
      >       TemplateList,
      >       JSStrictArgumentsObject to torque.
      > 2. Updated torque code formatter to now handle multi-line
      >             declarations correctly.
      >
      > Bug: v8:8952
      > Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988
      > Reviewed-by: Simon Zünd <szuend@chromium.org>
      > Commit-Queue: Suraj Sharma <surshar@microsoft.com>
      > Cr-Commit-Position: refs/heads/master@{#61624}
      
      Removed the Torque code Formatter update from this CL
      
      Bug: v8:8952
      Change-Id: I01e88ac36acd7ba18791bec609e5ae737672c731
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619146
      Commit-Queue: Suraj Sharma <surshar@microsoft.com>
      Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61671}
      42fee61a
  3. 18 May, 2019 1 commit
  4. 17 May, 2019 1 commit
  5. 13 Feb, 2019 1 commit
  6. 09 Jan, 2019 1 commit
  7. 03 Jan, 2019 1 commit
  8. 17 Dec, 2018 1 commit
  9. 12 Dec, 2018 1 commit
  10. 08 Dec, 2018 1 commit
  11. 27 Aug, 2018 1 commit
    • Sathya Gunasekaran's avatar
      [Intl] Correctly pass usage option to Collator · 59c03fef
      Sathya Gunasekaran authored
      The spec specifies that search and standard can not be valid values
      for the collation extension keyword. Instead users are expected to use
      the options bag to set the correct usage options.
      
      But, ICU expects the usage option to be set through the collation
      extension value.
      
      In this patch, we set the usage option using the collation extension
      value in ICU. For resolvedOptions, we filter out this extension value
      using ICU to be spec compatible.
      
      Previously, we stored the usage option on the JSCollator instance. But
      this patch changes the logic to just look it up from the icu::Collator
      when required. This saves one word of memory.
      
      This fails a test262 that was incorrectly fixed. A follow on patch
      will fix the test262 test.
      
      Bug: v8:5751
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: I8c66c6286287e686f4cd152fa1301f9d51c38654
      Reviewed-on: https://chromium-review.googlesource.com/1180488Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55437}
      59c03fef
  12. 14 Aug, 2018 1 commit
  13. 08 Aug, 2018 1 commit
    • Sathya Gunasekaran's avatar
      [Intl] Optimize Intl.Collator · 363fe1eb
      Sathya Gunasekaran authored
      This patch ports most of the Intl.Collator from JS to C++.
      
      The Intl.Collator object no longer stores all the resolved
      values. Instead these are looked up on demand as part of
      Intl.Collator.prototype.resolvedOptions(), saving several words. In
      the future, we can cache the result of the resolvedOptions as well.
      
      In this patch, we use ICU to do parsing of the unicode extension in
      the bcp47 language tag instead of using a custom extension parser.
      
      This patch also fixes several spec compliance bugs as well.
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: Iaaa7be4a628404da1bd83d882e04a2c6de70ebd9
      Bug: v8:5751, v8:7480
      Reviewed-on: https://chromium-review.googlesource.com/1165084
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54965}
      363fe1eb