- 21 May, 2019 1 commit
-
-
Georg Neis authored
This reverts commit 42fee61a. Reason for revert: it's not safe to access in-object fields that way. Will post more information in Gerrit. Original change's description: > Reland "[torque] Convert few class layout to torque." > > This is a reland of b9bfd006 > > Original change's description: > > [torque] Convert few class layout to torque and updated torque code formatter. > > > > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, > > TemplateList, > > JSStrictArgumentsObject to torque. > > 2. Updated torque code formatter to now handle multi-line > > declarations correctly. > > > > Bug: v8:8952 > > Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988 > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#61624} > > Removed the Torque code Formatter update from this CL > > Bug: v8:8952 > Change-Id: I01e88ac36acd7ba18791bec609e5ae737672c731 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619146 > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61671} TBR=surshar@microsoft.com,szuend@chromium.org Change-Id: I6fd66ce67aeecf0128878924d5e5b6a71ad88e32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8952 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622109Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61692}
-
- 20 May, 2019 1 commit
-
-
Suraj Sharma authored
This is a reland of b9bfd006 Original change's description: > [torque] Convert few class layout to torque and updated torque code formatter. > > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, > TemplateList, > JSStrictArgumentsObject to torque. > 2. Updated torque code formatter to now handle multi-line > declarations correctly. > > Bug: v8:8952 > Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#61624} Removed the Torque code Formatter update from this CL Bug: v8:8952 Change-Id: I01e88ac36acd7ba18791bec609e5ae737672c731 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619146 Commit-Queue: Suraj Sharma <surshar@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61671}
-
- 18 May, 2019 1 commit
-
-
Michael Achenbach authored
This reverts commit b9bfd006. Reason for revert: The updated formatter violates some existing files that now require new formatting: https://ci.chromium.org/p/v8/builders/ci/V8%20Presubmit/4411 Original change's description: > [torque] Convert few class layout to torque and updated torque code formatter. > > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, > TemplateList, > JSStrictArgumentsObject to torque. > 2. Updated torque code formatter to now handle multi-line > declarations correctly. > > Bug: v8:8952 > Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#61624} TBR=jgruber@chromium.org,tebbi@chromium.org,surshar@microsoft.com,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8952 Change-Id: I98424deb8002ba9b92262c4b7a1f753bd7c4f7c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617927Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61629}
-
- 17 May, 2019 1 commit
-
-
Suraj Sharma authored
1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, TemplateList, JSStrictArgumentsObject to torque. 2. Updated torque code formatter to now handle multi-line declarations correctly. Bug: v8:8952 Change-Id: I97846b1bc0d2cba5d7a68468fc263423b1b55d19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536988Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Suraj Sharma <surshar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#61624}
-
- 13 Feb, 2019 1 commit
-
-
Nico Weber authored
For macros expanding to function definitions, I removed the spurious ; after macro invocations. For macros expandign to function declarations, I made the ; required and consistently inserted it. No behavior change. Bug: chromium:926235 Change-Id: Ib8085d85d913d74307e3481f7fee4b7dc78c7549 Reviewed-on: https://chromium-review.googlesource.com/c/1467545Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59558}
-
- 09 Jan, 2019 1 commit
-
-
Jakob Kummerow authored
The incremental migration required several pairs of functionally equivalent macros. This patch consolidates everything onto the respective new version and drops the obsolete versions. Bug: v8:3770 Change-Id: I4fb05ff223e8250c83a13f46840810b0893f410b Reviewed-on: https://chromium-review.googlesource.com/c/1398223Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58659}
-
- 03 Jan, 2019 1 commit
-
-
Frank Tang authored
This reverts commit 8d094249. Reason for revert: Cause Memory regression TBR=gsathya@chromium.org Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} TBR=cira@chromium.org,jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7481 Change-Id: Idabf2183684f264271ebe2b8c0ca10ae8e30d811 Reviewed-on: https://chromium-review.googlesource.com/c/1393499Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58506}
-
- 17 Dec, 2018 1 commit
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Ie80ce957ff1d2bcd3596491066f6562ce0ad129a Reviewed-on: https://chromium-review.googlesource.com/c/1380114 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58294}
-
- 12 Dec, 2018 1 commit
-
-
Frank Tang authored
Fix intl402/*/ignore-invalid-unicode-ext-values Add tests for other valid/invalid -u- ext values. Bug: v8:7481 Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 Reviewed-on: https://chromium-review.googlesource.com/c/1351307 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58173}
-
- 08 Dec, 2018 1 commit
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I1d74ffe9e5478b4b8bc0acbf088d20919d458d50 Reviewed-on: https://chromium-review.googlesource.com/c/1363822 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#58112}
-
- 27 Aug, 2018 1 commit
-
-
Sathya Gunasekaran authored
The spec specifies that search and standard can not be valid values for the collation extension keyword. Instead users are expected to use the options bag to set the correct usage options. But, ICU expects the usage option to be set through the collation extension value. In this patch, we set the usage option using the collation extension value in ICU. For resolvedOptions, we filter out this extension value using ICU to be spec compatible. Previously, we stored the usage option on the JSCollator instance. But this patch changes the logic to just look it up from the icu::Collator when required. This saves one word of memory. This fails a test262 that was incorrectly fixed. A follow on patch will fix the test262 test. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8c66c6286287e686f4cd152fa1301f9d51c38654 Reviewed-on: https://chromium-review.googlesource.com/1180488Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55437}
-
- 14 Aug, 2018 1 commit
-
-
Ujjwal Sharma authored
This increases the size of a Collator instance by a word to store the bound compare function. The instance to be bound is stored on the context of this builtin function. Bug: v8:7800 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie7581ab59fdfe4efff6d960e07ed2164fa6d9959 Reviewed-on: https://chromium-review.googlesource.com/1171967Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55130}
-
- 08 Aug, 2018 1 commit
-
-
Sathya Gunasekaran authored
This patch ports most of the Intl.Collator from JS to C++. The Intl.Collator object no longer stores all the resolved values. Instead these are looked up on demand as part of Intl.Collator.prototype.resolvedOptions(), saving several words. In the future, we can cache the result of the resolvedOptions as well. In this patch, we use ICU to do parsing of the unicode extension in the bcp47 language tag instead of using a custom extension parser. This patch also fixes several spec compliance bugs as well. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iaaa7be4a628404da1bd83d882e04a2c6de70ebd9 Bug: v8:5751, v8:7480 Reviewed-on: https://chromium-review.googlesource.com/1165084 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54965}
-