Skip to content

V
V8
Switch branch/tag
  1. 15 Aug, 2015 1 commit
    • caitpotter88's avatar
      [parser] make kInvalidLhsInFor a SyntaxError · 9b15445e
      caitpotter88 authored 
      Second item in section 13.7.5.1 states that the error should be a
SyntaxError, when previously CheckAndRewriteReferenceExpression
would always emit a ReferenceError.

BUG=v8:4373
R=adamk, rossberg
LOG=N
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1292393002

Cr-Commit-Position: refs/heads/master@{#30184}
      9b15445e
  3. 13 Aug, 2015 2 commits
  5. 04 Aug, 2015 1 commit
    • rossberg's avatar
      [es6] Refactor FormalParameter · 56bd11a1
      rossberg authored 
      Store arity in FormalParameters; store name (instead of var) and is_rest flag in individual parameters. Ensure that the arity is always maintained consistently.

This is preparation for more parameter destructuring adjustments. In particular, a follow-up CL will separate parameter recording from declaring the variables.

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:811
LOG=N

Review URL: https://codereview.chromium.org/1259013003

Cr-Commit-Position: refs/heads/master@{#30002}
      56bd11a1
  7. 23 Jul, 2015 1 commit
  9. 20 Jul, 2015 1 commit
  11. 15 Jul, 2015 1 commit
  13. 09 Jul, 2015 1 commit
    • adamk's avatar
      Fix lazy compilation of eval() under nosnap/--use-strict · 33a37398
      adamk authored 
      When running without a snapshot, the GlobalEval function gets lazy compiled.
By the time we compile it, its name is "eval", which causes the parser to
choke (functions named "eval" aren't allowed in strict mode!).

Instead, we now always skip checking the function name when lazy-parsing,
as the name has already been checked appropriately by the preparser.

Also cleaned up other cases that don't require name checking by introducing
FunctionNameValidity enum and passing appropriate values throughout the
parser and preparser.

This lets us pass an additional 18 test262 tests.

BUG=v8:4198
LOG=n

Review URL: https://codereview.chromium.org/1227093005

Cr-Commit-Position: refs/heads/master@{#29559}
      33a37398
  15. 08 Jul, 2015 1 commit
  17. 07 Jul, 2015 1 commit
  19. 22 Jun, 2015 3 commits
  21. 15 Jun, 2015 2 commits
  23. 09 Jun, 2015 4 commits
  25. 04 Jun, 2015 1 commit
  27. 01 Jun, 2015 2 commits
    • caitpotter88's avatar
      Revert of [es6] implement default parameters via desugaring (patchset #19... · 904fbc30
      caitpotter88 authored 
      Revert of [es6] implement default parameters via desugaring (patchset #19 id:380001 of https://codereview.chromium.org/1127063003/)

Reason for revert:
Broken on arm64

Original issue's description:
> [es6] implement default parameters via desugaring
>
> Stage 1 implementation:
>
> - Parameters can't be referenced before initialized (from left-to-right)
> - SingleNameBindings only, no support for BindingPatterns
>
> Known issues:
>
> - Incorrect scoping (parameter expressions may reference variables declared in function body)
> - Function arity is untouched
> - Hole-checking needs work
> - Rest parameters are broken when mixed with optional arguments
>
> BUG=v8:2160
> LOG=N
> R=arv@chromium.org, rossberg@chromium.org
>
> Committed: https://crrev.com/892c85485881f8be2f17bd83238980f858126576
> Cr-Commit-Position: refs/heads/master@{#28739}

TBR=rossberg@chromium.org,wingo@igalia.com,arv@chromium.org,dslomov@chromium.org,adamk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:2160

Review URL: https://codereview.chromium.org/1163853002

Cr-Commit-Position: refs/heads/master@{#28740}
      904fbc30
    • caitpotter88's avatar
      [es6] implement default parameters via desugaring · 892c8548
      caitpotter88 authored 
      Stage 1 implementation:

- Parameters can't be referenced before initialized (from left-to-right)
- SingleNameBindings only, no support for BindingPatterns

Known issues:

- Incorrect scoping (parameter expressions may reference variables declared in function body)
- Function arity is untouched
- Hole-checking needs work
- Rest parameters are broken when mixed with optional arguments

BUG=v8:2160
LOG=N
R=arv@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/1127063003

Cr-Commit-Position: refs/heads/master@{#28739}
      892c8548
  29. 26 May, 2015 1 commit
    • arv's avatar
      [es6] Support super.property in eval and arrow functions · 44e98103
      arv authored 
      When we enter a method that needs access to the [[HomeObject]]
we allocate a local variable `.home_object` and assign it the
value from the [[HomeObject]] private symbol. Something along
the lines of:

  method() {
    var .home_object = %ThisFunction()[home_object_symbol];
    ...
  }

BUG=v8:3867, v8:4031
LOG=N

Review URL: https://codereview.chromium.org/1135243004

Cr-Commit-Position: refs/heads/master@{#28644}
      44e98103
  31. 18 May, 2015 2 commits
  33. 13 May, 2015 1 commit
  35. 06 May, 2015 1 commit
  37. 28 Apr, 2015 1 commit
  39. 27 Apr, 2015 1 commit
  41. 22 Apr, 2015 3 commits
  43. 21 Apr, 2015 2 commits
  45. 17 Apr, 2015 1 commit
  47. 16 Apr, 2015 1 commit
  49. 13 Apr, 2015 2 commits
  51. 10 Apr, 2015 2 commits