1. 13 Sep, 2021 1 commit
    • Michael Lippautz's avatar
      heap: ArrayBufferSweeper refactoring · 210987a5
      Michael Lippautz authored
      The refactoring is triggered by https://crrev.com/c/3121905 where we
      noticed that a bunch of tricky counter paths could be simplified,
      making reasoning about corectness easier.
      
      In this CL:
      1. Use uniqe_ptr instead of Optional to allow moving SweepingJob away
         from the header file.
      2. sweeping_in_progress_ is replaced with simply checking for a job.
      3. freed_bytes_ are moved to the job and the dependency is reversed,
         avoiding the inside-out (Job->Sweeper) dependency completely.
      4. Merge() and counter updates are merged into a Finalize() method.
      5. FinishIfDone() allows for conditional finization.
      6. young_bytes_ and old_bytes_ are removed as they were always updated
         when the corresponding bytes in the ArrayBufferList was updated.
      
      Change-Id: I56e5b04087166ce03d3a9195ac48359122a84c73
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124776Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
      Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76795}
      210987a5
  2. 07 May, 2021 1 commit
    • Dominik Inführ's avatar
      [heap] Immediately update external memory on JSArrayBuffer::Detach · edd27c77
      Dominik Inführ authored
      This CL changes the accounting of array buffers, such that Detach
      deducts the backing store immediately. Previously this was corrected
      in the next GC cycle.
      
      Not updating backing_store_bytes_ immediately could cause an overflow
      in WasmMemoryObject::Grow. Grow first detaches the backing store from
      the old JSArrayBuffer and then attaches it to a new one. This results
      in the backing store being accounted twice temporarily, this could cause
      overflows on 32-bit systems.
      
      Bug: chromium:1204455
      Change-Id: I7cf2ca9a12bb5caf7bcffa25a34567774cf155b8
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2871458
      Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74429}
      edd27c77
  3. 23 Nov, 2020 1 commit
  4. 29 Oct, 2020 1 commit
    • Dominik Inführ's avatar
      [heap] Merge ArrayBufferExtension lists sooner · deda7cd0
      Dominik Inführ authored
      Merge the list of concurrently swept ArrayBufferExtensions sooner back
      to the main thread. When appending a new ArrayBufferExtension check
      whether the concurrent sweeping was already finished and merge the lists
      if it is.
      
      In order to reduce the number of GCs in the linked test case, reset
      young_bytes_ and old_bytes_ to 0 while sweeping the
      ArrayBufferExtensions. Surviving extensions will be accounted again
      when merging lists.
      
      As a drive-by change remove scavenge.process_array_buffers from
      GCTracer. GCTracer also printed the wrong value for fast_promote.
      
      Bug: v8:11044
      Change-Id: I8a772df895c43a69493015f42336c6f33fe52056
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505764Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70880}
      deda7cd0
  5. 11 Feb, 2020 1 commit
  6. 10 Feb, 2020 2 commits
  7. 24 Jan, 2020 1 commit