1. 03 May, 2019 1 commit
    • Maciej Goszczycki's avatar
      Revert "[heap] Set read-only space's and its pages' heap_ to null." · fa4b433f
      Maciej Goszczycki authored
      This reverts commit 964edc25.
      
      Reason for revert: chromium:959190
      
      Original change's description:
      > [heap] Set read-only space's and its pages' heap_ to null.
      >
      > Various small changes are required to enable this.
      >
      > HeapObject::GetReadOnlyRoots no longer uses the Space's heap when
      > possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition).
      > This requires that ReadOnlyRoots be construct-able using a raw pointer
      > to the read-only space's roots array.
      >
      > Global read-only heap state is now cleared by tests where appropriate
      > and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future
      > issues easier.
      >
      > String padding is now always cleared just before read-only space is
      > sealed when not deserializing.
      >
      > Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372
      > Bug: v8:7464
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830
      > Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61188}
      
      TBR=ulan@chromium.org,hpayer@chromium.org,delphick@chromium.org,goszczycki@google.com
      
      Change-Id: I53cecf3976dfeabae309040313351385f651f010
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7464, chromium:959190
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591608Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Commit-Queue: Adam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61217}
      fa4b433f
  2. 02 May, 2019 1 commit
    • Maciej Goszczycki's avatar
      [heap] Set read-only space's and its pages' heap_ to null. · 964edc25
      Maciej Goszczycki authored
      Various small changes are required to enable this.
      
      HeapObject::GetReadOnlyRoots no longer uses the Space's heap when
      possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition).
      This requires that ReadOnlyRoots be construct-able using a raw pointer
      to the read-only space's roots array.
      
      Global read-only heap state is now cleared by tests where appropriate
      and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future
      issues easier.
      
      String padding is now always cleared just before read-only space is
      sealed when not deserializing.
      
      Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372
      Bug: v8:7464
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830
      Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61188}
      964edc25
  3. 15 Feb, 2019 1 commit
  4. 16 Oct, 2018 1 commit
    • Dan Elphick's avatar
      Clarify roots iteration · 08b8e0ff
      Dan Elphick authored
      Change Heap::IterateStrongRoots to never iterate the read-only roots. In
      doing so remove VISIT_ALL_BUT_READ_ONLY and
      VISIT_ONLY_STRONG_FOR_SERIALIZATION. All such uses should now use
      VISIT_ALL and VISIT_ONLY_STRONG. Where ReadOnlyRoots iteration is
      required, this adds ReadOnlyRoots(isolate)->Iterate() at the call site.
      
      Add new begin, end, strong_mutable_roots_begin and
      strong_mutable_roots_end methods to RootsTable and try and make the
      existing uses a little more consistent.
      
      Bug: v8:8191
      Change-Id: Ie9d0f9e5186db418428e2fafd38432b0bd879daa
      Reviewed-on: https://chromium-review.googlesource.com/c/1278500
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56672}
      08b8e0ff
  5. 11 Oct, 2018 1 commit
  6. 26 Sep, 2018 1 commit