- 20 Dec, 2014 2 commits
-
-
machenbach authored
Revert of Remove obsolete V8_INFINITY macro. (patchset #3 id:40001 of https://codereview.chromium.org/798413003/) Reason for revert: Speculative revert. This seems to block the current roll: https://codereview.chromium.org/819653003/ I retried several times, also with a new roll. The error is internal - but that doesn't make much of a difference. Original issue's description: > Remove obsolete V8_INFINITY macro. > > Use std::numeric_limits consistently. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/31c66e2d53569c4e229d55483d28208491e73612 > Cr-Commit-Position: refs/heads/master@{#25897} TBR=svenpanne@chromium.org,bmeurer@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/813813003 Cr-Commit-Position: refs/heads/master@{#25912}
-
machenbach authored
Revert of [mips] Fix typos introduced by previous commit. (patchset #1 id:1 of https://codereview.chromium.org/814203002/) Reason for revert: Needed in order to revert https://codereview.chromium.org/798413003 Original issue's description: > [mips] Fix typos introduced by previous commit. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/0c96a8b19730e79bc9cae08f3d86755c7b7c962e > Cr-Commit-Position: refs/heads/master@{#25899} TBR=svenpanne@chromium.org,bmeurer@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/822523002 Cr-Commit-Position: refs/heads/master@{#25911}
-
- 19 Dec, 2014 2 commits
-
-
Benedikt Meurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/814203002 Cr-Commit-Position: refs/heads/master@{#25899}
-
bmeurer authored
Use std::numeric_limits consistently. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/798413003 Cr-Commit-Position: refs/heads/master@{#25897}
-
- 12 Dec, 2014 2 commits
-
-
Michael Stanton authored
This patch finally allows running and passing tests with vector-based Load and KeyedLoad ICs. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/767743002 Cr-Commit-Position: refs/heads/master@{#25800}
-
svenpanne authored
FINAL implies OVERRIDE, which in turn implies virtual, so there's no need to use more than one of these. The Google C++ style guide even requires this, see http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance. While we're here, port r24662 to x87. The net result is that v8 compiles again with a current clang. BUG=v8:3753 LOG=y Review URL: https://codereview.chromium.org/797943002 Cr-Commit-Position: refs/heads/master@{#25792}
-
- 03 Dec, 2014 1 commit
-
-
Dusan Milosavljevic authored
The V8_INFINITY macro expands to constant expression of type float. TEST=mjsunit/constant-folding-2 BUG= R=balazs.kilvady@imgtec.com Review URL: https://codereview.chromium.org/779433003 Cr-Commit-Position: refs/heads/master@{#25635}
-
- 10 Nov, 2014 1 commit
-
-
jkummerow@chromium.org authored
BUG=chromium:431602 LOG=y R=jarin@chromium.org Review URL: https://codereview.chromium.org/714663002 Cr-Commit-Position: refs/heads/master@{#25249} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25249 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Oct, 2014 1 commit
-
-
mvstanton@chromium.org authored
BUG=v8:3605 LOG=N R=jkummerow@chromium.org, ulan@chromium.org Review URL: https://codereview.chromium.org/650073002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Oct, 2014 2 commits
-
-
mvstanton@chromium.org authored
It's good to have typing around this value. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/641373002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24528 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
Additional static information needs to be passed to Load and KeyedLoad calls if --vector-ics is turned on. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/633423002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24519 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Sep, 2014 1 commit
-
-
svenpanne@chromium.org authored
Boring semi-mechanical stuff... R=jarin@chromium.org Review URL: https://codereview.chromium.org/598953002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Sep, 2014 4 commits
-
-
svenpanne@chromium.org authored
* Make the detailed deopt reason mandatory on x64, other platforms will follow in separate CLs. * Extracted and improved jump table entry sharing logic: When --trace-deopt is on, we get separate entries for different deopt reasons. This enables us to distinguish the several reasons single instructions can have. * Don't emit superfluous jump table comments: The bailout ID is still visible, and the jump table entry number is not interesting (but easy to determine if really needed). * Unify the internal name of the jump table member across platforms. R=jarin@chromium.org Review URL: https://codereview.chromium.org/595513002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
This way the deoptimization reasons are actually threaded through to the jump table. Tiny cleanup of related MIPS/MIPS64 code on the way. R=jarin@chromium.org Review URL: https://codereview.chromium.org/585423002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/587223002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
As discussed in https://codereview.chromium.org/582743002/, here a mechanical refactoring... R=jarin@chromium.org Review URL: https://codereview.chromium.org/587623002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24103 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Sep, 2014 2 commits
-
-
svenpanne@chromium.org authored
For a given address/type pair we should always find a deoptimization bailout ID, otherwise something is wrong. This was already asserted on ARM, but we now do this consistently on all platforms. Removed some usesless naming creativity on the way. R=jarin@chromium.org Review URL: https://codereview.chromium.org/587473003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24077 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Note that we still need to migrate from sometimes emitting those comments by hand to passing a reason explicitly, but this can be done incrementally in separate CLs. R=jarin@chromium.org Review URL: https://codereview.chromium.org/582743002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24061 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Sep, 2014 1 commit
-
-
svenpanne@chromium.org authored
This is a purely mechanical refactoring and a first step towards being able to report more helpful deoptimization reasons. With this refactoring, we know at least the mnemonic of the instruction causing the deopt, although this is not used yet. Future steps will be using the mnemonic, passing additional explicit deopt reasons and removing the fragile machinery of searching for code comments. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/559143003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24026 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Sep, 2014 1 commit
-
-
svenpanne@chromium.org authored
Every DeoptimizeIf should be preceded by a RecordComment explaining the reason. In the long run, the reason should be an argument of DeoptimizeIf, but we're not there yet. On x87, things are a bit ugly due to some pushing/popping, so if somebody feels inclined to improve this: Feel free. Probably the right approach would be reloading instead of the push/pop horror. Another thing is our inconsistent handling of the "done" continuation of deferred code on the various platforms, I made tiny changes on the way, but this should better be unified somehow, with all those micro-optimizations removed. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/578583002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23996 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Sep, 2014 1 commit
-
-
mvstanton@chromium.org authored
CodeStubs use state types defined in ic.h, but this has the unfortunate effect of spreading ic.h all over the place. Instead, define these shared state types in ic-public.h and allow ic.h to concern itself with internal state change of the ICs. More work could/should be done here, but this is a first step. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/565873002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23977 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Sep, 2014 2 commits
-
-
balazs.kilvady@imgtec.com authored
Port r23877 (bd09296) Original commit message: At the same time we spread knowledge about how to create the initial IC code object too widely. Consolidate code creation and unify it with a descriptor via CodeFactory. BUG= R=paul.lind@imgtec.com Review URL: https://codereview.chromium.org/564883002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23884 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
balazs.kilvady@imgtec.com authored
Port r23854 (3870059) Original commit message: Added CallInterfaceDescriptors to all code stubs. A handful of code stubs are too complex to be described this way, and they are encoded with the macro DEFINE_NULL_CALL_INTERFACE_DESCRIPTOR(). Along the way: * allowed inheritance of CallInterfaceDescriptors. * Defined static Register methods for some of the new CallInterfaceDescriptors. We could go a lot further here, but it doesn't have to be done immediately. * Added Representation arrays to some CallInterfaceDescriptors, especially where future hydrogen versions of the stubs could benefit from this knowledge. BUG= R=dusan.milosavljevic@imgtec.com Review URL: https://codereview.chromium.org/562153002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23872 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Sep, 2014 1 commit
-
-
arv@chromium.org authored
This is governed by the harmony-object-literals flag. BUG=v8:3516 LOG=Y R=rossberg@chromium.org Review URL: https://codereview.chromium.org/477263002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23846 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Sep, 2014 1 commit
-
-
balazs.kilvady@imgtec.com authored
MIPS: To aid vector-based load ic work, we need to be able to handle the megamorphic load case in hydrogen. Port r23772 (d6d07c5) Original commit message: Encapsulate megamorphic load/tail-call in hydrogen. A simple approach is to wrap the probe activity in a hydrogen instruction. The instruction is novel in that it always tail-calls away. BUG= R=paul.lind@imgtec.com Review URL: https://codereview.chromium.org/546733003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23781 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Sep, 2014 1 commit
-
-
balazs.kilvady@imgtec.com authored
Port r23639 (e5a2758) Original commit message: The ic-convention classes that hold register specifications are merged into these new call descriptor classes, which should represent a final home for that information. BUG= R=paul.lind@imgtec.com Review URL: https://codereview.chromium.org/538573002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Sep, 2014 2 commits
-
-
balazs.kilvady@imgtec.com authored
Port r23617 (1ad2f2a) TEST=base-unittests,cctest,mjsunit BUG= R=paul.lind@imgtec.com Review URL: https://codereview.chromium.org/519283005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23626 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Less useless creativity is best creativity! R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/526223002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Aug, 2014 1 commit
-
-
balazs.kilvady@imgtec.com authored
Port r23391 (c3bf1dc) Original commit message: A change to a convention shouldn't require recompilation of ic.h/.cc. BUG= R=paul.lind@imgtec.com, vogelheim@chromium.org Review URL: https://codereview.chromium.org/508673002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Aug, 2014 3 commits
-
-
balazs.kilvady@imgtec.com authored
Port r23359 (2e682e9) BUG= R=paul.lind@imgtec.com Review URL: https://codereview.chromium.org/503103002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23372 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
balazs.kilvady@imgtec.com authored
MIPS: Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compiler. Port r23306 (b95f295) BUG= R=paul.lind@imgtec.com, verwaest@chromium.org Review URL: https://codereview.chromium.org/496393002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23340 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
Since the deopt patch address needs to be available during GC to resolve safepoints, we need to move it to the code object (instead of the deoptimization input data) - accessing a separate fixed array is not safe during GC. This CL adds a deoptimization_pc field to each safepoint. The fields points to the deoptimization block. The CL also fixes wrong register allocator constraints for frame states on calls. These should always live on the stack because registers are not preserved during a call. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/504493002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23334 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Aug, 2014 1 commit
-
-
yangguo@chromium.org authored
R=marja@chromium.org Review URL: https://codereview.chromium.org/471923002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23141 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Aug, 2014 1 commit
-
-
dusan.milosavljevic@imgtec.com authored
Fixing gclient runhooks failure caused by reverted commit r23050. TEST= BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Review URL: https://codereview.chromium.org/467583002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23088 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Aug, 2014 4 commits
-
-
machenbach@chromium.org authored
This reverts commit r23050 for breaking runhooks on chromium. See e.g.: http://build.chromium.org/p/client.v8/builders/Chrome%20Linux%20Perf/builds/1438/steps/runhooks/logs/stdio TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/458983003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23053 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dusan.milosavljevic@imgtec.com authored
Original commit r23028 breaks ARM64 build due to conflicting FP64 symbolic constant definition in src/globals.h and src/arm64/constants-arm64.h. TEST= BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Review URL: https://codereview.chromium.org/457313003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23050 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Breaks compilation of ARM64. | Additional summary: | - Introduce fp64 fpu mode into mips32 port required for r6. | - Implement runtime detections for fpu mode and arch. revision to preserve | compatibility with previous architecture revisions. | | TEST= | BUG= | R=jkummerow@chromium.org, paul.lind@imgtec.com | | Review URL: https://codereview.chromium.org/453043002 BUG=none LOG=n TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/458193002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23030 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dusan.milosavljevic@imgtec.com authored
Additional summary: - Introduce fp64 fpu mode into mips32 port required for r6. - Implement runtime detections for fpu mode and arch. revision to preserve compatibility with previous architecture revisions. TEST= BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Review URL: https://codereview.chromium.org/453043002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23028 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2014 1 commit
-
-
danno@chromium.org authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/426233002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22709 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-