- 23 Oct, 2018 7 commits
-
-
Gus Caplan authored
This CL replaces the stack trace parameter with a the array that is usually passed to the JS prepareStackTrace callback. This allows two important goals to be realized: 1) we can easily stringify individual frames and 2) we can (if needed) call back into JS from this callback with a usable structure. If, as is sometimes the case, a v8::StackTrace is needed, |v8::Exception::GetStackTrace| can be used on the exception that is passed to PrepareStackTraceCallback. Bug: v8:7637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I57fa1f2b4552cc7f69351fe0918f4e59e3f5fce1 Reviewed-on: https://chromium-review.googlesource.com/c/1266698Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#56880}
-
Hai Dang authored
Currently Torque's Array.prototype.slice creates holey arrays for those that don't fit in new space in its slow path (by calling ArraySpeciesCreate), even if the source is packed. This creates regression on packed arrays where TurboFan optimizes and then deoptimizes because the maps don't match. See https://chromeperf.appspot.com/report?sid=4553b0826123337f5026fd6b4a285d5fc3cd77cafb515ddd954d195630642730 This CL reduces the chance that Torque's Array.prototype.slice returns holey arrays. In particular, in the case of a large FastJSArray, ExtractFastJSArray can still be used because it can handle large objects, and will return a packed array if the source array is also packed. Change-Id: I691cf48e07c699e5d42afda0bea6cbdc117b653f Reviewed-on: https://chromium-review.googlesource.com/c/1293372Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Hai Dang <dhai@google.com> Cr-Commit-Position: refs/heads/master@{#56879}
-
Benedikt Meurer authored
This builtin was initially used to create the promise for an async function, but that is now done by the AsyncFunctionEnter intrinsic. Bug: v8:7253 Change-Id: I90d0bb31c1548bbfdb53833a5c06161db368f4f0 Reviewed-on: https://chromium-review.googlesource.com/c/1296129Reviewed-by:
-
Hannes Payer authored
Bug: chromium:897074 Change-Id: I65894046064a230847f3e629e56d8a171546aa51 Reviewed-on: https://chromium-review.googlesource.com/c/1293950Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56877}
-
Benedikt Meurer authored
Add missing typing rules for calls to Promise builtins. All of these return receivers always, since PromiseCapabilities.[[Promise]] can be any receiver essentially. Adding the typing rules here helps to rule out unnecessary Smi checks in the general case. Bug: v8:7253 Change-Id: Ia51546420f331431872183a92702855f91b7daba Reviewed-on: https://chromium-review.googlesource.com/c/1293956Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56876}
-
Frank Tang authored
Move Normalize into intl-objects.* Move V8BreakIterator code to js-break-iterator* Add heap-symbol for breakType of JSBreakIterator Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id25af28770ae3c0b7716f4e3b602d4b040194a7d Reviewed-on: https://chromium-review.googlesource.com/c/1293110 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Alexei Filippov authored
BUG=chromium:889545 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic00ffa9968cffaf2e20682e247747b5f7dc0f145 Reviewed-on: https://chromium-review.googlesource.com/c/1285394 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#56874}
-
- 22 Oct, 2018 33 commits
-
-
Frank Tang authored
Fold methods from intl.* to objects/intl-objects.* Move Isolate* to the first parameter for some method Move ICUSerice type under Intl Hide ICUTimeZoneCache under a CreateTimeZoneCache factory method. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie6f6a1ceee789333a077c1965de8e11d8c15c175 Reviewed-on: https://chromium-review.googlesource.com/c/1293109 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
Full custom preview generation is moved to custom-preview file including frontend part. New custom preview implementation returns body getter function instead of bind function, formatter and config objects. Body getter function calls formatter.body(object, config) and returns json ML. R=dgozman@chromium.org Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I14ff3d8abb4a47d2bbc2e6eaa1835fc362ac7369 Reviewed-on: https://chromium-review.googlesource.com/c/1292686 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: Ia33e925339c66fcefb9c3739c1985477190dab44 Reviewed-on: https://chromium-review.googlesource.com/c/1294372Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56871}
-
Camillo Bruni authored
Bug: chromium:897514 Change-Id: Ie7950a2caa2e63e102096a6a36475351259ea854 Reviewed-on: https://chromium-review.googlesource.com/c/1293955 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56870}
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: I26510b95469b6d9724bdae150f65f4c3068553ea Reviewed-on: https://chromium-review.googlesource.com/c/1293774Reviewed-by:
-
andrew-cc-chen authored
Change-Id: Id27bfca6f49d4ec351988a597307558cd75ecf56 Reviewed-on: https://chromium-review.googlesource.com/c/1278499Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56868}
-
Alexei Filippov authored
Change-Id: Iefd58de58d5aaa9ac30f87dba249f7a123ede0bd Reviewed-on: https://chromium-review.googlesource.com/c/1292685Reviewed-by:
-
Maya Lekova authored
NOTRY=true R=sigurds@chromium.org Change-Id: I94a735508f2ec4ca0b21e48ee0f486c3189b2d8a Reviewed-on: https://chromium-review.googlesource.com/c/1293954Reviewed-by:
-
Jakob Gruber authored
TryLookupCode can be passed arbitrary addresses, e.g. by tentative name lookups during disassembly. This CL makes sure that addresses within non-builtin-code sections of the embedded blob (metadata or padding) are handled properly. Bug: v8:6666, v8:8334 Change-Id: I42eca57062e30eabd7bb1b069786aa809706cd2c Reviewed-on: https://chromium-review.googlesource.com/c/1292060Reviewed-by:
-
Jakob Gruber authored
This removes a bunch of porting helpers, e.g. scopes that mark the addressability of ebx, printing embedded builtin candidates, and the call/jump mechanism through a virtual target register. This also disables root register verification by default on ia32. It can be completely removed in a bit. Bug: v8:6666 Change-Id: I4705d61991ddc57c30981c311a1c8c5e2f8ddf4d Reviewed-on: https://chromium-review.googlesource.com/c/1288271Reviewed-by:
-
Alexey Kozyatinskiy authored
Test to cover a lot of injected script source corner cases. R=dgozman@chromium.org Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia631de58c5a92b39ec3933c56cf7e3f108b9bd9e Reviewed-on: https://chromium-review.googlesource.com/c/1292688 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Typically compiler does not have to compile one-shot code but, there are some cases where user can capture IIFEs and execute it multiple times. Adding counter to track number of such closures compiled with one-shot bytecodes. Bug: v8:8072 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I752a12cff6ee9bb751323f4d58897cdd41c6890c Reviewed-on: https://chromium-review.googlesource.com/c/1237679Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
Change-Id: I8b50ff0d53787fb19604644a71f091837a8dcbde Reviewed-on: https://chromium-review.googlesource.com/c/1292062Reviewed-by:
-
Michael Starzinger authored
This removes some unnecessary runtime calls when encoding/decoding values stored in exception objects. It reduces code size of the generated code. R=clemensh@chromium.org BUG=v8:8341 Change-Id: I2394994be01d3071e58bfa2bfbba8bf72a6a04a5 Reviewed-on: https://chromium-review.googlesource.com/c/1293373 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56860}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I1e168132f5d3c90e1a3ee5c13ebc6dbc11e9daa1 Reviewed-on: https://chromium-review.googlesource.com/c/1288250 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#56859}
-
Benedikt Meurer authored
This CL introduces a new fast-path for `Promise.all(a)` for the case that elements in `a` are native promises, and the Promise.prototype and Promise function itself are intact. If so, we can skip the lookups of "resolve" on Promise and "then" on the result of invoking "resolve", which are both quite expensive, and we can instead directly call the PerformPromiseThen() operation on the element of `a`. In addition to that we don't need to create and chain a result promise, since this is only used when either async_hooks or DevTools are enabled. Otherwise it's a "throwaway promise" only used to satisfy the operation parameter signature (see https://github.com/tc39/ecma262/pull/1146). This results in a significant performance improvement on `Promise.all()` heavy code. For example the parallel-promises-es2015-native test goes from around 84ms to roughly 68ms, which is almost a 20% improvement. Bug: v8:7253 Ref: tc39/ecma262#1146 Change-Id: Iab9c57edb26d13a467b0653fd8de6149c382efc6 Reviewed-on: https://chromium-review.googlesource.com/c/1293374Reviewed-by:
-
Clemens Hammacher authored
This removes the {error} and {verror} methods of {ResultBase} and introduces a named constructor {Error} instead. This allows to construct an error result in a single expression, and moves {Result} closer to a container that is initialized once and is immutable afterwards (just the {MoveErrorFrom} method is still violating this pattern). R=titzer@chromium.org Bug: v8:8238 Change-Id: Iec16c8c6d66300ee82a48e8a9e941c72ae26e202 Reviewed-on: https://chromium-review.googlesource.com/c/1293370 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56857}
-
Camillo Bruni authored
Making --data-path a subdir of --user-data-dir makes it easier to clean up data after a benchmark run. Bug: chromium:861668 Change-Id: If44527163ea396b11346d65d76411d03a5b9a424 Reviewed-on: https://chromium-review.googlesource.com/c/1292065Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#56856}
-
Marja Hölttä authored
This reverts commit 49bd7f50. Reason for revert: breaks nonintl build since the added string is inside wrong ifdefs Original change's description: > [js weak refs] Add WeakCell.clear() > > BUG=v8:8179 > > Change-Id: Ic0d9af273a8a92177bf60e4be0dd5bddaf31868c > Reviewed-on: https://chromium-review.googlesource.com/c/1292058 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56853} TBR=marja@chromium.org,hpayer@chromium.org,gsathya@chromium.org Change-Id: I7d6831cfd8a5263ee327c2a80274d1cd10dd65cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8179 Reviewed-on: https://chromium-review.googlesource.com/c/1293573Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56855}
-
Michael Starzinger authored
This changes the encoding of values stored in exception objects from a typed uint16 array (a JSObject) to a {FixedArray} instead. Note that it increases the memory footprint of the encoding, but will allow accessing elements directly from generated code and also encode reference types properly. The memory footprint can/should be optimized only after the implementation is feature complete. R=clemensh@chromium.org BUG=v8:8341 Change-Id: If67c4e498d815e14f95d014e6a1f7a6725aa0b3a Reviewed-on: https://chromium-review.googlesource.com/c/1293371 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Marja Hölttä authored
BUG=v8:8179 Change-Id: Ic0d9af273a8a92177bf60e4be0dd5bddaf31868c Reviewed-on: https://chromium-review.googlesource.com/c/1292058Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56853}
-
Ross McIlroy authored
BUG=v8:8293 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic0e12cbcea76f76fce543714dee972c784095143 Reviewed-on: https://chromium-review.googlesource.com/c/1290795 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#56852}
-
Toon Verwaest authored
Change-Id: I16f68db6b7793e3d7839e0afcd7c5bd6753b0913 Reviewed-on: https://chromium-review.googlesource.com/c/1292063Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56851}
-
Stephan Herhut authored
Change the status files to only run on release bots and furthermore exclude those that run on an arm simultaor. This should still provide sufficient coverage while keeping resource usage at bay. Bug: v8:8331, v8:8332 Change-Id: I515e68929af660932a1224294bd09ebc05705324 Reviewed-on: https://chromium-review.googlesource.com/c/1292061Reviewed-by:
-
Hai Dang authored
This improves the performance of copying Smi or Object arrays if the new array is allocated in new space. Bug: v8:7980 Change-Id: I8e91a879f603d118b4bb1393e7b8b92f4c0b3696 Reviewed-on: https://chromium-review.googlesource.com/c/1283053 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Florian Sattler authored
BUG=v8:7926 Change-Id: Ib4dd3017c7d6f28025ab308063d7dedd0138dfa6 Reviewed-on: https://chromium-review.googlesource.com/c/1291470 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Toon Verwaest authored
This improves the error message for []=>{}. Now rather than pointing at ] and saying that's the unexpected token, it reports "SyntaxError: Malformed arrow function parameter list", pointing at [. Change-Id: I88457dc9f929a7c2b07b36ea798f11e9a7d24414 Reviewed-on: https://chromium-review.googlesource.com/c/1293369 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: -
Yang Guo authored
Bug: v8:8333 Change-Id: I04bb28f909a1c144f513964115b4f2dfaced3146 Reviewed-on: https://chromium-review.googlesource.com/c/1291372 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:897074 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I728572cda9a8914ee689eeee68a060b5713e4c6b Reviewed-on: https://chromium-review.googlesource.com/c/1290972Reviewed-by:
-
Ross McIlroy authored
BUG=v8:8293 Change-Id: Ic58ac512d5f32d26756e21ca929dda79f133a40e Reviewed-on: https://chromium-review.googlesource.com/c/1290982Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56844}
-
Toon Verwaest authored
Change-Id: I7d95c0263649c69ff960925fcbde49e0ba9fa064 Reviewed-on: https://chromium-review.googlesource.com/c/1292059Reviewed-by:
-
Andreas Haas authored
Two zones in ExecuteCompilation have the same scope, so we can combine them. In addition I moved measurement code at the end of the function so that we don't have to store the result of the compilation in a helper. R=clemensh@chromium.org Bug: v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3b4790fa62adbe361d41be188c7f0510b12d957c Reviewed-on: https://chromium-review.googlesource.com/c/1291072 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This adds an attribute field to the binary encoding of exception types in the exceptions and import section. Currently the attribute value is not used and expected to be zero, but it ensures the binary encoding is extensible for future changes. R=clemensh@chromium.org TEST=unittests/WasmModuleVerifyTest BUG=v8:8153 Change-Id: I6f0e10cb1b6515177d8200ebf1f4f0b122832868 Reviewed-on: https://chromium-review.googlesource.com/c/1291075 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
