- 25 Feb, 2020 1 commit
-
-
Clemens Backes authored
This is a reland of 78defee4 Original change's description: > [inspector] Check that wasm wrappers appear in profiles > > This extends the existing wasm profiling test to also check that > wasm-to-js and js-to-wasm wrappers appear in the profiles as expected. > It thus serves as a regression test for the status quo. > > R=bmeurer@chromium.org > > Bug: chromium:1054386 > Change-Id: I5d4d8e6a252c6eb266b910621fca43a6ff0837bd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066970 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66401} TBR=bmeurer@chromium.org Bug: chromium:1054386, v8:10266 Change-Id: Iae04c0564ee8f0330d61ce954d895a41497c5a85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071260Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66424}
-
- 24 Feb, 2020 2 commits
-
-
Clemens Backes authored
This reverts commit 78defee4. Reason for revert: Timeout on TSan: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/30410 Original change's description: > [inspector] Check that wasm wrappers appear in profiles > > This extends the existing wasm profiling test to also check that > wasm-to-js and js-to-wasm wrappers appear in the profiles as expected. > It thus serves as a regression test for the status quo. > > R=bmeurer@chromium.org > > Bug: chromium:1054386 > Change-Id: I5d4d8e6a252c6eb266b910621fca43a6ff0837bd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066970 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66401} TBR=clemensb@chromium.org,bmeurer@chromium.org Change-Id: Iac4299d5a4dc74041fbceac98cd2c2b96b9425df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1054386 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069328Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66406}
-
Clemens Backes authored
This extends the existing wasm profiling test to also check that wasm-to-js and js-to-wasm wrappers appear in the profiles as expected. It thus serves as a regression test for the status quo. R=bmeurer@chromium.org Bug: chromium:1054386 Change-Id: I5d4d8e6a252c6eb266b910621fca43a6ff0837bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066970Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66401}
-
- 10 Jan, 2020 1 commit
-
-
Sigurd Schneider authored
This CL adds timestamps to coverage updates. This is useful for clients, because between requesting a coverage update and collecting coverage data significant time may pass. This change allows precise attribution at what time a coverage update was taken. Change-Id: I65a9cccb0171e892b7dbe35d105d3ca246ba08d0 Bug: chromium:1022031 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1992435Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65696}
-
- 08 Oct, 2019 1 commit
-
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set|Tee)Local' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set|Tee)Local\b/kExprLocal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I1617f1b2a100685a3bf56218e76845a9481959c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847354Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64161}
-
- 16 May, 2019 2 commits
-
-
Jakob Gruber authored
Now that function counts are based on dedicated call counters instead of FeedbackVector::invocation_count, we can enable optimizations for block coverage modes. This significantly speeds up V8 with enabled coverage: Before this CL, the web-tooling-benchmark regressed by 70% (block count coverage vs. no coverage). With this CL, the regression is reduced to 40%. Bug: v8:6000,v8:9148 Change-Id: I6bb538bd66f32f016c66c1d1996bce3b25958232 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615241 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61582}
-
Jakob Gruber authored
Prior to this CL, call counts at function scope were taken from the FeedbackVector::invocation_count field. This had two major drawbacks: 1. for generator functions, these count the number of resumptions instead of the number of calls; and 2. the invocation count is not maintained in optimized code. The solution implemented here is to add a dedicated call counter at function scope which is incremented exactly once each time the function is called. A minor complication is that our coverage output format expects function-scope counts in the dedicated CoverageFunction object, and not as a CoverageBlock. Thus function-scope block counts are initially marked with magic positions, and later recognized and rewritten during processing. This CL thus fixes reported generator function call counts and enables optimizations in block coverage modes (more to come in a follow-up). Drive-by: Don't report functions with empty source ranges. Bug: v8:6000,v8:9148,v8:9212 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Idbe5edb35a595cf12b6649314738ac00efd173b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613996 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61574}
-
- 20 Feb, 2019 1 commit
-
-
Clemens Hammacher authored
This is a reland of 6202c445. Moved skipped test from 'variant == jitless' to 'lite_mode or variant == jitless'. Original change's description: > [inspector] Add wasm profiling test > > This adds a first simple test to check that CPU profiles contain wasm > function names. > > R=herhut@chromium.org, kozyatinskiy@chromium.org > > Bug: v8:8783 > Change-Id: I26b1fd2b7ec555c073d80a464ee8a799b017b07a > Reviewed-on: https://chromium-review.googlesource.com/c/1454597 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Stephan Herhut <herhut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59703} TBR=herhut@chromium.org Bug: v8:8783 Change-Id: I4f68db86bf1caa4f0d68dd4fa227ded25bf5145a Reviewed-on: https://chromium-review.googlesource.com/c/1477678Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59730}
-
- 19 Feb, 2019 2 commits
-
-
Sathya Gunasekaran authored
This reverts commit 6202c445. Reason for revert: times out on arm https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8921075891748393232/+/steps/Check_-_default/0/logs/console-profile-wasm/0 Original change's description: > [inspector] Add wasm profiling test > > This adds a first simple test to check that CPU profiles contain wasm > function names. > > R=herhut@chromium.org, kozyatinskiy@chromium.org > > Bug: v8:8783 > Change-Id: I26b1fd2b7ec555c073d80a464ee8a799b017b07a > Reviewed-on: https://chromium-review.googlesource.com/c/1454597 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Stephan Herhut <herhut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59703} TBR=yangguo@chromium.org,kozyatinskiy@chromium.org,clemensh@chromium.org,herhut@chromium.org Change-Id: Ib211a38a32ee08c18e4a19f05d9fc68d6a2d2901 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8783 Reviewed-on: https://chromium-review.googlesource.com/c/1475914Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#59704}
-
Clemens Hammacher authored
This adds a first simple test to check that CPU profiles contain wasm function names. R=herhut@chromium.org, kozyatinskiy@chromium.org Bug: v8:8783 Change-Id: I26b1fd2b7ec555c073d80a464ee8a799b017b07a Reviewed-on: https://chromium-review.googlesource.com/c/1454597 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#59703}
-
- 15 Feb, 2019 1 commit
-
-
Leszek Swirski authored
In addition to the previous change enabling forced FunctionDeclaration allocation when block code coverage is enabled, enable it now for all (non-best-effort) code coverage by reading off the coverage mode from the isolate (rather than relying on the presence of a source range map). Bug: chromium:927464 Change-Id: I26f86c9fbebc0df52d5cdeff3ca1095215a6d912 Reviewed-on: https://chromium-review.googlesource.com/c/1456041 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59626}
-
- 05 Feb, 2019 1 commit
-
-
Leszek Swirski authored
Preserve coverage for unused functions by force marking them used when code coverage is enabled. Bug: chromium:927464 Change-Id: Ia973467d06f7268f4e98cc76d0bb98cc591e979c Reviewed-on: https://chromium-review.googlesource.com/c/1454717 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59373}
-
- 25 Jan, 2019 1 commit
-
-
Leszek Swirski authored
Declare Variables with a name and position, rather than by passing through a VariableProxy. This allows us to not create dummy proxies for things like function declarations, and allows us to consider those declarations unused. As a side-effect, we also have to check if a variable is unused in the bytecode generator (as it will no longer be allocated), and we end up skip generating code/SFIs for dead variables/functions. Change-Id: I4c2c872473f23e124f9456b4b92f87159658f8e0 Reviewed-on: https://chromium-review.googlesource.com/c/1414916 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59088}
-
- 21 Dec, 2018 1 commit
-
-
Jakob Gruber authored
This changes a few bits about how continuation counters are handled. It introduces a new mechanism that allows removal of a continuation range after it has been created. If coverage is enabled, we run a first post-processing pass on the AST immediately after parsing, which removes problematic continuation ranges in two situations: 1. nested continuation counters - only the outermost stays alive. 2. trailing continuation counters within a block-like structure are removed if the containing structure itself has a continuation. R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org Bug: v8:8381, v8:8539 Change-Id: I6bcaea5060d8c481d7bae099f6db9f993cc30ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1339119Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58443}
-
- 13 Dec, 2018 1 commit
-
-
Ross McIlroy authored
Also disables --stress-flush-bytecode on some mjsunit tests which fail when bytecode flushing is stressed due to test invariants. Bug=v8:8395 Change-Id: If627910214b3c266e7776340ba182829148e8289 Reviewed-on: https://chromium-review.googlesource.com/c/1372071Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58230}
-
- 31 May, 2018 2 commits
-
-
Sergiy Byelozyorov authored
This reverts commit 003159e7. Reason for revert: breaks roll into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_headless_rel/3140 Original change's description: > [inspector] RemoteObject.description should be empty for primitive type > > We currently report description field for numbers. On client side user > can calculate description as remoteObject.unserializableValue || > (remoteObject.value + ''). Let's report description only for objects to > simplify value -> remoteObject logic a bit. > > R=dgozman@chromium.org > TBR=jgruber@chromium.org > > Bug: chromium:595206 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc > Reviewed-on: https://chromium-review.googlesource.com/737485 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53453} TBR=dgozman@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifc184e1ac158d9ea7034922a7250444448fac49f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1081207Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53461}
-
Alexey Kozyatinskiy authored
We currently report description field for numbers. On client side user can calculate description as remoteObject.unserializableValue || (remoteObject.value + ''). Let's report description only for objects to simplify value -> remoteObject logic a bit. R=dgozman@chromium.org TBR=jgruber@chromium.org Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc Reviewed-on: https://chromium-review.googlesource.com/737485 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#53453}
-
- 20 Nov, 2017 1 commit
-
-
jgruber authored
When collecting source ranges for conditionals (`a ? b : c`), include the '?' and ':' tokens in the then- and else ranges, respectively. Bug: v8:7098 Change-Id: I22315e2040c96c977e0b49e1fafe4228a6558471 Reviewed-on: https://chromium-review.googlesource.com/778321Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49484}
-
- 08 Sep, 2017 1 commit
-
-
Franziska Hinkelmann authored
JavaScript is a dynamically typed language. But most code is written with fixed types in mind. When debugging JavaScript, it is helpful to know the types of variables and parameters at runtime. It is often hard to infer types for complex code. Type profiling provides this information at runtime. Node.js uses the inspector protocol. This CL allows Node.js users to access and analyse type profile for via Node modules or the in-procress api. Type Profile helps developers to analyze their code for correctness and performance. Design doc: https://docs.google.com/a/google.com/document/d/1O1uepXZXBI6IwiawTrYC3ohhiNgzkyTdjn3R8ysbYgk/edit?usp=sharing Add `takeTypeProfile` to the inspector protocol. It returns a list of TypeProfileForScripts, which in turn contains the type profile for each function. We can use TypeProfile data to annotate JavaScript code. Sample script with data from TypeProfile: function f(/*Object, number, undefined*/a, /*Array, number, null*/b, /*boolean, Object, symbol*/c) { return 'bye'; /*string*/}; f({}, [], true); f(3, 2.3, {a: 42}); f(undefined, null, Symbol('hello'));/*string*/ Bug: v8:5933 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I626bfb886b752f90b9c86cc6953601558b18b60d Reviewed-on: https://chromium-review.googlesource.com/508588 Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47920}
-
- 28 Aug, 2017 1 commit
-
-
Yang Guo authored
This is so that precise coverage starts with a clean slate. The old behavior can be emulated by calling getBestEffortCoverage before starting precise coverage. R=jgruber@chromium.org Bug: chromium:757998 Change-Id: Ib3ee2316966f676456198159bdcf8ba8b9d3896f Reviewed-on: https://chromium-review.googlesource.com/635084 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47629}
-
- 23 Aug, 2017 1 commit
-
-
Yang Guo authored
Add "detailed" flag to Profiler.startPreciseCoverage to specify granularity (block coverage vs function coverage). The default value is currently set to FLAG_block_coverage, which is currently true. This is so that the V8 roll does not break LayoutTests. I'll set it to false once I made changes to Blink. R=jgruber@chromium.org, pfeldman@chromium.org Bug: v8:6738 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7242e897ab02713188a5292ca8c8bb58985e3a9b Reviewed-on: https://chromium-review.googlesource.com/625616Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47533}
-
- 10 Aug, 2017 1 commit
-
-
Michael Starzinger authored
This is in preparation to the removal of the FullCodeGenerator, we no longer need the ability to stress the underlying implementation. R=rmcilroy@chromium.org BUG=v8:6409 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Iad3177d6de4a68b57c12a770b6e85ed7a9710254 Reviewed-on: https://chromium-review.googlesource.com/584747Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47276}
-
- 07 Aug, 2017 1 commit
-
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: Iad6f815d2476c59a498b7f580ec664417e83c675 Reviewed-on: https://chromium-review.googlesource.com/600050 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47197}
-
- 02 Aug, 2017 2 commits
-
-
jgruber authored
Consider: function f() { return; } This CL ensures that the closing brace is considered as covered by introducing a special case for open-ended range rewrites when the parent range is the function range itself. Bug: v8:6000, v8:6661 Change-Id: I0be307759967e9f4df245a4f367326a37dda86fd Reviewed-on: https://chromium-review.googlesource.com/597651Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47079}
-
Julien Brianceau authored
Bug: chromium:750830 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Icab7b5a1c469d5e77d04df8bfca8319784e92af4 Reviewed-on: https://chromium-review.googlesource.com/595655 Commit-Queue: Julien Brianceau <jbriance@cisco.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47072}
-
- 31 Jul, 2017 2 commits
-
-
jgruber authored
This is a reland of 7bb6cd63 Original change's description: > [coverage] Ship block coverage > > Enables block coverage by default. > > Design doc: http://goo.gl/hSJhXn > Tracking bug: http://crbug.com/v8/6000 > > Bug: v8:6000 > Change-Id: I8c56474473b60e4707b75dc601b3e88455861a27 > Reviewed-on: https://chromium-review.googlesource.com/583093 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46898} Bug: v8:6000 Change-Id: I033d89a35c23fcff083f83103df45e33f7962d67 Reviewed-on: https://chromium-review.googlesource.com/592968 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47003}
-
Jakob Gruber authored
Function-granularity coverage skips functions that are both uncovered and have an uncovered parent. This optimization needs to be tweaked once block coverage and incremental collection is in play, as it is possible to have a function with invocation_count == 0 (i.e. uncovered at function granularity) that still has relevant block-granularity coverage. Bug: v8:6000 Change-Id: I4cc81b8a6935aa58e29d383ed4fa749cbfe69352 Reviewed-on: https://chromium-review.googlesource.com/589508Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46991}
-
- 27 Jul, 2017 1 commit
-
-
Michael Achenbach authored
This reverts commit 7bb6cd63. Reason for revert: layout tests Original change's description: > [coverage] Ship block coverage > > Enables block coverage by default. > > Design doc: http://goo.gl/hSJhXn > Tracking bug: http://crbug.com/v8/6000 > > Bug: v8:6000 > Change-Id: I8c56474473b60e4707b75dc601b3e88455861a27 > Reviewed-on: https://chromium-review.googlesource.com/583093 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46898} NOTRY=true TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: I51d6f13d3ad0d2d2262bdd8d67135931cbc27032 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6000 Reviewed-on: https://chromium-review.googlesource.com/588789Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46923}
-
- 26 Jul, 2017 1 commit
-
-
jgruber authored
Enables block coverage by default. Design doc: http://goo.gl/hSJhXn Tracking bug: http://crbug.com/v8/6000 Bug: v8:6000 Change-Id: I8c56474473b60e4707b75dc601b3e88455861a27 Reviewed-on: https://chromium-review.googlesource.com/583093 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#46898}
-
- 17 Jul, 2017 1 commit
-
-
jgruber authored
Bug: v8:6000 Change-Id: I2853d44d8bcf34b28630594cc9c2782046bd4b28 Reviewed-on: https://chromium-review.googlesource.com/573900Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46700}
-
- 14 Jul, 2017 1 commit
-
-
jgruber authored
Bug: v8:6000 Change-Id: I8c068383300ba869a87f836504c84ea08fcff87e Reviewed-on: https://chromium-review.googlesource.com/568307Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46675}
-
- 13 Jul, 2017 1 commit
-
-
Ross McIlroy authored
Removes the --ignition flag which is now on by default. Adds a --stress-fullcodegen flag which enables running all functions supported by fullcodegen to be compiled by fullcodegen. This will enable moving parser internalization later when we are not stressing fullcodegen or compiling asm.js functions. BUG=v8:5203, v8:6409, v8:6589 Change-Id: I7fa68016d4e734755434ec0b4e749ef65ffa7f4e Reviewed-on: https://chromium-review.googlesource.com/565569 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#46635}
-
- 07 Jul, 2017 1 commit
-
-
jgruber authored
This adds a new binary block coverage mode (in addition to the existing count block coverage), as well as a few transformation passes to reduce the number of uselessly reported ranges. Bug: v8:6000 Change-Id: I4fb234ca015990d00aa2f1dccb87f76ba4748994 Reviewed-on: https://chromium-review.googlesource.com/552642 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46463}
-
- 06 Jul, 2017 1 commit
-
-
jgruber authored
This CL adds a few transformations that clean up the set of reported source ranges. Duplicates, empty, and uncovered ranges are removed, and nested/consecutive ranges are merged if possible. BUG=v8:6000 Change-Id: I421ee35ce8292cfe84c1eea4f653762cea5d909d Reviewed-on: https://chromium-review.googlesource.com/558411Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46450}
-
- 23 Jun, 2017 2 commits
-
-
jgruber authored
Drive-by-fixes: Singleton ranges past EOF, disable optimization for block count mode. Bug: v8:6000 Change-Id: I718891f8821285ce3d7d8360faaa91a43de5b93d Reviewed-on: https://chromium-review.googlesource.com/541300Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46168}
-
jgruber authored
This piggy-backs on top of existing precise and best-effort coverage to expose block coverage through the inspector protocol. Coverage collection now implicitly reports block-granularity coverage when available. A new 'isBlockCoverage' property on Inspector's FunctionCoverage type specifies the granularity of reported coverage. For now, only count-based block coverage is supported, but binary block coverage should follow soon. Support is still gated behind the --block-coverage flag. Bug: v8:6000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I9c4d64e1d2a098e66178b3a68dcee800de0081af Reviewed-on: https://chromium-review.googlesource.com/532975 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#46157}
-
- 19 May, 2017 1 commit
-
-
dgozman authored
This refactoring makes it easier to write advanced tests and gives full control over what's happening to the test code. It also forces description for every test. BUG=none Review-Url: https://codereview.chromium.org/2891213002 Cr-Commit-Position: refs/heads/master@{#45412}
-
- 28 Apr, 2017 1 commit
-
-
Mythri authored
1. Replaces --crankshaft with --opt in tests. 2. Also fixes presubmit to check for --opt flag when assertOptimized is used. 3. Updates testrunner/local/variants.py and v8_foozie.py to use --opt flag. This would mean, nooptimize variant means there are no optimizations. Not even with %OptimizeFunctionOnNextCall. Bug:v8:6325 Change-Id: I638e743d0773a6729c6b9749e2ca1e2537f12ce6 Reviewed-on: https://chromium-review.googlesource.com/490206 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44985}
-
- 03 Apr, 2017 1 commit
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:6165 Review-Url: https://codereview.chromium.org/2794443002 Cr-Commit-Position: refs/heads/master@{#44329}
-
- 24 Mar, 2017 1 commit
-
-
yangguo authored
Only include function ranges for with non-0 counts or if the immediate outer function has non-0 count. R=caseq@chromium.org, jgruber@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2764073004 Cr-Original-Commit-Position: refs/heads/master@{#44079} Committed: https://chromium.googlesource.com/v8/v8/+/a7577ede0b74967727895eba5e06dbe1d01fb56d Review-Url: https://codereview.chromium.org/2764073004 Cr-Commit-Position: refs/heads/master@{#44120}
-