1. 06 Oct, 2020 1 commit
    • Ulan Degenbaev's avatar
      Revert "[heap] Convert WeakObjects to heap::base::Worklist" · a282d2e9
      Ulan Degenbaev authored
      This reverts commit 969cdfe6.
      
      Reason for revert: speculative revert for crbug.com/1135472
      
      Original change's description:
      > [heap] Convert WeakObjects to heap::base::Worklist
      >
      > This splits WeakObjects into explicit global and local worklists.
      > The latter are defined in WeakObjects::Local and are thread-local.
      >
      > The main thread local worklist is stored in
      > MarkCompactCollector::local_weak_objects and exists during marking
      > similar to local_marking_worklists. Concurrent markers create their
      > own local worklists that are published at the end.
      >
      > Change-Id: I093fdc580b4609ce83455b860b90a5099085beac
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2440607
      > Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#70317}
      
      TBR=ulan@chromium.org,dinfuehr@chromium.org
      
      Change-Id: I3fa3bfdcf3c359f46a3b56c19fb4e486883cde9d
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2452749Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#70344}
      a282d2e9
  2. 05 Oct, 2020 1 commit
  3. 25 Sep, 2020 1 commit
  4. 14 Sep, 2020 1 commit
  5. 10 Sep, 2020 3 commits
    • Omer Katz's avatar
      Reland "Reland "cppgc, heap: Don't eagerly allocate worklist segments"" · 5b9889d9
      Omer Katz authored
      This is a reland of f25cb50a
      
      Removed the problematic tests.
      The problem with the test was that we try to pop from an empty segment.
      GCC flags that as accessing beyond the array (i.e. index is uint16_t
      equivalent of -1). Preceding the actual pop is a DCHECK that asserts
      the segment isn't empty. In practice, since we have the DCHECK and
      access to the segment is always via a Local, this shouldn't be a
      problem.
      Unfortunately, GCC flags the access regardless. The DCHECK goes through
      a function pointer so GCC cannot determine that in our unittest the
      DCHECK would crash if index is 0 and the access would not happen (The
      indirection was added to allow for test DCHECK handlers that don't
      crash, so we can't mark the function pointer as noreturn).
      
      Drive-by: Segment::Pop and Segment::Push rely on the their Local
      counterparts checking of emptiness/fullness, so we should always
      access segments via Locals. Making the Segment ctor private.
      
      Original change's description:
      > Reland "cppgc, heap: Don't eagerly allocate worklist segments"
      >
      > This is a reland of c99147c6
      >
      > Original change's description:
      > > cppgc, heap: Don't eagerly allocate worklist segments
      > >
      > > Bug: chromium:1056170
      > > Change-Id: I75a6b5f52bfe8dd71abc086e5d1e060759ad7fc0
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391254
      > > Commit-Queue: Omer Katz <omerkatz@chromium.org>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#69778}
      >
      > Bug: chromium:1056170
      > Change-Id: I4633da065976a6b2710d2f23b946fd2af0e65c83
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401425
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Omer Katz <omerkatz@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#69806}
      
      Bug: chromium:1056170
      Change-Id: I7a122d1a2d20cd4e7c824d249975b4d3df30e03e
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403251Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Commit-Queue: Omer Katz <omerkatz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69829}
      5b9889d9
    • Maya Lekova's avatar
      Revert "Reland "cppgc, heap: Don't eagerly allocate worklist segments"" · 68b788ca
      Maya Lekova authored
      This reverts commit f25cb50a.
      
      Reason for revert: Fails compilation on gcc https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20gcc%20-%20debug/9026?
      
      Original change's description:
      > Reland "cppgc, heap: Don't eagerly allocate worklist segments"
      > 
      > This is a reland of c99147c6
      > 
      > Original change's description:
      > > cppgc, heap: Don't eagerly allocate worklist segments
      > >
      > > Bug: chromium:1056170
      > > Change-Id: I75a6b5f52bfe8dd71abc086e5d1e060759ad7fc0
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391254
      > > Commit-Queue: Omer Katz <omerkatz@chromium.org>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#69778}
      > 
      > Bug: chromium:1056170
      > Change-Id: I4633da065976a6b2710d2f23b946fd2af0e65c83
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401425
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Omer Katz <omerkatz@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#69806}
      
      TBR=ulan@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org
      
      Change-Id: I004173e2a82518a88e68eae3a6f7e96656c0ad7e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1056170
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403249Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69809}
      68b788ca
    • Omer Katz's avatar
      Reland "cppgc, heap: Don't eagerly allocate worklist segments" · f25cb50a
      Omer Katz authored
      This is a reland of c99147c6
      
      Original change's description:
      > cppgc, heap: Don't eagerly allocate worklist segments
      >
      > Bug: chromium:1056170
      > Change-Id: I75a6b5f52bfe8dd71abc086e5d1e060759ad7fc0
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391254
      > Commit-Queue: Omer Katz <omerkatz@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#69778}
      
      Bug: chromium:1056170
      Change-Id: I4633da065976a6b2710d2f23b946fd2af0e65c83
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401425Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Omer Katz <omerkatz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69806}
      f25cb50a
  6. 09 Sep, 2020 3 commits
  7. 07 Jul, 2020 1 commit
  8. 22 Jun, 2020 1 commit