Skip to content

V
V8
Switch branch/tag
  1. 09 Nov, 2016 1 commit
  3. 08 Nov, 2016 1 commit
    • lpy's avatar
      [Tracing] Use TracingCategoryObserver in gc statistics · 7d28301d
      lpy authored 
      This patch is a follow-up patch to enable gc statistics to use
TracingCategoryObserver.

Previously we need to pass --track_gc_object_stats to v8 if we want to enable
gc statistics in tracing. In this patch, we introducce an integer flag
FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
will set it to 0x01, tracing will set it to 0x10 when we start tracing and
reset the bit when we stop tracing.

BUG=v8:5590

Review-Url: https://codereview.chromium.org/2459903003
Cr-Commit-Position: refs/heads/master@{#40817}
      7d28301d
  5. 07 Nov, 2016 1 commit
  7. 05 Nov, 2016 1 commit
  9. 04 Nov, 2016 2 commits
  11. 03 Nov, 2016 3 commits
  13. 28 Oct, 2016 2 commits
    • lpy's avatar
      [Tracing] Implement TracingCategoryObserver. · 6df8096a
      lpy authored 
      This patch implements TracingCategoryObserver to set global flag when a V8
specific category is enabled. Previously, we set a global flag each time when we
encounter a top level trace event, and use it as a global check. With this
patch, we can set a group of flags when tracing is enabled; besides, we make
V8 tracing feature use V8 flags instead of defining its own flag in a messy way.

With this patch, whatever V8 flag we want to imply in tracing, we define another
integer flag, and the original V8 flag will set it to 0x01 when passing by
commandline, tracing will set it to 0x10 when we start tracing and reset the bit
when we stop tracing.

Review-Url: https://codereview.chromium.org/2436273002
Cr-Commit-Position: refs/heads/master@{#40659}
      6df8096a
    • lpy's avatar
      [Tracing] Fix inaccurate timer calculation in runtime statistics. · 92d9a56a
      lpy authored 
      Previously we reset runtime counters and dump them when we enter, exit top level
trace events respectively. However, there is gap between two top level trace
events and runtime counters may be activated, resetting the counters makes the
accumulated time inaccurate, and we may end up with negative time due to the
nature of how we accumulate time.

This patch fixes this problem by only resetting counters when there's no
counters active, and before dump counters, we traverse current active counters
to calculate their time, and then restart their timer.

BUG=chromium:658145

Review-Url: https://codereview.chromium.org/2457523002
Cr-Commit-Position: refs/heads/master@{#40653}
      92d9a56a
  15. 19 Oct, 2016 1 commit
  17. 12 Oct, 2016 1 commit
  19. 06 Oct, 2016 1 commit
  21. 27 Sep, 2016 2 commits
  23. 26 Sep, 2016 1 commit
  25. 22 Sep, 2016 1 commit
  27. 19 Sep, 2016 1 commit
  29. 08 Sep, 2016 1 commit
  31. 05 Sep, 2016 1 commit
    • fmeawad's avatar
      [RuntimeCallStats] Move tracing runtime instrumentation closer to the original version. · e5ba156d
      fmeawad authored 
      After we landed the tracing runtime call stats, which gave
us a lot of V8 insight in tracing, we noticed that there is
some arising issues and discrepancies.

Issues include:
Missing trace events, that happened due to
transforming those trace events into runtime calls

Discrepancies include:
Missing categories in Runtime call stats like GC,
because we are not handling the Scoped runtime calls
properly in the tracing version.

To reduce/eliminate those issue, we are taking a small
step back. We are unifying the RuntimeStats code and
using the original one. That would allow us to use all
the original probes but emit trace events from them.
We are also putting back the trace-events in their place.

The output from both system should be intact (Except of
the addition of the missing trace-events).

Also as a byproduct, we are reducing the number of context
scopes by half since we are using the same scope as
runtime call stats.

As a follow up to this CL, we will address the non-scoped
Runtime Call Stats (mainly in GC).
BUG=642373

Review-Url: https://codereview.chromium.org/2296243002
Cr-Commit-Position: refs/heads/master@{#39180}
      e5ba156d
  33. 26 Aug, 2016 1 commit
  35. 10 Aug, 2016 1 commit
  37. 08 Aug, 2016 1 commit
  39. 05 Aug, 2016 1 commit
  41. 03 Aug, 2016 4 commits
  43. 15 Jun, 2016 1 commit
  45. 14 Jun, 2016 1 commit
  47. 13 Jun, 2016 1 commit
  49. 12 Jun, 2016 1 commit
  51. 26 Feb, 2016 1 commit
    • fmeawad's avatar
      Reland: Add Scoped Context Info (Isolate) to V8 Traces · 567e5839
      fmeawad authored 
      This patch adds the newly added support for contexts in V8 Tracing, as well
as use it to mark all the entry points for a V8 Isolate.

Update for reland: The current tracing interface needs to be updated (AddTraceEvent),
but the embedders need to migrate to the new version before removing the old version.
(Reland of: https://codereview.chromium.org/1686233002)

The revert happened because the 2 signatures of the old and new AddTraceEvent where different
so it threw an overload-virtual error on cross arm debug. This issue is temporary, and to solve
it, I added an implementation of the old and new everywhere until the embedder implements the new.

BUG=v8:4565
LOG=N

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1704253002

Cr-Commit-Position: refs/heads/master@{#34332}
      567e5839
  53. 17 Feb, 2016 2 commits
  55. 16 Feb, 2016 1 commit
  57. 17 Dec, 2015 1 commit