1. 20 Jun, 2018 1 commit
  2. 26 Apr, 2018 2 commits
  3. 25 Apr, 2018 2 commits
  4. 31 Oct, 2017 1 commit
    • Mythri's avatar
      [TurboFan] Remove a check on nesting levels inlining heuristics · 5b38c7fc
      Mythri authored
      We have a check on maximum number of levels that can be inlined. This
      in some cases causes performance cliffs, when we cannot inline a small
      function because it has exceeded the number of levels. This cl removes
      that check. The intuition is that, having gone down several levels in
      a particular line stopping inlining that chain and exploring a new
      call site may not be beneficial. This cl also introduces a absolute
      limit on the number of nodes that can be inlined (including the small
      functions).
      
      Bug: v8:6871, chromium:779509
      Change-Id: Id29639ff2fd85b84d8746da3fb78a82d4e9852e8
      Reviewed-on: https://chromium-review.googlesource.com/743727Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Mythri Alle <mythria@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49050}
      5b38c7fc
  5. 30 Oct, 2017 1 commit
    • Michael Stanton's avatar
      Revert "[TurboFan] Remove maximum inlining levels check from inlining heuristics" · f585415a
      Michael Stanton authored
      This reverts commit ecd3a2ea.
      
      Reason for revert: Bug 779509, a crash with chrome.
      
      Original change's description:
      > [TurboFan] Remove maximum inlining levels check from inlining heuristics
      > 
      > We have a check on maximum number of levels that can be inlined. This
      > in some cases causes performance cliffs, when we cannot inline a small
      > function because it has exceeded the number of levels. This cl removes
      > that check. The intuition is that, having gone down several levels in
      > a particular line stopping inlining that chain and exploring a new
      > call site may not be beneficial.
      > 
      > Bug: v8:6871
      > Change-Id: I120056db38e78ce48dff010b6cf994259238582a
      > Reviewed-on: https://chromium-review.googlesource.com/741705
      > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
      > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49009}
      
      TBR=mythria@chromium.org,bmeurer@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:6871
      Change-Id: I4766f911cb326c224af110be5c0dd7a44362a880
      Reviewed-on: https://chromium-review.googlesource.com/743785Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49037}
      f585415a
  6. 27 Oct, 2017 1 commit
  7. 23 Oct, 2017 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] improve this value for arrow function in scopes · a11b0d96
      Alexey Kozyatinskiy authored
      Currently we incorrectly show global object as arrow function receiver.
      With this CL:
      - if this is used inside of function we show correct this value,
      - if this is unused and V8 optimizes it out - we show undefined.
      
      Second is known issue which we should address separately.
      
      R=dgozman@chromium.org,yangguo@chromium.org
      
      Bug: chromium:552753
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Iac88a07fe622eb9b2f8af7ecbc4a32a56c8cdfaa
      Reviewed-on: https://chromium-review.googlesource.com/723840
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48839}
      a11b0d96
  8. 11 Sep, 2017 1 commit
  9. 29 Aug, 2017 1 commit
  10. 18 Aug, 2017 1 commit
    • Ben L. Titzer's avatar
      [frames] Unpack FrameSummary early in FrameInspector. · 5b0c1c65
      Ben L. Titzer authored
      This CL is a precursor to the callback-based enumeration of frame summaries.
      It removes the reliance of FrameInspector on having a cached copy of the
      FrameSummary, instead unpacking it to instance variables so that clients
      of FrameInspector do not need to get information from two sources
      (the FrameSummary and the FrameInspector itself).
      
      R=yangguo@chromium.org
      
      Bug: 
      Change-Id: Ib388566c2e1a1147ee0a581323932982a29ae4ff
      Reviewed-on: https://chromium-review.googlesource.com/618334
      Commit-Queue: Ben Titzer <titzer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47420}
      5b0c1c65
  11. 27 Jul, 2017 1 commit