- 13 Sep, 2016 21 commits
-
-
hpayer authored
BUG=chromium:630386 Review-Url: https://codereview.chromium.org/2239733002 Cr-Commit-Position: refs/heads/master@{#39382}
-
bmeurer authored
When lowering DataField accesses, we should pay attention to the MachineRepresentation reported by the AccessInfo. This doesn't yet change the rest of the pipeline to take full advantage of the representations. Drive-by-fix: Make the code more robust, especially the part that deals with mutable heap number access. R=mvstanton@chromium.org BUG=v8:5267,v8:5270 Review-Url: https://codereview.chromium.org/2334193002 Cr-Commit-Position: refs/heads/master@{#39381}
-
hpayer authored
BUG=chromium:630386 Review-Url: https://codereview.chromium.org/2337943002 Cr-Commit-Position: refs/heads/master@{#39380}
-
bmeurer authored
When inlining sloppy functions try to find some witness in the effect chain that the receiver is already a JSReceiver and thereby avoid inserting the JSConvertReceiver node, which we currently cannot really optimize away most of the time. Middle-term we may want to change the way CheckMaps works and have some unified mechanism to deal with effect chain walks to find witnesses for various map related facts. Also we may want to consider doing this optimization later, although that requires some more refactorings since we already promised that JSConvertReceiver gives a Type::Receiver. R=mstarzinger@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2333213002 Cr-Commit-Position: refs/heads/master@{#39379}
-
leszeks authored
Moves the context chain search loop out of generated bytecode, and into the (Lda|Ldr|Sda)ContextSlot handler, by passing the context depth in as an additional operand. This should decrease the bytecode size and increase performance for deep context chain searches, at the cost of slightly increasing bytecode size for shallow context access. Review-Url: https://codereview.chromium.org/2336643002 Cr-Commit-Position: refs/heads/master@{#39378}
-
mvstanton authored
To make better inlining decisions, it's good to have call counts for poly/mega-morphic cases. This CL makes it work for calls, and another will follow to better unify the code between constructor calls and normal calls (and thence, to record megamorphic call counts there as well). BUG= Review-Url: https://codereview.chromium.org/2325083003 Cr-Commit-Position: refs/heads/master@{#39377}
-
ishell authored
BUG=v8:5269 Review-Url: https://codereview.chromium.org/2325013004 Cr-Commit-Position: refs/heads/master@{#39376}
-
ivica.bogosavljevic authored
BUG= Review-Url: https://codereview.chromium.org/2331843004 Cr-Commit-Position: refs/heads/master@{#39375}
-
ulan authored
We check for external memory limit in Heap::ReportExternalMemoryPressure. BUG=chromium:616434 Review-Url: https://codereview.chromium.org/2329993002 Cr-Commit-Position: refs/heads/master@{#39374}
-
mstarzinger authored
This makes sure OSR entry points can be added without having special {OsrPoll} instructions in the bytecode stream. Eventually we might end up merging back-branches and OSR polls together. Any loop header can be used as an OSR entry point. R=bmeurer@chromium.org BUG=v8:4764 Review-Url: https://codereview.chromium.org/2329933003 Cr-Commit-Position: refs/heads/master@{#39373}
-
ishell authored
BUG=v8:5269 Review-Url: https://codereview.chromium.org/2327103002 Cr-Commit-Position: refs/heads/master@{#39372}
-
bmeurer authored
Don't sort inline candidates by comparing Node pointers, where the order depends on the allocation order and the concrete Zone memory layout at runtime. Instead sort based on NodeId, which is deterministic. R=mvstanton@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2336113002 Cr-Commit-Position: refs/heads/master@{#39371}
-
machenbach authored
BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2328233002 Cr-Commit-Position: refs/heads/master@{#39370}
-
machenbach authored
BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2322163003 Cr-Commit-Position: refs/heads/master@{#39369}
-
bmeurer authored
Also unify the Pow implementation somewhat. There are still some inconsistencies with the FPU version for x64/ia32, but that has to be resolved separately. R=ahaas@chromium.org, mvstanton@chromium.org BUG=v8:5086 Review-Url: https://codereview.chromium.org/2333663002 Cr-Commit-Position: refs/heads/master@{#39368}
-
machenbach authored
BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2328293002 Cr-Commit-Position: refs/heads/master@{#39367}
-
bmeurer authored
Add strength reduction rules to optimize CheckTaggedSigned(CheckTaggedSigned(x)) -> CheckTaggedSigned(x) and CheckTaggedPointer(CheckTaggedPointer(x)) -> CheckTaggedPointer(x) where we do some cleanup optimizations after loop peeling and redundancy elimination, which can generate these constructs. BUG=v8:5267 Review-Url: https://codereview.chromium.org/2336093002 Cr-Commit-Position: refs/heads/master@{#39366}
-
bmeurer authored
Reduce compilation time (with clang) for opcodes-unittest.cc from 1m38s to roughly 1s by not overusing the macro expansion magic. TBR=jarin@chromium.org Review-Url: https://codereview.chromium.org/2331413002 Cr-Commit-Position: refs/heads/master@{#39365}
-
bmeurer authored
Cleanup fix addressing the comment on crrev.com/2325943002. TBR=jarin@chromium.org,brucedawson@chromium.org Review-Url: https://codereview.chromium.org/2335083002 Cr-Commit-Position: refs/heads/master@{#39364}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2336023002 Cr-Commit-Position: refs/heads/master@{#39363}
-
kozyatinskiy authored
Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2337523003 Cr-Commit-Position: refs/heads/master@{#39362}
-
- 12 Sep, 2016 19 commits
-
-
mtrofin authored
This change avoids needing to keep around an unused compiled module. Instead, the result of compiling the wasm bytes is given to the first instance. The module object and that instance object point to the same compiled module. Instances are, then, cloned from the compiled module the module object points to. When an instance is collected, we make sure that the module object still has a clone available, and, if the last instance is GC-ed, we also reset the compiled module so that it does not reference its heap, so that it (==heap) may be collected. This is achieved by linking the clones in a double-linked list and registering a finalizer for each. When we create an instance, we tie it in the front of the list, making the module object point to it (O(1)). When the finalizer is called, we relink the list over the dying object (O(1)). The costliest operation is finalizing the last instance, since we need to visit all wasm functions and reset heap references. BUG=v8:5316 Committed: https://crrev.com/01f5af515728aebe6c5246f4f7dd6c573e8748af Review-Url: https://codereview.chromium.org/2305903002 Cr-Original-Commit-Position: refs/heads/master@{#39153} Cr-Commit-Position: refs/heads/master@{#39361}
-
mtrofin authored
Moved the compilation/instantiation pipeline to work off the module object (JSObject), making the compiled module data (the FixedArray) an implementation detail. This: - simplifies the code by removing duplicate decode->compile->instantiate sequences - sets up the stage for "dressing up" the runtime model with stronger typed APIs - helps relanding this CL: https://codereview.chromium.org/2305903002/. It turns out that GCs during the cloning/instantiation events cause trouble, and centering the source of truth on the module object helps address this issue. In the process, clarified cctest setup for wasm-capable isolates, and changed signatures for consistency (using ModuleOrigin througout). BUG= Review-Url: https://codereview.chromium.org/2320723005 Cr-Commit-Position: refs/heads/master@{#39360}
-
cbruni authored
The raw pointer to the parameter_map might get stale in case of accessors present on the arguments object. Drive-by-fix: use nullptr instead of the_hole with isolate access. BUG=chromium:645680 Review-Url: https://codereview.chromium.org/2332503002 Cr-Commit-Position: refs/heads/master@{#39359}
-
jarin authored
BUG=chromium:645851 Review-Url: https://codereview.chromium.org/2332633002 Cr-Commit-Position: refs/heads/master@{#39358}
-
adamk authored
The whitelist is populated with those inline intrinsics that are lowered in JSIntrinsicInlining and were not previously blacklisted. Thus the only additional FrameStates this CL adds are those where the caller tries to call the INLINE version of an intrinsic but ends up calling the RUNTIME version instead. R=bmeurer@chromium.org BUG=chromium:644631 Review-Url: https://codereview.chromium.org/2331543002 Cr-Commit-Position: refs/heads/master@{#39357}
-
bjaideep authored
Backtrace() and backtrace_symbols() API are not supported on AIX and there are no user-mode equivalent API for the same. For now, disabling the call to those API. Currently this is preventing V8 to build on AIX. This debug functionality was added in https://codereview.chromium.org/2248393002 R=rmcilroy@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2324453002 Cr-Commit-Position: refs/heads/master@{#39356}
-
v8-autoroll authored
Rolling v8/base/trace_event/common to 26eac53e73b09625e9b8f783b479e54fcae85f58 Rolling v8/build to 9d601d07a9adaa2719d114290e79084d429a7dab Rolling v8/third_party/WebKit/Source/platform/inspector_protocol to f9c1216417fe8e8f99d861a4d9cf360ae1d8645e Rolling v8/tools/clang to 4ac706a04b38c05a8012257dc657e069134902c7 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2331963002 Cr-Commit-Position: refs/heads/master@{#39355}
-
ishell authored
BUG=v8:5269 Review-Url: https://codereview.chromium.org/2322373002 Cr-Commit-Position: refs/heads/master@{#39354}
-
ulan authored
Reland "[heap] Fix a formatting bug in --trace-incremental-marking. (patchset #2 id:20001 of https://codereview.chromium.org/2324623004/ )" This reverts commit 6c2a217e. The performance regression in crbug.com/645411 was not caused by the original CL. TBR=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2329983002 Cr-Commit-Position: refs/heads/master@{#39353}
-
neis authored
This adds partial support of exports to the runtime system and to the interpreter. It introduces a new HeapObject JSModule that maps each of the module's export names to a Cell containing the exported value. Several aspects of this implementation are subject to change in follow-up CLs. BUG=v8:1569 Committed: https://crrev.com/241a0412eed919395a2e163b30b9b66071ce5c17 Review-Url: https://codereview.chromium.org/2302783002 Cr-Original-Commit-Position: refs/heads/master@{#39341} Cr-Commit-Position: refs/heads/master@{#39352}
-
ahaas authored
With this CL the wasm-code-fuzzer first decodes and interprets the test case generated by the fuzzer. It then compiles the test case, but only executes the compiled instance if the interpretation of the test case was successful. If the compiled instance is executed, then the result of the execution is compared with the result of the interpretation. Additionally this CL refactors the CompileAndRunWasmModule function in wasm-module.cc to resuse code in the call to the interpreter. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2321443002 Cr-Commit-Position: refs/heads/master@{#39351}
-
ishell authored
BUG=v8:5269 Review-Url: https://codereview.chromium.org/2325013003 Cr-Commit-Position: refs/heads/master@{#39350}
-
bmeurer authored
We shall not mix AVX and SSE instructions as that can cause performance regressions in some areas, so make sure to emit vsqrtsd instead of sqrtsd when AVX is enabled. R=ahaas@chromium.org Review-Url: https://codereview.chromium.org/2335603002 Cr-Commit-Position: refs/heads/master@{#39349}
-
ulan authored
This patch changes incremental marking work scheduling from combination of idle/delayed tasks to ordinary short-running tasks and moves more marking work from V8.Execute to tasks by accounting how much bytes were marked in tasks. BUG=chromium:616434 LOG=NO Review-Url: https://codereview.chromium.org/2321553002 Cr-Commit-Position: refs/heads/master@{#39348}
-
petermarshall authored
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng BUG=v8:5364 Review-Url: https://codereview.chromium.org/2313393005 Cr-Commit-Position: refs/heads/master@{#39347}
-
rmcilroy authored
Rework Runtime::FunctionForName to take a c-string instead of a v8::String so that the parser can parse native syntax runtime calls without doing on-the-fly internalization. Also adds a c-string variant of IntrinsicIndexForName for the same reasons. BUG=v8:5215,chromium:634953 Review-Url: https://codereview.chromium.org/2324803002 Cr-Commit-Position: refs/heads/master@{#39346}
-
neis authored
Revert of [modules] Basic support of exports (patchset #10 id:180001 of https://codereview.chromium.org/2302783002/ ) Reason for revert: Failures related to deopt. Original issue's description: > [modules] Basic support of exports > > This adds partial support of exports to the runtime system and > to the interpreter. It introduces a new HeapObject JSModule that > maps each of the module's export names to a Cell containing the > exported value. > > Several aspects of this implementation are subject to change in > follow-up CLs. > > BUG=v8:1569 > > Committed: https://crrev.com/241a0412eed919395a2e163b30b9b66071ce5c17 > Cr-Commit-Position: refs/heads/master@{#39341} TBR=adamk@chromium.org,rmcilroy@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Review-Url: https://codereview.chromium.org/2328283002 Cr-Commit-Position: refs/heads/master@{#39345}
-
neis authored
R=rmcilroy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2331913002 Cr-Commit-Position: refs/heads/master@{#39344}
-
Alexander.Gilday2 authored
Migrate ToNumber platform builtin to TurboFan. Also move NonNumberToNumber builtin implementation to helper function. BUG=v8:5049 Review-Url: https://codereview.chromium.org/2327703003 Cr-Commit-Position: refs/heads/master@{#39343}
-