- 09 Dec, 2015 2 commits
-
-
jkummerow authored
In particular, return Maybe<bool> from any function that can throw, and use MAYBE_RETURN and RETURN_FAILURE macros consistently where applicable. No change in behavior intended. Review URL: https://codereview.chromium.org/1513713002 Cr-Commit-Position: refs/heads/master@{#32723}
-
jkummerow authored
JSProxy::HasProperty was missing an early "return Nothing<bool>". KeyAccumulator's FilterProxyKeys() didn't handle SKIP_STRINGS correctly. BUG=v8:1543 LOG=n R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1505253002 Cr-Commit-Position: refs/heads/master@{#32699}
-
- 03 Dec, 2015 1 commit
-
-
jkummerow authored
Not exposed/used yet, therefore also not testable yet. Review URL: https://codereview.chromium.org/1491743008 Cr-Commit-Position: refs/heads/master@{#32571}
-
- 02 Dec, 2015 2 commits
-
-
jkummerow authored
Split out of PropertyAttributes, and used for all filtering purposes. Also moved PropertyAttributes into the v8::internal:: namespace. No change in behavior intended. Review URL: https://codereview.chromium.org/1492653004 Cr-Commit-Position: refs/heads/master@{#32525}
-
jkummerow authored
And use it to fix Object.keys() for proxies. BUG=v8:1543 LOG=n R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1488873003 Cr-Commit-Position: refs/heads/master@{#32496}
-
- 28 Nov, 2015 3 commits
-
-
jkummerow authored
Both are integrated into JSReceiver::GetKeys(). For now, the implementation ignores Symbol/DONT_ENUM filtering. BUG=v8:1543 LOG=n Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97 Cr-Commit-Position: refs/heads/master@{#32384} Review URL: https://codereview.chromium.org/1474083003 Cr-Commit-Position: refs/heads/master@{#32386}
-
machenbach authored
Revert of [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]] (patchset #3 id:40001 of https://codereview.chromium.org/1474083003/ ) Reason for revert: [Sheriff] Speculative revert for gc mole: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/5164 Original issue's description: > [proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]] > > Both are integrated into JSReceiver::GetKeys(). > > For now, the implementation ignores Symbol/DONT_ENUM filtering. > > BUG=v8:1543 > LOG=n > > Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97 > Cr-Commit-Position: refs/heads/master@{#32384} TBR=verwaest@chromium.org,bmeurer@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1543 Review URL: https://codereview.chromium.org/1482113002 Cr-Commit-Position: refs/heads/master@{#32385}
-
jkummerow authored
Both are integrated into JSReceiver::GetKeys(). For now, the implementation ignores Symbol/DONT_ENUM filtering. BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1474083003 Cr-Commit-Position: refs/heads/master@{#32384}
-
- 04 Nov, 2015 1 commit
-
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1425403002 Cr-Commit-Position: refs/heads/master@{#31788}
-