- 05 May, 2021 1 commit
-
-
Daniel Dromboski authored
These should all be forward/backward compatible with Python 2/Python 3. [tools] Tweak statusfile.py for Python 3 .iteritems() does not exist in Python 3, only .items(). (While .iteritems() was meant to be an optimization over .items() in Python 2, .items() should work fine, and it is forward/backward compatible.) [tools] Fix another Python 3 issue in mb.py sys.platform used to return e.g. 'linux2', which is 'linux' plus whatever the first digit of `uname -r` was when Python was built. As of Python 3.3, it always returns just 'linux' for Linux OSes. Use `sys.platform.startswith('linux')` for forward/backward compatibility. [tools] Make base_runner.py Python 3 compatible dict.keys() returns a dict_keys in Python 3, whereas it used to return a simple array. list() is forward/backward compatible with identical results on Python 2/3 (returns array). (Tested on Linux x64, trying to recreate NodeJS's CI workflow.) [tools] Make tools/dev/v8gen.py work with Python 3 dict.keys() returns a dict_keys in Python 3, whereas it used to return a simple array. list() is forward/backward compatible with identical results on Python 2/3 (returns array). Comparing a None-type value numerically used to result in the None-type value always being considered "less than" the thing it is compared to. As of Python 3, numerically comparing against None or None-typed values results in an error. Check if a value is truthy before numerically comparing it, for forward/backward compatibility. print() used to transparently decode byte strings in Python 2. In Python 3, they must be explicitly decoded first. (Tested on Linux 64-bit, trying to recreate NodeJS's CI workflow.) Bug: v8:9871 Change-Id: I059bf98577a67649bbe7ec49848989d468da96b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2867270Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74369}
-
- 11 Feb, 2021 1 commit
-
-
Pierre Langlois authored
Bug: v8:11361 Change-Id: Ie36b612907fab01c269567e901494d2c7ea01b6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2689192Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#72654}
-
- 28 Jan, 2021 1 commit
-
-
Sathya Gunasekaran authored
Looks like this was broken by the renaming in https://chromium-review.googlesource.com/c/v8/v8/+/2627309 Bug: v8:11361 Change-Id: I07c74a847171070a6a9296f3f6e1ef1f45002c66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2651700Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#72384}
-
- 19 Feb, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
There are now less that 400 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 You can see the reports here: https://travis-ci.com/bmsdave/v8/builds This CL was uploaded by git cl split. Bug: v8:8594 Change-Id: I661c52a70527e8ddde841fee6d4dcba282b4a938 Reviewed-on: https://chromium-review.googlesource.com/c/1470123 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59675}
-
- 02 Nov, 2016 1 commit
-
-
dschuff authored
'a' and 'w' are mutually exclusive and just 'a' is what we actually want. Linux doesn't care (it just takes the first one) but Windows throws a ValueError. R=machenbach@chromium.org BUG=None Review-Url: https://codereview.chromium.org/2467363002 Cr-Commit-Position: refs/heads/master@{#40711}
-
- 22 Sep, 2016 1 commit
-
-
machenbach authored
BUG=chromium:648583 NOTRY=true Review-Url: https://codereview.chromium.org/2365573002 Cr-Commit-Position: refs/heads/master@{#39626}
-
- 02 Sep, 2016 1 commit
-
-
machenbach authored
This prepares using mb as a library and not as a sub process. It is used like that in the new list command that shows available configurations. Also added more robust checks of user inputs, better hints and better docu. BUG=chromium:625791 NOTRY=true Review-Url: https://codereview.chromium.org/2300333002 Cr-Commit-Position: refs/heads/master@{#39136}
-
- 21 Jul, 2016 1 commit
-
-
machenbach authored
Helper script to generate gn arguments based on common developer defaults or builder configurations. BUG=chromium:625791 NOTRY=true Review-Url: https://codereview.chromium.org/2138693002 Cr-Commit-Position: refs/heads/master@{#37947}
-