- 03 Dec, 2021 1 commit
-
-
Michael Lippautz authored
Bug: chromium:1276129 Change-Id: I5d47e50c0b778e6ac1fbdbc8660c471c74424322 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312272 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78224}
-
- 24 Nov, 2020 1 commit
-
-
Georg Neis authored
Apart from removing Min and Max (utils.h), this is mostly a renaming. In a few cases I had to add a cast. In a bunch of cases I had to use initializer lists to force call-by-value for static member constants because call-by-reference wouldn't compile (like in the previous CL). In a few places I used initializer lists in place of nested min/max operations. Bug: v8:11074 Change-Id: I53a5411be6334ff41e7a8517e6b87fb46f14d086 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545523 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#71380}
-
- 06 Jun, 2019 1 commit
-
-
Ulan Degenbaev authored
If the embedder specifies an initial heap size, then we can take it as a hint to skip full GCs below that threshold. Bug: v8:9306 Change-Id: I42a4c597bf75c6ba9845ed7a6bd9946012979005 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646515Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62030}
-
- 31 May, 2019 1 commit
-
-
Ulan Degenbaev authored
The size is now computed as a fraction of the old space size: - for low memory devices (<512MB) the fraction is 1 / 256. - for all other devices the fraction is 1 / 128. The values were chosen to minimize the difference between the new and the old heuristics. Bug: v8:9306 Change-Id: I3246fe2d6fc589af6220e2566e3f10fb13470b82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632158Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61947}
-
- 23 May, 2019 1 commit
-
-
Michael Lippautz authored
Rework limit computation: - Model controller as static classes based on traits. - Compute growing factors for both controllers and pick the larger growing factor for both controllers. - Factor out limit computation in its own function. Bug: chromium:948807 Change-Id: Id466a66d7aa573de91ad388ea9218e9f6721d19a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627534 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61801}
-
- 22 May, 2019 3 commits
-
-
Michael Lippautz authored
Provide a global memory controller used to compute limits for combined on-heap and embedder memory. The global controller uses the same mechanism (gc speed, mutator speed) and growing factors as the regular on-heap controller. Rely on V8's mechanisms for configured state that stops shrinking the limit. Reland: - API fixes with overrides and default versions. - Fix of depending on uninitialized values when using the old API. - GCTracer: Fixed issue in speed computation. - GCTracer: Added unittests. This reverts commit 5e043f27. Bug: chromium:948807 Change-Id: I0f81253b3e1a8b49a7ac107c012a15e33cb514d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622852Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61735}
-
Yang Guo authored
Bug: v8:9247 Change-Id: I79e0553e8a0d6dac2aa16b94a6c0e05b6ccde4a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621934 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61725}
-
Clemens Hammacher authored
This reverts commit dac86be2. Reason for revert: Still failing msan: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/26904 Original change's description: > Reland "[heap] Add global memory controller" > > Provide a global memory controller used to compute limits for combined > on-heap and embedder memory. The global controller uses the same > mechanism (gc speed, mutator speed) and growing factors as the regular > on-heap controller. > > Rely on V8's mechanisms for configured state that stops shrinking the > limit. > > This reverts commit 5e043f27. > > Tbr: ulan@chromium.org > Bug: chromium:948807 > Change-Id: Id4f94e7dcb458d1d0d2f872194f8f3ea0959a73f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622968 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61715} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: If30649f158a08fd185f2771a13b8e09cf53fb667 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:948807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622849Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61716}
-
- 21 May, 2019 3 commits
-
-
Michael Lippautz authored
Provide a global memory controller used to compute limits for combined on-heap and embedder memory. The global controller uses the same mechanism (gc speed, mutator speed) and growing factors as the regular on-heap controller. Rely on V8's mechanisms for configured state that stops shrinking the limit. This reverts commit 5e043f27. Tbr: ulan@chromium.org Bug: chromium:948807 Change-Id: Id4f94e7dcb458d1d0d2f872194f8f3ea0959a73f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622968Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61715}
-
Michael Lippautz authored
This reverts commit cfe281f3. Reason for revert: Fails on gcc bots Original change's description: > [heap] Add global memory controller > > Provide a global memory controller used to compute limits for combined > on-heap and embedder memory. The global controller uses the same > mechanism (gc speed, mutator speed) and growing factors as the regular > on-heap controller. > > Rely on V8's mechanisms for configured state that stops shrinking the > limit. > > Bug: chromium:948807 > Change-Id: I3283a2c28e6ab889f8d2ad85c9b67b8f234b9900 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619762 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61712} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,bikineev@chromium.org Change-Id: I503d5a1436eb9156556b5bca852d2b2f9da2446f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:948807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622967Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61713}
-
Michael Lippautz authored
Provide a global memory controller used to compute limits for combined on-heap and embedder memory. The global controller uses the same mechanism (gc speed, mutator speed) and growing factors as the regular on-heap controller. Rely on V8's mechanisms for configured state that stops shrinking the limit. Bug: chromium:948807 Change-Id: I3283a2c28e6ab889f8d2ad85c9b67b8f234b9900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619762 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61712}
-
- 17 May, 2019 1 commit
-
-
Michael Lippautz authored
- Move generic pieces into MemoryController. - Keep V8's specific factor computations in HeapController. Bug: chromium:948807 Change-Id: I1c1fc0516a429b19ce6458f75888b3f9d51824ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617678 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61626}
-
- 15 May, 2019 1 commit
-
-
Clemens Hammacher authored
The 'z' length modifier for {size_t} in format strings was introduced with C99, hence it is available in all environments we support. R=jgruber@chromium.org, mlippautz@chromium.org Bug: v8:9183 Change-Id: I1bc2abec3f9c7b38186128202fef4719853de7d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1613243Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61536}
-
- 15 Feb, 2019 1 commit
-
-
Jakob Kummerow authored
This takes heap-inl.h out of the "Giant Include Cluster". Naturally, that means adding a bunch of explicit includes in a bunch of places that relied on transitively including them before. As of this patch, no header file outside src/heap/ includes heap-inl.h. Bug: v8:8562,v8:8499 Change-Id: I65fa763f90e66afc30d105b9277792721f05a6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1459659 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59617}
-
- 10 Sep, 2018 1 commit
-
-
Michael Lippautz authored
Split off from https://chromium-review.googlesource.com/c/v8/v8/+/1196484 Bug: chromium:879045 Change-Id: I58b1a2ad10729f54c9a452dcfecd7511660460f6 Reviewed-on: https://chromium-review.googlesource.com/1216285 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55764}
-
- 30 Aug, 2018 1 commit
-
-
Michael Lippautz authored
Revert "Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery."" This reverts commit eb164dbd. Revert "[d8] Fixed external gc test (limit multiplied by number of isolates)." This reverts commit 38cbc26a. Revert "[heap] Fixed typo in method name." This reverts commit 263174af. Bug: chromium:845409, chromium:879045 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I555bcff2ad04ae23368c7b3999a237083010f9c6 Reviewed-on: https://chromium-review.googlesource.com/1196550Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55529}
-
- 28 Aug, 2018 1 commit
-
-
Rodrigo Bruno authored
Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This is a reland of ba735dde Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} Bug: chromium:845409 Change-Id: Iaff177f7bebbc073460fab0ae4e5cd9e632e1921 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1177301Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55454}
-
- 14 Aug, 2018 2 commits
-
-
Sathya Gunasekaran authored
Revert "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This reverts commit ba735dde. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21991 Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} TBR=ulan@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: Iaf65227c65c11effa11662ac7d7bd7736f4d7846 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1174858Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55129}
-
Rodrigo Bruno authored
Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b Reviewed-on: https://chromium-review.googlesource.com/1160162 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55128}
-
- 09 Aug, 2018 1 commit
-
-
Rodrigo Bruno authored
The HeapController is now refactored in a way that new controllers only need to specify the constants that define how a space grows and shrinks. Bug: chromium:845409 Change-Id: I804eed440a791d6fbd232b7540a1cbe66b16a5f1 Reviewed-on: https://chromium-review.googlesource.com/1165347 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55006}
-
- 02 Aug, 2018 1 commit
-
-
Rodrigo Bruno authored
This CL introduces a new MemoryController that will be used to control the size of external memory (array buffers and external string for now). Bug: chromium:845409 Change-Id: I119506ce0243ac33cec2b783b888b53ee11225a9 Reviewed-on: https://chromium-review.googlesource.com/1156393 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54854}
-
- 21 Jun, 2018 2 commits
-
-
Rodrigo Bruno authored
Bug: chromium:852748 Change-Id: Iac1c52d45e84af190415aeae5df167ab501b4bc4 Reviewed-on: https://chromium-review.googlesource.com/1109821Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#53918}
-
Rodrigo Bruno authored
Bug: chromium:852748 Change-Id: Ifdadf3188815fe38741e6f0e817070972e7f445b Reviewed-on: https://chromium-review.googlesource.com/1108205 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53904}
-
- 08 Jun, 2018 1 commit
-
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: If1fbb03258fdfae528069ba37bbef0395ddb230d Reviewed-on: https://chromium-review.googlesource.com/1090920Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#53608}
-
- 07 Jun, 2018 1 commit
-
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I377d6f9d26a193f7fd829f7b74f9fdabc1337dc0 Reviewed-on: https://chromium-review.googlesource.com/1089053 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53580}
-