- 26 Nov, 2018 36 commits
-
-
Ulan Degenbaev authored
This patch gives DescriptorArray its own visitor id and its own layout that is independent from the layout of WeakFixedArray. This allows us to use raw 16-bit integers for keeping track of the number of descriptors (total, non-slack, and marked). As a side-effect, we save one word per descriptor array on 64-bit. v8:8486 Change-Id: If8389dde446319e5b3491abc948b52539dba235c Reviewed-on: https://chromium-review.googlesource.com/c/1349245 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57845}
-
Ben L. Titzer authored
Flag flip to enable this feature. R=mstarzinger@chromium.org Bug: v8:8423 Change-Id: I59ee8c49c2f0323a32e8c7e6c9cf8d929b4a8bb4 Reviewed-on: https://chromium-review.googlesource.com/c/1349239 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57844}
-
George Wort authored
This implements copy sign for both the arm32 and arm64 port of Liftoff. Bug: v8:6600 Change-Id: Ic822e75417c6b911a03e8e9a2d6d59a98fbc3d18 Reviewed-on: https://chromium-review.googlesource.com/c/1348430 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57843}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I920c4ac8e66a7f29c28fcc62a0b1ea62370bdf5d Reviewed-on: https://chromium-review.googlesource.com/c/1350993Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57842}
-
George Wort authored
This implements arithmetic operations on f64, as well as conditional set for the arm32 port of Liftoff. Bug: v8:6600 Change-Id: Ia060652e5292ed94da8a0ba656bddbcc13d9f610 Reviewed-on: https://chromium-review.googlesource.com/c/1348349 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57841}
-
Daniel Clifford authored
In the process, use the correct ArrayPrototype* naming convention for the slice and splice builtins. Change-Id: I1f85e5512dbde8f92e7c764aef9f137d0a6693e0 Reviewed-on: https://chromium-review.googlesource.com/c/1350869Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#57840}
-
Mike Stanton authored
CL "[Cleanup] String::GetChars() should assert against heap allocation" was missing one DisallowHeapAllocation declaration. (I had Michi look over the change, as the callstack actually comes from the garbage collector. Marja, I put you on TBR). Thanks all.. TBR=marja@chromium.org No-tree-checks: true No-try: true Bug: v8:8238 Change-Id: I71333124bc4bcef945430fc5242a516b6ed277ff Reviewed-on: https://chromium-review.googlesource.com/c/1351013 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57839}
-
Clemens Hammacher authored
For indirect calls, we need to set up the tables correctly. This CL adds this to the test case generation logic. R=ahaas@chromium.org Change-Id: I18a5a8e0659c46daec00d46d02fe50d5d94638d6 Reviewed-on: https://chromium-review.googlesource.com/c/1349985Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57838}
-
Clemens Hammacher authored
Indirect calls rely on fixed signature indexes. Thus make test case generation output the signatures exactly like they appear in the module. R=ahaas@chromium.org Change-Id: I80b088024da759ec87695363aeefb28685e1d704 Reviewed-on: https://chromium-review.googlesource.com/c/1350831Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57837}
-
Marja Hölttä authored
BUG=v8:5402,v8:8238 Change-Id: Idd00fc664da8173612266ba7a976b383bb1f728e Reviewed-on: https://chromium-review.googlesource.com/c/1349329 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57836}
-
Ben L. Titzer authored
This CL adds new Wasm import call kinds that correspond to various math functions that can be imported from JavaScript, such as trigonometry. Instead of calling a special import wrapper that converts arguments to tagged values by boxing, we can now generate calls to little WASM stubs that contain a single WASM bytecode each. R=mstarzinger@chromium.org BUG=v8:8423 Change-Id: I59b1be2dd36d190a8b6c98b88c86cecc0ca7f4a2 Reviewed-on: https://chromium-review.googlesource.com/c/1349279 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57835}
-
Tobias Tebbi authored
This reverts commit 41ad531f. Reason for revert: https://crbug.com/907498 Original change's description: > [turbofan] in-block scheduling: schedule non-effect-chain nodes late > > By giving higher priority to processing non-effect-chain nodes, this > changes the scheduling inside of basic blocks to place nodes before the > latest possible effect chain node. > > Change-Id: I8b130904a1bb2360b995eb9de4f471a911a4e388 > Reviewed-on: https://chromium-review.googlesource.com/c/1337743 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57656} TBR=mstarzinger@chromium.org,tebbi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I76e57a25c157beed364455b0f1b55380305ef6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1350989Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57834}
-
Leszek Swirski authored
No-tree-checks: true No-try: true Change-Id: I7f2d5806a94f381849e395f590f943eb8b1a0196 Reviewed-on: https://chromium-review.googlesource.com/c/1350994 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#57833}
-
Michael Starzinger authored
R=leszeks@chromium.org TEST=cctest/test-icache No-Tree-Checks: true Change-Id: Ied26bb04d844a7585444a8bb48e12865133a4e81 Reviewed-on: https://chromium-review.googlesource.com/c/1350990 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57832}
-
Leszek Swirski authored
This is a reland of ca086a49 Original change's description: > [parser] Perfect hash for keywords > > Use gperf to generate a perfect hash table for keyword lookup. Adds a > python script which munges the output of gperf and adds additional > cleanup and optimisations. > > Change-Id: I3656a7287dbd0688917893de3a671faef9e4578a > Reviewed-on: https://chromium-review.googlesource.com/c/1349240 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57790} Change-Id: Ifb53527ba3d0652ea4f5d03740f7c856ad5d91da Reviewed-on: https://chromium-review.googlesource.com/c/1350121Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57831}
-
Camillo Bruni authored
Bug: v8:8238 Change-Id: I0f3b8336a63bb4e1859997b7b9f150f1e7b2d988 Reviewed-on: https://chromium-review.googlesource.com/c/1346338 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57830}
-
Andreas Haas authored
The flag is only available in d8 and should therefore not be in flag-definitions.h. R=clemensh@chromium.org Bug: v8:8238 Change-Id: Idd69914cea03e736cf3b156b5961d583a7b5352c Reviewed-on: https://chromium-review.googlesource.com/c/1349244 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57829}
-
Benedikt Meurer authored
We cannot assign a meaningful type to Promise#catch() or Promise#finally(), since they both return whatever the invocation of 'then' on the receiver returns, and that is monkeypatchable by arbitrary user JavaScript. Bug: chromium:908309, v8:7253 Change-Id: Ib15f81c366938a1b1f10be6c6af85c1f3374b898 Reviewed-on: https://chromium-review.googlesource.com/c/1350789Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57828}
-
Toon Verwaest authored
Change-Id: Ib584fa4fa38d1f042dc7220f516e35c0619ace45 Reviewed-on: https://chromium-review.googlesource.com/c/1350127Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57827}
-
Michael Starzinger authored
R=ulan@chromium.org BUG=v8:6792,v8:8157 Change-Id: Idf43b4dc74ad7ba89142f2480ed8632adf75f8ec Reviewed-on: https://chromium-review.googlesource.com/c/1348069 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57826}
-
Aleksandar Rikalo authored
Addition to d0562944. Bug: chromium:896326 Change-Id: Ie76f6be778e963ad5205a99853f491b164dddf9a Reviewed-on: https://chromium-review.googlesource.com/c/1349269Reviewed-by: Predrag Rudic <prudic@wavecomp.com> Reviewed-by: Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57825}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: Ie0a6eeb42b57db2309403acd23e986f73cb33afe Reviewed-on: https://chromium-review.googlesource.com/c/1350123 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57824}
-
Jakob Gruber authored
The ProfileEntryHookStub is no longer used and can be removed. Bug: v8:7777, v8:8503 Change-Id: I4ccd75d38cfee3e7963338d5d8213915db9be4a9 Reviewed-on: https://chromium-review.googlesource.com/c/1349191 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57823}
-
Sigurd Schneider authored
This script counts lines of code before and after preprocessor expansion. When running: tools/locs.py --build-dir out.gn/repro --smallest --largest --worst in the v8 directory, it reports: Processed 1,520 files in 24.62 sec. src ( 625 files): 365,679 to 53,468,383 ( 146.22x) third_party ( 432 files): 239,081 to 9,502,094 ( 39.74x) gen ( 19 files): 64,040 to 1,415,287 ( 22.10x) total ( 1520 files): 1,173,349 to 102,831,949 ( 87.64x) test ( 392 files): 489,865 to 37,476,036 ( 76.50x) Largest 3 files after expansion: 33,495 to 140,401 ( 4.19x) gen/torque-generated/builtins-array-from-dsl-gen.cc 100,014 to 140,111 ( 1.40x) ../../test/cctest/gay-precision.cc 100,014 to 140,110 ( 1.40x) ../../test/cctest/gay-shortest.cc Worst expansion (3 files): 6 to 100,826 (14403.71x) ../../test/fuzzer/wasm-data-section.cc 6 to 100,826 (14403.71x) ../../test/fuzzer/wasm-function-sigs-section.cc 6 to 100,826 (14403.71x) ../../test/fuzzer/wasm-globals-section.cc Smallest 3 input files: 0 to 0 ( 0.00x) ../../testing/gtest/empty.cc 1 to 0 ( 0.00x) ../../src/x64/simulator-x64.cc 4 to 4,423 ( 884.60x) ../../buildtools/third_party/libc++/trunk/src/utility.cpp Notry: true Change-Id: Ie1da942463d9e6a84338a9bd57d9ddc46d2856dc Reviewed-on: https://chromium-review.googlesource.com/c/1349571 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57822}
-
Mike Stanton authored
R=jkummerow@chromium.org Bug: v8:8238 Change-Id: Ie28326ebe6c69e194857aed7b5d49cb8e5a40a29 Reviewed-on: https://chromium-review.googlesource.com/c/1349243Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#57821}
-
Jakob Gruber authored
It's been failing for a while, and looks like we reach some arbitrary heap limit, triggering an early OOM before the debugger hook is set. Bug: v8:8494 Change-Id: I472dc8955ba2f0eb018ac6e7ca83e4beaaefc318 Reviewed-on: https://chromium-review.googlesource.com/c/1350830Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57820}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I325b10268a9ed9548fd28ecc3e5e2b0959afcdc4 Reviewed-on: https://chromium-review.googlesource.com/c/1350125Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57819}
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Change-Id: I8b8651e499c2d862ae9f81a18af11d610214c0cd Reviewed-on: https://chromium-review.googlesource.com/c/1350118 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57818}
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Change-Id: If9e39eb64db24e7d7dd2ae639d95f750aef04210 Reviewed-on: https://chromium-review.googlesource.com/c/1350119 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57817}
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Change-Id: I88fb20bb78df733fb135d2103b38908926a9d512 Reviewed-on: https://chromium-review.googlesource.com/c/1350115 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57816}
-
Toon Verwaest authored
No-Tree-Checks: true No-Try: true Bug: chromium:908231 Change-Id: I1acf33400ad3546974a0ccb5955f8c6966b17dcf Reviewed-on: https://chromium-review.googlesource.com/c/1350116 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57815}
-
Marja Hölttä authored
- Remove heap-inl.h includes from places where it looked unnecessary. (This is a non-scientific approach, because it's probably pulled in indirectly anyway.) - Annotate places which include heap-inl.h because they need heap/ internals. - ACCESSORS legitimately needs heap-inl.h because of Heap::FromWritableHeapObject. - Add includes to heap/heap-write-barrier(-inl).h - A bunch of IWYU fixes discovered when working on this CL (includes which were missing because heap-inl.h pulls them in indirectly). BUG=v8:7490,v8:8238,v8:8499 Change-Id: I00f9a74d430f13d7c080dca77a92b03bcca7ef96 Reviewed-on: https://chromium-review.googlesource.com/c/1349241Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57814}
-
Toon Verwaest authored
Bug: chromium:908250 Change-Id: I414255f00bf7dcec0cf8b35e314a2b9b78a9116e Reviewed-on: https://chromium-review.googlesource.com/c/1350117 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57813}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I106b783899cef2f124450f8cc266b3b2ac09b4ae Reviewed-on: https://chromium-review.googlesource.com/c/1350114Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57812}
-
Maya Lekova authored
This reverts commit ca086a49. Reason for revert: Seems to be the cause for https://bugs.chromium.org/p/chromium/issues/detail?id=908296 Original change's description: > [parser] Perfect hash for keywords > > Use gperf to generate a perfect hash table for keyword lookup. Adds a > python script which munges the output of gperf and adds additional > cleanup and optimisations. > > Change-Id: I3656a7287dbd0688917893de3a671faef9e4578a > Reviewed-on: https://chromium-review.googlesource.com/c/1349240 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57790} TBR=marja@chromium.org,leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia0cc283f21e9f6793522c46a1fd40ba2d88597fb Reviewed-on: https://chromium-review.googlesource.com/c/1350113Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#57811}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b471e77..2339062 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id6d0f397d17a6602222e109de565b41ff7451d0b Reviewed-on: https://chromium-review.googlesource.com/c/1350284 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57810}
-
- 25 Nov, 2018 3 commits
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Id515906744a738d5d40dbb6dee15e243623f020c Reviewed-on: https://chromium-review.googlesource.com/c/1349111 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57809}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fa87ce6..b471e77 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie8d912df3b6c2cdb4688fca4070e58734ed412f1 Reviewed-on: https://chromium-review.googlesource.com/c/1350269Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57808}
-
Jakob Kummerow authored
Removing the temporarily duplicated classes FixedArrayPtr and FixedArrayBasePtr. Bug: v8:3770 Change-Id: I056ad74ff69593e9f134ef5c976766812c4d9275 Reviewed-on: https://chromium-review.googlesource.com/c/1345913 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#57807}
-
- 24 Nov, 2018 1 commit
-
-
Sigurd Schneider authored
This reverts commit 81b5f713. Revert "[heap] Cleanup embedder tracing APIs" This reverts commit ce02d86b. Tbr: mlippautz@chromium.org Change-Id: I5900ac3c070c93b869c9173316a466d39287713a Reviewed-on: https://chromium-review.googlesource.com/c/1350111Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57806}
-