- 25 Nov, 2015 1 commit
-
-
adamk authored
Also fix CheckConflictingVarDeclarations() to properly handle legacy const bindings. Without that change enabling the flag causes code like: function f() { const x; var x; } to throw an early error, rather than wait to throw the error until f is invoked. The previous patch ran into problems with the fuzzer; that crash was fixed (with test coverage added) in https://crrev.com/ceb92ebfdfb561d71038793c02b42aa973f55ec4 BUG=v8:811 LOG=y TBR=rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1473243006 Cr-Commit-Position: refs/heads/master@{#32306}
-
- 24 Nov, 2015 2 commits
-
-
adamk authored
Revert of Move --harmony-destructuring-bind to shipping (patchset #5 id:80001 of https://codereview.chromium.org/1451843002/ ) Reason for revert: Fails on V8 Fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/6028 Original issue's description: > Move --harmony-destructuring-bind to shipping > > Also fix CheckConflictingVarDeclarations() to properly handle > legacy const bindings. Without that change enabling the flag > causes code like: > > function f() { const x; var x; } > > to throw an early error, rather than wait to throw the error > until f is invoked. > > BUG=v8:811 > LOG=y > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/515093630a4a925a66d550561e38293d49633f10 > Cr-Commit-Position: refs/heads/master@{#32222} TBR=rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Review URL: https://codereview.chromium.org/1470333002 Cr-Commit-Position: refs/heads/master@{#32226}
-
adamk authored
Also fix CheckConflictingVarDeclarations() to properly handle legacy const bindings. Without that change enabling the flag causes code like: function f() { const x; var x; } to throw an early error, rather than wait to throw the error until f is invoked. BUG=v8:811 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1451843002 Cr-Commit-Position: refs/heads/master@{#32222}
-
- 17 Nov, 2015 1 commit
-
-
caitpotter88 authored
Per http://tc39.github.io/ecma262/#sec-identifiers-static-semantics-early-errors (13.2.2), make it a SyntaxError if an Identifier has the same StringValue as a ReservedWord. BUG=v8:2222, v8:1972 LOG=N R=adamk@chromium.org, rossberg@chromium.org, wingo@chromium.org Review URL: https://codereview.chromium.org/1429983002 Cr-Commit-Position: refs/heads/master@{#32052}
-
- 09 Nov, 2015 1 commit
-
-
caitpotter88 authored
Remove some non-standard code that doesn't do anything anyways. While FireFox uses this to set the default value for the multiline flag, it is nonstandard and slated for removal. The matching behaviour has never been implemented in either JSC or V8, so there is little web-compat risk. The only possible risk could be someone depending on the ToBoolean() behaviour of the flag, but this seems unlikely. BUG=v8:3870 LOG=N R=adamk@chromium.org, littledan@chromium.org, yangguo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1417733012 Cr-Commit-Position: refs/heads/master@{#31882}
-
- 05 Nov, 2015 1 commit
-
-
littledan authored
This patch moves ES2015 ToLength semantics on array operations, etc to from staging to shipping. R=adamk BUG=v8:3087 LOG=Y Review URL: https://codereview.chromium.org/1433473003 Cr-Commit-Position: refs/heads/master@{#31810}
-
- 04 Nov, 2015 1 commit
-
-
mstarzinger authored
This removes special casing for the 'f.arguments' property accessor. Any local 'arguments' variable should not be allowed to influence the value returned by the indirect 'f.arguments' property. That property creates a new object with a separate identity everytime it is read. This is by now consistent with other browsers. R=rossberg@chromium.org TEST=mjsunit/arguments-indirect Review URL: https://codereview.chromium.org/1408983006 Cr-Commit-Position: refs/heads/master@{#31776}
-
- 03 Nov, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org TEST=mozilla/js1_5/Regress/regress-343713 Review URL: https://codereview.chromium.org/1424313007 Cr-Commit-Position: refs/heads/master@{#31749}
-
- 30 Oct, 2015 2 commits
-
-
machenbach authored
Revert of Remove RegExp.multiline accessors. (patchset #3 id:40001 of https://codereview.chromium.org/1410993008/ ) Reason for revert: [Sheriff] Causes layout test failures. Original issue's description: > Remove RegExp.multiline accessors. > > This is non-standard and not even documented on MDN. > > On Firefox, setting RegExp.multiline to true adds the multiline flag to all > newly created RegExp objects (both from constructor and from literal). > > In V8 this has no effect. > > Source archaelogy shows that this is from the initial commit. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/e8f752ce0c2a488e88cd87fe75f3907b4303d0a0 > Cr-Commit-Position: refs/heads/master@{#31673} TBR=bmeurer@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1431433004 Cr-Commit-Position: refs/heads/master@{#31679}
-
yangguo authored
This is non-standard and not even documented on MDN. On Firefox, setting RegExp.multiline to true adds the multiline flag to all newly created RegExp objects (both from constructor and from literal). In V8 this has no effect. Source archaelogy shows that this is from the initial commit. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1410993008 Cr-Commit-Position: refs/heads/master@{#31673}
-
- 23 Oct, 2015 1 commit
-
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1423753002 Cr-Commit-Position: refs/heads/master@{#31520}
-
- 20 Oct, 2015 3 commits
-
-
Benedikt Meurer authored
Revert "[turbofan] Stage --turbo-inlining behind --turbo flag." and "[turbofan] Skip more tests that fail with --turbo-inlining." This reverts commit 019f9408, 6ed05f44 and e34c343d. TBR=mstarzinger@chromium.org BUG=v8:4493 LOG=n Review URL: https://codereview.chromium.org/1413183004 . Cr-Commit-Position: refs/heads/master@{#31393}
-
Benedikt Meurer authored
TBR=mstarzinger@chromium.org BUG=v8:4493 LOG=n Review URL: https://codereview.chromium.org/1415843002 . Cr-Commit-Position: refs/heads/master@{#31388}
-
mstarzinger authored
This stages the general purpose inlining mechanism in TurboFan and also disables the remaining tests that still fail. We do this to get test coverage early and to avoid regressing inlining as we go along. R=bmeurer@chromium.org BUG=v8:4493 LOG=n Review URL: https://codereview.chromium.org/1412703002 Cr-Commit-Position: refs/heads/master@{#31386}
-
- 19 Oct, 2015 1 commit
-
-
machenbach authored
BUG=chromium:535160 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1411213002 Cr-Commit-Position: refs/heads/master@{#31370}
-
- 16 Oct, 2015 1 commit
-
-
machenbach authored
BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1409113002 Cr-Commit-Position: refs/heads/master@{#31336}
-
- 29 Sep, 2015 1 commit
-
-
dusan.m.milosavljevic authored
TEST= BUG= Review URL: https://codereview.chromium.org/1334793004 Cr-Commit-Position: refs/heads/master@{#31011}
-
- 24 Sep, 2015 1 commit
-
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1367933002 Cr-Commit-Position: refs/heads/master@{#30906}
-
- 17 Sep, 2015 3 commits
-
-
jkummerow authored
Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Original review: https://codereview.chromium.org/1348653003/ This reverts commit 5f44a910. NOTRY=true Review URL: https://codereview.chromium.org/1356613002 Cr-Commit-Position: refs/heads/master@{#30798}
-
jkummerow authored
Revert of [test] Fix cctest path separators on Windows (patchset #2 id:20001 of https://codereview.chromium.org/1348653003/ ) Reason for revert: mozilla tests are failing on Windows Original issue's description: > [test] Fix cctest path separators on Windows > > Now run-tests.py understands "suite/foo/bar" with forward slashes for > command-line test selection on all test suites on all platforms. > > Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; > that behavior is sacrificed here in favor of unification. For the cctest > suite, OTOH, it wasn't possible on Windows to select specific tests at all. > > Committed: https://crrev.com/b36cfdb39ae648b49a1396c4f669df9b1f57996c > Cr-Commit-Position: refs/heads/master@{#30794} TBR=machenbach@google.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1349163002 Cr-Commit-Position: refs/heads/master@{#30795}
-
jkummerow authored
Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Review URL: https://codereview.chromium.org/1348653003 Cr-Commit-Position: refs/heads/master@{#30794}
-
- 01 Sep, 2015 2 commits
-
-
machenbach authored
TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1320443008 Cr-Commit-Position: refs/heads/master@{#30511}
-
machenbach authored
TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1307123003 Cr-Commit-Position: refs/heads/master@{#30494}
-
- 31 Aug, 2015 1 commit
-
-
littledan authored
This is a change for ES2015. Date objects have mutable state, so having a mutable prototype is bad for SES requirements, and it is an inconsistency from the typical ES2015 class style of objects BUG=v8:4004 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1317403002 Cr-Commit-Position: refs/heads/master@{#30486}
-
- 27 Jul, 2015 1 commit
-
-
yangguo authored
This reverts commit 1f61ac50. TBR=littledan@chromium.org BUG=chromium:513160 LOG=N Review URL: https://codereview.chromium.org/1256193002 Cr-Commit-Position: refs/heads/master@{#29866}
-
- 24 Jul, 2015 2 commits
-
-
machenbach authored
Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (patchset #1 id:1 of https://codereview.chromium.org/1243053005/) Reason for revert: [Sheriff] This causes a breakage with custom snapshot (bisected locally): http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/1190 Original issue's description: > Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" > > $toLength is slow, causing a 3.8%-8% regression in the Octane RegExp > benchmark. Reverting this patch brings it back up. To make this change, > we'll need a faster implementation fo $toLength. > > BUG=chromium:513160 > LOG=Y > R=adamk > > Committed: https://crrev.com/477d651c6a978bdf34954048a235895c62dab0ac > Cr-Commit-Position: refs/heads/master@{#29830} TBR=adamk@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:513160 Review URL: https://codereview.chromium.org/1254723005 Cr-Commit-Position: refs/heads/master@{#29835}
-
littledan authored
$toLength is slow, causing a 3.8%-8% regression in the Octane RegExp benchmark. Reverting this patch brings it back up. To make this change, we'll need a faster implementation fo $toLength. BUG=chromium:513160 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1243053005 Cr-Commit-Position: refs/heads/master@{#29830}
-
- 16 Jul, 2015 1 commit
-
-
littledan authored
ES2015 made a change vs ES5, where the "lastIndex" property of a RegExp (which can be modified by a user to start the next search at a different location) is cast to an integer with ToLength rather than ToInteger. The main difference is on negative numbers, and this is tested by test262. This patch implements that change on RegExps and enables the test262 test now that it passes. R=adamk LOG=Y BUG=v8:4244 Review URL: https://codereview.chromium.org/1241713004 Cr-Commit-Position: refs/heads/master@{#29715}
-
- 11 Jun, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org BUG=v8:4131 LOG=N Review URL: https://codereview.chromium.org/1177743002 Cr-Commit-Position: refs/heads/master@{#28935}
-
- 13 Apr, 2015 1 commit
-
-
arv authored
This reverts commit e965a1f8. The reason is that it breaks jsfiddle.com BUG=476437, v8:4001 LOG=N R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1086673002 Cr-Commit-Position: refs/heads/master@{#27791}
-
- 08 Apr, 2015 1 commit
-
-
arv authored
BUG=v8:4001 LOG=N R=adamk@chromium.org, rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1051373002 Cr-Commit-Position: refs/heads/master@{#27680}
-
- 07 Apr, 2015 1 commit
-
-
mstarzinger authored
This enables eager optimization of top-level code with TurboFan and extends test coverage by triggering it with the --always-opt flag. Script contexts are now also properly allocated in TurboFan. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1053063003 Cr-Commit-Position: refs/heads/master@{#27633}
-
- 13 Mar, 2015 1 commit
-
-
arv authored
ES6 specs the function length property (it was not part of ES5) and it makes it configurable. BUG=v8:3045 LOG=N R=mstarzinger@chromium.org, adamk@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/993073002 Cr-Commit-Position: refs/heads/master@{#27190}
-
- 03 Feb, 2015 1 commit
-
-
balazs.kilvady authored
BUG= Review URL: https://codereview.chromium.org/894123002 Cr-Commit-Position: refs/heads/master@{#26392}
-
- 21 Jan, 2015 3 commits
-
-
bmeurer authored
TBR=machenbach@chromium.org BUG=v8:3837 LOG=n Review URL: https://codereview.chromium.org/864073002 Cr-Commit-Position: refs/heads/master@{#26203}
-
Benedikt Meurer authored
TBR=yangguo@chromium.org BUG=v8:3837 LOG=n Review URL: https://codereview.chromium.org/861233002 Cr-Commit-Position: refs/heads/master@{#26196}
-
verwaest authored
BUG=259443 LOG=y Review URL: https://codereview.chromium.org/861623002 Cr-Commit-Position: refs/heads/master@{#26189}
-
- 12 Jan, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org TEST=mozilla/js1_5/Regress/regress-396684 BUG=v8:3786 Review URL: https://codereview.chromium.org/832713005 Cr-Commit-Position: refs/heads/master@{#26026}
-
- 17 Dec, 2014 2 commits
-
-
erikcorry authored
R=marja@chromium.org BUG= Review URL: https://codereview.chromium.org/810053002 Cr-Commit-Position: refs/heads/master@{#25873}
-
erik.corry authored
R=marja@chromium.org BUG= Review URL: https://codereview.chromium.org/798713004 Cr-Commit-Position: refs/heads/master@{#25858}
-