- 18 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
This CL fixes all occurences that don't require special OWNER reviews, or can be reviewed by Michi. After this one, we should be able to reenable the readability/check cpplint check. R=mstarzinger@chromium.org Bug: v8:6837, v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ic81d68d5534eaa795b7197fed5c41ed158361d62 Reviewed-on: https://chromium-review.googlesource.com/721120 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48670}
-
- 30 Nov, 2015 1 commit
-
-
bradnelson authored
Shifts of integer values are in some contexts collapsed by the parser into single literal AST nodes, rather than a direct representation of the parse tree. Confirming this behavior in tests. Integer TypedArrays are assumed to load and store "intish" values rather than more fine-grained type information. Reducing the precision of the typing information to match the spec and simplify the wasm generator. The asm spec requires load and store values of various "float?", "floatish", "double?" and "intish" types to ensure undefined values are not visible and that float32 rounding occurs at the right time. More closely matching this. Adding additional testing around unsigned / signed comparisons, loads and stores. Adding addition debug mode printing when asserting about types fail. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator, wasm side tests R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1471073003 Cr-Commit-Position: refs/heads/master@{#32419}
-
- 31 Aug, 2015 2 commits
-
-
bradnelson authored
Assume a zone is in scope instead of a handles object. Move INT32_TYPE into test-typing-reset. Provide a CHECK_SKIP() macro to allow skipping sections of an ast expression walk. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-typing-reset, test-ast-expression-visitor R=rossberg@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1319983004 Cr-Commit-Position: refs/heads/master@{#30484}
-
bradnelson authored
Unbounded is defined in terms of None any Any, which don't require an explicit zone. Switching Unbounded to be the same. BUG= None TEST= trybots R= titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1322003002 Cr-Commit-Position: refs/heads/master@{#30482}
-
- 24 Aug, 2015 1 commit
-
-
bradnelson authored
Adding an AstExpressionVisitor to touch each expression node in an AST. Adding TypingReseter to clear the slate after a failed asm.js validation that has set partial typing information. Adding a ExpressionTypeCollector to walk the expressions in an AST and emit them as a string for testing. Adding tests of the above. LOG=N BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-typing-reset,test-ast-expression-visitor R=rossberg@chromium.org,titzer@chromium.org Review URL: https://codereview.chromium.org/1288773007 Cr-Commit-Position: refs/heads/master@{#30336}
-