- 20 Apr, 2022 24 commits
-
-
Camillo Bruni authored
- Use explicit options when running gmcole.py from run-gcmole.py - Use gcmole.py-relative paths to find the default V8 root dir for maximum convenience when running locally Change-Id: Iba0da90b99b0321129f1c4099f437c76dabb1186 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582386Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80058}
-
Camillo Bruni authored
We do change CWD in the script which breaks relative input paths to d8 and .js files for instance. Drive-by-fix: - Show clear warning if `perf record` failed Change-Id: Ib900ca6b53307e13be459beba1e96ddfc8ee9b79 No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593784Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80057}
-
Al Muthanna Athamina authored
Bug: v8:12802 Change-Id: I2573ed6b59fe51a135bbec5734ff1b7414316b0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596163Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#80056}
-
Thibaud Michaud authored
R=clemensb@chromium.org CC=gdeepti@chromium.org Bug: v8:12284 Change-Id: Idddb0b7648b29612fa0308520ca2fc2a3e5647f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593218Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80055}
-
Victor Gomes authored
The register allocator might be able to choose between a floating or general registers. Bug: v8:7700 Change-Id: Ib74b8c6cd5db12ae34b7f08cd2aeb21ffd3bac33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596121Reviewed-by:
-
Jakob Gruber authored
This adds the OSR state to the FV, where the state consists of the osr_urgency (same semantics as previously on the BytecodeArray) and a maybe_has_optimized_osr_code bit (set if any optimized OSR Turbofan code exists for this function). The two are packed into one field for efficient OSR checks in generated code (to be implemented in the followup CL). Bug: v8:12161 Change-Id: Id4edb8f5db0bf02e0d04b87aeec8d8c53e213503 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596120 Commit-Queue: Jakob Linke <jgruber@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
Omer Katz authored
Allocation origin tracking also implicitly disables inline allocations. Bug: chromium:1316121, v8:12612 Change-Id: I7efecff3bb0cceef1071853e18a01effcc97243f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593116Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80052}
-
Leszek Swirski authored
MaglevCompilationInfo stores the overall compilation information (zone, graph, labeller, etc.), while MaglevCompilationUnit stores per-function information (function, bytecode analysis, register count, etc.). Without inlining, these are 1:1 and we've been pretty sloppy in deciding which to pass around. Once we implement inlining though, we want to be careful to pass MaglevCompilationInfo where we're processing the whole graph, and MaglevCompilationUnit where we're processing something function-specific. This does the pre-work of cleaning this up in preparation for inlining. Bug: v8:7700 Change-Id: Ic50fdd97e56f6c963ab490bd419eb65fe0873688 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596162 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Victor Gomes authored
... and rename Untagged to Int32. Bug: v8:7700 Change-Id: Ib206dba74432b3f1f70fd62006cb6a1222b40ed9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3584114Reviewed-by:
-
Benoît Lizé authored
Reason for reland: Fixed Fuchsia build. Original change's description: > [builtins] Remap builtins on Linux > > This is a CL similar to > https://chromium-review.googlesource.com/c/v8/v8/+/3553006, but on Linux > rather than macOS. The goal is to allow builtins to use short builtin > calls without paying a memory cost, by remapping rather than copying > them. > > However, while macOS has a system call making this easier, on Linux we > don't have one on most kernels. There is the recently-introduced > mremap(MREMAP_DONTUNMMAP), which is available in 5.7, but only works on > anonymous mappings until 5.13, which is too recent for most Android > devices. > > Instead, we open() the file containing the builtins, and mmap() it at > the desired location. > > Change-Id: I4524f349948b8f48c4536cf392a1cd179662a6cc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570426 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Commit-Queue: Benoit Lize <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80022} Change-Id: I0cc8cf510bd2cb8621130bea8406d79aa209948c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596164Reviewed-by:
Jakob Linke <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80049}
-
Jakob Gruber authored
.. which points back at the corresponding feedback vector slot for each JumpLoop bytecode. Bug: v8:12161 Change-Id: I95f4d013544a69e088314655af7eb1dc504a8657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596166Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org CC=gdeepti@chromium.org Bug: v8:12284 Change-Id: If78b5a86364b015483131ef321ca9e928e8ddfc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585338Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Simon Zünd authored
Doc: https://bit.ly/revive-restart-frame Context: https://crrev.com/c/3582395 (whole feature) This CL adds a new optional flag `canBeRestarted` to every call frame in Debugger.paused events. As the name suggests, the flag indicates whether we can restart a particular frame through Debugger.restartFrame once implemented. We are not able to safely restart all frames: * We don't support WASM frames * We don't support frames where resumable functions (async fns, generators) and embedder C++ frames are between the top-most frame and the to-be-restarted frame. Note that from a CDP perspective the flag doesn't actually guarantee a successful restart. CDP clients can issue CDP commands between the Debugger.paused event and before a user decides to restart a frame, which can potentially mess with the stack. The `canBeRestarted` flag tests are folded into the Debugger.restartFrame tests. As the feature is not yet fully implemented we short-circuit most of the tests for now and only run them up until the first Debugger.restartFrame call fails (except "fails-for-resumables.js"). This means the tests exercise the `canBeRestarted` flag, but not the restarting functionality itself. R=bmeurer@chromium.org, kimanh@chromium.org Bug: chromium:1303521 Change-Id: I01ab46dc3557ab8383960969fbe03e00604cc5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596160Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#80046}
-
Jakob Gruber authored
These will soon be used to store cached OSR code. Bug: v8:12161 Change-Id: I49b6f1cd648e1fd033ac09b2e590bc185f5461e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596165 Commit-Queue: Jakob Linke <jgruber@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
Clemens Backes authored
The fix is merged to all channels, add the regression test. R=thibaudm@chromium.org Bug: chromium:1314184 Change-Id: I7b7ca13ff34b19c3dbb727d248619dc1ff874873 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596161Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80044}
-
Clemens Backes authored
Memory masking was removed in https://crrev.com/c/3045704. The comment and CHECK referred to the code to compute the memory mask, so it does not apply any more. Thus remove it as well. R=thibaudm@chromium.org Bug: v8:12425 Change-Id: If11af4f2179dc01003ea6b532c6ac5696d6fa475 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3592953Reviewed-by:
-
Victor Gomes authored
Since next() comes from ThreadedListTraits, the users of this class can modify the list by modifying the next pointer. This however breaks the invariant that `tail_` points to the last element of the list. We ensure this invariant lazily. This should be _almost_ no effect for users that do not manually modify the next pointer. Change-Id: If46283ab4fc5036a81f353b25823b0fd39b3e232 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578803Reviewed-by:
-
Tobias Tebbi authored
This is a reland of commit 6819f75d Original change's description: > Reland "Reland "[baseline] Enable concurrent sparkplug"" > > This reverts commit 5d6a16fb. > > Reason for revert: it was a flake > > Original change's description: > > Revert "Reland "[baseline] Enable concurrent sparkplug"" > > > > This reverts commit fee91f9a. > > > > Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64/44699/overview > > > > Original change's description: > > > Reland "[baseline] Enable concurrent sparkplug" > > > > > > Issue that cause the revert was fixed: v8:12713 > > > https://bugs.chromium.org/p/v8/issues/detail?id=12713 > > > > > > This is a reland of commit f01a6098 > > > > > > Original change's description: > > > > [baseline] Enable concurrent sparkplug > > > > > > > > Bug: v8:12054 > > > > Change-Id: I1b0ee1a9541a75412b882b259e421aa6e88317da > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259658 > > > > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > > > > Cr-Commit-Position: refs/heads/main@{#79485} > > > > > > Bug: v8:12054 > > > Change-Id: Iafba22e3fa3b38eddb226db6cd5afdb7e3e6b435 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3528992 > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#79618} > > > > Bug: v8:12054 > > Change-Id: I3ba60433fdbb5617900c83d022e4dd6f830695f9 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3550271 > > Auto-Submit: Tobias Tebbi <tebbi@chromium.org> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Owners-Override: Tobias Tebbi <tebbi@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#79619} > > Bug: v8:12054 > Change-Id: Ia0fe1df00f5e715ceda46fbcdc48aed0f0190362 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3550272 > Owners-Override: Tobias Tebbi <tebbi@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79622} Bug: v8:12054 Change-Id: I43bf2d8aa25a8dcf286c46be18c372aadfb55701 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563559Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80041}
-
Andreas Haas authored
R=manoskouk@chromium.org Change-Id: I931e8ab0847db5126c2895412b4b357d482dfeb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593782Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80040}
-
Tamer Tas authored
This CL speeds up one of the slowest builders on the CQ to improve overall CQ time. R=machenbach@chromium.org,liviurau@chromium.org,alexschulze@chromium.org Bug: v8:12810 Change-Id: I80adfb3abdea1ef7e14abf0a8c2dc2cc2b4d77d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593134 Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=bmeurer@chromium.org Bug: chromium:1303521 Change-Id: Iff7247fda94037ff4f9d37f334d386eb4e63ce62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595819 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Simon Zünd authored
Doc: https://bit.ly/revive-restart-frame Context: https://crrev.com/c/3582395 (whole feature) This CL adds the second batch of inspector tests for the upcoming "Restart frame" feature. Landing the tests upfront allows us to better discuss the proposed API as well as think early about corner cases we should test. The tests check for the functionality of `Debugger.restartFrame`, as well as the newly added parameter `canBeRestarted` in the `Debugger.paused` event. Bug: chromium:1303521 Change-Id: Ie9dda100cdc5217a4e4cc2f0cf7019a33d124120 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585947Reviewed-by:
-
Camillo Bruni authored
Bug: v8:12795, chromium:1316443 Change-Id: Ib4cbbad42da80dfb566e559e70db30a670cc4326 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593221 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7aeed11..3dce554 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/28b8ede..e356f14 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7d2693a..89ccf4a Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a6d209a..be2c378 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I27acb5fb4e6158fc69c0ec5b0ea225e1227a4782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3595619 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80035}
-
- 19 Apr, 2022 16 commits
-
-
Milad Fa authored
Port 4ae5a813 Original Commit Message: Having it around is an invitation to use it in new places. This CL removes the generic Dummy descriptor and replaces it by other existing descriptors if possible, and defines specialized dummies otherwise. In the future, every builtin should have a real descriptor. Especially new ASM builtins should define descriptors and use them in their implementation (use Descriptor::FooRegister() instead of documenting the calling convention as comments). R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ied285739f8ab017f17341c9c3bbbb1217be947e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3594539Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80034}
-
Omer Katz authored
Bug: chromium:1316121, v8:12612 Change-Id: I83d1b580e2bfd03ed36b174ff4503976c8bd1922 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593115Reviewed-by:
-
Clemens Backes authored
{LiftoffOptions} already contains many (optional) parameters for Liftoff compilation, but not all of them. This CL moves the function index and the {for_debugging} field also into that struct, to further reduce the number of parameters to {ExecuteLiftoffCompilation} and to improve readability by having a factory-like initialization of the {LiftoffOptions} struct. That struct is now also passed down to the LiftoffCompiler directly instead of unpacking the fields again. R=thibaudm@chromium.org Bug: v8:12809 Change-Id: I8824a1908f214cbf4c21f113934fef3ece1bf88b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3513894Reviewed-by: -
Alexander Schulze authored
Bug: v8:12793 Change-Id: Ic5e414b5081f4eff95c34910f97dccbb16a9339b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593785 Auto-Submit: Alexander Schulze <alexschulze@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Having it around is an invitation to use it in new places. This CL removes the generic Dummy descriptor and replaces it by other existing descriptors if possible, and defines specialized dummies otherwise. In the future, every builtin should have a real descriptor. Especially new ASM builtins should define descriptors and use them in their implementation (use Descriptor::FooRegister() instead of documenting the calling convention as comments). Change-Id: Ib577aa03b5e5a522460d1084cc9605c55cd29d6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585945 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This reverts commit dec4bb06. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/Linux%20V8%20FYI%20Release%20(NVIDIA) Original change's description: > [turbofan] Support additional operators in SLVerifier > > This CL extends SimplifiedLoweringVerifier by a few additional operators. > > It fixes the missing type on a LoadElement node generated during > js-typed-lowering, that was detected by the verifier. > > Bug: v8:12619 > Change-Id: I14e3ece15f6a90e6906c140696dcd2e6b74a2527 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557510 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80014} Bug: v8:12619 Change-Id: I79caa97bba1f29b549d494a747d0f65a85d60315 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593135 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80029}
-
Shu-yu Guo authored
This reverts commit b1dd8287. Reason for revert: Breaking fuschia build https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Fuchsia%20-%20builder/13592/overview Original change's description: > [builtins] Remap builtins on Linux > > This is a CL similar to > https://chromium-review.googlesource.com/c/v8/v8/+/3553006, but on Linux > rather than macOS. The goal is to allow builtins to use short builtin > calls without paying a memory cost, by remapping rather than copying > them. > > However, while macOS has a system call making this easier, on Linux we > don't have one on most kernels. There is the recently-introduced > mremap(MREMAP_DONTUNMMAP), which is available in 5.7, but only works on > anonymous mappings until 5.13, which is too recent for most Android > devices. > > Instead, we open() the file containing the builtins, and mmap() it at > the desired location. > > Change-Id: I4524f349948b8f48c4536cf392a1cd179662a6cc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570426 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Commit-Queue: Benoit Lize <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80022} Change-Id: I0093fe84216f8c8fd1a8691c53817e578d92fa40 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3594009 Auto-Submit: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80028}
-
Thibaud Michaud authored
A GC can happen while we allocate the resume callback, and before the suspender is fully initialized. We cannot just change the order of allocation, because they both reference each other. So temporarily set a default value for the "resume" property to make the GC happy. R=jkummerow@chromium.org Bug: v8:12803 Change-Id: Ieecc5182b8dcf7a159713c9400d65da59c4b2af6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3586989Reviewed-by:
-
Camillo Bruni authored
These tools haven't been used in a while and are unmaintained. We can use pprof with stack-filtering to achieve similar results. Change-Id: I84392c066dffc6b0d9efba27a8fdfb31091796bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3593786Reviewed-by:
-
jameslahm authored
- Add RunJSNoChecked to run the script which possibly throws. - Add CompileRun to run the script outside TEST_F, e.g., in FunctionTemplate and helpers etc. Bug: v8:12781 Change-Id: Ibab2e19cf1f7c76f7a81a90fc5894e7e6bfb7cdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3586770Reviewed-by:
-
Omer Katz authored
This CL is the first step towards creating a paged new sapce. The CL creates a base class for new space that holds all fields not specific to the semi space based implementation, and methods that do not interact with the semi spaces. Methods are moved as is to the new base class. Future CLs will rename the classes, split/refactor additional methods, and make other methods virtual. Bug: v8:12612 Change-Id: Ibd8ec5135d66daf0fd025493bfaff537d61e049f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3584120Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80024}
-
Toon Verwaest authored
This CL splits the stack frame into tagged and untagged slots, and allows reuse of slots for values that are also tagged/untagged. Bug: v8:7700 Change-Id: Id068807d1cd9bcd8c9e41d330f44acf346b16685 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585959Reviewed-by:
-
Benoît Lizé authored
This is a CL similar to https://chromium-review.googlesource.com/c/v8/v8/+/3553006, but on Linux rather than macOS. The goal is to allow builtins to use short builtin calls without paying a memory cost, by remapping rather than copying them. However, while macOS has a system call making this easier, on Linux we don't have one on most kernels. There is the recently-introduced mremap(MREMAP_DONTUNMMAP), which is available in 5.7, but only works on anonymous mappings until 5.13, which is too recent for most Android devices. Instead, we open() the file containing the builtins, and mmap() it at the desired location. Change-Id: I4524f349948b8f48c4536cf392a1cd179662a6cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570426Reviewed-by:
-
Nikolaos Papaspyrou authored
Since https://crrev.com/c/3486556, several old metrics related to GC have disappeared from chromeperf, showing very small (near zero) values, e.g., v8-gc-scavenger, v8-gc-full-mark-compactor, v8-gc-latency-mark-compactor. This CL fixes this issue. Bug: chromium:1315527 Bug: chromium:1154636 Change-Id: I5ee7167a6d4a6a54b2272bb63588990db17dabbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585565Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Yolanda Chen authored
The SSE2_UNOP instructions have various src and dst register types for 256-bit AVX. One of them, the ucomisd instruction does not support YMM. Other two: vcvtpd2ps and vcvttpd2dq use XMM as dst register. We extend the Operand type to Operand256 to represent m256 to distiguish with the 128-bit AVX instruction. Since this is a small suite, we explicitly specify the operand type for each instruction. Bug: v8:12228 Change-Id: I07c8168bd49f75eb8e4df8d6adfcfb37c1d34fff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3518423Reviewed-by:
-
jameslahm authored
Isolates all have difference perf_output_handle_ for perf dump file, which will corrupt when perfing multiple isolate within one process. And we could use the same perf_output_handle_ between isolates within one process to avoid the corrupt. We also use the mutex to protect the perf_output_handle_ change. Bug: v8:10278 Change-Id: If10a677e4df7d4cd577bbb85bcefe75d76aaf26b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585491 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80019}
-
