Skip to content

V
V8
Switch branch/tag
  1. 14 Jul, 2016 1 commit
    • adamk's avatar
      Slight cleanup of TryCatch parsing/variable declaration · 458bd3b9
      adamk authored 
      Instead of unconditionally parsing the catch parameter as an expression
and then recovering if it turns out to be a simple variable proxy
(the overwhelmingly common case), this patch peeks one token ahead
before attempting to parse. This avoids doing the usual RemoveUnresolved
gymnastics in ParseTryStatement, and as a side-effect slightly improves
function name inference for an async arrow function test case.

Review-Url: https://codereview.chromium.org/2151433005
Cr-Commit-Position: refs/heads/master@{#37780}
      458bd3b9
  3. 13 Jul, 2016 1 commit
  5. 12 Jul, 2016 1 commit
  7. 11 Jul, 2016 2 commits
  9. 07 Jul, 2016 1 commit
  11. 04 Jul, 2016 1 commit
  13. 01 Jul, 2016 1 commit
  15. 30 Jun, 2016 1 commit
    • hablich's avatar
      Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.... · b1f7f1f4
      hablich authored 
      Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ )

Reason for revert:
Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/

Original issue's description:
> Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.
>
> The spec was modified to relax some requirements which implementors had not been
> enforcing. Part of this process involved introducing a new abstract operation
> ToIndex, which had partial overlap with our existing semantics as well as some
> differences (most notably treating undefined as 0). Test262 tests were introduced to
> check for the new semantics, some of which we were failing. This patch amends the
> parts of our implementation corresponding to specification algorithms which use
> ToIndex to follow its semantics precisely.
>
> BUG=v8:4784,v8:5120
>
> Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132
> Cr-Commit-Position: refs/heads/master@{#37406}

TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4784,v8:5120

Review-Url: https://codereview.chromium.org/2113593002
Cr-Commit-Position: refs/heads/master@{#37417}
      b1f7f1f4
  17. 29 Jun, 2016 2 commits
    • bakkot's avatar
      Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. · 09720349
      bakkot authored 
      The spec was modified to relax some requirements which implementors had not been
enforcing. Part of this process involved introducing a new abstract operation
ToIndex, which had partial overlap with our existing semantics as well as some
differences (most notably treating undefined as 0). Test262 tests were introduced to
check for the new semantics, some of which we were failing. This patch amends the
parts of our implementation corresponding to specification algorithms which use
ToIndex to follow its semantics precisely.

BUG=v8:4784,v8:5120

Review-Url: https://codereview.chromium.org/2090353003
Cr-Commit-Position: refs/heads/master@{#37406}
      09720349
    • jwolfe's avatar
      Allow trailing commas in function parameter lists · 1ac09655
      jwolfe authored 
      Add a flag harmony_trailing_commas_in_parameters that allows trailing
commas in function parameter declaration lists and function call
parameter lists. Trailing commas are allowed in parenthetical lists like
`(a, b, c,)` only if the next token is `=>`, thereby making it an arrow
function declaration. Only 1 trailing comma is allowed, not `(a,,)`. A
trailing comma must follow a non-rest parameter, so `(,)` and `(...a,)`
are still SyntaxErrors. However, a trailing comma is allowed after a
spread parameter, e.g. `a(...b,);`.

Add parser tests for all of the above.

BUG=v8:5051
LOG=y

Review-Url: https://codereview.chromium.org/2094463002
Cr-Commit-Position: refs/heads/master@{#37355}
      1ac09655
  19. 28 Jun, 2016 2 commits
    • neis's avatar
      Fix behavior of throw on yield*. · 2f0cb3af
      neis authored 
      When calling the throw method on a generator suspended inside a yield*, yield*
in turn tries to call throw on its iterable.  If the iterable does not provide a
throw method, yield* must try to call the return method instead and then throw a
TypeError.  Due to a bug in our desugaring, we never threw the TypeError.

R=adamk@chromium.org
BUG=v8:5132

Review-Url: https://codereview.chromium.org/2094253002
Cr-Commit-Position: refs/heads/master@{#37314}
      2f0cb3af
    • neis's avatar
      Fix behavior of return on yield*. · 6dffb078
      neis authored 
      When calling the return method on a generator suspended inside a yield*, yield*
in turn calls return on its iterable.  If this results in a "done" iterator,
yield* must return immediately, thus terminating the generator.  For some
reason, we didn't terminate the generator but continued right after the yield*.

R=adamk@chromium.org
BUG=v8:5131

Review-Url: https://codereview.chromium.org/2100093002
Cr-Commit-Position: refs/heads/master@{#37310}
      6dffb078
  21. 25 Jun, 2016 1 commit
  23. 24 Jun, 2016 1 commit
  25. 22 Jun, 2016 1 commit
  27. 21 Jun, 2016 2 commits
  29. 15 Jun, 2016 2 commits
  31. 14 Jun, 2016 3 commits
  33. 13 Jun, 2016 1 commit
  35. 10 Jun, 2016 1 commit
    • littledan's avatar
      Async/await event listener test · 5d7b9ece
      littledan authored 
      This patch adds a test for async/await analogous to a previous Promise test.
It also fixes a typo in promise.js and makes a previous Promise test more
correct by ensuring that all assertions run before completion, fixing the
test expectations for the real result (which seems correct).

BUG=v8:4483
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2037653002
Cr-Commit-Position: refs/heads/master@{#36903}
      5d7b9ece
  37. 07 Jun, 2016 1 commit
  39. 03 Jun, 2016 1 commit
  41. 02 Jun, 2016 1 commit
  43. 31 May, 2016 2 commits
  45. 27 May, 2016 1 commit
    • littledan's avatar
      Improve strictness of Annex B 3.3 for generators and async functions · 6390282f
      littledan authored 
      Annex B 3.3 applies only for ordinary FunctionDeclarations, not
GeneratorDeclarations or AsyncFunctionDeclarations. This patch
- Skips applying Annex B 3.3 to async functions
- Adds a flag to refrain from applying it to generators
- UseCounter for how often duplicate function in block occurs
  with generators (unclear how to measure need for hoisting from block)

BUG=v8:4806

Review-Url: https://codereview.chromium.org/1995863002
Cr-Commit-Position: refs/heads/master@{#36557}
      6390282f
  47. 24 May, 2016 1 commit
  49. 23 May, 2016 1 commit
  51. 20 May, 2016 2 commits
  53. 19 May, 2016 2 commits
  55. 18 May, 2016 1 commit
  57. 17 May, 2016 2 commits