1. 10 Jan, 2017 2 commits
  2. 09 Jan, 2017 2 commits
  3. 07 Jan, 2017 2 commits
    • machenbach's avatar
      Revert of [intl] Remove redundant type checking system (patchset #4 id:60001... · b1e4f79e
      machenbach authored
      Revert of [intl] Remove redundant type checking system (patchset #4 id:60001 of https://codereview.chromium.org/2600913002/ )
      
      Reason for revert:
      Breaks noi18n.
      
      Original issue's description:
      > [intl] Remove redundant type checking system
      >
      > Previously, the Intl implementation tracked types two ways:
      >  - In the intl_initialized_marker_symbol
      >  - In various named properties of the intl_impl_object_symbol value
      >
      > As far as I can tell, these will never disagree with each other,
      > modulo bugs in Intl itself. This patch removes the second type
      > checking system.
      >
      > This reland includes a fixed type check for
      > Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      > method which is not bound. All future methods will follow this
      > pattern.
      >
      > BUG=v8:5751,chromium:677055, v8:4962
      > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      >
      > Review-Url: https://codereview.chromium.org/2600913002
      > Cr-Commit-Position: refs/heads/master@{#42118}
      > Committed: https://chromium.googlesource.com/v8/v8/+/aa8a2d2789f79c2c367db406e453b9044e594e25
      
      TBR=yangguo@chromium.org,adamk@chromium.org,littledan@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5751,chromium:677055, v8:4962
      
      Review-Url: https://codereview.chromium.org/2617323002
      Cr-Commit-Position: refs/heads/master@{#42119}
      b1e4f79e
    • littledan's avatar
      [intl] Remove redundant type checking system · aa8a2d27
      littledan authored
      Previously, the Intl implementation tracked types two ways:
       - In the intl_initialized_marker_symbol
       - In various named properties of the intl_impl_object_symbol value
      
      As far as I can tell, these will never disagree with each other,
      modulo bugs in Intl itself. This patch removes the second type
      checking system.
      
      This reland includes a fixed type check for
      Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl
      method which is not bound. All future methods will follow this
      pattern.
      
      BUG=v8:5751,chromium:677055, v8:4962
      CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
      
      Review-Url: https://codereview.chromium.org/2600913002
      Cr-Commit-Position: refs/heads/master@{#42118}
      aa8a2d27
  4. 06 Jan, 2017 1 commit
  5. 04 Jan, 2017 3 commits
  6. 03 Jan, 2017 1 commit
    • gsathya's avatar
      [promises] Refactor debug code · a2c15ba3
      gsathya authored
      -- Removes remaning debug from promise.js and moves it to c++
      -- Changes debug_id to be a smi in PromiseReactionJobInfo and
         PromiseResolveThenableJobInfo.
      -- Changes debug_name to be a smi in PromiseReactionJobInfo and
         PromiseResolveThenableJobInfo.
      -- Adds PromiseDebugActionName and PromiseDebugActionType enums
      -- Adds PromiseDebugActionNameToString and
         PromiseDebugActionTypeToString helper methods
      -- Changes variable `status` to be int in runtime functions.
      -- Changes debug_id to start from 1, not 0 for easier bookkeeping.
      
      BUG=v8:5343
      
      Review-Url: https://codereview.chromium.org/2606093002
      Cr-Commit-Position: refs/heads/master@{#42052}
      a2c15ba3
  7. 02 Jan, 2017 1 commit
    • caitp's avatar
      [promises] port NewPromiseCapability to TF · 4f95a1eb
      caitp authored
      - Adds CodeAssembler::ConstructJS() to simplify calling JS functions as
      constructors, used by NewPromiseCapability()
      - Defines PromiseCapability as a special JSObject subclass, with a
      non-exensible Map, and read-only non-configurable DataDescriptors which
      point to its in-object fields. This allows its fields to be used by JS
      builtins until there is no longer any need.
      
      Currently, the performance benefit comes from
      https://codereview.chromium.org/2567033003/, but does not appear to
      regress performance in any significant way.
      
      BUG=v8:5343
      TBR=ulan@chromium.org
      
      Review-Url: https://codereview.chromium.org/2567333002
      Cr-Commit-Position: refs/heads/master@{#42014}
      4f95a1eb
  8. 29 Dec, 2016 1 commit
    • gsathya's avatar
      [promises] Remove deferred object · 5668ce39
      gsathya authored
      This patch stores the promise, resolve, reject properties of the
      deferred object created by CreateInternalPromiseCapability and
      NewPromiseCapability directly on the promise (if the promise hasn't
      been fulfilled), otherwise they are stored on the
      PromiseReactionJobInfo.
      
      This patch removes the currently unused
      CreateInternalPromiseCapability and inlines the call to create the
      deferred promise object.
      
      NewPromiseCapability is the only function that works with a deferred.
      
      This patch results in a 8.5% improvement in benchmarks over 5 runs.
      
      BUG=v8:5343
      
      Review-Url: https://codereview.chromium.org/2590563003
      Cr-Commit-Position: refs/heads/master@{#41991}
      5668ce39
  9. 27 Dec, 2016 1 commit
  10. 23 Dec, 2016 2 commits
  11. 22 Dec, 2016 1 commit
  12. 21 Dec, 2016 5 commits
  13. 20 Dec, 2016 3 commits
  14. 19 Dec, 2016 2 commits
  15. 16 Dec, 2016 1 commit
  16. 15 Dec, 2016 1 commit
  17. 14 Dec, 2016 1 commit
  18. 13 Dec, 2016 1 commit
    • gsathya's avatar
      PromiseHandle port to TF · 9fc3c017
      gsathya authored
      Splits PromiseHandle into two TF builtins to account for catch
      prediction. An exception in PromiseHandleReject builtin results in a
      "caught" prediction whereas an expception in PromiseHandle results in a
      "promise rejection" prediction.
      
      An extra is_exception_caught bit is added to Code to mark this catch
      prediction behavior.
      
      BUG=v8:5343
      
      Review-Url: https://codereview.chromium.org/2572623002
      Cr-Commit-Position: refs/heads/master@{#41683}
      9fc3c017
  19. 08 Dec, 2016 2 commits
  20. 06 Dec, 2016 3 commits
  21. 05 Dec, 2016 3 commits
    • ynovikov's avatar
      Reland of [typedarrays] remove invalid optimization in NAMEConstructor()... · f5cb17a8
      ynovikov authored
      Reland of [typedarrays] remove invalid optimization in NAMEConstructor() (patchset #1 id:1 of https://codereview.chromium.org/2548583003/ )
      
      Reason for revert:
      The bot was not affected by the revert. Speculation was wrong.
      
      Original issue's description:
      > Revert of [typedarrays] remove invalid optimization in NAMEConstructor() (patchset #1 id:1 of https://codereview.chromium.org/2544503002/ )
      >
      > Reason for revert:
      > Speculative revert for causing timeouts on Win Debug gpu fyi bot
      >
      > Nothing else looks even remotely relevant in the list of changes.
      > Will reland if this doesn't fix the issues.
      >
      > BUG=670396
      >
      > Original issue's description:
      > > [typedarrays] remove invalid optimization in NAMEConstructor()
      > >
      > > Before, we were treating objects with the builtin ArrayValues iterator
      > > method as array-like, where the iterator would iterate through to the
      > > full length of the object.
      > >
      > > This optimization was not sound, because it does not ensure that the
      > > next method hasn't been modified. Even if it hasn't been modified,
      > > it's entirely possible to be modified during iteration. Thus, this
      > > optimization has been removed due to its observability.
      > >
      > > BUG=v8:5699
      > > R=littledan@chromium.org, cbruni@chromium.org
      > >
      > > Committed: https://crrev.com/77df8c67d9609ada3b7d79e8e6d33f198bbad5a1
      > > Cr-Commit-Position: refs/heads/master@{#41394}
      >
      > TBR=cbruni@chromium.org,littledan@chromium.org,caitp@igalia.com
      > # Not skipping CQ checks because original CL landed more than 1 days ago.
      > BUG=v8:5699
      >
      > Committed: https://crrev.com/0ea4a542202d501c4e550474e89512532571f3a0
      > Cr-Commit-Position: refs/heads/master@{#41461}
      
      TBR=cbruni@chromium.org,littledan@chromium.org,caitp@igalia.com,enne@chromium.org
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=670396
      
      Review-Url: https://codereview.chromium.org/2553873002
      Cr-Commit-Position: refs/heads/master@{#41504}
      f5cb17a8
    • gsathya's avatar
      Object · 30b564c7
      gsathya authored
      -- New JSObject for promises: JSPromise
      
      Builtins
      -- PromiseThen TFJ
      -- PromiseCreateAndSet TFJ for internal use
      -- PerformPromiseThen TFJ for internal use
      -- PromiseInit for initial promise setup
      -- SpeciesConstructor for use in PromiseThen
      -- ThrowIfNotJSReceiver for use in SpeciesConstructor
      -- AppendPromiseCallback to update FixedArray with new callback
      -- InternalPerformPromiseThen
      
      Promises.js
      -- Cleanup unused symbols
      -- Remove PerformPromiseThen
      -- Remove PromiseThen
      -- Remove PromiseSet
      -- Remove PromiseAttachCallbacks
      
      Runtime
      -- PromiseSet to set promise inobject values
      -- Refactor functions to use FixedArrays for callbacks instead of
         JSArray
      -- Runtime_PromiseStatus to return promise status
      -- Runtime_PromiseResult to return promise result
      -- Runtime_PromiseDeferred to return deferred attached to promise
      -- Runtime_PromiseRejectReactions to return reject reactions attached
         to promise
      
      This CL results in a 13.07% improvement in the promises benchmark
      (over 5 runs).
      
      BUG=v8:5343
      
      Review-Url: https://codereview.chromium.org/2536463002
      Cr-Commit-Position: refs/heads/master@{#41503}
      30b564c7
    • bmeurer's avatar
      [builtins] Don't enforce I+TF for ArraySort helpers. · 704d737d
      bmeurer authored
      The current Array.prototype.sort implementation is pretty sensitive to
      compiler changes, i.e. switching to I+TF completely, so refactor it a
      bit so that it can stay with FCG+CS for now.
      
      Middle-term the Array builtins need to be refactored to TurboFan
      builtins anyways.
      
      BUG=chromium:670691,v8:5666
      R=jarin@chromium.org
      
      Review-Url: https://codereview.chromium.org/2553523002
      Cr-Commit-Position: refs/heads/master@{#41471}
      704d737d
  22. 04 Dec, 2016 1 commit