1. 05 Nov, 2019 1 commit
  2. 12 Sep, 2019 1 commit
  3. 24 Jun, 2019 1 commit
    • Mathias Bynens's avatar
      [objects] Rename JSValue to JSPrimitiveWrapper · e428dfd7
      Mathias Bynens authored
      We currently use the class name “JSValue” for JSObjects that wrap
      primitive values. This name is a common source of confusion. This patch
      switches to a name that’s more clear.
      
      In addition to manual tweaks, the patch applies the following mechanical
      global replacements:
      
      before                          | after
      --------------------------------|--------------------------------------
      if_valueisnotvalue              | if_valueisnotwrapper
      if_valueisvalue                 | if_valueiswrapper
      js_value                        | js_primitive_wrapper
      JS_VALUE_TYPE                   | JS_PRIMITIVE_WRAPPER_TYPE
      JSPrimitiveWrapperType          | JSPrimitiveWrapper type
      jsvalue                         | js_primitive_wrapper
      JSValue                         | JSPrimitiveWrapper
      _GENERATED_JSVALUE_FIELDS       | _GENERATED_JSPRIMITIVE_WRAPPER_FIELDS
      
      Change-Id: I9d9edea784eab6067b013e1f781e4db2070f807c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1672942Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#62337}
      e428dfd7
  4. 23 May, 2019 1 commit
  5. 21 May, 2019 1 commit
  6. 20 May, 2019 1 commit
  7. 17 May, 2019 2 commits
  8. 15 May, 2019 1 commit
  9. 28 Jan, 2019 1 commit
  10. 03 Oct, 2018 1 commit
  11. 03 Aug, 2018 1 commit
  12. 29 Jul, 2018 1 commit
    • Jungshik Shin's avatar
      Reland "[Intl] Move Number.toLocaleString from js to c++" · 65d0b783
      Jungshik Shin authored
      This reverts commit c83fae06.
      
      Reason for revert: the CL that required the revert of this CL was relanded.
      
      https://chromium-review.googlesource.com/c/v8/v8/+/1154247
      
      Original change's description:
      > Revert "[Intl] Move Number.toLocaleString from js to c++"
      >
      > This reverts commit a895f01a.
      >
      > Reason for revert: Needed for other revert:
      > https://chromium-review.googlesource.com/c/v8/v8/+/1152767
      >
      > Original change's description:
      > > [Intl] Move Number.toLocaleString from js to c++
      > >
      > >
      > > Bug: v8:7960
      > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > > Change-Id: I21a524b620e210cce625a1a00e68c0b687187087
      > > Reviewed-on: https://chromium-review.googlesource.com/1144659
      > > Commit-Queue: Frank Tang <ftang@chromium.org>
      > > Reviewed-by: Jungshik Shin <jshin@chromium.org>
      > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#54741}
      >
      > TBR=jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org
      >
      > Change-Id: I060fa2834dde5e1b4cc71923cc066d97bce2a33b
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: v8:7960
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Reviewed-on: https://chromium-review.googlesource.com/1152787
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#54746}
      
      TBR=machenbach@chromium.org,jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: v8:7960
      Change-Id: I7a7a67db77b9b5a181f1751a03186eb7e8b271a0
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1154248
      Commit-Queue: Jungshik Shin <jshin@chromium.org>
      Reviewed-by: 's avatarJungshik Shin <jshin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54774}
      65d0b783
  13. 27 Jul, 2018 2 commits
  14. 03 Jul, 2018 1 commit
  15. 20 Jul, 2017 1 commit
  16. 30 Jun, 2017 1 commit
  17. 19 Apr, 2017 1 commit
  18. 18 Apr, 2017 2 commits
  19. 16 Mar, 2017 1 commit
  20. 13 Mar, 2017 1 commit
  21. 07 Mar, 2017 1 commit
  22. 03 Mar, 2017 1 commit
  23. 23 Feb, 2017 1 commit
  24. 17 Feb, 2017 1 commit
  25. 16 Dec, 2016 1 commit
  26. 12 Dec, 2016 1 commit
  27. 01 Dec, 2016 1 commit
  28. 28 Nov, 2016 1 commit
  29. 24 Nov, 2016 3 commits
  30. 16 Nov, 2016 2 commits
  31. 15 Nov, 2016 1 commit
  32. 26 Oct, 2016 1 commit
    • bmeurer's avatar
      [builtins] Don't canonicalize results of Math double operations. · 9f4f582b
      bmeurer authored
      For Math builtins that likely yield double results, i.e. Math.sin,
      Math.cos and friends, don't bother trying to canonicalize the result
      to Smi. The rationale behind this is that other parts of V8 use the
      HeapNumber representation as a hint to assume that certain values
      should be represented as double (i.e. for the array elements kind
      and for double field tracking). This way the chance that we make
      the ideal decision early on is better.
      
      For Math.abs we establish the contract that if the input value is a
      Smi, then we try hard to return a Smi (doesn't work for minimal Smi
      value), otherwise we preserve the HeapNumberness of the input.
      
      Same for the generic Add, Subtract, Multiply, etc. code stubs.
      
      R=yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2451973003
      Cr-Commit-Position: refs/heads/master@{#40573}
      9f4f582b
  33. 20 Oct, 2016 1 commit
  34. 19 Oct, 2016 1 commit