- 31 Oct, 2017 14 commits
-
-
Jakob Kummerow authored
Implicit case-fallthrough strikes again. Bug: v8:6791 Change-Id: Iee6422a67797f8958527507bac538bcdac2ebddc Reviewed-on: https://chromium-review.googlesource.com/747075Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49057}
-
Jakob Kummerow authored
Objects with both dictionary and non-dictionary maps can store their hash in the {properties} field when they have no other properties. Bug: chromium:778952 Change-Id: I8ac8c31eaac32116415e3c65cef8dee260dca2c9 Reviewed-on: https://chromium-review.googlesource.com/747272Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49056}
-
Junliang Yan authored
Takes too long on bots to run Bug: Change-Id: Ia99717fe943ff6437497425abd3a3cb9999d7564 Reviewed-on: https://chromium-review.googlesource.com/746533Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#49055}
-
Leszek Swirski authored
When closing untagged template string literals, create a single n-ary addition operation, instead of a tree of binary operations. As a clean-up, this also entirely removes the "second" field from n-ary operations. This was proving to be too confusing an API when building an n-ary operation incrementally from a single expression (rather than converting a binary operation). Bug: v8:6964 Change-Id: I8f2a395d413cf345bab0a1a347b47f412cde83b1 Reviewed-on: https://chromium-review.googlesource.com/739821Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#49054}
-
Adam Klein authored
Also replaced kTrue/kFalse with a kBoolean type, and remove now-unused IsTypeX() methods (leaving ones that are called frequently). Bug: v8:6984 Change-Id: I0cbffc37efaa391981d8dce564051ce43257ed8a Reviewed-on: https://chromium-review.googlesource.com/745023Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49053}
-
Michael Achenbach authored
Change-Id: I9fbf2b291299d7bdf12e98e8a55f2d56b59807c8 Reviewed-on: https://chromium-review.googlesource.com/746881Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49052}
-
Michael Achenbach authored
This is a reland of f259ec2d Original change's description: > [build] Include deopt-fuzzer isolates on fuzzer builders > > TBR=sergiyb@chromium.org > NOTRY=true > NOTREECHECKS=true > > Bug: v8:7012 > Change-Id: I1d0b0488cd9b7bf6a30edc0b010f32fb0914ed0b > Reviewed-on: https://chromium-review.googlesource.com/743783 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49032} TBR=sergiyb@chromium.org Bug: v8:7012 Change-Id: Idbc7126ea0cbc37da1536ca3c0ed03c4ddb7c93d Reviewed-on: https://chromium-review.googlesource.com/746781Reviewed-by:
-
Mythri authored
We have a check on maximum number of levels that can be inlined. This in some cases causes performance cliffs, when we cannot inline a small function because it has exceeded the number of levels. This cl removes that check. The intuition is that, having gone down several levels in a particular line stopping inlining that chain and exploring a new call site may not be beneficial. This cl also introduces a absolute limit on the number of nodes that can be inlined (including the small functions). Bug: v8:6871, chromium:779509 Change-Id: Id29639ff2fd85b84d8746da3fb78a82d4e9852e8 Reviewed-on: https://chromium-review.googlesource.com/743727Reviewed-by:
-
Benedikt Meurer authored
This adds support to the KeyedLoadIC to ignore out of bounds accesses for Strings and return undefined instead. We add a dedicated bit to the Smi handler to encode the OOB state and have TurboFan generate appropriate code for that case as well. This is mostly useful when programs accidentially access past the length of a string, which was observed and fixed for example in Babel recently, see https://github.com/babel/babel/pull/6589 for details. The idea is to also extend this mechanism to Arrays and maybe other receivers, as reading beyond the length is also often used in jQuery and other popular libraries. Note that this is considered a mitigation for a performance cliff and not a general optimization of OOB accesses. These should still be avoided and handled properly instead. This seems to further improve the babel test on the web-tooling-benchmark by around 1%, because the OOB access no longer turns the otherwise MONOMORPHIC access into MEGAMORPHIC state. Bug: v8:6936, v8:7014 Change-Id: I9df03304e056d7001a65da8e9621119f8e9bb55b Reviewed-on: https://chromium-review.googlesource.com/744022 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Mircea Trofin authored
This both simplifies the code, and brings it in-line with what we need for wasm on the native heap. Bug: v8:6876 Change-Id: Ia48aed86ddcd94e85c0aecc053c327dfacb795d6 Reviewed-on: https://chromium-review.googlesource.com/744593 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#49048}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c5d82db..7765787 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/e043d81..3275a09 Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/110e5f6..ca0bd08 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/52d748d..6fd9f08 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib82da8ba88f625e1d64070d69df742a3ec0792ef Reviewed-on: https://chromium-review.googlesource.com/745603Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49047}
-
Adam Klein authored
This reverts commit 521fa16e. Reason for revert: fails tests under code-serializer: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/17691 Original change's description: > [runtime] Slightly optimize creation of class literals. > > TBR=bmeurer@chromium.org > > Bug: v8:5799 > Change-Id: I61de5f8b3333db174dadf76ed983950acb39742b > Reviewed-on: https://chromium-review.googlesource.com/649509 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49044} TBR=rmcilroy@chromium.org,yangguo@chromium.org,mythria@chromium.org,gsathya@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: I994edb855a8a0aa6e7e7476b0b013a46aac6f2e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5799 Reviewed-on: https://chromium-review.googlesource.com/745581Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5785 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia386725996beb8f47f97930c9dfc8a9639887fea Reviewed-on: https://chromium-review.googlesource.com/744739Reviewed-by:
-
Igor Sheludko authored
TBR=bmeurer@chromium.org Bug: v8:5799 Change-Id: I61de5f8b3333db174dadf76ed983950acb39742b Reviewed-on: https://chromium-review.googlesource.com/649509 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49044}
-
- 30 Oct, 2017 25 commits
-
-
Junliang Yan authored
R=joransiu@ca.ibm.com, jbarboza@ca.ibm.com, michael_dawson@ca.ibm.com Bug: Change-Id: I1f25a81637dd50b1d7e9a47154e3df4c61521fad Reviewed-on: https://chromium-review.googlesource.com/744504Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#49043}
-
Sathya Gunasekaran authored
Create new state before parsing FormalParameter because we don't want to use any of the parameters as an inferred function name. Previously the stacktrace was: test.js:3: Error: boom throw new Error('boom'); ^ Error: boom at param (test.js:3:11) at test.js:4:5 at test.js:6:3 The stacktrace with this patch: test.js:3: Error: boom throw new Error('boom'); ^ Error: boom at test.js:3:11 at test.js:4:5 at test.js:6:3 Bug: v8:6822, v8:6513 Change-Id: Ifbadc660fc4e85248af405acd67c025f11662bd4 Reviewed-on: https://chromium-review.googlesource.com/742657Reviewed-by: -
Andreas Haas authored
With the existing platform API it is not possible to post foreground tasks from background tasks. This is, however, required to implement asynchronous compilation for WebAssembly. With this CL we add the concept of a TaskRunner to the platform API. The TaskRunner contains all data needed to post a foreground task and can be used both from a foreground task and a background task. Eventually the TaskRunner should replace the existing API. In addition, this CL contains a default implementation of the TaskRunner. This implementation has tempory workaround for platforms which do not provide a TaskRunner implementation yet. This default implementation should be deleted again when all platforms provide a TaskRunner implementation. R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6ea4a1c9da1eb9a19e8ce8f2163000dbc2598802 Reviewed-on: https://chromium-review.googlesource.com/741588 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Camillo Bruni authored
This CL contains the base implementation for logging function events. Currently only compiler events are support (compile, compile-lazy...), future CLs will enable log events for parsing and first-time exeuction of functions. Bug: chromium:757467 Change-Id: Ia705979190a3ebc1009989610483a7a141bc504b Reviewed-on: https://chromium-review.googlesource.com/743921Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49040}
-
Igor Sheludko authored
... when storing to proxies. Bug: chromium:772897 Change-Id: Ia91e69f35dc3b1f67b67038bd8206e508149e9a3 Reviewed-on: https://chromium-review.googlesource.com/744041Reviewed-by:
-
Junliang Yan authored
Port 776d6e9d R=rossberg@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, jbarboza@ca.ibm.com BUG= LOG=N Change-Id: I62e59ba70fac2627a5ee00fd3007766c7c570ba3 Reviewed-on: https://chromium-review.googlesource.com/742694Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#49038}
-
Michael Stanton authored
This reverts commit ecd3a2ea. Reason for revert: Bug 779509, a crash with chrome. Original change's description: > [TurboFan] Remove maximum inlining levels check from inlining heuristics > > We have a check on maximum number of levels that can be inlined. This > in some cases causes performance cliffs, when we cannot inline a small > function because it has exceeded the number of levels. This cl removes > that check. The intuition is that, having gone down several levels in > a particular line stopping inlining that chain and exploring a new > call site may not be beneficial. > > Bug: v8:6871 > Change-Id: I120056db38e78ce48dff010b6cf994259238582a > Reviewed-on: https://chromium-review.googlesource.com/741705 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49009} TBR=mythria@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6871 Change-Id: I4766f911cb326c224af110be5c0dd7a44362a880 Reviewed-on: https://chromium-review.googlesource.com/743785Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#49037}
-
peterwmwong authored
- Add WeakMapPrototypeSet and WeakSetPrototypeAdd TFJ builtins - Fast paths for... 1) existing key 2) new key when ObjectHashTable has a "sufficient capacity" - Create WeakCollectionsBuiltinsAssembler to consolidate common WeakMap/WeakSet code generation - Convert existing WeakMapLookupHashIndex to use WeakCollectionsBuiltinsAssembler Some quick benchmarks shows performance gains of... - 1.56x - 1.98x for WeakMap constructor - 1.66x - 2.06x for WeakSet constructor - 1.50x - 2.11x for WeakMap.p.set - 1.54x - 2.26x for WeakSet.p.add https: //github.com/peterwmwong/v8-perf/blob/master/weakcollection-set/README.md Bug: v8:5049, v8:6604 Change-Id: I3499d46be6b2b3b1d8d46720ebe86cc5142ee542 Reviewed-on: https://chromium-review.googlesource.com/737935 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49036}
-
Camillo Bruni authored
Test that console.time/End/Stamp properly show up in the log file. Change-Id: I99904e20fc98811ed3e3b5e5a9d186b459b8d4be Reviewed-on: https://chromium-review.googlesource.com/743020 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49035}
-
Michael Achenbach authored
This proceeds the experiment using the legacy bots, since luci bots are blocked on https://crbug.com/776734. NOTRY=true Bug: chromium:772816, chromium:776734 Change-Id: I7532e04e98a96d69dbeefcd6edf66fb0cddbe111 Reviewed-on: https://chromium-review.googlesource.com/743365Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49034}
-
Michael Achenbach authored
This reverts commit f259ec2d. Reason for revert: Breaks tree Original change's description: > [build] Include deopt-fuzzer isolates on fuzzer builders > > TBR=sergiyb@chromium.org > NOTRY=true > NOTREECHECKS=true > > Bug: v8:7012 > Change-Id: I1d0b0488cd9b7bf6a30edc0b010f32fb0914ed0b > Reviewed-on: https://chromium-review.googlesource.com/743783 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49032} TBR=machenbach@chromium.org,sergiyb@chromium.org Change-Id: If1846d2a711edeb44f031e536f84cc4b71a107e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7012 Reviewed-on: https://chromium-review.googlesource.com/743784Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true NOTREECHECKS=true Bug: v8:7012 Change-Id: I1d0b0488cd9b7bf6a30edc0b010f32fb0914ed0b Reviewed-on: https://chromium-review.googlesource.com/743783 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Change-Id: Ib7254e7239169ec7148cdd02208eb363465c5db6 Reviewed-on: https://chromium-review.googlesource.com/743725Reviewed-by:
-
Michael Achenbach authored
This prepares for: https://chromium-review.googlesource.com/c/chromium/tools/build/+/743381 NOTRY=true Bug: v8:7012 Change-Id: Ic40aa08cbc7b68b2a1b55924536a319f729a557a Reviewed-on: https://chromium-review.googlesource.com/743363Reviewed-by:
-
Leszek Swirski authored
Following up on adding n-ary nodes, this extends the parser and interpreter to support n-ary logical operations. Bug: v8:6964 Bug: chromium:731861 Change-Id: Ife2141c389b9abccd917ab2aaddf399c436ef777 Reviewed-on: https://chromium-review.googlesource.com/735497Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ic3e6db16678f513d8bb8eaea2695ae78e383b448 Reviewed-on: https://chromium-review.googlesource.com/736034 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Toon Verwaest authored
The bytecode interpreter nor TF rely on the explicit return value of store ICs anymore, so we can just return whatever is in the result slot. It won't be visible to JS anyway. Bug: Change-Id: I389615d1d77c5b050832f23a08e3d3bc07d9cbc6 Reviewed-on: https://chromium-review.googlesource.com/743366Reviewed-by:
-
Benedikt Meurer authored
This is preparation for supporting OOB loads from strings, which requires the KeyedLoadIC to track this information. Bug: v8:6936, v8:7014 Change-Id: Ide132244ee523397dd418d21fe3377976f6633fd Reviewed-on: https://chromium-review.googlesource.com/743481Reviewed-by:
-
Georg Neis authored
This reverts commit 32141e93. Reason for revert: Got merged to stable end of last week. Original change's description: > Disable --turbo-inline-array-builtins by default. > > Current chrome stable has a high number of crashes due to bugs in > this feature. These bugs are already fixed but the fixes are hard > to merge back. Therefore we decided to disable the feature in stable. > This CL is intended to be merged to stable and then reverted in tot. > > Bug: chromium:762020 > Change-Id: Ibd5a08e3b303a204fb84a408271a1c0f97cc5b7b > Reviewed-on: https://chromium-review.googlesource.com/738176 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48931} TBR=jarin@chromium.org,neis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:762020 Change-Id: Id1fe2f417e09a7b451484fc16710b09469cdb74d Reviewed-on: https://chromium-review.googlesource.com/743321Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Remove distinction between lazy and non-lazy CallApiCallback, always explicitly set up target context Bug: Change-Id: I0cb751a0415433fdfec21451e2fac3e0726bf26e Reviewed-on: https://chromium-review.googlesource.com/743019 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The CheckSeqString operator unnecessarily materialized two bits for the separate conditions, but we can actually check for SeqString with just a single mask instead, which saves the intermediate computations and two registers. Bug: v8:5267 Change-Id: Ib937a5a4eebdc271a2bbbc6f074f5992e06b2fa9 Reviewed-on: https://chromium-review.googlesource.com/741702Reviewed-by:
-
Benedikt Meurer authored
Change-Id: I721a014262641ccc2b7dde97eaf0cadbb8d0b649 Reviewed-on: https://chromium-review.googlesource.com/743016Reviewed-by:
-
Benedikt Meurer authored
This was discovered on the babel test of the web-tooling-benchmark, which suffers from a high %KeyedGetProperty overhead, and most of these calls come from the fact that the KeyedLoadIC_Megamorphic bails out to the runtime call for all String instance types. Just handling in-bound accesses to characters reduces the overhead incurred by %KeyedGetProperty from roughly 9% to roughly 2% only. This reduces the number of runs per second on the babel test by around 7-8% on average. Bug: v8:6936, v8:7014 Change-Id: I0dc247d7d6457c7032636d2852cb54cef1b24979 Reviewed-on: https://chromium-review.googlesource.com/743012Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/824d0c1..c5d82db TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7c4bbc126a7d3322a836562684e466bf2a667747 Reviewed-on: https://chromium-review.googlesource.com/742805Reviewed-by:
-
Mircea Trofin authored
Interpreter entries may be called from wasm functions, when debugging. That means that, when moving on the native heap, interpreter entries need to be native, too. That means they cannot reference movable GC objects. The only such reference was to the instance object, which is needed in the WasmRunInterpreter runtime function. We can fetch the instance using GetWasmInstanceOnTop() instead. Bug: v8:6876 Change-Id: I7198a849cc0e441b057537a570a3dfa6f3197149 Reviewed-on: https://chromium-review.googlesource.com/742391 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49019}
-
- 29 Oct, 2017 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/626232b..824d0c1 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I87554731f13dc5bf1137816c4a6b4cb43d27bf8f Reviewed-on: https://chromium-review.googlesource.com/742803Reviewed-by:
-
