- 05 Apr, 2022 1 commit
-
-
Camillo Bruni authored
- Double click on the current timeline selection to focus and zoom in - Make timeline-tracks focusable by setting a tabindex - Add back arrow-key navigation for the map panel (only when focused) - Prepare code for adding keyboard-based horizontal scrolling - Use --code-font CSS variable Bug: v8:10644 Change-Id: Ic473695c9fcdc795d173cd064b4660e100ae8b24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568475Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79786}
-
- 02 Mar, 2022 1 commit
-
-
Camillo Bruni authored
Profiler: - Track profiler tick durations - Various speedups due to low-level hacking Improve code-panel: - Better register highlighting - Added address navigation and highlighting - Removed obsolete inline source-view Improve script-panel: - Keep current source position focused when showing related entries - Better tool-tip with buttons to focus on grouped entries per source postion - Focus by default on other views when showing related entries Improve timeline-panel: - Initialise event handlers late to avoid errors - Lazy initialise chunks to avoid errors when zooming-in and trying to create tooltips at the same time Change-Id: I3f3c0fd51985aaa490d62f786ab52a4be1eed292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3492521Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79329}
-
- 01 Jul, 2021 1 commit
-
-
Camillo Bruni authored
Start a local symbol server using the local-web-sever node package: ws --stack system-analyzer/lws-middleware.js lws-static cors The system-analyzer will then use it to symbolize profiles. Note: The symbol server will execute `nm` and `objdump` locally. Change-Id: Icff6e9f5af24f214f353c049f5cd13eedccf0f88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979591 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75501}
-
- 29 Jun, 2021 1 commit
-
-
Camillo Bruni authored
Add common TimelineTrackStackedBase base class for TimelineTrackTick and TimelineTrackTimer for visualising stacked time ranges that only need rescaling when zooming in. Additional changes: - Highlight matching registers in disassembly - Simplify CodeLogEntry summary for script code - Show event for array items in the property-link-table Bug: v8:10644 Change-Id: I0b37274e12ba55f1c6251b90d39d996ffae7f37e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992716Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75437}
-
- 22 Jun, 2021 1 commit
-
-
Leszek Swirski authored
- Asynchronously load source map from sourceMappingURL - Once loaded, annotate source positions with their original position - Update script panel tooltip to include link to original source - For the above, make DOM.element a slightly more flexible API, allowing defining attributes and children - Also fix ToolTipEvent handling to support nodes. - Shuffle around some code to make createScriptNode async, in case we want to load the source map when building the script node itself. - Drive-by: make source markers a simple backgroundColor when there is only one group. Change-Id: I0926807761cbfe8b6dd8ff5154815a7e5ccb39bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2972827 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75302}
-
- 16 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Show related code object for Maps - Fix opening transition trees - Rename *LogEntry.prototype.codeLogEntry to .code - Show Arrays as dropdowns in tooltips - Avoid hiding the tooltip when clicking on the tooltip itself - Show links to code variants (bytecode/baseline/optimized) - Fix chunk offset calculation - Fix code for browsers that don't support navigator.scheduling.isInputPending Bug: v8:10644 Change-Id: I858dc410657d26d076214368814a52177b124f4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964592 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75169}
-
- 15 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Open and focus separate views for each log entry - Map.prototype.parent is now a getter - Fix SharedLibLogEntry tooltips - Store codeEntry in IcLogEntry for linking back to code objects - New property-link-table which is used in tooltip and code-panel - Ignore right-click events in the timeline-tracks Bug: v8:10644, v8:11835 Change-Id: Id2fe5002b776adf362b1580b96082c84790a6ef0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960804Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75150}
-
- 14 Jun, 2021 1 commit
-
-
Leszek Swirski authored
Add a new LogEntry for sharedlib PCs Change-Id: I4f7fdca93a9905e41b73347df475dffcb84bcb89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959620 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75125}
-
- 11 Jun, 2021 1 commit
-
-
Leszek Swirski authored
Use the Streams API for file Blobs, instead of FileReader, to allow large files to be loaded in chunks. Change-Id: I241e0daff3f9c3d491dde2f3e8e52ea2236f05be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953286 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75095}
-
- 07 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Introduce proper TickLogEntry and use a separate Timeline object - Update the main rendering to use SVG for speed - Separate custom-elements: timeline-track-map and timeline-track-tick - Revamp flame-chart drawing - Enable map-transitions overlay - Use mouse position to infer current log-entry instead of individual event handlers - Fix first timelineLegend column header - Fixing scrollbar-color for FireFox Change-Id: I7c53c13366b3e4614b1c5592dfaa69d0654a3b5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944430 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74987}
-
- 31 May, 2021 2 commits
-
-
Camillo Bruni authored
This adds a first crude version of displaying a flamechart in the system-analyzer. - Basic function types are distinguishable by colors. - Tooltip information is available as well Bug: v8:11835 Change-Id: I87e092f749d4c16aa5017af39df8d2f7bd7e2edd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928179 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74860}
-
Camillo Bruni authored
Removing some additional complexity that is not frequently used. Change-Id: I10195971d872d710ba3a87170fb62c1948e7716e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2923502Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74851}
-
- 25 May, 2021 1 commit
-
-
Camillo Bruni authored
Enable more complex tooltips with clickable links and references. - Use short filename for Script.name if they are unique - Use shared App.isClickable method - Remove various toStringLong methods - Rename CodeLogEntry.disassemble to .code - Add DOM.button helper Bug: v8:10644 Change-Id: I5d46ffd560b37278dc46b8347cb9ff0a7fdfa2ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2916373Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74746}
-
- 29 Apr, 2021 1 commit
-
-
Camillo Bruni authored
Selecting a single script from related events was not implemented. Change-Id: Id6dbe7f8eb235c5917e48a9ade7347404c114618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2859943Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74281}
-
- 12 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Drive-by-fix: - fix load spinner z-index Change-Id: I4a8f9b768ec858da4d91780ae0998a685f4438bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624609Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72044}
-
- 08 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Change the background of source position markers based on the events they link to. Bug: v8:10644 Change-Id: I108d9f5670acdaf5835905c2b44648c0eaf6dbd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604708 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71970}
-
- 07 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Prepare the system analyzer to be able to select events related to a a single code log entry. - Rename source-panel to script-script panel - Update main index.css to support selects in the panel selection header Bug: v8:10644 Change-Id: Ie8dd1839294687cb9e25995bcb7ef246a7d7f48d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604707Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71948}
-
- 21 Dec, 2020 1 commit
-
-
Camillo Bruni authored
- Fix landing page - Introduce and use SelectRelatedEvent for centralising the logic of finding and showing related LogEntries. It also clears the selection of all list panels if there are no related entries. - Add "select related" button to the script-panel to show events only from the currently selected script - Add selection type tabs for the map-panel - Fix transition colors for map-transitions view - Introduce separate map-transition view for the currently selected Map Bug: v8:10644 Change-Id: I4199a8332bab2518d98078712ed5ce9a8f1dc19e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599555 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71849}
-
- 14 Dec, 2020 2 commits
-
-
Camillo Bruni authored
Associate DeoptLogEntry with both, the function's source position and the deopt location's source position. Also fixes the list-panel click handler to support all clickable entry types. Bug: v8:10644, v8:10754 Change-Id: If10272a926d5dad10b29322e237610900715b9dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584955 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71732}
-
Camillo Bruni authored
- Show selection tab-bar - Hide panels on empty timeline - Fix legend position in ic list-panel Bug: v8:10644 Change-Id: I4ef09627ed4de8682adb60f88be38867bc91640d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584953Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71731}
-
- 08 Dec, 2020 1 commit
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I83801396fe683173349d14a7590828ec86587eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575122Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71655}
-
- 05 Dec, 2020 1 commit
-
-
Camillo Bruni authored
- Clean up entry selection code - Add source positions for code and deopt events - Fix log entry selection from script - Improve log parsing speed Bug: v8:10644 Change-Id: Ie466679132b8ce24506ecf75223118b32275f931 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569756 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71624}
-
- 02 Dec, 2020 2 commits
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I727f844f3796f37e92c8855e02d519abeee73dc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2566760 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71558}
-
Camillo Bruni authored
- Add FLAG_log_code_disassemble - Add code-disassamble log entries for Code and BytecodeArray - Add basic code-panel to system-analyzer Bug: v8:10644 Change-Id: I1abb339a42b55df01265d63d0f0d8c1ac2e041dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565517Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71556}
-
- 30 Nov, 2020 4 commits
-
-
Camillo Bruni authored
- Timeline.selection is now a Timeline as well - Allow remove the current timeline-track selection by double-clicking outside-the selection - Update the timeline-track stats based on the current selection - Simplify DOM element creation methods - Add separate SelectionHandler class for timeline-track Bug: v8:10644 Change-Id: I4f15d6ab4f5ec6b7330e22769472ca3074b00edd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565130 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71497}
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I934795e6ef8c42c3bc801c84dfb5f9770acd46fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565057Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71486}
-
Camillo Bruni authored
Drive-by-fix: - better handle tooltip text Bug: v8:10644 Change-Id: Ibe20a1e0a0ebd298855afcbdc6f28e6fa4d1e64e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563660 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71479}
-
Camillo Bruni authored
- Fix transition view selection and opening of subtrees - Fix transition colors by storing an index on the uniqueType map in the timeline - Do not reset the current list in the transition view when clicking on a map - Support changing source positions in the source panel - Highlight the current source position with a pulsing marker - Fix kColors usage in timeline-track Bug: v8:10644 Change-Id: I5130f18d9076cb37f9c3c8d585c9e47038ca411b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562386Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71477}
-
- 26 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- Add ToolTip helper that tracks scrolling target elements - Auto hide if the target scrolls out of view - ToolTip position depends on target position - Add basic tooltips for maps in the transition view, entries in timeline tracks and the source panel Drive-by-fix: - Move events.mjs to view/ folder - Add basic toString methods on various log entries - Add requestAnimationFrame update support for V8CustomElement Bug: v8:10644 Change-Id: I1059733cd094a986b715547b3d5747eefbc54bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551103 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71434}
-
- 18 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- introduce view specific helper.mjs module - clean up some imports Bug: v8:10644 Change-Id: I0497c1a962c90f61f2beca667aca4a3f53a11e59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545705Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71269}
-
- 16 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- Reuse DOM nodes if possible - Delay slow DOM node removal to not block the UI - Fix global time range syncing when adding timelines to the state - Use a Proxy to cache CSS colors instead of querying CSS properties on every access - Set className on newly create DOM nodes instead of adding to the classList - Use bound functions for event handlers that are added multiple times - Speed up Chunk.getBreackdown - Use CSS gradient for timeline-track chunk backgrounds, which is an order of magnitude faster than the serialised canvas approach Bug: v8:10644 Change-Id: Ie2d6d5b404f18e920c10c0a6460669fd4d0b20e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539947 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71207}
-
- 03 Nov, 2020 1 commit
-
-
Sathya Gunasekaran authored
This is a reland of 1ec8f1da Original change's description: > [presubmit] Add JS formatting for tools/system-analyzer > > Bug: v8:10670 > Change-Id: Ifb653ada003719faff261b6e5b2169db37cffdaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282522 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68909} Bug: v8:10670 Change-Id: I4903b3eb8ff39a76594324076f0840b06290044e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307229 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70938}
-
- 02 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- Move all createElement helpers onto a separate DOM class - Make ICPanel.update async - Show number of selected IC events in the ICPanel header - Use shared bound functions for event listeners in the ICPanel groups - Use triangle to mark opened and closed ICPanel groups - Use global --border-color CSS variable Bug: v8:10644 Change-Id: Ib35d94db1019d5cdcee057f0f047472f478ab3be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507718Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70919}
-
- 29 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Use initial color for TimelineTrack chunks - Use async functions for TimelineTrack setChunkBackgrounds - Introduce timeSelection setter on TimelinePanel - Propagate time selection down to the TimelinePanel - Avoid layout recalculation in TimelineTrack updateSelection drive-by-cleanups: - Add common event listeners only to top-level document - Use console.warn instead of console.error for better debugging in DevTools Bug: v8:10644 Change-Id: Ie4f80f1c6c3f4fa193f8ac01225e0fb76981551d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497175 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70886}
-
- 23 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Display spinner properly again - Defer loadding additional App and subsequent modules - Preload file reader module and template Change-Id: Ifc81a93864d61c282db90df25f93dc0eefef4373 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2494925 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70730}
-
- 22 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Move map stats into a separate panel - Don't handle selection events twice - Simplify map-stats panel html Change-Id: I0cd135727e69c8e42d34af3b75d42861ce06f8e4 Bug: v8:10644 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2485075Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70717}
-
- 20 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Fix State timerange adjustment for multiple timelines - Fix grid layout for detail panels - Style panels consistently - Simplify file-reader html Bug: v8:10644 Change-Id: I277d88e2deb2bf71b0204034f6e63ea35f85a791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2485812 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70653}
-
- 19 Oct, 2020 3 commits
-
-
Camillo Bruni authored
Drive-by-fix: - fix legend formatting - Fix color from type retrieval - Partially fix file location parsing in Processor Bug: v8:10644 Change-Id: I8d9ecc4923c9772de66da74e9440b293fcecc5e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2465831 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70608}
-
Camillo Bruni authored
- Avoid private fields (using _xyz instead of #xyz) - Avoid static fields on classes These are temporary changes that eventually will be reverted once FireFox and Safari support it. Bug: v8:10644 Change-Id: I3d757251eaedef92751970d866882c3d912c7e3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464924 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70607}
-
Camillo Bruni authored
- Use *LogEntry in more places to avoid confusion with HTML Events - Move Processor.kProperties to IcLogEntry.getPropertyNames - Move timeline-track legend "All" entry to the end Bug: v8:10644 Change-Id: I5a9e833ad0570c39d3106955fa2ba00af53b7062 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2463241 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70606}
-