1. 22 Apr, 2015 1 commit
  2. 16 Apr, 2015 1 commit
  3. 14 Apr, 2015 2 commits
  4. 19 Mar, 2015 1 commit
  5. 11 Mar, 2015 1 commit
  6. 16 Feb, 2015 1 commit
  7. 12 Feb, 2015 2 commits
  8. 30 Jan, 2015 1 commit
  9. 11 Nov, 2014 1 commit
  10. 10 Nov, 2014 2 commits
  11. 14 Oct, 2014 1 commit
  12. 22 Aug, 2014 1 commit
  13. 07 Aug, 2014 1 commit
  14. 04 Aug, 2014 1 commit
  15. 15 Jul, 2014 1 commit
  16. 01 Jul, 2014 1 commit
  17. 30 Jun, 2014 2 commits
  18. 03 Jun, 2014 1 commit
  19. 28 May, 2014 1 commit
  20. 13 May, 2014 1 commit
  21. 29 Apr, 2014 1 commit
  22. 24 Apr, 2014 2 commits
  23. 17 Apr, 2014 1 commit
    • adamk@chromium.org's avatar
      ES6: Add support for Map/Set forEach · 3308cb58
      adamk@chromium.org authored
      This implements MapIterator and SetIterator which matches
      the same constructs in the ES6 spec. However, these 2
      iterators are not exposed to user code yet. They are only
      used internally to implement Map.prototype.forEach and
      Set.prototype.forEach.
      
      Each iterator has a reference to the OrderedHashTable where
      it directly accesses the hash table's entries.
      
      The OrderedHashTable has a reference to the newest iterator
      and each iterator has a reference to the next and previous
      iterator, effectively creating a double linked list.
      
      When the OrderedHashTable is mutated (or replaced) all the
      iterators are updated.
      
      When the iterator iterates passed the end of the data table
      it closes itself. Closed iterators no longer have a
      reference to the OrderedHashTable and they are removed from
      the double linked list. In the case of Map/Set forEach, we
      manually call Close on the iterator in case an exception was
      thrown so that the iterator never reached the end.
      
      At this point the OrderedHashTable keeps all the non finished
      iterators alive but since the only thing we currently expose
      is forEach there are no unfinished iterators outside a forEach
      call. Once we expose the iterators to user code we will need
      to make the references from the OrderedHashTable to the
      iterators weak and have some mechanism to close an iterator
      when it is garbage collected.
      
      BUG=1793, 2323
      LOG=Y
      R=adamk@chromium.org
      TBR=mstarzinger@chromium.org
      
      Review URL: https://codereview.chromium.org/238063009
      
      Patch from Erik Arvidsson <arv@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      3308cb58
  24. 16 Apr, 2014 4 commits
    • adamk@chromium.org's avatar
      Revert "ES6: Add support for Map/Set forEach" · 91618cf1
      adamk@chromium.org authored
      This reverts https://code.google.com/p/v8/source/detail?r=20823
      
      It broke Windows builds. Will need to find a Windows try bot to figure
      out why.
      
      TBR=mstarzinger@chromium.org,arv@chromium.org
      
      Review URL: https://codereview.chromium.org/238973011
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20824 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      91618cf1
    • adamk@chromium.org's avatar
      ES6: Add support for Map/Set forEach · 7c300d1f
      adamk@chromium.org authored
      This implements MapIterator and SetIterator which matches
      the same constructs in the ES6 spec. However, these 2
      iterators are not exposed to user code yet. They are only
      used internally to implement Map.prototype.forEach and
      Set.prototype.forEach.
      
      Each iterator has a reference to the OrderedHashTable where
      it directly accesses the hash table's entries.
      
      The OrderedHashTable has a reference to the newest iterator
      and each iterator has a reference to the next and previous
      iterator, effectively creating a double linked list.
      
      When the OrderedHashTable is mutated (or replaced) all the
      iterators are updated.
      
      When the iterator iterates passed the end of the data table
      it closes itself. Closed iterators no longer have a
      reference to the OrderedHashTable and they are removed from
      the double linked list. In the case of Map/Set forEach, we
      manually call Close on the iterator in case an exception was
      thrown so that the iterator never reached the end.
      
      At this point the OrderedHashTable keeps all the non finished
      iterators alive but since the only thing we currently expose
      is forEach there are no unfinished iterators outside a forEach
      call. Once we expose the iterators to user code we will need
      to make the references from the OrderedHashTable to the
      iterators weak and have some mechanism to close an iterator
      when it is garbage collected.
      
      BUG=1793,2323
      LOG=Y
      TBR=mstarzinger@chromium.org
      
      Review URL: https://codereview.chromium.org/240323003
      
      Patch from Erik Arvidsson <arv@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20823 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      7c300d1f
    • adamk@chromium.org's avatar
      Revert "ES6: Add support for Map/Set forEach" · a44e10ca
      adamk@chromium.org authored
      This reverts commit https://code.google.com/p/v8/source/detail?r=20781.
      
      It broke the Win32 builders.
      
      TBR=mstarzinger@chromium.org
      
      Review URL: https://codereview.chromium.org/239163012
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      a44e10ca
    • adamk@chromium.org's avatar
      ES6: Add support for Map/Set forEach · a1af5a2a
      adamk@chromium.org authored
      This implements MapIterator and SetIterator which matches
      the same constructs in the ES6 spec. However, these 2
      iterators are not exposed to user code yet. They are only
      used internally to implement Map.prototype.forEach and
      Set.prototype.forEach.
      
      Each iterator has a reference to the OrderedHashTable where
      it directly accesses the hash table's entries.
      
      The OrderedHashTable has a reference to the newest iterator
      and each iterator has a reference to the next and previous
      iterator, effectively creating a double linked list.
      
      When the OrderedHashTable is mutated (or replaced) all the
      iterators are updated.
      
      When the iterator iterates passed the end of the data table
      it closes itself. Closed iterators no longer have a
      reference to the OrderedHashTable and they are removed from
      the double linked list. In the case of Map/Set forEach, we
      manually call Close on the iterator in case an exception was
      thrown so that the iterator never reached the end.
      
      At this point the OrderedHashTable keeps all the non finished
      iterators alive but since the only thing we currently expose
      is forEach there are no unfinished iterators outside a forEach
      call. Once we expose the iterators to user code we will need
      to make the references from the OrderedHashTable to the
      iterators weak and have some mechanism to close an iterator
      when it is garbage collected.
      
      BUG=1793,2323
      LOG=Y
      R=adamk@chromium.org, mstarzinger@chromium.org
      
      Review URL: https://codereview.chromium.org/236143002
      
      Patch from Erik Arvidsson <arv@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20781 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      a1af5a2a
  25. 11 Apr, 2014 1 commit
  26. 24 Jan, 2014 1 commit
  27. 16 Jan, 2014 5 commits
  28. 14 Oct, 2013 1 commit