- 01 Aug, 2016 1 commit
-
-
cbruni authored
BUG=chromium:630217 Review-Url: https://codereview.chromium.org/2196533003 Cr-Commit-Position: refs/heads/master@{#38213}
-
- 29 Jul, 2016 1 commit
-
-
jochen authored
TBR=marja@chromium.org BUG= Review-Url: https://codereview.chromium.org/2194863002 Cr-Commit-Position: refs/heads/master@{#38169}
-
- 28 Jul, 2016 1 commit
-
-
cbruni authored
The timing scopes don't come for free and in the case of wrapper creation only add overhead. This CL removes the histogram timer for CallAs(Function|Constructor) and Function::(NewInstance|Call). BUG=chromium:630217 Review-Url: https://codereview.chromium.org/2188193002 Cr-Commit-Position: refs/heads/master@{#38138}
-
- 20 Jul, 2016 1 commit
-
-
yangguo authored
Review-Url: https://codereview.chromium.org/2162503002 Cr-Commit-Position: refs/heads/master@{#37892}
-
- 19 Jul, 2016 1 commit
-
-
jochen authored
BUG=chromium:618305 R=verwaest@chromium.org CC=dcheng@chromium.org,haraken@chromium.org Review-Url: https://codereview.chromium.org/2162443002 Cr-Commit-Position: refs/heads/master@{#37867}
-
- 18 Jul, 2016 2 commits
-
-
jochen authored
Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead just return undefined > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > BUG=chromium:541703 > R=verwaest@chromium.org,bmeurer@chromium.org BUG=chromium:541703 R=verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2155503004 Cr-Commit-Position: refs/heads/master@{#37842}
-
jochen authored
BUG= R=ulan@chromium.org,verwaest@chromium.org Review-Url: https://codereview.chromium.org/2153423002 Cr-Commit-Position: refs/heads/master@{#37824}
-
- 14 Jul, 2016 3 commits
-
-
wfh authored
This is a dependent CL for the blink/chromium side change in https://codereview.chromium.org/2130293003/ BUG=614440 Review-Url: https://codereview.chromium.org/2139873002 Cr-Commit-Position: refs/heads/master@{#37781}
-
cbruni authored
Reland of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #1 id:1 of https://codereview.chromium.org/2140563002/ ) Reason for reland: https://codereview.chromium.org/2122953002 fixed context issues. Original issue's description: > Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #2 id:20001 of https://codereview.chromium.org/2131483002/ ) > > Reason for revert: > crashes: crbug.com/626719 > > Original issue's description: > > Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context > > > > A bit of browsing around indicates that the new fast-path is taken most of the time: > > 3496 Entering new > > 152295 Reentering same > > > > BUG= > > > > Committed: https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490 > > Cr-Commit-Position: refs/heads/master@{#37570} > > TBR=jochen@chromium.org,verwaest@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= > > Committed: https://crrev.com/bec49a4876fdf8a20600ecdfc8534d0ef45c9528 > Cr-Commit-Position: refs/heads/master@{#37632} TBR=jochen@chromium.org,verwaest@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2152803003 Cr-Commit-Position: refs/heads/master@{#37778}
-
neis authored
BUG= Review-Url: https://codereview.chromium.org/2149763004 Cr-Commit-Position: refs/heads/master@{#37774}
-
- 11 Jul, 2016 2 commits
-
-
jkummerow authored
Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #2 id:20001 of https://codereview.chromium.org/2131483002/ ) Reason for revert: crashes: crbug.com/626719 Original issue's description: > Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context > > A bit of browsing around indicates that the new fast-path is taken most of the time: > 3496 Entering new > 152295 Reentering same > > BUG= > > Committed: https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490 > Cr-Commit-Position: refs/heads/master@{#37570} TBR=jochen@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2140563002 Cr-Commit-Position: refs/heads/master@{#37632}
-
machenbach authored
Revert "Move SimulatorHelper into V8 out of profiler clients." This reverts commit b8372411. Revert "Make use of v8::TickSample instead of v8::internal::TickSample in logger." This reverts commit c3a16f0a. Revert "Clean up SimulatorHelper code." This reverts commit 8ee236e1. BUG=v8:5193 TBR=alph@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2138643003 Cr-Commit-Position: refs/heads/master@{#37626}
-
- 08 Jul, 2016 2 commits
-
-
alph authored
Clients should not know about the simulator. BUG=v8:4789 Review-Url: https://codereview.chromium.org/2128613004 Cr-Commit-Position: refs/heads/master@{#37617}
-
alph authored
Isolate is not going to retain a CPU profiler. The client will be creating an instance of profiler when needed. Deprectate v8::Isolate::GetCpuProfiler() BUG=v8:4789 Review-Url: https://codereview.chromium.org/2117343006 Cr-Commit-Position: refs/heads/master@{#37613}
-
- 07 Jul, 2016 4 commits
-
-
jochen authored
Such an object can be used to later create a context from it. It has to have access checks with handlers enabled, as it cannot be accessed otherwise. BUG=chromium:618305 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2107673003 Cr-Commit-Position: refs/heads/master@{#37594}
-
ulan authored
For motivation see the bug. BUG=625865 LOG=NO Review-Url: https://codereview.chromium.org/2121273002 Cr-Commit-Position: refs/heads/master@{#37581}
-
ulan authored
BUG=chromium:626256 LOG=NO Review-Url: https://codereview.chromium.org/2126193002 Cr-Commit-Position: refs/heads/master@{#37578}
-
verwaest authored
A bit of browsing around indicates that the new fast-path is taken most of the time: 3496 Entering new 152295 Reentering same BUG= Review-Url: https://codereview.chromium.org/2131483002 Cr-Commit-Position: refs/heads/master@{#37570}
-
- 06 Jul, 2016 2 commits
-
-
lpy authored
We want to eventually move the profiling functionality out of V8 as library, this patch exposes TickSample and its APIs in v8-profiler.h so that when embedders use library, they can have more details. Minor change: Rename tick-sample.[h|cc] to simulator-helper.[h|cc]. BUG=v8:4789 LOG=N Review-Url: https://codereview.chromium.org/2105943002 Cr-Commit-Position: refs/heads/master@{#37564}
-
jochen authored
BUG=chromium:625823 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2123143002 Cr-Commit-Position: refs/heads/master@{#37549}
-
- 01 Jul, 2016 1 commit
-
-
littledan authored
This patch implements "immutable prototype exotic objects" from the ECMAScript spec, which are objects whose __proto__ cannot be changed, but are not otherwise frozen. They are introduced in order to prevent a Proxy from being introduced to the prototype chain of the global object. The API is extended by a SetImmutablePrototype() call in ObjectTemplate, which can be used to vend new immutable prototype objects. Additionally, Object.prototype is an immutable prototype object. In the implementation, a new bit is added to Maps to say whether the prototype is immutable, which is read by SetPrototype. Map transitions to the immutable prototype state are not saved in the transition tree because the main use case is just for the prototype chain of the global object, which there will be only one of per Context, so no need to take up the extra word for a pointer in each full transition tree. BUG=v8:5149 Review-Url: https://codereview.chromium.org/2108203002 Cr-Commit-Position: refs/heads/master@{#37482}
-
- 30 Jun, 2016 1 commit
-
-
yangguo authored
R=mstarzinger@chromium.org BUG=v8:5117 Review-Url: https://codereview.chromium.org/2109773004 Cr-Commit-Position: refs/heads/master@{#37426}
-
- 29 Jun, 2016 1 commit
-
-
jochen authored
BUG=none R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2101413002 Cr-Commit-Position: refs/heads/master@{#37365}
-
- 28 Jun, 2016 2 commits
-
-
yangguo authored
This part of the snapshot API should not be in use yet, so we can still change this. The motivation for this change is: - Use MaybeHandle where reasonable. - Remove ambiguity: when we use index to create context from snapshot, we should not have a silent fallback if snapshot is not available. - Symmetry: rename to Context::FromSnapshot to mirror templates. R=jochen@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2100073002 Cr-Commit-Position: refs/heads/master@{#37334}
-
alph authored
The main fix is to mark stack memory the SafeStackFrameIterator accesses as initialied. Drive-by: Make sure we bail out when the simulator is in the process of updating FP/SP registers. BUG=v8:5156 Review-Url: https://codereview.chromium.org/2104763002 Cr-Commit-Position: refs/heads/master@{#37315}
-
- 27 Jun, 2016 3 commits
-
-
jochen authored
This superseeds all-can-read/all-can-write properties BUG=chromium:618305 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2087823002 Cr-Commit-Position: refs/heads/master@{#37286}
-
franzih authored
We can check if the instance type of an object is JS_PROMISE_TYPE to determine if it is a promise rather than test whether the property promise_state_symbol is present. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2091243002 Cr-Commit-Position: refs/heads/master@{#37283}
-
franzih authored
Replace explicit Object::IsErrorObject() and v8::IsNativeError() with macro generated functions Object::IsJSError() and HeapObject::IsJSError(). BUG= Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b Cr-Commit-Position: refs/heads/master@{#37244} CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2090333002 Cr-Commit-Position: refs/heads/master@{#37279}
-
- 24 Jun, 2016 2 commits
-
-
machenbach authored
Revert of Use instance type in Object::IsErrorObject(). (patchset #9 id:160001 of https://codereview.chromium.org/2090333002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7700 Please rebase upstream first if intended. Original issue's description: > Use JS_ERROR_TYPE to check for error objects. > > Replace explicit Object::IsErrorObject() with macro generated functions Object::IsJSError() and HeapObject::IsJSError(). > > BUG= > > Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b > Cr-Commit-Position: refs/heads/master@{#37244} TBR=verwaest@chromium.org,jochen@chromium.org,franzih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2092083002 Cr-Commit-Position: refs/heads/master@{#37250}
-
franzih authored
Replace explicit Object::IsErrorObject() with macro generated functions Object::IsJSError() and HeapObject::IsJSError(). BUG= Review-Url: https://codereview.chromium.org/2090333002 Cr-Commit-Position: refs/heads/master@{#37244}
-
- 22 Jun, 2016 1 commit
-
-
jochen authored
This way embedders don't have to manually convert them to strings BUG=chromium:619166 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2085223002 Cr-Commit-Position: refs/heads/master@{#37179}
-
- 21 Jun, 2016 2 commits
-
-
verwaest authored
BUG=chromium:595492 Review-Url: https://codereview.chromium.org/2084923003 Cr-Commit-Position: refs/heads/master@{#37153}
-
yangguo authored
R=jochen@chromium.org, verwaest@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2076083002 Cr-Commit-Position: refs/heads/master@{#37122}
-
- 20 Jun, 2016 1 commit
-
-
yangguo authored
R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2066993004 Cr-Commit-Position: refs/heads/master@{#37109}
-
- 15 Jun, 2016 3 commits
-
-
yangguo authored
R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2055203002 Cr-Commit-Position: refs/heads/master@{#37008}
-
machenbach authored
Revert of Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) (patchset #2 id:20001 of https://codereview.chromium.org/2063853002/ ) Reason for revert: [Sheriff] Speculative revert for http://crbug.com/620279 Original issue's description: > Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) > > The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. > > As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. > > The original CL was failing the TSAN builder, the variable in question was intended to be accessed quickly with no guarantee. > Switched to using an Atomic variable with no barrier read/write. > > BUG=v8:5089 > > patch from issue 2052523002 at patchset 100001 (http://crrev.com/2052523002#ps100001) > > Committed: https://crrev.com/fd7080cbefc21f2f890b5db00d4eadf163e2cbbf > Cr-Commit-Position: refs/heads/master@{#36973} TBR=cbruni@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2068143002 Cr-Commit-Position: refs/heads/master@{#36997}
-
alph authored
Driveby: some surrounding code refactoring/cleanup. BUG=v8:4789 Review-Url: https://codereview.chromium.org/2056253003 Cr-Commit-Position: refs/heads/master@{#36993}
-
- 14 Jun, 2016 2 commits
-
-
fmeawad authored
The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. The original CL was failing the TSAN builder, the variable in question was intended to be accessed quickly with no guarantee. Switched to using an Atomic variable with no barrier read/write. BUG=v8:5089 patch from issue 2052523002 at patchset 100001 (http://crrev.com/2052523002#ps100001) Review-Url: https://codereview.chromium.org/2063853002 Cr-Commit-Position: refs/heads/master@{#36973}
-
cbruni authored
Reland of place all remaining Oddball checks with new function (patchset #1 id:1 of https://codereview.chromium.org/2060213002/ ) Reason for revert: Cannot reproduce gc-stress failures locally. Original issue's description: > Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) > > Reason for revert: > failing tests > > Original issue's description: > > Replace all remaining Oddball checks with new function > > > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > > The new method all take the isolate as parameter. > > > > BUG= > > > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > > Cr-Commit-Position: refs/heads/master@{#36921} > > TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/33b8bc24a12fb062100c0be84456faeb0b9fa5d1 > Cr-Commit-Position: refs/heads/master@{#36923} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2059173002 Cr-Commit-Position: refs/heads/master@{#36957}
-
- 13 Jun, 2016 1 commit
-
-
cbruni authored
Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) Reason for revert: failing tests Original issue's description: > Replace all remaining Oddball checks with new function > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > The new method all take the isolate as parameter. > > BUG= > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > Cr-Commit-Position: refs/heads/master@{#36921} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2060213002 Cr-Commit-Position: refs/heads/master@{#36923}
-