- 27 Aug, 2018 10 commits
-
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: chromium:877964 Change-Id: Ia7ea1094ea339f6e956cb7241f7d35913b7821b2 Reviewed-on: https://chromium-review.googlesource.com/1190502Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55430}
-
Andreas Haas authored
{Isolate::Deinit} waits for all created {OptimizingCompiler::CompileTask}s to finish. However, these CompileTasks run in the background and can be blocked by other tasks which run in the background, e.g. WebAssembly compilation tasks. With this CL we stop WebAssembly compilation tasks before we wait for the {optimizingCompiler:::CompileTask}s. R=mstarzinger@chromium.org CC=jarin@chromium.org Change-Id: I1549c1babdebc2e951aef5e48d0aa8130884fb7d Reviewed-on: https://chromium-review.googlesource.com/1190302Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55429}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: v8:5918 Change-Id: I6fc16e3c6415246072b7626bdfd13ea0b7ce2dc2 Reviewed-on: https://chromium-review.googlesource.com/1189983Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55428}
-
Peter Marshall authored
This reverts commit 133a6815. Reason for revert: Regresses parsing time Original change's description: > [cleanup] Replace ZoneList with ZoneVector for parser reported_errors_ > > We use a ZoneVector because we do a fair amount of random access e.g. > in ExpressionClassifier::Accumulate() so the vector is better suited > than ZoneChunkList as it has constant time random access. > > Bug: v8:6333 > Change-Id: I83e1de60ee8fe319cfa5ce77fc5f5f86beb5307d > Reviewed-on: https://chromium-review.googlesource.com/1054672 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55315} TBR=neis@chromium.org,petermarshall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6333 Change-Id: Ib89f0aa1f27b7d6dbbf21af60ed7d1bcd2c0b7d3 Reviewed-on: https://chromium-review.googlesource.com/1189803Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55427}
-
Bret Sepulveda authored
This patch disables the conditions that cause the test to flake, but as a band-aid that doesn't fix the underlying issue. Bug: v8:8084 Change-Id: I46380d0ce4f450c176583330ed760bc3b57b9edc Reviewed-on: https://chromium-review.googlesource.com/1189822Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#55426}
-
Michael Achenbach authored
This is for temporarily testing if those bots work as expected on V8 CQ. They'll be afterwards added only on demand on presubmit for API changes. NOTRY=true TBR=delphick@chromium.org Bug: v8:8058 Change-Id: I841539a899f2987914588b2f84d402e3403bb41e Reviewed-on: https://chromium-review.googlesource.com/1189942 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=ahaas@chromium.org Change-Id: I904de575c8c049de64111c12b940c48a50090668 Reviewed-on: https://chromium-review.googlesource.com/1186338 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55424}
-
Sigurd Schneider authored
This CL changes a constant pool test to include tests for the marker and the encoded pool size. Change-Id: Ia5cfd173e5d523a02252fd3b14f302e5c8994881 Reviewed-on: https://chromium-review.googlesource.com/1186626Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#55423}
-
Hai Dang authored
With warmup and/or longer runs, the benchmark results are more reliable. This CL also splits the benchmark into smaller ones for easier management. Change-Id: Ieba0734bef841d131b3184938109ca179994e173 Reviewed-on: https://chromium-review.googlesource.com/1188572Reviewed-by:
-
Ujjwal Sharma authored
https://chromium-review.googlesource.com/c/v8/v8/+/1178763 added DateTimeFormat.prototype.format to the C++ side of things, removing the need for the runtime function, but the function wasn't removed. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie73fefb5477dfb7f04a4f8852e086a92332c05fc Reviewed-on: https://chromium-review.googlesource.com/1189502 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55421}
-
- 26 Aug, 2018 2 commits
-
-
Sigurd Schneider authored
NOTRY=true NOTREECHECKS=true TBR=mslekova@chromium.org Change-Id: I92373d44389d34e3249757639a9f0c4f1c8ce03f Reviewed-on: https://chromium-review.googlesource.com/1189362 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55420}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/03bbc87..dd6b994 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7b7eb88..2d0e03c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6a9b88a4fe1b419fdca0f57848b680aea861a1e7 Reviewed-on: https://chromium-review.googlesource.com/1189423 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55419}
-
- 25 Aug, 2018 3 commits
-
-
Ujjwal Sharma authored
This increases the size of a V8BreakIterator instance by a word to store the adopt text function. The instance to be bound is stored on the context of this builtin function. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I466ead6c8fc9d531d2213cfdd488fa1484496f69 Reviewed-on: https://chromium-review.googlesource.com/1186925 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f4d0db4..03bbc87 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1e44d06..bc2c0a9 Rolling v8/third_party/proguard: https://chromium.googlesource.com/chromium/src/third_party/proguard/+log/67ad7bd..a3729be Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b31d680..bb4146f TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic17addf2ee4ca056eae0c741edbe5483c9de8e8a Reviewed-on: https://chromium-review.googlesource.com/1189092Reviewed-by:
-
Deepti Gandluri authored
- Implement all the I64Atomic operations on ARM - Change assembler methods to use Registers instead of memory operands - Move atomics64 test up be tested on all archs, disable tests on MIPS BUG:v8:6532 Change-Id: I91bd42fa819f194be15c719266c36230f9c65db8 Reviewed-on: https://chromium-review.googlesource.com/1180211 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#55416}
-
- 24 Aug, 2018 25 commits
-
-
Frank Tang authored
This is a reland of 2dc505a4 Original change's description: > [Intl] remove unused js > > Bug: v8:8066 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I9d86577540cf227e038354d9661c60fcdc644b3f > Reviewed-on: https://chromium-review.googlesource.com/1179467 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55200} Bug: v8:8066 Change-Id: Id1f63c2e9c855250a7af01c1e0877296c0320d20 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1185762 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Georg Neis authored
If maxLength is larger than String::kMaxLength, we used to throw immediately. However, we must first look at the filler argument, which is observable. Moreover, if the filler is empty, we must return the input unchanged. Bug: v8:8078 Change-Id: Ic3d135f9e25da56df45b059144e45e19dda9c3d8 Reviewed-on: https://chromium-review.googlesource.com/1188313 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cbc08db..f4d0db4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f62079a..1e44d06 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd765da..7b7eb88 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/454f3b2..3ec92c8 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/297a4dd..a191af9 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/323cf32..d8cf40c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/45de59d..b31d680 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If5e7643d5977ee2c837677dc8fa73b1c0608be36 Reviewed-on: https://chromium-review.googlesource.com/1188526 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Ali Ijaz Sheikh authored
ASAN complained about this on another commit: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20ASAN/26688 causing revert: https://chromium-review.googlesource.com/c/v8/v8/+/1162122 Change-Id: I3bb16177be9d49496db024ce92fd4354b12d8cc3 Reviewed-on: https://chromium-review.googlesource.com/1187832Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#55412}
-
Dan Elphick authored
This doubles the size of the snapshot since it creates all of the handlers twice (and it doesn't use any of these new ones). However it's all behind a flag. For now all bytecode handlers are marked as being not Isolate independent to prevent snapshot creation failures. Bug: v8:8068 Change-Id: Id49f521445643d9fc6b141353f0a29b585160e10 Reviewed-on: https://chromium-review.googlesource.com/1185100 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55411}
-
Michael Starzinger authored
R=sigurds@chromium.org TEST=mjsunit/wasm/module-memory Change-Id: I30b52a09d8655340199dc449aaa91e6a351e2111 Reviewed-on: https://chromium-review.googlesource.com/1188567Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55410}
-
Hai Dang authored
In the case where the array is a fast packed array, the CSA no longer needs to check whether the prototype has elements. This only needed when the array is holey. This is a follow-up of CL #1183671. Change-Id: I0087b827200995c741141f3183bf9a2c748d3b55 Reviewed-on: https://chromium-review.googlesource.com/1188315Reviewed-by:
-
Benedikt Meurer authored
Thus far the LoadElimination didn't consider CheckHeapObject a renaming operation and would therefore miss opportunities to eliminate redundant loads or map checks where the input is not checked for sminess in all cases. This kind of pattern is very common with code that results from builtin inlining in JSCallReducer, as here we don't unconditionally insert CheckHeapObject nodes if we can tell from the graph that the receiver already has a certain map (by walking the effect chain upwards). Bug: v8:8070 Change-Id: I980f382205757a754f93a5741de1ee08b75ee070 Reviewed-on: https://chromium-review.googlesource.com/1188129Reviewed-by:
-
Benedikt Meurer authored
This allows to replace redundant LoadField's whose type doesn't match the type of the replacement, by just turning those LoadField's into TypeGuard's. Bug: v8:8070 Change-Id: Ia329bb536f8829be27e070e90e9eaae0618dac7a Reviewed-on: https://chromium-review.googlesource.com/1188131Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
jgruber authored
In preparation for kRootRegister support on ia32. Bug: v8:6666 Change-Id: I6bbc87734d189bb8cde5d057a54f8155606d142d Reviewed-on: https://chromium-review.googlesource.com/1188319 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55406}
-
Maya Lekova authored
This reverts commit 177e0aa3. Reason for revert: Causes a flaky test on Windows - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/4373 Bug: v8:8087 Original change's description: > [heap] Reland: Reuse object evacuation information for slot recording in Scavenger. > > This reverts commit 5876d8f5. > > Bug: chromium:852420 > Change-Id: I318587f20409f98d05278fc0b4c14da09d259cd3 > Reviewed-on: https://chromium-review.googlesource.com/1188128 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55393} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: If553b74f8443ad98822a2a3d147dc8963346043c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/1188542Reviewed-by:
-
Georg Neis authored
Now that we always instantiate the right ObjectData subclass, we can give precise types to members. R=jarin@chromium.org Bug: v8:7790 Change-Id: Ic2194de90f458ddccbeb9f101903e5865fb4eb41 Reviewed-on: https://chromium-review.googlesource.com/1187103Reviewed-by:
-
Florian Sattler authored
This halfs the test size but also halfs the baseline for the score to make it comparable. Bug: v8:7926 Change-Id: Id3769def6a555ef1bddf8dd5e54c04b8652e5b54 Reviewed-on: https://chromium-review.googlesource.com/1188465Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55403}
-
Georg Neis authored
Also define classes NativeContext and InternalizedString. Those object kinds were already part of our Object hierarchy but didn't have their own class, which was inconvenient. R=jarin@chromium.org, mslekova@chromium.org Bug: v8:7790 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic443a2b2e34afc89bc924e845d995e3f287a2535 Reviewed-on: https://chromium-review.googlesource.com/1185592Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
It appears that the fields are already being unescaped elsewhere, perhaps by the JSON writer. So if we unescape when adding the source filename and contents, unescaping will happen again later and plain backslashes will be interpreted as escape codes. Bug: v8:6240 Change-Id: Ic66b9017ae685d6dd12944ee8d254991e26fbd32 Reviewed-on: https://chromium-review.googlesource.com/1186625Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org TEST=mjsunit/wasm/module-memory Change-Id: If190f4f75feb0560bfb608b5ec01234c95e1f715 Reviewed-on: https://chromium-review.googlesource.com/1188464Reviewed-by:
-
Toon Verwaest authored
Change-Id: I228bbd81807fdfac9e760576f89aeb133e45cf61 Reviewed-on: https://chromium-review.googlesource.com/1186326 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=ahaas@chromium.org BUG=v8:8091 Change-Id: I648e5a957e02d32e51c94175a6596801ca5ebd9e Reviewed-on: https://chromium-review.googlesource.com/1188310 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
jgruber authored
This fixes several issues related to off-heap trampoline handling on ia32. Unlike other architectures, ia32 uses a pc-relative call/jump for the off-heap trampoline. That means we cannot skip reloc info emission, and we need to relocate when the buffer grows during code generation. Finally, inlined trampolines must not clobber and thus also need to use a pc-relative call/jump. Drive-by: Use PreserveRootIA32 config only for whitelisted builtins to build successfully by default. Bug: v8:6666 Change-Id: I2b72147c6c70036cd13d8b22e2c80ade786c47b8 Reviewed-on: https://chromium-review.googlesource.com/1188316 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Sreten Kovacevic authored
Original commit d67d91db Change-Id: I2787a090e8794b91a7f08635ce73f925e1021477 Reviewed-on: https://chromium-review.googlesource.com/1188317Reviewed-by:
-
Michael Starzinger authored
R=sigurds@chromium.org TEST=cctest/test-jump-table-assembler/JumpTablePatchingStress BUG=v8:8085 Change-Id: Iad786172541a2a72d2b774b60da87f40d70ca71d Reviewed-on: https://chromium-review.googlesource.com/1188135 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:8090 Change-Id: I6f8a4d2bcfa25bcc83f29e5fd39f9e72ba18d4ac Reviewed-on: https://chromium-review.googlesource.com/1188132Reviewed-by:
-
Hannes Payer authored
This reverts commit 5876d8f5. Bug: chromium:852420 Change-Id: I318587f20409f98d05278fc0b4c14da09d259cd3 Reviewed-on: https://chromium-review.googlesource.com/1188128Reviewed-by:
-
Michael Starzinger authored
This method introduces an inherent race because it allows changing global static flag variables from concurrently running Isolates (or Workers). Since there are not too many use-cases left, the method in question can be removed entirely. R=hpayer@chromium.org Change-Id: I9798730dd775b04f0bc83f18ed5982672e76e5d5 Reviewed-on: https://chromium-review.googlesource.com/1186731Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55392}
-
Ross McIlroy authored
This reverts commit bca38dbf. Reason for revert: Makes ODROIDs flaky. BUG=v8:8086 Original change's description: > [Tests] Fix some OOM failures on Android by explicitly setting max_old_space_size. > > BUG=v8:8040 > > Change-Id: I8de22af3978f2a8eb844eabdb757bd635050f901 > Reviewed-on: https://chromium-review.googlesource.com/1181432 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55227} TBR=ulan@chromium.org,rmcilroy@chromium.org Bug: v8:8040 Change-Id: Ife980e8706ebbff4d86d87739c2f621d7a976039 Reviewed-on: https://chromium-review.googlesource.com/1188322 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
